Hi Stefan
It seems this patch series is not a production fix. It is more like a
prototype, my personally feeling.
A common issue in patch 2, 3, 4, 5, is that using "comment" to remove the code.
Please remove the unnecessary code directly without // or /**/ in C, and # in
INF.
For patch 1, if y
Stefan
This patch is NOT acceptable.
> + if (1 /*PcdGetBool (PcdRandomizePlatformHierarchy)*/) {
Nacked-by: Jiewen Yao
Thank you
Yao Jiewen
> -Original Message-
> From: Stefan Berger
> Sent: Friday, August 6, 2021 11:33 PM
> To: devel@edk2.groups.io; Yao, Jiewen
> Cc: marcandre.lur
This patch adds the required platform description files, along with
the hardware configuration libraries, for the SolidRun
CN913x CEx7 Evaluation Board. Supported interfaces:
* SPI flash & memory-mapped variable storage access
* uSD
* eMMC
* 7x PCIE root complex
* USB
* Networking:
* 1Gbps RGMII
This patch introduces the top device tree for the CN913x CEx7
Evaluation Board, based on the sources which are common for the
Cn913x SoCs. Also an .inf file is added to allow its compilation.
Signed-off-by: Marcin Wojtas
---
Silicon/Marvell/OcteonTx/DeviceTree/T91/Cn913xCEx7Eval.inf | 22 +
Sil
This patch adds ACPI tables description for the SolidRun
CN913x CEx7 Evaluation Board platform.
Signed-off-by: Marcin Wojtas
---
Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn913xCEx7Eval.inf|
61 +++
Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn913xCEx7Eval/Dbg2.h |
9
Hi,
This patchset introduces support for the CEx7 Evaluation Board
Support, together with the ACPI tables and DT (edk2-non-osi patch).
Additional patch toggles the default HW description to ACPI for
all platforms based on SoCs.
Supported interaces:
* SPI flash & memory-mapped variable storage acc
All currently supported platforms based on the Marvell SoCs offer
both DT and ACPI. Reverse the default setting and pick ACPI as the main
HW description.
Signed-off-by: Marcin Wojtas
---
Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 7 +++
1 file changed, 7 insertions(+)
diff --git a/Sili
Hi,
On 8/6/21 10:47 AM, Andrei Warkentin wrote:
Hi Jeremy,
Reviewed-by: Andrei Warkentin
MADT -> MCFG
Yah, I have to start thinking about what I'm typing :)
Root port registers would be NonCacheable just like the outbound mapping.
(Also, with https://mantis.uefi.org/mantis/view.php?id=2
> On Aug 1, 2021, at 7:35 PM, Ni, Ray wrote:
>
> I also vote "using HOB passing policy". This design helps the new
> bootloader/payload architecture.
>
> EDKII library class design was a good design which mimics C++ class to
> provide same interface for:
> 1. different phases (PEI, DXE, runt
Hi,
On 8/6/21 11:04 AM, Andrei Warkentin wrote:
Ok, I misunderstood the patch set (I thought the PciHostBridgeLib itself would
eventually move to DEN0115).
I still think that (in general) would be a good idea - if not for the benefit
of the Pi, then for the next upstreamed platform where you
Hi,
So I've tested with all the comments below and everything seems to be
working fine, so no issues there. I will re-post RSN.
Thanks,
On 8/6/21 8:42 AM, Ard Biesheuvel via groups.io wrote:
On Thu, 5 Aug 2021 at 18:36, Jeremy Linton wrote:
Since we plan on toggling between XHCI and PCI
Hi,
On 8/6/21 10:37 AM, Andrei Warkentin wrote:
Hi Jeremy,
MADT -> MCFG (and in other patches as well, where you refer to MADT)
I will take 4 letter acronyms that start with an M...
Thanks,
The other feedback that Ard provided makes sense to me as well.
A
--
Andrei Warkentin,
Arm Enabl
Ard,
Is the removal of the COMMON section during the build not redundant to the
-fno-common option? Do you expect cases where we will still see the undesired
variable collisions?
Thanks,
Christopher Zurcher
-Original Message-
From: devel@edk2.groups.io On Behalf Of gaoliming
Sent: Wedn
From: Daniel Maddy
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3535
Updates ACPI table structures in MinPlatformPkg for ACPI 6.3.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Eric Dong
Cc: Daniel Maddy
Co-authored-by: Michael Kubacki
Signed-off-by: Michael Kubacki
---
Pla
Reviewed-by: Guo Dong
-Original Message-
From: devel@edk2.groups.io On Behalf Of Zhiguang Liu
Sent: Thursday, August 5, 2021 9:31 PM
To: devel@edk2.groups.io
Cc: Dong, Guo ; Ni, Ray ; Ma, Maurice
; You, Benjamin
Subject: [edk2-devel] [PATCH 1/4] UefiPayloadPkg: Add Fixed PCDs and use
Reviewed-by: Guo Dong
-Original Message-
From: Liu, Zhiguang
Sent: Thursday, August 5, 2021 9:31 PM
To: devel@edk2.groups.io
Cc: Dong, Guo ; Ni, Ray ; Ma, Maurice
; You, Benjamin
Subject: [PATCH 2/4] UefiPayloadPkg: define some PCD as DynamicEX PCD
Define some PCDs as DynamicEX PCD t
Reviewed-by: Guo Dong
-Original Message-
From: Liu, Zhiguang
Sent: Thursday, August 5, 2021 9:31 PM
To: devel@edk2.groups.io
Cc: Dong, Guo ; Ni, Ray ; Ma, Maurice
; You, Benjamin
Subject: [PATCH 3/4] UefiPayloadPkg: change the default value of some PCDs.
Change the default value of
Reviewed-by: Guo Dong
-Original Message-
From: Liu, Zhiguang
Sent: Thursday, August 5, 2021 9:31 PM
To: devel@edk2.groups.io
Cc: Dong, Guo ; Ni, Ray ; Ma, Maurice
; You, Benjamin
Subject: [PATCH 4/4] UefiPayloadPkg: Add a macro to enable or diable the serial
driver.
This patch doe
Reviewed-by: Guo Dong
-Original Message-
From: Ni, Ray
Sent: Friday, August 6, 2021 1:16 AM
To: devel@edk2.groups.io
Cc: Dong, Guo ; Ma, Maurice ; You,
Benjamin
Subject: [PATCH] UefiPayloadPkg/PayloadEntry: Inherit 4/5-level paging from
bootloader
The patch removes the dep on PcdU
To avoid this type of build errors, disable
'PcdGetBool (PcdRandomizePlatformHierarchy)'.
Building ...
/home/stefanb/dev/edk2/SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
[X64]
In file included from
/home/stefanb/dev/edk2/Build/OvmfX64/DEBUG_GCC5/X64/Sec
Compile the added code now.
Signed-off-by: Stefan Berger
---
OvmfPkg/AmdSev/AmdSevX64.dsc | 3 +++
.../Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 +
OvmfPkg/OvmfPkgIa32.dsc| 3 +++
OvmfPkg/OvmfPkgIa32X6
Use the newly added functions to disable the TPM2 platform hierarchy.
Signed-off-by: Stefan Berger
---
OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 6 ++
OvmfPkg/Library/PlatformBootManagerLibBhyve/BdsPlatform.c | 6 ++
OvmfPkg/Library/PlatformBootManagerLibGrub/BdsPlatfor
Signed-off-by: Stefan Berger
---
.../Include/Library/TpmPlatformHierarchyLib.h | 27 ++
.../PeiDxeTpmPlatformHierarchyLib.c | 266 ++
.../PeiDxeTpmPlatformHierarchyLib.inf | 45 +++
3 files changed, 338 insertions(+)
create mode 100644 SecurityPkg/Include/Libr
This series imports code from the edk2-platforms project related to
changing the password of the TPM2 platform hierarchy and uses it to
disable the TPM2 platform hierarchy in OVMF. It addresses the OVMF
aspects of the following bugs:
https://bugzilla.tianocore.org/show_bug.cgi?id=3510
https://bugz
Fix the following build issue.
/home/stefanb/dev/edk2/SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.inf(46):
error 4000: Value of Guid [gMinPlatformPkgTokenSpaceGuid] is not found under
[Guids] section in
/home/stefanb/dev/edk2/MdePkg/MdePkg.dec
Signed-off-by: Stefan Berger
---
.../PeiDxeTpmPlatformHierarchyLib.c | 23 +++
.../PeiDxeTpmPlatformHierarchyLib.inf | 39 +++
2 files changed, 62 insertions(+)
create mode 100644
SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLibNull/PeiDxeTpmPlatformHi
Disable the dependency on the MinPlatformPkg to avoid this type of build
errors:
/home/stefanb/dev/edk2/SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.inf(39):
error 000E: File/directory not found in workspace
/home/stefanb/dev/edk2/MinPlatformPkg/MinPlatf
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Pedro Falcato
> Sent: Thursday, August 5, 2021 3:50 PM
> To: Kinney, Michael D ; devel@edk2.groups.io
> Cc: Leif Lindholm ; Bret Barkelew
>
> Subject: Re: [edk2-devel] [Patch 0/3] Ext4Pkg: Add Ext4Pkg
>
> Hi Mike,
>
> Tha
Ok, I misunderstood the patch set (I thought the PciHostBridgeLib itself would
eventually move to DEN0115).
I still think that (in general) would be a good idea - if not for the benefit
of the Pi, then for the next upstreamed platform where you could avoid
implementing custom config access code
Hi Jeremy,
Is any of this still conceptually necessary if we adopt the SMCCC interface
within UEFI?
Instead of assuming the first downstream bus is bus 1, could you read the
secondary BN from the RP?
--
Andrei Warkentin,
Arm Enablement Architect,
Cloud Platform Business Unit, VMware
__
Reviewed-by: Andrei Warkentin
--
Andrei Warkentin,
Arm Enablement Architect,
Cloud Platform Business Unit, VMware
From: devel@edk2.groups.io on behalf of Jeremy Linton
via groups.io
Sent: Thursday, August 5, 2021 7:35 PM
To: devel@edk2.groups.io
Cc: p...@akeo.
Hi Jeremy,
Reviewed-by: Andrei Warkentin
MADT -> MCFG
Root port registers would be NonCacheable just like the outbound mapping.
(Also, with https://mantis.uefi.org/mantis/view.php?id=2220, _MEM attributes
aside from NonCacheable and Prefetchable are effectively deprecated).
Note: I really w
Hi Jeremy,
MADT -> MCFG (and in other patches as well, where you refer to MADT)
The other feedback that Ard provided makes sense to me as well.
A
--
Andrei Warkentin,
Arm Enablement Architect,
Cloud Platform Business Unit, VMware
From: devel@edk2.groups.io on b
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3508
Sort the CpuCacheInfo array by CPU package ID, core type, cache level
and cache type.
Signed-off-by: Jason Lou
Cc: Ray Ni
Cc: Eric Dong
Cc: Laszlo Ersek
Cc: Rahul Kumar
---
UefiCpuPkg/Library/CpuCacheInfoLib/CpuCacheInfoLib.c
Sure, I will rename "Fields" and "Data64" in v3 patch.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#78809): https://edk2.groups.io/g/devel/message/78809
Mute This Topic: https://groups.io/mt/84704801/21656
Group Owner: devel+ow...@edk2.
Hi,
On 8/6/21 8:42 AM, Ard Biesheuvel wrote:
On Thu, 5 Aug 2021 at 18:36, Jeremy Linton wrote:
The CM4 has an actual pcie slot, so we need to move the linkup
check to the configuration probe logic. Further the device
restriction logic needs to be relaxed to support downstream
PCIe switches.
With the renaming, Reviewed-by: Ray Ni
> -Original Message-
> From: Ni, Ray
> Sent: Friday, August 6, 2021 9:55 PM
> To: Lou, Yun ; devel@edk2.groups.io
> Cc: Dong, Eric ; Laszlo Ersek ;
> Kumar, Rahul1
> Subject: RE: [PATCH v2] UefiCpuPkg/CpuCacheInfoLib: Sort CpuCacheInfo array
>
> T
Reviewed-by: Ray Ni
> -Original Message-
> From: Liu, Zhiguang
> Sent: Friday, August 6, 2021 12:31 PM
> To: devel@edk2.groups.io
> Cc: Dong, Guo ; Ni, Ray ; Ma, Maurice
> ; You, Benjamin
>
> Subject: [PATCH 4/4] UefiPayloadPkg: Add a macro to enable or diable the
> serial driver.
>
Reviewed-by: Ray Ni
> -Original Message-
> From: Liu, Zhiguang
> Sent: Friday, August 6, 2021 12:31 PM
> To: devel@edk2.groups.io
> Cc: Dong, Guo ; Ni, Ray ; Ma, Maurice
> ; You, Benjamin
>
> Subject: [PATCH 1/4] UefiPayloadPkg: Add Fixed PCDs and use Macro to define
> the default val
Reviewed-by: Ray Ni
> -Original Message-
> From: Liu, Zhiguang
> Sent: Friday, August 6, 2021 12:31 PM
> To: devel@edk2.groups.io
> Cc: Dong, Guo ; Ni, Ray ; Ma, Maurice
> ; You, Benjamin
>
> Subject: [PATCH 3/4] UefiPayloadPkg: change the default value of some PCDs.
>
> Change the de
Reviewed-by: Ray Ni
> -Original Message-
> From: Liu, Zhiguang
> Sent: Friday, August 6, 2021 12:31 PM
> To: devel@edk2.groups.io
> Cc: Dong, Guo ; Ni, Ray ; Ma, Maurice
> ; You, Benjamin
>
> Subject: [PATCH 2/4] UefiPayloadPkg: define some PCD as DynamicEX PCD
>
> Define some PCDs as
The patch looks good to me. 2 minor comments:
> + } Fields;
1. Can you rename to "Bits" to align to existing naming convention?
>
> + UINT64Data64;
2. Can you rename to "Uint64"?
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online
On Fri, 6 Aug 2021 at 10:30, Grzegorz Bernacki wrote:
>
> This commit adds code which check BootDiscoveryPolicy variable and
> calls Boot Policy Manager Protocol to connect device specified by
> the variable. To enable that mechanism for platform
> EfiMdeModulePkgTokenSpaceGuid.PcdBootDiscoveryPol
On Thu, 5 Aug 2021 at 18:36, Jeremy Linton wrote:
>
> The CM4 has an actual pcie slot, so we need to move the linkup
> check to the configuration probe logic. Further the device
> restriction logic needs to be relaxed to support downstream
> PCIe switches.
>
> Suggested-by: René Treffer
> Signed-
On Thu, 5 Aug 2021 at 18:36, Jeremy Linton wrote:
>
> Since we plan on toggling between XHCI and PCI the PCI
> root needs to be in its own SSDT. This is all thats needed
> of UEFI. The SMC conduit is provided directly to the running
> OS. When the OS detects this PCIe port, on a machine without
>
Hello Liming
Thanks a lot for helping these patches to land.
I'm back on this and will address comments in a PATCH v5.
Regards,
etienne
On Wed, 28 Jul 2021 at 09:43, gaoliming wrote:
>
> Etienne:
>
> I check the build log. Two build failure here. Can you update the patch to
> fix them?
>
> 1.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3508
Sort the CpuCacheInfo array by CPU package ID, core type, cache level
and cache type.
Signed-off-by: Jason Lou
Cc: Ray Ni
Cc: Eric Dong
Cc: Laszlo Ersek
Cc: Rahul Kumar
---
UefiCpuPkg/Library/CpuCacheInfoLib/CpuCacheInfoLib.c
From: Jason
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3508
Sort the CpuCacheInfo array by the core type values from largest to
smallest.
Signed-off-by: Jason Lou
Cc: Ray Ni
Cc: Eric Dong
Cc: Laszlo Ersek
Cc: Rahul Kumar
---
UefiCpuPkg/Library/CpuCacheInfoLib/CpuCacheInfoLib.c
The uuid.h only included in file GenFvInternalLib.c,
but no interface from libuuid is used in this file.
So remove this include and link to libuuid.
Cc: Bob Feng
Cc: Liming Gao
Cc: Yuwei Chen
Signed-off-by: Wenyi Xie
---
BaseTools/Source/C/GenFv/GenFvInternalLib.c | 5 -
BaseTools/Source/
Main Changes :
1.remove include uuid.h and link to libuuid. And try to build under linux, the
building is sucessful.
Wenyi Xie (1):
BaseTools: Remove dependence of libuuid
BaseTools/Source/C/GenFv/GenFvInternalLib.c | 5 -
BaseTools/Source/C/DevicePath/GNUmakefile | 4
BaseTools/So
On Thu, 5 Aug 2021 at 00:03, Jeff Brasen wrote:
>
> Relocate LINUX_EFI_INITRD_MEDIA_GUID from OvmfPkg to MdePkg as it has
> use outside of Ovmf applications
>
> Jeff Brasen (2):
> OvmfPkg: Remove Initrd LINUX_EFI_INITRD_MEDIA_GUID
> MdePkg: add definition of LINUX_EFI_INITRD_MEDIA_GUID
>
> Md
Looks good. Thanks, Greg.
Reviewed-by: Sunny Wang
For others' reference, this patch is similar to the one below for Rasberry Pi
that just got merged.
- https://edk2.groups.io/g/devel/message/78514
After merging this change, we should be able to easily enable "boot discovery
policy" on other A
This commit adds code which check BootDiscoveryPolicy variable and
calls Boot Policy Manager Protocol to connect device specified by
the variable. To enable that mechanism for platform
EfiMdeModulePkgTokenSpaceGuid.PcdBootDiscoveryPolicy PCD must be
added to DSC file and BootDiscoveryPolicyUiLib sh
For this series.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 05/08/2021, 17:25, "Chris Jones" wrote:
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516)
This patch series introduces a header file for the latest version of the
ACPI 6.4 specification, Janu
The patch removes the dep on PcdUse5LevelPageTable.
Now the payload inherits the 5-level paging setting from
bootloader in IA-32e mode and uses 4-level paging in
legacy protected mode.
This fix the potential issue when bootloader enables 5-level paging
but 64bit payload sets 4-level page table to
55 matches
Mail list logo
