With the renaming, Reviewed-by: Ray Ni <ray...@intel.com> > -----Original Message----- > From: Ni, Ray > Sent: Friday, August 6, 2021 9:55 PM > To: Lou, Yun <yun....@intel.com>; devel@edk2.groups.io > Cc: Dong, Eric <eric.d...@intel.com>; Laszlo Ersek <ler...@redhat.com>; > Kumar, Rahul1 <rahul1.ku...@intel.com> > Subject: RE: [PATCH v2] UefiCpuPkg/CpuCacheInfoLib: Sort CpuCacheInfo array > > The patch looks good to me. 2 minor comments: > > + } Fields; > 1. Can you rename to "Bits" to align to existing naming convention? > > > > > + UINT64 Data64; > > 2. Can you rename to "Uint64"? >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#78807): https://edk2.groups.io/g/devel/message/78807 Mute This Topic: https://groups.io/mt/84704801/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
