[edk2-devel] 回复: [PATCH v2] MdePkg/BaseLib: Add support for the XSETBV instruction

Reviewed-by: Liming Gao > -邮件原件- > 发件人: Jiaxin Wu > 发送时间: 2021年4月2日 9:51 > 收件人: devel@edk2.groups.io > 抄送: Michael D Kinney ; Liming Gao > ; Zhiguang Liu ; Ni Ray > ; Yao Jiewen ; Zhang Hongbin1 > > 主题: [PATCH v2] MdePkg/BaseLib: Add support for the XSETBV instruction > > *v2: refine t

Re: [edk2-devel] [PATCH v1 1/1] UefiCpuPkg: PiSmmCpuDxeSmm: Check buffer size before accessing

Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of Kun Qin > Sent: Saturday, March 27, 2021 7:42 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Laszlo > Ersek ; Kumar, Rahul1 > > Subject: [edk2-devel] [PATCH v1 1/1] UefiCpuPkg: PiSmmCpuDxeSmm

[edk2-devel] [PATCH 1/3] MinPlatformPkg/CoreCommonLib.dsc: Consume MicrocodeLib

Signed-off-by: Ray Ni Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong --- Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc b/Platform/In

[edk2-devel] [PATCH 0/3] Update edk2-platform repo to consume MicrocodeLib

Ray Ni (3): MinPlatformPkg/CoreCommonLib.dsc: Consume MicrocodeLib Vlv2TbltDevicePkg/PlatformPkg[IA32|X64].dsc: Consume MicrocodeLib IntelSiliconPkg/ShadowMicrocodePei: Consume MicrocodeLib .../Include/Dsc/CoreCommonLib.dsc | 3 +- .../Vlv2TbltDevicePkg/PlatformPkgIA32.dsc

[edk2-devel] [PATCH 3/3] IntelSiliconPkg/ShadowMicrocodePei: Consume MicrocodeLib

Signed-off-by: Ray Ni Cc: Rangasai V Chaganty Cc: Siyuan Fu --- .../ShadowMicrocode/ShadowMicrocodePei.c | 155 ++ .../ShadowMicrocode/ShadowMicrocodePei.inf| 3 +- 2 files changed, 13 insertions(+), 145 deletions(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Featur

[edk2-devel] [PATCH 2/3] Vlv2TbltDevicePkg/PlatformPkg[IA32|X64].dsc: Consume MicrocodeLib

Signed-off-by: Ray Ni Cc: Zailiang Sun Cc: Yi Qian --- Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 + Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 + 2 files changed, 2 insertions(+) diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc b/Platform/Intel/Vl

[edk2-devel] [PATCH 4/4] UefiCpuPkg/MpInitLib: Consume MicrocodeLib to remove duplicated code

Signed-off-by: Ray Ni Cc: Eric Dong Cc: Laszlo Ersek Cc: Rahul Kumar --- UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 1 + UefiCpuPkg/Library/MpInitLib/Microcode.c | 484 -- UefiCpuPkg/Library/MpInitLib/MpLib.h | 1 + UefiCpuPkg/Library/MpInitLib/PeiMpInitL

[edk2-devel] [PATCH 3/4] UefiPayloadPkg/UefiPayloadPkg.dsc: Consume MicrocodeLib

Signed-off-by: Ray Ni Cc: Maurice Ma Cc: Guo Dong Cc: Benjamin You --- UefiPayloadPkg/UefiPayloadPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc index e3b017858e..37ad5a0ae7 100644 --- a/UefiPayloadPkg/UefiPaylo

[edk2-devel] [PATCH 1/4] UefiCpuPkg: Add MicrocodeLib for loading microcode

Signed-off-by: Ray Ni Cc: Eric Dong Cc: Laszlo Ersek Cc: Rahul Kumar --- UefiCpuPkg/Include/Library/MicrocodeLib.h | 120 +++ .../Library/MicrocodeLib/MicrocodeLib.c | 322 ++ .../Library/MicrocodeLib/MicrocodeLib.inf | 32 ++ UefiCpuPkg/UefiCpuPkg.dec

[edk2-devel] [PATCH 0/4] UefiCpuPkg: Add MicrocodeLib for loading microcode

The patch set creates a new MicrocodeLib for loading microcode. Then updates all platforms to include this lib in DSC. Then updates the MpInitLib to consume this lib. Edk2-platforms change will be sent out in a separate patch set. Ray Ni (4): UefiCpuPkg: Add MicrocodeLib for loading microcode

[edk2-devel] [PATCH 2/4] OvmfPkg: Add MicrocodeLib in DSC files.

Signed-off-by: Ray Ni Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Jordan Justen --- OvmfPkg/AmdSev/AmdSevX64.dsc | 1 + OvmfPkg/Bhyve/BhyveX64.dsc | 1 + OvmfPkg/OvmfPkgIa32.dsc | 1 + OvmfPkg/OvmfPkgIa32X64.dsc | 1 + OvmfPkg/OvmfPkgX64.dsc | 1 + OvmfPkg/OvmfXen.dsc | 1 +

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/1] MinPlatformPkg/Acpi/AcpiSmm: Add Standalone MM support

Pushed: https://github.com/tianocore/edk2-platforms/commit/3250973 > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Monday, March 8, 2021 9:18 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao > ; Dong, Eric > Subject: [edk2-platform

[edk2-devel] [PATCH] IntelFsp2Pkg: Fix multibyte array data issue

Change-Id: Iad50d68a93ea1da13c2264fac7229f2d540531f0 Signed-off-by: Loo Tung Lun --- IntelFsp2Pkg/Tools/FspDscBsf2Yaml.py | 1 - 1 file changed, 1 deletion(-) diff --git a/IntelFsp2Pkg/Tools/FspDscBsf2Yaml.py b/IntelFsp2Pkg/Tools/FspDscBsf2Yaml.py index cad9b60e73..5e94e86db5 100644 --- a/Intel

Re: [edk2-devel] [PATCH v2] MdePkg/BaseLib: Add support for the XSETBV instruction

Reviewed-by: Ray Ni > -Original Message- > From: Wu, Jiaxin > Sent: Friday, April 2, 2021 9:51 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Liming Gao > ; Liu, Zhiguang > ; Ni, Ray ; Yao, Jiewen > ; Zhang, Hongbin1 > > Subject: [PATCH v2] MdePkg/BaseLib: Add support for the

[edk2-devel] [PATCH v2] MdePkg/BaseLib: Add support for the XSETBV instruction

*v2: refine the coding format. https://bugzilla.tianocore.org/show_bug.cgi?id=3284 This patch is to support XSETBV instruction so as to support Extended Control Register(XCR) write. Extended Control Register(XCR) read has already been supported by below commit to support XGETBV instruction: 9b3c

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/1] MinPlatformPkg/Acpi/AcpiSmm: Add Standalone MM support

Reviewed-by: Nate DeSimone > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Monday, March 8, 2021 9:18 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao > ; Dong, Eric > Subject: [edk2-platforms][PATCH v2 1/1] MinPlatformPkg/Acpi/Ac

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/1] MinPlatformPkg/Acpi/AcpiSmm: Add Standalone MM support

Hi Michael, Reply is inline. Thanks, Nate > -Original Message- > From: Michael Kubacki > Sent: Thursday, April 1, 2021 5:50 PM > To: Desimone, Nathaniel L ; > devel@edk2.groups.io; Chiu, Chasel ; Liming Gao > ; Dong, Eric > Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 1/1] > Min

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/1] MinPlatformPkg/Acpi/AcpiSmm: Add Standalone MM support

Hi Nate, Reply is inline. Thanks, Michael On 4/1/2021 12:47 PM, Desimone, Nathaniel L wrote: Hi Michael, Review comments inline. Thanks, Nate -Original Message- From: devel@edk2.groups.io On Behalf Of Michael Kubacki Sent: Friday, March 26, 2021 6:45 PM To: devel@edk2.groups.io; C

Re: [edk2-devel] [Patch 1/1] CryptoPkg: Simplify DSC by using UnitTestFrameworkPkgTarget.dsc.inc

Reviewed-by: Jiewen Yao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael D > Kinney > Sent: Wednesday, March 31, 2021 8:29 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Lu, XiaoyuX ; Jiang, Guomin ; > Bret Barkelew > Subject: [edk2-devel] [Patc

Re: [edk2-devel] [PATCH v1] MdePkg/BaseLib: Add support for the XSETBV instruction

Please fix this: > \ No newline at end of file thanks, ray From: devel@edk2.groups.io on behalf of Wu, Jiaxin Sent: Thursday, April 1, 2021 9:50:29 PM To: devel@edk2.groups.io ; Wu, Jiaxin Cc: Kinney, Michael D ; Liming Gao ; Liu, Zhiguang ; Yao, Jiewen ; Zh

[edk2-devel] Enabling Secure boot

Hi, I have enable the secure boot for CorebootPayloadPkg in EDK 2017 and got the secure boot configuration in the boot menu. But the problem is Attempt secure boot is disabled. Also when I changed from standard mode to custom mode to add vmware key in the db, after reset its not getting saved. T

[edk2-devel] Enabling Secure boot

Hi, I want to enable secure boot in edk2. I am using edk2-2017 with coreboot for Intel architecture. I compiled edk with -D -D SECURE_BOOT_ENABLE and also applied some patches, with this I am getting secure boot configuration in the Boot Menu configuration. But " *AttemptSecureBoot" is disabled

[edk2-devel] Driver health : Posting message in MessageList

Hi , For our products, we have UEFI Driver and HII Driver as two separate images (this is a requirement for our product because we want to keep UEFI Driver as thin as possible). - Main role of UEFI Driver is providing boot services, reporting/solving health issues, posting messages in messa

Re: [edk2-devel] Driver health : Posting message in MessageList

+ Mike On Tue, Mar 30, 2021 at 1:56 AM EDK wrote: > Hi , > > For our products, we have UEFI Driver and HII Driver as two separate > images (this is a requirement for our product because we want to keep UEFI > Driver as thin as possible). > >- Main role of UEFI Driver is providing boot servic

Re: [edk2-devel] [edk2-platforms][PATCH v2 4/5] Vlv2TbltDevicePkg: PlatformPkg DSC: Added library for VariableSmmRuntimeDxe

Thanks for your review, Michael. Could any maintainer please help merging this specific patch? All other patches in this series are already merged into mainline by Liming here (https://edk2.groups.io/g/devel/message/73035). Please let me know if it is preferable for me to send this single pat

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/1] MinPlatformPkg/Acpi/AcpiSmm: Add Standalone MM support

Hi Michael, Review comments inline. Thanks, Nate > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Friday, March 26, 2021 6:45 PM > To: devel@edk2.groups.io; Chiu, Chasel ; Desimone, > Nathaniel L ; Liming Gao > ; Dong, Eric > Subject: Re: [edk2-d

Re: [edk2-devel] [PATCH v3 15/46] Intel/BoardModulePkg: sort load option in the first boot

Hi Ling, This appears to be a duplicate of a patch that has already been applied: https://github.com/tianocore/edk2-platforms/commit/abf4c54 Was this message sent in error? Thanks, Nate > -Original Message- > From: Ling Jia > Sent: Friday, March 12, 2021 3:01 AM > To: devel@edk2.grou

Re: [edk2-devel] [PATCH v3 01/46] TigerlakeOpenBoardPkg: Fix build errors with GCC5

Hi Ling, This appears to be a duplicate of a patch that has already been applied: https://edk2.groups.io/g/devel/message/71894 https://github.com/tianocore/edk2-platforms/commit/12ef75dc Was this message sent in error? Thanks, Nate > -Original Message- > From: Ling Jia > Sent: Frida

Re: [EXTERNAL] [edk2-devel] [PATCH 1/1] MdeModulePkg/BmpSupportLib: Allow BMP with extra data

I agree with the proposal for a deeper security review. I also would suggest that we can provide tooling with BaseTools to check and/or correct the format of a BMP to match what the code expects (since there seems to be ambiguity in the spec/implementation). We’ve got a validator in Mu and woul

Re: [EXTERNAL] [edk2-devel] [PATCH 1/1] BaseTools/Ecc: Update structpcd parsing method.

What does “update” mean in this context? What behavior is changing? - Bret From: Yuwei Chen via groups.io Sent: Thursday, April 1, 2021 12:04 AM To: devel@edk2.groups.io Cc: mliang2x; Feng, Bob C

Re: [edk2-devel] MinPlatform Board port (GSoC 2021)

Hi Benjamin, I sent an email to Google on your #2 question and got the following response: Email address, preferred name and legal name are different things. The legal name is what should match the proof of enrollment. The preferred name is what is public (what mentors will see and will be on t

[edk2-devel] Cancelled Event: TianoCore Design Meeting - APAC/NAMO - Friday, 2 April 2021 #cal-cancelled

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCELLED CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:Asia/Shanghai LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/Asia/Shanghai X-LIC-LOCATION:Asia/Shanghai BEGIN:STANDARD TZNAME:CST TZOFFSETFROM

[edk2-devel] [edk2-platforms][PATCH V2 7/7] Platform/ARM/Morello: Add virtio net support

This patch registers a virtio net device for Morello FVP platform. Signed-off-by: Chandni Cherukuri --- Platform/ARM/Morello/MorelloPlatform.dec| 6 ++ Platform/ARM/Morello/MorelloPlatformFvp.dsc | 7 +++ Platform/ARM/Morello/MorelloPlatformFvp.fdf

[edk2-devel] [edk2-platforms][PATCH V2 6/7] Platform-ARM-Morello: Add Readme.md file

This patch adds Readme.md file for Morello Platform. The document consists of information regarding the platform, steps to build and boot till UEFI Shell on the Morello FVP Platform. Signed-off-by: Chandni Cherukuri --- Platform/ARM/Morello/Readme.md | 46 1 file changed, 46

[edk2-devel] [edk2-platforms][PATCH V2 4/7] Platform/ARM/Morello: Add Configuration Manager for Morello

This patch implements the configuration manager for Morello platform. It enables support for generating the following ACPI tables for Morello FVP Platform: 1. FADT 2. DSDT 3. GTDT 4. MADT 5. SPCR 6. DBG2 7. PPTT

[edk2-devel] [edk2-platforms][PATCH V2 5/7] Platform/ARM/Morello: Add initial support for Morello Platform

From: Anurag Koul This patch adds the initial support for Morello FVP platform. Co-authored-by: Chandni Cherukuri Signed-off-by: Chandni Cherukuri --- Platform/ARM/Morello/MorelloPlatform.dec | 60 Platform/ARM/Morello/MorelloPlatform.dsc.inc | 236 +++ Platform/ARM/More

[edk2-devel] [edk2-platforms][PATCH V2 3/7] Platform/ARM/Morello: Add PlatformDxe driver for Morello

From: Anurag Koul This patch adds the PlatformDxe Driver for Morello platform. It includes the registration of the ramdisk device. Co-authored-by: Chandni Cherukuri Signed-off-by: Chandni Cherukuri --- Platform/ARM/Morello/Drivers/PlatformDxe/PlatformDxeFvp.inf | 44 ++ Platform/A

[edk2-devel] [edk2-platforms][PATCH V2 2/7] Platform/ARM/Morello: Add support for PciHostBridgeLib

Morello FVP platform supports a PCIe root complex. This patch implements PciHostBridgeLib to support PCIe. Signed-off-by: Chandni Cherukuri --- Platform/ARM/Morello/Library/PciHostBridgeLib/PciHostBridgeLibFvp.inf | 48 ++ Platform/ARM/Morello/Library/PciHostBridgeLib/PciHostBridgeLibFvp.c

[edk2-devel] [edk2-platforms][PATCH V2 0/7] Add Morello FVP platform support

Changes since V1: - Added 2 new patches which provide virtio net support and documentation for the Morello FVP platform. - Resolved the coding style errors and ran Ecc. - Replaced function macros with functions in ConfigurationManager. Morello is an ARMv8-A platform that implements the capabilit

[edk2-devel] [edk2-platforms][PATCH V2 1/7] Platform/ARM/Morello: Add Platform library implementation

From: Anurag Koul This patch adds initial Morello Platform Library support. It includes virtual memory map and helper functions for platform initialization. Co-authored-by: Chandni Cherukuri Signed-off-by: Chandni Cherukuri --- Platform/ARM/Morello/Library/PlatformLib/PlatformLib.inf | 52 +

Re: [edk2-devel] [patch V4 16/29] NetworkPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

Reviewed-by: Maciej Rabeda On 28-Mar-21 14:02, Dandan Bi wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLib

Re: [edk2-devel] [PATCH v1] MdePkg/BaseLib: Add support for the XSETBV instruction

Hi Liming and Jiewen, Could you help review the patch? Thanks, Jiaxin > -Original Message- > From: devel@edk2.groups.io On Behalf Of Wu, > Jiaxin > Sent: Wednesday, March 31, 2021 3:54 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Liming Gao > ; Liu, Zhiguang ; Yao, > Jiewen

Re: [edk2-devel] [RFC PATCH 12/19] OvmfPkg/MemEncryptSevLib: Add support to validate system RAM

Hi Yao, On 4/1/21 1:37 AM, Yao, Jiewen wrote: > Hi > Would you please clarify why the IA32 version implementation is empty? > > Does it mean IA32 does not need validate? > Or IA32 should never call this function? > > Anyway, I recommend to add some comment to describe it clearly. > If it should ne

Re: [edk2-devel] [PATCH v1 1/1] UefiCpuPkg: Remove PEI/DXE instances of CpuTimerLib.

1. Since the time it takes to find specified GUID Extension Hob (CpuCrystalFrequencyHob: about 2000ns) is much longer than it takes to calculate TSC frequency with CPUID (about 450ns), I recommend using BaseCpuTimerLib instead of PeiCpuTimerLib. 2. The time it takes to get TSC frequency from glo

[edk2-devel] [PATCH 1/1] Basetools: Keep StdErr in screen when StdOut in file

Currently, when using GCC toolchain and loging the StdOut into files, the StdErr will also be logged into files without shown in screen. This patch fixes this issue. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3278 Cc: Bob Feng Cc: Liming Gao Cc: Wenyi Xie Signed-off-by: Yuwei Chen --

Re: [edk2-devel] [PATCH 1/1] BaseTools/Ecc: Update structpcd parsing method.

Please ignore this patch, sorry for wrong sending. Thanks, Yuwei > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yuwei > Chen > Sent: Thursday, April 1, 2021 3:04 PM > To: devel@edk2.groups.io > Cc: Liang, MingyueX ; Feng, Bob C > ; Liming Gao > Subject: [edk2-devel] [PAT

[edk2-devel] [PATCH 1/1] BaseTools/Ecc: Update structpcd parsing method.

From: mliang2x Update the pcdparser method in Dec and DSC files. Signed-off-by: Mingyue Liang Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen --- .../Ecc/MetaFileWorkspace/MetaFileParser.py | 464 ++ 1 file changed, 265 insertions(+), 199 deletions(-) diff --git a/BaseTools/So