Re: [edk2-devel] [PATCH 0/1] Fix XhciDxe Timeouts

> -Original Message- > From: Laszlo Ersek > Sent: Wednesday, September 2, 2020 2:49 PM > To: devel@edk2.groups.io; Wu, Hao A ; > patrick.h...@hpe.com > Cc: Wang, Jian J ; Ni, Ray ; Liming > Gao (Byosoft address) > Subject: Re: [edk2-devel] [PATCH 0/1] Fix XhciDxe Timeouts > > On 09/02/20

Re: [edk2-devel] [PATCH EDK2 v1 1/1] EmulatorPkg/host: fix overflow in Mult

Ray, On 09/01/20 12:58, wenyi,xie via groups.io wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2947 > > When calculating memory regions and store the information in the > gSystemMemory in file WinHost.c, the code below will cause overflow, > because _wtoi (MemorySizeStr) return an in

Re: [edk2-devel] [PATCH v3] MdeModulePkg/Library: add PEIM and SEC module type to TpmMeasurementLibNull

Jian, Hao, On 09/01/20 09:26, Qi Zhang wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2940 > > Signed-off-by: Qi Zhang > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Jiewen Yao > Reviewed-by: Laszlo Ersek > --- > .../Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf | 2 +- >

Re: [edk2-devel] [PATCH 0/1] Fix XhciDxe Timeouts

On 09/02/20 07:08, Wu, Hao A wrote: >> -Original Message- >> From: patrick.h...@hpe.com >> Sent: Wednesday, September 2, 2020 2:55 AM >> To: devel@edk2.groups.io >> Cc: henz ; Wang, Jian J ; Wu, >> Hao A ; Ni, Ray >> Subject: [PATCH 0/1] Fix XhciDxe Timeouts >> >> From: henz >> >> Timeou

Re: [edk2-devel] [PATCH 0/3] SecurityPkg/DxeImageVerificationLib: catch alignment overflow (CVE-2019-14562)

On 09/02/20 08:41, Yao, Jiewen wrote: > Yes. I recommend to merge to stable202008. Thank you, I will do that soon. Laszlo > > >> -Original Message- >> From: devel@edk2.groups.io On Behalf Of Laszlo Ersek >> Sent: Wednesday, September 2, 2020 2:35 PM >> To: devel@edk2.groups.io; Yao, Ji

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/XhciDxe: Fix Broken Timeouts

Hi Patrick, On 09/01/20 20:55, patrick.h...@hpe.com wrote: > From: henz some meta-comments: (1) Please consider setting the "user.name" item in your git config to your full name, "Patrick Henz". Because right now it seems to be just "henz", and that doesn't look very nice in the git commit hist

Re: [edk2-devel] [PATCH 0/3] SecurityPkg/DxeImageVerificationLib: catch alignment overflow (CVE-2019-14562)

Yes. I recommend to merge to stable202008. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo Ersek > Sent: Wednesday, September 2, 2020 2:35 PM > To: devel@edk2.groups.io; Yao, Jiewen > Cc: Wang, Jian J ; Xu, Min M ; > Wenyi Xie ; Philippe Mathieu-Daudé > ; Liming Ga

[edk2-devel] [PATCH 0/1] Fix XhciDxe Timeouts

From: henz Timeouts in the XhciDxe driver are taking longer than expected due to the timeout loops not accounting for code execution time. As en example, 5 second timeouts have been observed to take around 36 seconds to complete. Use SetTimer and Create/CheckEvent from Boot Services to determine

[edk2-devel] [PATCH 1/1] MdeModulePkg/XhciDxe: Fix Broken Timeouts

From: henz REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2948 Timeouts in the XhciDxe driver are taking longer than expected due to the timeout loops not accounting for code execution time. As en example, 5 second timeouts have been observed to take around 36 seconds to complete. Use SetTim

Re: [edk2-devel] [PATCH 2/3] SecurityPkg/DxeImageVerificationLib: assign WinCertificate after size check

> -Original Message- > From: Laszlo Ersek > Sent: Tuesday, September 01, 2020 5:12 PM > To: edk2-devel-groups-io > Cc: Wang, Jian J ; Yao, Jiewen > ; Xu, Min M ; Wenyi Xie > > Subject: [PATCH 2/3] SecurityPkg/DxeImageVerificationLib: assign > WinCertificate after size check > > Curren

Re: [edk2-devel] [PATCH 3/3] SecurityPkg/DxeImageVerificationLib: catch alignment overflow (CVE-2019-14562)

On September 01, 2020 5:12 PM, Laszlo Ersek wrote: > The DxeImageVerificationHandler() function currently checks whether > "SecDataDir" has enough room for "WinCertificate->dwLength". However, > for advancing "OffSet", "WinCertificate->dwLength" is aligned to the next > multiple of 8. If "WinCertif

Re: [edk2-devel] [PATCH 1/3] SecurityPkg/DxeImageVerificationLib: extract SecDataDirEnd, SecDataDirLeft

> -Original Message- > From: Laszlo Ersek > Sent: Tuesday, September 01, 2020 5:12 PM > To: edk2-devel-groups-io > Cc: Wang, Jian J ; Yao, Jiewen > ; Xu, Min M ; Wenyi Xie > > Subject: [PATCH 1/3] SecurityPkg/DxeImageVerificationLib: extract > SecDataDirEnd, SecDataDirLeft > > The fo

Re: [edk2-devel] [PATCH 0/3] SecurityPkg/DxeImageVerificationLib: catch alignment overflow (CVE-2019-14562)

(+Liming, +Phil) On 09/02/20 06:02, Yao, Jiewen wrote: > The series (1~3) is reviewed-by: Jiewen Yao Thank you Everyone for the reviews and testing. Jiewen: do you think we should merge this series into the master branch before edk2-stable202008? I think it qualifies (it is a CVE fix), but I wo

Re: [edk2-devel] [PATCH 0/1] Fix XhciDxe Timeouts

> -Original Message- > From: patrick.h...@hpe.com > Sent: Wednesday, September 2, 2020 2:55 AM > To: devel@edk2.groups.io > Cc: henz ; Wang, Jian J ; Wu, > Hao A ; Ni, Ray > Subject: [PATCH 0/1] Fix XhciDxe Timeouts > > From: henz > > Timeouts in the XhciDxe driver are taking longer th

[edk2-devel] [PATCH v10 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

Signed-off-by: Vladimir Olovyannikov Cc: Zhichao Gao Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Ray Ni Cc: Liming Gao Cc: Nd Cc: Laszlo Ersek Cc: Samer El-Haj-Mahmoud This patchset introduces an http client utilizing EDK2 HTTP protocol, to allow fast image downloading from http/ht

[edk2-devel] [PATCH v10 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

Introduce an http client utilizing EDK2 HTTP protocol, to allow fast image downloading from http/https servers. HTTP download speed is usually faster than tftp. The client is based on the same approach as tftp dynamic command, and uses the same UEFI Shell command line parameters. This makes it easy

Re: [edk2-devel] [PATCH 0/3] SecurityPkg/DxeImageVerificationLib: catch alignment overflow (CVE-2019-14562)

The series (1~3) is reviewed-by: Jiewen Yao Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo Ersek > Sent: Tuesday, September 1, 2020 5:12 PM > To: edk2-devel-groups-io > Cc: Wang, Jian J ; Yao, Jiewen ; > Xu, Min M ; Wenyi Xie > Subject: [edk

Re: [edk2-devel] [PATCH v9 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

Hi Zhichao, Thank you for the feedback. > -Original Message- > From: Gao, Zhichao > Sent: Tuesday, September 1, 2020 7:32 PM > To: devel@edk2.groups.io; vladimir.olovyanni...@broadcom.com > Cc: Samer El-Haj-Mahmoud ; Laszlo > Ersek ; Maciej Rabeda > ; Wu, Jiaxin ; Fu, > Siyuan ; Ni, Ray ;

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/XhciDxe: Fix Broken Timeouts

In general, thanks for enhancing the logic to take the cmd execution duration into the timeout. 2 minor comments: > > + (EFI_TIMER_PERIOD_MICROSECONDS(0x)): 1. Can you enhance the patch to avoid creating the timer event the Timeout is 0. > > + } while (!

Re: [edk2-devel] [PATCH v9 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

There is no much change for the shell part VS V6. But there are still some coding issue. I already fixed it in my branch https://github.com/ZhichaoGao/edk2/tree/push, only indent issue. Another issue is the EfiTimeToEpoch: --- UINT32 EpochDays; // Number of days elapsed since EPOCH_JULIAN_DA

Re: [edk2-devel] [PATCH v3 3/3] IntelSiliconPkg/PlatformVTdInfoSamplePei: Install Null Root Entry Table

Reviewed-by: Ray Ni > -Original Message- > From: Sheng, W > Sent: Monday, August 31, 2020 2:38 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chaganty, Rangasai V > > Subject: [PATCH v3 3/3] IntelSiliconPkg/PlatformVTdInfoSamplePei: Install > Null Root Entry Table > > BIOS uses TE wit

Re: [edk2-devel] [PATCH 2/3] SecurityPkg/DxeImageVerificationLib: assign WinCertificate after size check

On 2020/9/1 17:12, Laszlo Ersek wrote: > Currently the (SecDataDirLeft <= sizeof (WIN_CERTIFICATE)) check only > guards the de-referencing of the "WinCertificate" pointer. It does not > guard the calculation of the pointer itself: > > WinCertificate = (WIN_CERTIFICATE *) (mImageBase + OffSet)

Re: [edk2-devel] [PATCH 3/3] SecurityPkg/DxeImageVerificationLib: catch alignment overflow (CVE-2019-14562)

On 2020/9/1 17:12, Laszlo Ersek wrote: > The DxeImageVerificationHandler() function currently checks whether > "SecDataDir" has enough room for "WinCertificate->dwLength". However, for > advancing "OffSet", "WinCertificate->dwLength" is aligned to the next > multiple of 8. If "WinCertificate->dw

Re: [edk2-devel] [PATCH 1/3] SecurityPkg/DxeImageVerificationLib: extract SecDataDirEnd, SecDataDirLeft

On 2020/9/1 17:12, Laszlo Ersek wrote: > The following two quantities: > > SecDataDir->VirtualAddress + SecDataDir->Size > SecDataDir->VirtualAddress + SecDataDir->Size - OffSet > > are used multiple times in DxeImageVerificationHandler(). Introduce helper > variables for them: "SecDataDir

Re: [edk2-devel] Basetools as a pip module

> On Sep 1, 2020, at 4:35 PM, Matthew Carlson wrote: > > Hello all, > > A recent topic on the RFC mailing list went out and the work on moving > Basetools/Sources/Python to a separate repo has started. See the RFC > conversation here: https://edk2.groups.io/g/rfc/topic/74009714#270 >

Re: 回复: [edk2-devel] [Patch V2] BaseTools/Ecc: Fix an issue of path separator compatibility

Thank you Laszlo. -Original Message- From: devel@edk2.groups.io On Behalf Of Laszlo Ersek Sent: Wednesday, September 2, 2020 2:04 AM To: devel@edk2.groups.io; gaolim...@byosoft.com.cn; Feng, Bob C Cc: Chen, Christine ; Zhang, Shenglei Subject: Re: 回复: [edk2-devel] [Patch V2] BaseTools

[edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Add check for CR3/GDT/IDT.

AP needs to run from real mode to 32bit mode to LONG mode. Page table (pointed by CR3) and GDT are necessary to set up to correct value when CPU execution mode is switched to LONG mode. AP uses the same location page table (CR3) and GDT as what BSP uses. But when the page table or GDT is above 4GB,

回复: 回复: [edk2-devel] [Patch V2] BaseTools/Ecc: Fix an issue of path separator compatibility

Laszlo: Thank you! Liming > -邮件原件- > 发件人: bounce+27952+64917+4905953+8761...@groups.io > 代表 Laszlo Ersek > 发送时间: 2020年9月2日 2:04 > 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn; > bob.c.f...@intel.com > 抄送: 'Yuwei Chen' ; 'Shenglei Zhang' > > 主题: Re: 回复: [edk2-devel] [Patch V2] Ba

[edk2-devel] Basetools as a pip module

Hello all, A recent topic on the RFC mailing list went out and the work on moving Basetools/Sources/Python to a separate repo has started. See the RFC conversation here: https://edk2.groups.io/g/rfc/topic/74009714#270 The repo in question is here: https://github.com/tianocore/edk2-basetools The

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH V2 2/2] EdkRepo: Add support for subst drives

Instead of looping over the dictionary, could we convert the target drive and see if it's in the dictionary? I am thinking like remove the : from os.path.splitdrive(workspace_dir)[0].upper() string and see if that's in the dictionary? > -Original Message- > From: devel@edk2.groups.io

[edk2-devel] Cancelling September Community meeting

Dear Community members, I plan on cancelling the September 3rd community meeting due to the holiday week (labor day) in US and no updates from the Stewards call since this week's Stewards meeting has also been cancelled. Let's resume during October. Please send me any topics that you like to dis

[edk2-devel] Cancelled Event: TianoCore Community Meeting - EMEA / NAMO - Thursday, 3 September 2020 #cal-cancelled

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCELLED CALSCALE:GREGORIAN BEGIN:VEVENT UID:1ao6.1590558161886501237.j...@groups.io DTSTAMP:20200901T210321Z ORGANIZER;CN=Soumya Guptha:mailto:soumya.k.gup...@intel.com DTSTART:20200903T16Z DTEND:20200903T17000

[edk2-devel] Cancelled Event: TianoCore Community Meeting - APAC / NAMO - Thursday, 3 September 2020 #cal-cancelled

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCELLED CALSCALE:GREGORIAN BEGIN:VEVENT UID:1i0d.1590558226951005717.t...@groups.io DTSTAMP:20200901T210352Z ORGANIZER;CN=Soumya Guptha:mailto:soumya.k.gup...@intel.com DTSTART:20200904T023000Z DTEND:20200904T03300

[edk2-devel] [PATCH edk2-platforms 1/1] SbsaQemu: AcpiDxe: Read MPIDR from device tree

The Qemu device tree for Sbsa platform now contains MPIDR value for every CPU in the form of "reg" property under every CPU's node. Hence, add a function that provides support to read this value from the device tree. Signed-off-by: Tanmay Jagdale --- .../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c

Re: [edk2-devel] [PATCH v3 0/6] Extend Last Attempt Status Usage

Hi Mike, I agree that's a good way to meet the requirement. Maintaining the two APIs would just be a transient state (i.e. on order of days) to update edk2-platforms users and then we could remove the old API, right? Our main concern was maintaining the two APIs side-by-side long term. Thank

Re: 回复: [edk2-devel] [Patch V2] BaseTools/Ecc: Fix an issue of path separator compatibility

On 09/01/20 16:42, gaoliming wrote: > Reviewed-by: Liming Gao Merged in commit 751355992635, via . Thanks Laszlo >> -邮件原件- >> 发件人: bounce+27952+64887+4905953+8761...@groups.io >> 代表 Bob Feng >> 发送时间: 2020年9月1日 18:23 >> 收件人: devel@edk2.groups.

[edk2-devel] [PATCH v10 0/5] Use RngLib instead of TimerLib for OpensslLib

From: Matthew Carlson Hello all, This patch contains a fix for Bugzilla 1871. There's been a good bit of community discussion around the topic, so below follows a general overview of the discussion and what this patch does. This is the seventh iteration of this patch series, focused on code sty

[edk2-devel] [PATCH v10 5/5] CryptoPkg: OpensslLib: Use RngLib to generate entropy in rand_pool

From: Matthew Carlson Ref: https://github.com/tianocore/edk2/pull/845 Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871 Changes OpenSSL to no longer depend on TimerLib and instead use RngLib. This allows platforms to decide for themsevles what sort of entropy source they provide to OpenSS

[edk2-devel] [PATCH v10 2/5] MdePkg: BaseRngLibDxe: Add RngLib that uses RngDxe

From: Matthew Carlson This adds a RngLib that uses the RngProtocol to provide randomness. This means that the RngLib is meant to be used with DXE_DRIVERS. Ref: https://github.com/tianocore/edk2/pull/845 Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871 Cc: Ard Biesheuvel Cc: Michael D K

[edk2-devel] [PATCH v10 0/5] Use RngLib instead of TimerLib for OpensslLib

From: Matthew Carlson Hello all, This patch contains a fix for Bugzilla 1871. There's been a good bit of community discussion around the topic, so below follows a general overview of the discussion and what this patch does. This is the seventh iteration of this patch series, focused on code sty

[edk2-devel] [PATCH v10 1/5] MdePkg: TimerRngLib: Added RngLib that uses TimerLib

From: Matthew Carlson Added a new RngLib that provides random numbers from the TimerLib using the performance counter. This is meant to be used for OpenSSL to replicate past behavior. This should not be used in production as a real source of entropy. Ref: https://github.com/tianocore/edk2/pull/8

[edk2-devel] [PATCH v10 4/5] ArmVirtPkg: Add RngLib based on TimerLib for CryptoPkg

From: Matthew Carlson Updates the DSC for the ArmVirtPkg platform to add a RngLib that uses the TimerLib. This is due to a later change that adds TimerLib as a dependency for OpenSSL. The TimerLib based RngLib mimics the behavior of OpenSSL previously and it is recommended to switch to a better s

[edk2-devel] [PATCH v10 3/5] OvmfPkg: Add RngLib based on TimerLib for Crypto

From: Matthew Carlson Updates the DSC's for Ovmf based platforms to add a RngLib that uses the TimerLib. This is due to a later change that adds TimerLib as a dependency for OpenSSL. The TimerLib based RngLib mimics the behavior of OpenSSL previously and it is recommended to switch to a better so

Re: [edk2-devel] [PATCH] SecurityPkg: Initailize variable Status before it is consumed.

On 09/01/20 09:02, Laszlo Ersek wrote: > On 09/01/20 02:55, Zhiguang Liu wrote: >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2945 >> >> V2: Move "Status = EFI_SUCCESS;" before the EDKII_TCG_PRE_HASH check. >> >> Cc: Jiewen Yao >> Cc: Jian J Wang >> Cc: Qi Zhang >> Cc: Rahul Kumar >> C

Re: [edk2-devel] [PATCH 3/3] SecurityPkg/DxeImageVerificationLib: catch alignment overflow (CVE-2019-14562)

On 09/01/20 17:53, Philippe Mathieu-Daudé wrote: > Hi Laszlo, > > On 9/1/20 11:12 AM, Laszlo Ersek wrote: >> The DxeImageVerificationHandler() function currently checks whether >> "SecDataDir" has enough room for "WinCertificate->dwLength". However, for >> advancing "OffSet", "WinCertificate->dwLen

Re: [edk2-devel] [PATCH 3/3] SecurityPkg/DxeImageVerificationLib: catch alignment overflow (CVE-2019-14562)

Hi Laszlo, On 9/1/20 11:12 AM, Laszlo Ersek wrote: > The DxeImageVerificationHandler() function currently checks whether > "SecDataDir" has enough room for "WinCertificate->dwLength". However, for > advancing "OffSet", "WinCertificate->dwLength" is aligned to the next > multiple of 8. If "WinCerti

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec: add FspMeasurementLib.h

On 09/01/20 02:50, Qi Zhang wrote: > Thanks Chasel! > > Hi, Liming > > I request this change to catch the stable release. Thanks! > > BRs > Qi Zhang > >> -Original Message- >> From: Chiu, Chasel >> Sent: Monday, August 31, 2020 10:54 AM >> To: Zhang, Qi1 ; devel@edk2.groups.io >> Cc: D

Re: [edk2-devel] [PATCH 2/3] SecurityPkg/DxeImageVerificationLib: assign WinCertificate after size check

On 9/1/20 11:12 AM, Laszlo Ersek wrote: > Currently the (SecDataDirLeft <= sizeof (WIN_CERTIFICATE)) check only > guards the de-referencing of the "WinCertificate" pointer. It does not > guard the calculation of the pointer itself: > > WinCertificate = (WIN_CERTIFICATE *) (mImageBase + OffSet);

Re: [edk2-devel] [PATCH 1/3] SecurityPkg/DxeImageVerificationLib: extract SecDataDirEnd, SecDataDirLeft

On 9/1/20 11:12 AM, Laszlo Ersek wrote: > The following two quantities: > > SecDataDir->VirtualAddress + SecDataDir->Size > SecDataDir->VirtualAddress + SecDataDir->Size - OffSet > > are used multiple times in DxeImageVerificationHandler(). Introduce helper > variables for them: "SecDataDirEn

Re: 回复: 回复: [edk2-devel] Patch List for 202008 stable tag

On 09/01/20 16:57, gaoliming wrote: > Hi, all > Now, we are in Hard Feature Freeze phase. 202008 stable tag will be > created on 2020-09-04 Date (00:00:00 UTC-8). > If you request any bug fix to catch this stable tag, please send your > request one day before 2020-09-04. > And, also make sure

回复: 回复: [edk2-devel] Patch List for 202008 stable tag

Hi, all Now, we are in Hard Feature Freeze phase. 202008 stable tag will be created on 2020-09-04 Date (00:00:00 UTC-8). If you request any bug fix to catch this stable tag, please send your request one day before 2020-09-04. And, also make sure this patch pass code review one day before 2020

Re: [edk2-devel] TCP Port for ISCSI Connection

Maciej, Thanks for the clarification. I agree with you. -Siva From: Rabeda, Maciej [mailto:maciej.rab...@linux.intel.com] Sent: Tuesday, September 1, 2020 8:12 PM To: Sivaraman Nainar; devel@edk2.groups.io Subject: Re: [edk2-devel] TCP Port for ISCSI Connection Siva, iSCSI targets can be config

回复: [edk2-devel] [Patch V2] BaseTools/Ecc: Fix an issue of path separator compatibility

Reviewed-by: Liming Gao > -邮件原件- > 发件人: bounce+27952+64887+4905953+8761...@groups.io > 代表 Bob Feng > 发送时间: 2020年9月1日 18:23 > 收件人: devel@edk2.groups.io > 抄送: Liming Gao ; Yuwei Chen > ; Shenglei Zhang > 主题: [edk2-devel] [Patch V2] BaseTools/Ecc: Fix an issue of path separator > compatibi

Re: [edk2-devel] TCP Port for ISCSI Connection

Siva, iSCSI targets can be configured to listen on any TCP port. Changing the UEFI iSCSI Client's TargetPort min/max will effectively prevent the user from communicating with the targets configured to listen on ports outside that range (in your example: below 1024). I do not see a reason behind

Re: [edk2-devel] [PATCH v3 2/3] IntelSiliconPkg/IntelVTdPmrPei: Fix PMR enabling setting confilct

Reviewed-by: Ray Ni > -Original Message- > From: Sheng, W > Sent: Monday, August 31, 2020 2:38 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chaganty, Rangasai V > > Subject: [PATCH v3 2/3] IntelSiliconPkg/IntelVTdPmrPei: Fix PMR enabling > setting confilct > > PMR enabling set by pr

Re: [edk2-devel] [PATCH v3 1/3] IntelSiliconPkg/VtdInfo: Add Null Root Entry Table PPI

Reviewed-by: Ray Ni > -Original Message- > From: Sheng, W > Sent: Monday, August 31, 2020 2:38 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chaganty, Rangasai V > > Subject: [PATCH v3 1/3] IntelSiliconPkg/VtdInfo: Add Null Root Entry Table PPI > > Null root entry table address is a f

Re: [edk2-devel] TCP Port for ISCSI Connection

Hello Maciej: The ports numbers from 0 to 1023 are having specific roles. Ex: 80 for HTTTP, 443 for HTTPS. In the case can we set Min as 1024 and Max as 65535. Thanks Siva From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Maciej Rabeda Sent: Tuesday, September 1, 2020 7:32

Re: [edk2-devel] TCP Port for ISCSI Connection

Hi Siva, What seems to be the problem at hand? What kind of range of values for TargetPort do you propose? TARGET_PORT_MIN/MAX_NUM refer to a range of values (0-65535) that be set in TargetPort field in iSCSI HII. 3260 is a default TCP port for iSCSI. I see nothing wrong with that. Thanks, Ma

Re: 回复: [edk2-devel] Patch List for 202008 stable tag

On 09/01/20 11:35, gaoliming wrote: > Hi, all > There are still some patches to be merged for 202008 stable tag. They > are all bug fixes. The risk is low. I agree to catch them in this > stable tag. If you have other comments, please reply this mail. > > https://edk2.groups.io/g/devel/message/6487

Re: [edk2-devel] [PATCH v4 0/6] Platform/RasberryPi: Thermal zone

On 8/31/20 7:25 PM, Jeremy Linton wrote: This set creates a basic thermal zone, which reads the SOC temp via a direct register read in AML. It also adds an active cooling policy using a GPIO pin for fan control that can optionally be enabled/disabled on either GPIO18 (commercial fan shim board) o

Re: [edk2-devel] [PATCH v4 6/6] Platform/RaspberryPi: Trivial whitespace cleanup

Hi Ard, On 2020.09.01 12:39, Ard Biesheuvel wrote: On 8/31/20 7:25 PM, Jeremy Linton wrote: Pete's review pointed out some whitespace issues in the context of a previous patch. Since there are a number of similar errors in the file lets fix them separately. Cc: Leif Lindholm Cc: Pete Batard

Re: [edk2-devel] [PATCH v4 6/6] Platform/RaspberryPi: Trivial whitespace cleanup

On 8/31/20 7:25 PM, Jeremy Linton wrote: Pete's review pointed out some whitespace issues in the context of a previous patch. Since there are a number of similar errors in the file lets fix them separately. Cc: Leif Lindholm Cc: Pete Batard Cc: Andrei Warkentin Cc: Ard Biesheuvel Cc: Samer E

[edk2-devel] [PATCH EDK2 v1 0/1] EmulatorPkg/host: fix overflow in Mult

Main Changes : convert int to uint64 to avoid overflow when Multiply two int. Wenyi Xie (1): EmulatorPkg/host: fix overflow in Mult EmulatorPkg/Win/Host/WinHost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive

[edk2-devel] [PATCH EDK2 v1 1/1] EmulatorPkg/host: fix overflow in Mult

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2947 When calculating memory regions and store the information in the gSystemMemory in file WinHost.c, the code below will cause overflow, because _wtoi (MemorySizeStr) return an int value and SIZE_1MB is also an int value, if MemorySizeStr is lag

Re: [edk2-devel] [Patch 1/1] BaseTools/Ecc: Fix an issue of path separator compatibility

Laszlo, 1) there is no special reason not using os.sep, I sent out a new patch to use it. Liming, 2) If this patch can be included in this stable tag, that will great. From the Bugzilla, I see this issue will block patch merging. Thanks, Bob -Original Message- From: Laszlo Ersek S

[edk2-devel] [Patch V2] BaseTools/Ecc: Fix an issue of path separator compatibility

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2904 The path separator is different in Windows and Linux, the original code does not handle this difference. This patch is to fix this issue. Signed-off-by: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Cc: Shenglei Zhang --- V2 Change to a better

回复: [edk2-devel] Patch List for 202008 stable tag

Hi, all There are still some patches to be merged for 202008 stable tag. They are all bug fixes. The risk is low. I agree to catch them in this stable tag. If you have other comments, please reply this mail. https://edk2.groups.io/g/devel/message/64873 [PATCH v3] MdeModulePkg/Library: add PEIM

[edk2-devel] [PATCH 3/3] SecurityPkg/DxeImageVerificationLib: catch alignment overflow (CVE-2019-14562)

The DxeImageVerificationHandler() function currently checks whether "SecDataDir" has enough room for "WinCertificate->dwLength". However, for advancing "OffSet", "WinCertificate->dwLength" is aligned to the next multiple of 8. If "WinCertificate->dwLength" is large enough, the alignment will return

[edk2-devel] [PATCH 0/3] SecurityPkg/DxeImageVerificationLib: catch alignment overflow (CVE-2019-14562)

Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=2215 Repo: https://pagure.io/lersek/edk2.git Branch: tianocore_2215 I'm neutral on whether this becomes part of edk2-stable202008. Cc: Jian J Wang Cc: Jiewen Yao Cc: Min Xu Cc: Wenyi Xie Thanks, Laszlo Laszlo Ersek (3): SecurityPkg/

[edk2-devel] [PATCH 1/3] SecurityPkg/DxeImageVerificationLib: extract SecDataDirEnd, SecDataDirLeft

The following two quantities: SecDataDir->VirtualAddress + SecDataDir->Size SecDataDir->VirtualAddress + SecDataDir->Size - OffSet are used multiple times in DxeImageVerificationHandler(). Introduce helper variables for them: "SecDataDirEnd" and "SecDataDirLeft", respectively. This saves us m

[edk2-devel] [PATCH 2/3] SecurityPkg/DxeImageVerificationLib: assign WinCertificate after size check

Currently the (SecDataDirLeft <= sizeof (WIN_CERTIFICATE)) check only guards the de-referencing of the "WinCertificate" pointer. It does not guard the calculation of the pointer itself: WinCertificate = (WIN_CERTIFICATE *) (mImageBase + OffSet); This is wrong; if we don't know for sure that we

[edk2-devel] Cancelled Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, 1 September 2020 #cal-cancelled

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCELLED CALSCALE:GREGORIAN BEGIN:VEVENT UID:mlda.1580078539586725120.r...@groups.io DTSTAMP:20200901T085154Z ORGANIZER;CN=Brian Richardson:mailto:brian.richard...@intel.com DTSTART:20200902T013000Z DTEND:20200902T0

回复: [edk2-devel] TianoCore Bug Triage - APAC / NAMO - Tue, 09/01/2020 6:30pm-7:30pm #cal-reminder

Hi, all There is only one new BZ with unassig...@tianocore.org . So, I will cancel this week bug triage meeting. 2946 EDK2 Code unassig...@tianocore.org UNCO BrotliCustomDecompressLib : Destinati

Re: [edk2-devel] [Patch 1/1] BaseTools/Ecc: Fix an issue of path separator compatibility

On 08/31/20 18:14, Bob Feng wrote: > From: "Bob Feng" > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2904 > > The path separator is different in Windows and Linux, the > original code does not handle this difference. This patch > is to fix this issue. > > Signed-off-by: Bob Feng > Cc:

Re: [edk2-devel] [PATCH v3] MdeModulePkg/Library: add PEIM and SEC module type to TpmMeasurementLibNull

On 09/01/20 09:26, Qi Zhang wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2940 > > Signed-off-by: Qi Zhang > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Jiewen Yao > Reviewed-by: Laszlo Ersek > --- > .../Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf | 2 +- > 1 file cha

Re: [edk2-devel] [PATCH EDK2 v2 1/1] SecurityPkg/DxeImageVerificationLib:Enhanced verification of Offset

On 09/01/20 09:43, xiewenyi (A) wrote: > To Jiewen, > > Sorry to make you lost，I mean the patches Laszlo proposed in email， > https://edk2.groups.io/g/devel/message/64243 > eb0c6bcb-77fb-2fb9-783e-aa5025953a80@redhat.com">http://mid.mail-archive.com/eb0c6bcb-77fb-2fb9-783e-aa5025953a80@redhat.com

Re: [edk2-devel] [PATCH EDK2 v2 1/1] SecurityPkg/DxeImageVerificationLib:Enhanced verification of Offset

To Jiewen, Sorry to make you lost，I mean the patches Laszlo proposed in email， https://edk2.groups.io/g/devel/message/64243 eb0c6bcb-77fb-2fb9-783e-aa5025953a80@redhat.com">http://mid.mail-archive.com/eb0c6bcb-77fb-2fb9-783e-aa5025953a80@redhat.com To Laszlo, Sure, I will test your patches again

Re: [edk2-devel] [PATCH EDK2 v2 1/1] SecurityPkg/DxeImageVerificationLib:Enhanced verification of Offset

I am sorry, that I am a little lost here. We have discussed different patches. I am not 100% sure which one is "Laszlo's patches". To make thing easy and record all actions, would you please reply the patch(es) you have verified, with your "tested-by:" tag? Thank you Yao Jiewen > -Origina

Re: [edk2-devel] [PATCH EDK2 v2 1/1] SecurityPkg/DxeImageVerificationLib:Enhanced verification of Offset

On 08/31/20 18:06, Yao, Jiewen wrote: > Sounds great. Appreciate your hard work on that. > > Will you post a patch to fix the issue again? Should I post the three patches that I had counter-proposed as a standalone series? See them at the end of the following message, in-line: https://edk2.grou

[edk2-devel] [PATCH v3] MdeModulePkg/Library: add PEIM and SEC module type to TpmMeasurementLibNull

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2940 Signed-off-by: Qi Zhang Cc: Jian J Wang Cc: Hao A Wu Cc: Jiewen Yao Reviewed-by: Laszlo Ersek --- .../Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeM

Re: [edk2-devel] [PATCH] SecurityPkg: Initailize variable Status before it is consumed.

Hi Liming, Can this patch check in before this stable tag? Thanks Zhiguang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Zhiguang > Liu > Sent: Tuesday, September 1, 2020 8:55 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Zhang, Qi1 ; Kumar, Rahul1 ;

Re: [edk2-devel] [PATCH EDK2 v2 1/1] SecurityPkg/DxeImageVerificationLib:Enhanced verification of Offset

I think Laszlo's patches is OK, I have applied and tested it using my case. It can catch the issue. DEBUG code and log below, SecDataDirEnd = SecDataDir->VirtualAddress + SecDataDir->Size; DEBUG((DEBUG_INFO, "SecDataDirEnd=0x%x.\n", SecDataDirEnd)); for (OffSet = SecDataDir->VirtualAddress;

Re: [edk2-devel] [PATCH v2] MdeModulePkg/Library: add PEIM and SEC module type to TpmMeasurementLibNull

On 09/01/20 03:35, Qi Zhang wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2940 > > Signed-off-by: Qi Zhang > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Jiewen Yao > --- > .../Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf | 2 +- > 1 file changed, 1 insertion(+), 1 delet

Re: [edk2-devel] [PATCH] SecurityPkg: Initailize variable Status before it is consumed.

On 09/01/20 02:55, Zhiguang Liu wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2945 > > V2: Move "Status = EFI_SUCCESS;" before the EDKII_TCG_PRE_HASH check. > > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Qi Zhang > Cc: Rahul Kumar > Cc: Laszlo Ersek > Reviewed-by: Jiewen Yao > Si