In general, thanks for enhancing the logic to take the cmd execution duration into the timeout. 2 minor comments:
> > + (EFI_TIMER_PERIOD_MICROSECONDS(0xFFFFFFFF)): 1. Can you enhance the patch to avoid creating the timer event the Timeout is 0. > > + } while (!EFI_ERROR(TimerStatus) && EFI_ERROR(gBS->CheckEvent > (TimeoutEvent))); > 2. Can you please move the !EFI_ERROR (TimerStatus) check from the while() to outside of while()? Because this status value never changes in while loop. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64934): https://edk2.groups.io/g/devel/message/64934 Mute This Topic: https://groups.io/mt/76575773/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
