On 09/02/20 07:08, Wu, Hao A wrote: >> -----Original Message----- >> From: [email protected] <[email protected]> >> Sent: Wednesday, September 2, 2020 2:55 AM >> To: [email protected] >> Cc: henz <[email protected]>; Wang, Jian J <[email protected]>; Wu, >> Hao A <[email protected]>; Ni, Ray <[email protected]> >> Subject: [PATCH 0/1] Fix XhciDxe Timeouts >> >> From: henz <[email protected]> >> >> Timeouts in the XhciDxe driver are taking longer than expected due to the >> timeout loops not accounting for code execution time. As en example, 5 second >> timeouts have been observed to take around 36 seconds to complete. >> Use SetTimer and Create/CheckEvent from Boot Services to determine when >> timeout occurred. This patch was tested using forced timeouts and print >> statements with QEmu as well as phycial hardware. The forced timeouts were >> implemented in code via static variables that guaranteed a timeout the first >> time >> the function with the broken timeout was called. >> >> Example: >> >> XhcExecTransfer ( >> . >> . >> ) >> { >> . >> . >> static int do_once = 1; // test line >> . >> . >> do { >> Finished = XhcCheckUrbResult (Xhc, Urb); >> if (do_once) Finished = 0; // test line >> if (Finished) { >> break; >> } >> gBS->Stall (XHC_1_MICROSECOND); >> } while (!EFI_ERROR(TimerStatus) && EFI_ERROR(gBS->CheckEvent >> (TimeoutEvent))); >> >> do_once = 0; // test line >> >> Using this forced timeout approach the correct timeouts were observed on both >> hardware and in QEmu. >> >> Similar broken timeout loops have been found in the Uhci and Ehci drivers. >> This >> patch does not fix those issues. > > > Hello Patrick, > > Besides the comments made by Ray in patch 1, could you help to provide 2 more > patches for UHCI and EHCI drivers as well for complete enhancement? > Thanks in advance.
We're very close to the edk2-stable202008 tag deadline. This patch -- which in v2 is going to be a patch series -- is not aiming at the stable tag, does it? Thanks! Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64949): https://edk2.groups.io/g/devel/message/64949 Mute This Topic: https://groups.io/mt/76576825/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
