Re: [edk2-devel] Http redirection handling using HttpDxe driver

2020-08-31 Thread Michael Turner via groups.io
The workaround we used was to open and close a new connection for every URL. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64868): https://edk2.groups.io/g/devel/message/64868 Mute This Topic: https://groups.io/mt/76459258/21656 Group Ow

[edk2-devel] [PATCH v2] MdeModulePkg/Library: add PEIM and SEC module type to TpmMeasurementLibNull

2020-08-31 Thread Qi Zhang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2940 Signed-off-by: Qi Zhang Cc: Jian J Wang Cc: Hao A Wu Cc: Jiewen Yao --- .../Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Library/TpmMeasure

[edk2-devel] TianoCore Bug Triage - APAC / NAMO - Tue, 09/01/2020 6:30pm-7:30pm #cal-reminder

2020-08-31 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Tuesday, 1 September 2020, 6:30pm to 7:30pm, (GMT-07:00) America/Los Angeles *Where:* https://bluejeans.com/889357567?src=join_info View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=816389 ) *Organizer:* Brian Richardson brian.

[edk2-devel] [PATCH] SecurityPkg: Initailize variable Status before it is consumed.

2020-08-31 Thread Zhiguang Liu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2945 V2: Move "Status = EFI_SUCCESS;" before the EDKII_TCG_PRE_HASH check. Cc: Jiewen Yao Cc: Jian J Wang Cc: Qi Zhang Cc: Rahul Kumar Cc: Laszlo Ersek Reviewed-by: Jiewen Yao Signed-off-by: Zhiguang Liu --- SecurityPkg/Tcg/Tcg2Pei/Tcg2P

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec: add FspMeasurementLib.h

2020-08-31 Thread Qi Zhang
Thanks Chasel! Hi, Liming I request this change to catch the stable release. Thanks! BRs Qi Zhang > -Original Message- > From: Chiu, Chasel > Sent: Monday, August 31, 2020 10:54 AM > To: Zhang, Qi1 ; devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Liming Gao > ; Dong, Eric > Subjec

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v2] EdkRepo: Return exit codes in edkrepo_entry_point.py

2020-08-31 Thread Nate DeSimone
The use of parenthesis is a little odd since "return" is a keyword not a function... but what you have is valid Python syntax and it won't become a tuple since there is no comma. Reviewed-by: Nate DeSimone -Original Message- From: Desimone, Ashley E Sent: Friday, August 21, 2020 12:5

[edk2-devel] [edk2-staging/EdkRepo] [PATCH V2 0/2] EdkRepo: Add support for SUBST drives

2020-08-31 Thread Nate DeSimone
Changes in V2: - Changed get_subst_drive_list() to get_subst_drive_dict() EdkRepo currently does not handle virtual drives created using the SUBST command. Specifically, when cloning or syncing a project to a subst drive the includeIf statements that redirect submodule fetches to mirror servers

[edk2-devel] [edk2-staging/EdkRepo] [PATCH V2 2/2] EdkRepo: Add support for subst drives

2020-08-31 Thread Nate DeSimone
get_workspace_path() now converts a virtual drive path to a real path before any git repo operations are done. Cc: Ashley E Desimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Cc: Erik Bjorge Signed-off-by: Nate DeSimone --- edkrepo/commands/clone_command.py | 6 ++ edkrepo/c

Re: [edk2-devel] [PATCH v4 5/6] Platform/RaspberryPi4: Allow the user to set Temp

2020-08-31 Thread Ard Biesheuvel
On 8/31/20 8:57 PM, Pete Batard wrote: One remark about using PcdSet32S ()  as opposed to PcdSet32 (), since we just went through an exercise making sure that we switched to the secure version of these calls. On 2020.08.31 18:25, Jeremy Linton wrote: Now that we have the ability to enable an

Re: [edk2-devel] [PATCH v4 5/6] Platform/RaspberryPi4: Allow the user to set Temp

2020-08-31 Thread Pete Batard
One remark about using PcdSet32S () as opposed to PcdSet32 (), since we just went through an exercise making sure that we switched to the secure version of these calls. On 2020.08.31 18:25, Jeremy Linton wrote: Now that we have the ability to enable an AML fan object, allow the user to select

Re: [edk2-devel] [PATCH v4 2/6] Platform/RaspberryPi: Monitor ACPI Table installs

2020-08-31 Thread Andrei Warkentin
This is really cool. Can be useful in a number of other places down the line (e.g. MAC address via device properties). Reviewed-by: Andrei Warkentin From: Jeremy Linton Sent: Monday, August 31, 2020 12:25 PM To: devel@edk2.groups.io Cc: Jeremy Linton ; Leif Lin

[edk2-devel] [PATCH v4 1/6] Platform/RaspberryPi4: Add a basic thermal zone

2020-08-31 Thread Jeremy Linton
Rather than exporting the temp sensor or mailbox in ACPI land we can wrap them in AML and use the default ACPI drivers provided by the OS. This enables the use of "sensors" in linux to report the SOC temp. As a first pass add a basic passive cooling ACPI thermalzone with trip points for passive co

[edk2-devel] [PATCH v4 6/6] Platform/RaspberryPi: Trivial whitespace cleanup

2020-08-31 Thread Jeremy Linton
Pete's review pointed out some whitespace issues in the context of a previous patch. Since there are a number of similar errors in the file lets fix them separately. Cc: Leif Lindholm Cc: Pete Batard Cc: Andrei Warkentin Cc: Ard Biesheuvel Cc: Samer El-Haj-Mahmoud Signed-off-by: Jeremy Linton

[edk2-devel] [PATCH v4 4/6] Platform/RaspberryPi4: Create ACPI fan object

2020-08-31 Thread Jeremy Linton
Now that we have a thermal zone we can add active cooling by specifying active cooling points (_ACx) which can be tied to fan objects that turn fans on/off using GPIO pins. Cc: Leif Lindholm Cc: Pete Batard Cc: Andrei Warkentin Cc: Ard Biesheuvel Cc: Samer El-Haj-Mahmoud Signed-off-by: Jeremy

[edk2-devel] [PATCH v4 0/6] Platform/RasberryPi: Thermal zone

2020-08-31 Thread Jeremy Linton
This set creates a basic thermal zone, which reads the SOC temp via a direct register read in AML. It also adds an active cooling policy using a GPIO pin for fan control that can optionally be enabled/disabled on either GPIO18 (commercial fan shim board) or GPIO19 by the user from the BDS. it shou

[edk2-devel] [PATCH v4 2/6] Platform/RaspberryPi: Monitor ACPI Table installs

2020-08-31 Thread Jeremy Linton
Hook the ACPI table install sequence and add some basic conditional and AML NameOp update logic. If a table has a non-zero PCD declared that pcd is checked for a non-zero value before allowing the table to be installed. We also add a table of NameOp to PCD's which will be written into a DSDT/SSDT t

[edk2-devel] [PATCH v4 3/6] Platform/RaspberryPi: Add entry for user fan control

2020-08-31 Thread Jeremy Linton
Add a menu item that allows the user to enable GPIO based fan control via SSDT and the previous NameObj replacement commit. This should only be seen/enabled on RPI4 because that is what its been tested with. Given GPIO pin current limitations its likely that a bit of additional circuitry is requir

[edk2-devel] [PATCH v4 5/6] Platform/RaspberryPi4: Allow the user to set Temp

2020-08-31 Thread Jeremy Linton
Now that we have the ability to enable an AML fan object, allow the user to select the temperature at which the fan cycles on. Cc: Leif Lindholm Cc: Pete Batard Cc: Andrei Warkentin Cc: Ard Biesheuvel Cc: Samer El-Haj-Mahmoud Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/AcpiTables/

Re: [edk2-devel] [PATCH V2 2/2] BaseTools: Factorize GCC flags

2020-08-31 Thread Ard Biesheuvel
On 8/31/20 6:27 PM, Laszlo Ersek wrote: On 08/31/20 18:18, Laszlo Ersek wrote: Obviously the following form would be preferred: scl enable example -- less --version Because this form would not require quoting, just prefixing. I need to slow down when reading manual pages. Now that I've a

Re: [edk2-devel] [PATCH V2 2/2] BaseTools: Factorize GCC flags

2020-08-31 Thread Laszlo Ersek
On 08/31/20 18:18, Laszlo Ersek wrote: > Obviously the following form would be preferred: > > scl enable example -- less --version > > Because this form would not require quoting, just prefixing. I need to slow down when reading manual pages. Now that I've actually *tried* the above, it works

Re: [edk2-devel] [PATCH V2 2/2] BaseTools: Factorize GCC flags

2020-08-31 Thread Laszlo Ersek
On 08/31/20 16:37, Ard Biesheuvel wrote: > Not sure how Leif feels about this, but i wouldn't mind retaining > GCC48 support only for IA32/X64. I've never considered GCC48 usable for ARM/AARCH64. I already use GCC48 for IA32/X64 only. Anyway... it looks like I am able to consume gcc-9 ("devtools

[edk2-devel] [Patch 1/1] BaseTools/Ecc: Fix an issue of path separator compatibility

2020-08-31 Thread Bob Feng
From: "Bob Feng" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2904 The path separator is different in Windows and Linux, the original code does not handle this difference. This patch is to fix this issue. Signed-off-by: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Cc: Shenglei Zhang --- B

[edk2-devel] [Patch 1/1] BaseTools/Ecc: Fix an issue of path separator compatibility

2020-08-31 Thread Bob Feng
From: "Bob Feng" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2904 The path separator is different in Windows and Linux, the original code does not handle this difference. This patch is to fix this issue. Signed-off-by: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Cc: Shenglei Zhang --- B

Re: [edk2-devel] [PATCH EDK2 v2 1/1] SecurityPkg/DxeImageVerificationLib:Enhanced verification of Offset

2020-08-31 Thread Yao, Jiewen
Sounds great. Appreciate your hard work on that. Will you post a patch to fix the issue again? Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of wenyi,xie > via groups.io > Sent: Monday, August 31, 2020 7:24 PM > To: Yao, Jiewen ; devel@edk2.groups.io;

Re: [edk2-devel] [PATCH] SecurityPkg: Initailize variable Status before it is consumed.

2020-08-31 Thread Yao, Jiewen
Agree with Laszlo. I prefer to move "Status = EFI_SUCCESS;" before the EDKII_TCG_PRE_HASH check. With that moving, reviewed-by: Jiewen Yao Thank you Yao Jiewen > -Original Message- > From: Laszlo Ersek > Sent: Monday, August 31, 2020 11:46 PM > To: devel@edk2.groups.io; Liu, Zhiguang

Re: [edk2-devel] [PATCH v9 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-08-31 Thread Vladimir Olovyannikov via groups.io
Hi Laszlo, > -Original Message- > From: Laszlo Ersek > Sent: Monday, August 31, 2020 2:15 AM > To: Vladimir Olovyannikov ; > devel@edk2.groups.io > Cc: Zhichao Gao ; Maciej Rabeda > ; Jiaxin Wu ; Siyuan > Fu ; Ray Ni ; Liming Gao > ; Nd ; Samer El-Haj-Mahmoud > > Subject: Re: [PATCH v9 0

Re: [edk2-devel] [PATCH v3 1/5] Platform/RaspberryPi4: Add a basic thermal zone

2020-08-31 Thread Jeremy Linton
On 8/31/20 10:33 AM, Ard Biesheuvel wrote: On 8/31/20 5:13 PM, Jeremy Linton wrote: Hi, On 8/31/20 8:15 AM, Pete Batard wrote: One general, non-blocking comment below: On 2020.08.28 23:02, Jeremy Linton wrote: Rather than exporting the temp sensor or mailbox in ACPI land we can wrap them in

Re: [edk2-devel] [PATCH] SecurityPkg: Initailize variable Status before it is consumed.

2020-08-31 Thread Laszlo Ersek
On 08/31/20 10:15, Zhiguang Liu wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2945 > > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Qi Zhang > Cc: Rahul Kumar > Signed-off-by: Zhiguang Liu > --- > SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 1 + > 1 file changed, 1 insertion(+) > > diff --

Re: [edk2-devel] [PATCH v3 1/5] Platform/RaspberryPi4: Add a basic thermal zone

2020-08-31 Thread Ard Biesheuvel
On 8/31/20 5:13 PM, Jeremy Linton wrote: Hi, On 8/31/20 8:15 AM, Pete Batard wrote: One general, non-blocking comment below: On 2020.08.28 23:02, Jeremy Linton wrote: Rather than exporting the temp sensor or mailbox in ACPI land we can wrap them in AML and use the default ACPI drivers provide

Re: [edk2-devel] [PATCH v3 1/5] Platform/RaspberryPi4: Add a basic thermal zone

2020-08-31 Thread Jeremy Linton
Hi, On 8/31/20 8:15 AM, Pete Batard wrote: One general, non-blocking comment below: On 2020.08.28 23:02, Jeremy Linton wrote: Rather than exporting the temp sensor or mailbox in ACPI land we can wrap them in AML and use the default ACPI drivers provided by the OS. This enables the use of "sens

Re: [edk2-devel] [PATCH V2 2/2] BaseTools: Factorize GCC flags

2020-08-31 Thread Ard Biesheuvel
On 8/31/20 4:03 PM, Laszlo Ersek wrote: On 08/31/20 15:22, Ard Biesheuvel wrote: mainline EDK2 is arguably a development tree I agree. not a stable production tree for ~5 year old firmware builds I agree with that too. But I don't think GCC48 is "holding back" edk2. I don't know of a fir

Re: [edk2-devel] [PATCH V2 2/2] BaseTools: Factorize GCC flags

2020-08-31 Thread Laszlo Ersek
On 08/31/20 15:22, Ard Biesheuvel wrote: > mainline EDK2 is arguably a development tree I agree. > not a stable production tree for ~5 year old firmware builds I agree with that too. But I don't think GCC48 is "holding back" edk2. I don't know of a firmware feature that suffers because I'd lik

回复: [edk2-devel] [PATCH V2 2/2] BaseTools: Factorize GCC flags

2020-08-31 Thread gaoliming
Ard: > -邮件原件- > 发件人: bounce+27952+64834+4905953+8761...@groups.io > 代表 Ard > Biesheuvel > 发送时间: 2020年8月31日 21:22 > 收件人: Leif Lindholm ; Laszlo Ersek > > 抄送: Pierre Gondois ; devel@edk2.groups.io; > bob.c.f...@intel.com; liming@intel.com; Tomas Pilar > ; nd > 主题: Re: [edk2-devel] [PA

Re: [edk2-devel] [PATCH V2 2/2] BaseTools: Factorize GCC flags

2020-08-31 Thread Ard Biesheuvel
On 8/28/20 9:15 PM, Leif Lindholm wrote: On Fri, Aug 28, 2020 at 18:56:45 +0200, Laszlo Ersek wrote: Leif, please comment! I did propose reverting it. But I asked for Ard's feedback on the reason for why we had the break in the flags-chain, in case he remembered (and he was on holiday at the t

Re: [edk2-devel] [PATCH v3 4/5] Platform/RaspberryPi4: Create ACPI fan object

2020-08-31 Thread Pete Batard
3 non-blocking whitespace in comments remarks, for consistency. And of course, same non blocking general remark as 1/5 of whether we may ultimately prefer to go with 4-char names for EC0/TZ0... On 2020.08.28 23:02, Jeremy Linton wrote: Now that we have a thermal zone we can add active cooling

Re: [edk2-devel] [PATCH v3 5/5] Platform/RaspberryPi: Trivial whitespace cleanup

2020-08-31 Thread Pete Batard
Thanks for this. On 2020.08.28 23:02, Jeremy Linton wrote: Pete's review pointed out some whitespace issues in the context of a previous patch. Since there are a number of similar errors in the file lets fix them separately. Cc: Leif Lindholm Cc: Pete Batard Cc: Andrei Warkentin Cc: Ard Bies

Re: [edk2-devel] [PATCH v3 2/5] Platform/RaspberryPi: Monitor ACPI Table installs

2020-08-31 Thread Pete Batard
On 2020.08.28 23:02, Jeremy Linton wrote: Hook the ACPI table install sequence and add some basic conditional and AML NameOp update logic. If a table has a non-zero PCD declared that pcd is checked for a non-zero value before allowing the table to be installed. We also add a table of NameOp to PC

Re: [edk2-devel] [PATCH v3 3/5] Platform/RaspberryPi: Add entry for user fan control

2020-08-31 Thread Pete Batard
On 2020.08.28 23:02, Jeremy Linton wrote: Add a menu item that allows the user to enable GPIO based fan control via SSDT and the previous NameObj replacement commit. This should only be seen/enabled on RPI4 because that is what its been tested with. Given GPIO pin current limitations its likely

Re: [edk2-devel] [PATCH v3 1/5] Platform/RaspberryPi4: Add a basic thermal zone

2020-08-31 Thread Pete Batard
One general, non-blocking comment below: On 2020.08.28 23:02, Jeremy Linton wrote: Rather than exporting the temp sensor or mailbox in ACPI land we can wrap them in AML and use the default ACPI drivers provided by the OS. This enables the use of "sensors" in linux to report the SOC temp. As a f

Re: [edk2-devel] [PATCH EDK2 v2 1/1] SecurityPkg/DxeImageVerificationLib:Enhanced verification of Offset

2020-08-31 Thread wenyi,xie via groups.io
Hi,Jiewen, I modify the PE file again, this time it can pass the check in PeCoffLib and cause offset overflow. First, create a PE file and sign it(only one signature), then using binary edit tool to modify content of PE file like below, 1.check the value of SecDataDir->VirtualAddress, in my PE

Re: [edk2-devel] [PATCH v9 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-08-31 Thread Laszlo Ersek
Hi Vladimir, On 08/30/20 02:28, Vladimir Olovyannikov wrote: > Signed-off-by: Vladimir Olovyannikov > Cc: Zhichao Gao > Cc: Maciej Rabeda > Cc: Jiaxin Wu > Cc: Siyuan Fu > Cc: Ray Ni > Cc: Liming Gao > Cc: Nd > Cc: Laszlo Ersek > Cc: Samer El-Haj-Mahmoud > > This patchset introduces an

Re: 回复: [edk2-devel] [PATCH] MdeModulePkg/Library: change TpmMeasurementLibNull to BASE library.

2020-08-31 Thread Laszlo Ersek
On 08/30/20 03:20, gaoliming wrote: > Jiewen: > >  Your understanding is correct. By design, BASE type is for all usages. > Non UEFI/PI implementation can also consume them. But, Edk2 main usage > is for UEFI/PI implementation. So, the developer may not be aware this > type. I agree more detail ru

Re: [edk2-devel] TCP Port for ISCSI Connection

2020-08-31 Thread Sivaraman Nainar
Rabeda: Could you please provide your comment on this. -Siva From: Sivaraman Nainar Sent: Tuesday, July 28, 2020 12:15 PM To: jiaxin...@intel.com Cc: devel@edk2.groups.io Subject: RE: TCP Port for ISCSI Connection Jiaxin: Can you please comment on the below query. -Siva From: devel@edk2.groups

Re: [edk2-devel] [PATCH] MdeModulePkg/Library: change TpmMeasurementLibNull to BASE library.

2020-08-31 Thread Laszlo Ersek
On 08/29/20 02:25, Bret Barkelew wrote: > Question (since it’s been brought up): when **wouldn’t** you use EFI_*? > They’re clearly superior in every way. I mean, they’ve got EFI right in > the name. Minimalism. EFI_* is appropriate (or even required) when the library deals with concepts

Re: [edk2-devel] [PATCH] MdeModulePkg/Library: change TpmMeasurementLibNull to BASE library.

2020-08-31 Thread Laszlo Ersek
On 08/29/20 02:19, Yao, Jiewen wrote: > Laszlo > Good feedback. > >> The reason is that this change actually requires us to change the lib >> class header too. Consider: the whole motivation for the patch is that a >> client module that is more primitive than either a PEIM or a DXE_DRIVER >> wants

Re: [edk2-devel] [PATCH 1/1] Maintainers.txt: Update reviewers of */RiscV64

2020-08-31 Thread Laszlo Ersek
On 08/30/20 13:44, Leif Lindholm wrote: > On Sun, Aug 30, 2020 at 16:03:06 +0800, Abner Chang wrote: >> Add reviewers for all /RiscV64 folders. >> >> Signed-off-by: Abner Chang >> Cc: Andrew Fish >> Cc: Laszlo Ersek >> Cc: Leif Lindholm >> Cc: Michael D Kinney >> Cc: Leif Lindholm >> --- >>

Re: [edk2-devel] [PATCH] SecurityPkg: Initailize variable Status before it is consumed.

2020-08-31 Thread Zhiguang Liu
Hi Liming, This is a small bug fix, and I want to catch the stable tag. Thanks Zhiguang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Zhiguang > Liu > Sent: Monday, August 31, 2020 4:16 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Zhang, Qi1 ; Kumar

Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Correcting EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT definition

2020-08-31 Thread Laszlo Ersek
On 08/28/20 20:39, Grimes, Paul wrote: > [AMD Public Use] > > Thanks for the feedback, Lazlo. I agree with your point on the optimal > format for these #defines. I think it would be best to submit the current > patch as is given that the same feedback could (should?) be applied to > various o

[edk2-devel] [PATCH] SecurityPkg: Initailize variable Status before it is consumed.

2020-08-31 Thread Zhiguang Liu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2945 Cc: Jiewen Yao Cc: Jian J Wang Cc: Qi Zhang Cc: Rahul Kumar Signed-off-by: Zhiguang Liu --- SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 1 + 1 file changed, 1 insertion(+) diff --git a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c b/SecurityPkg/Tcg/Tcg2