Hi Laszlo, > -----Original Message----- > From: Laszlo Ersek <ler...@redhat.com> > Sent: Monday, August 31, 2020 2:15 AM > To: Vladimir Olovyannikov <vladimir.olovyanni...@broadcom.com>; > devel@edk2.groups.io > Cc: Zhichao Gao <zhichao....@intel.com>; Maciej Rabeda > <maciej.rab...@linux.intel.com>; Jiaxin Wu <jiaxin...@intel.com>; Siyuan > Fu <siyuan...@intel.com>; Ray Ni <ray...@intel.com>; Liming Gao > <liming....@intel.com>; Nd <n...@arm.com>; Samer El-Haj-Mahmoud > <samer.el-haj-mahm...@arm.com> > Subject: Re: [PATCH v9 0/1] ShellPkg/DynamicCommand: add > HttpDynamicCommand > > Hi Vladimir, > > On 08/30/20 02:28, Vladimir Olovyannikov wrote: > > Signed-off-by: Vladimir Olovyannikov > > <vladimir.olovyanni...@broadcom.com> > > Cc: Zhichao Gao <zhichao....@intel.com> > > Cc: Maciej Rabeda <maciej.rab...@linux.intel.com> > > Cc: Jiaxin Wu <jiaxin...@intel.com> > > Cc: Siyuan Fu <siyuan...@intel.com> > > Cc: Ray Ni <ray...@intel.com> > > Cc: Liming Gao <liming....@intel.com> > > Cc: Nd <n...@arm.com> > > Cc: Laszlo Ersek <ler...@redhat.com> > > Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahm...@arm.com> > > > > This patchset introduces an http client utilizing EDK2 HTTP protocol, > > to allow fast image downloading from http/https servers. > > HTTP download speed is usually faster than tftp. > > The client is based on the same approach as tftp dynamic command, and > > uses the same UEFI Shell command line parameters. This makes it easy > > integrating http into existing UEFI Shell scripts. > > Note that to enable HTTP download, feature Pcd > > gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections must be set to > TRUE. > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2860 > > > > PATCH v9 changes: > > - check that Response pointer is not NULL before accessing Data > > structure > > member, to prevent possible NULL pointer dereference. > > looks like there's still intense development occurring in > HttpDynamicCommand. > > I'd like to conserve some testing effort on my end, so I'd like to test > this > feature only once more; just before it's merged. I suggest stabilizing the > feature set now, and only focusing on important bugfixes. I agree. The development phase is complete. I am not going to add new features, and the code I submitted for review is now fully in sync with my local development. I promise to just do bug fixes until it is merged in :)
Thank you, Vladimir > > Thanks! > Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64842): https://edk2.groups.io/g/devel/message/64842 Mute This Topic: https://groups.io/mt/76506533/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
