On 08/30/20 13:44, Leif Lindholm wrote: > On Sun, Aug 30, 2020 at 16:03:06 +0800, Abner Chang wrote: >> Add reviewers for all /RiscV64 folders. >> >> Signed-off-by: Abner Chang <abner.ch...@hpe.com> >> Cc: Andrew Fish <af...@apple.com> >> Cc: Laszlo Ersek <ler...@redhat.com> >> Cc: Leif Lindholm <l...@nuviainc.com> >> Cc: Michael D Kinney <michael.d.kin...@intel.com> >> Cc: Leif Lindholm <leif.lindh...@linaro.org> >> --- >> Maintainers.txt | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Maintainers.txt b/Maintainers.txt >> index 57cd2fc662..ff34a24abd 100644 >> --- a/Maintainers.txt >> +++ b/Maintainers.txt >> @@ -98,6 +98,11 @@ F: */Arm/ >> M: Leif Lindholm <l...@nuviainc.com> >> M: Ard Biesheuvel <ard.biesheu...@arm.com> >> >> +RISCV64 >> +F: */RiscV64/ >> +R: Abner Chang <abner.ch...@hpe.com> >> +R: Daniel Schaefer <daniel.schae...@hpe.com> > > I think we want an M: entry for this, and I think that should be you > (since you have the access privileges). It signifies that you are the > one responsible for patches that have been reviewed actually get > pushed. > > This doesn't always mean you need to do it yourself, especially for > this entry which will always overlap with other entries (like MdePkg, > MdeModulePkg, ...), but it does make it clear that you need to make > sure it doesn't get dropped. > > With that change: > Reviewed-by: Leif Lindholm <l...@nuviainc.com> > >> + >> EDK II Continuous Integration: >> ------------------------------ >> .azurepipelines/ >> -- >> 2.25.0 >> >
The placement and the contents of the addition look good to me. I don't know what the best approach is regarding R vs M. With or without the modification suggested by Leif: Acked-by: Laszlo Ersek <ler...@redhat.com> Thanks Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64822): https://edk2.groups.io/g/devel/message/64822 Mute This Topic: https://groups.io/mt/76510535/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
