Re: [edk2-devel] [PATCH edk2-platforms v3 01/24] Silicon/NXP: Add I2c lib

> > +/** > > + Early init I2C for reading the sysclk from I2c slave device. > > + I2c bus clock is determined from the clock input to I2c controller. > > + The clock input to I2c controller is derived from the sysclk. > > + sysclk is determined by clock generator, which is controller by i2c. >

Re: [edk2-devel] [edk2-platforms] [PATCH V1 1/2] CometlakeOpenBoardPkg: Add BDS Hook Dxe Driver

Reviewed-by: Chasel Chiu mailto:chasel.c...@intel.com>> From: Desimone, Nathaniel L Sent: Wednesday, April 22, 2020 4:40 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Chaganty, Rangasai V ; Kethi Reddy, Deepika ; Esakkithevar, Kathappan ; Agyeman, Prince ;

Re: [edk2-devel] [edk2-platforms] [PATCH V1 2/2] WhiskeylakeOpenBoardPkg/UpXtreme: Add BDS Hook Dxe Driver

Reviewed-by: Chasel Chiu mailto:chasel.c...@intel.com>> From: Desimone, Nathaniel L Sent: Wednesday, April 22, 2020 4:40 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Chaganty, Rangasai V ; Agyeman, Prince ; Michael Kubacki Subject: [edk2-platforms] [PATCH V

Re: [edk2-devel] [PATCH edk2-platforms v3 21/24] Platform/NXP: Use FV rules from ArmVirtPkg

> ArmVirtPkg > > On Wed, Apr 15, 2020 at 17:43:39 +0530, Pankaj Bansal wrote: > > From: Pankaj Bansal > > > > FVRules.fdf.inc is being replaced by the ArmVirtPkg/ArmVirtRules.fdf.inc > > at commit hash 746c5b6238f1ee55deb4b3ec32a6d732e27eeeaa > > This is better - but why? > The intent is to re

Re: [edk2-devel] [PATCH] MdeModulePkg/PciHostBridge: Update Mem and PMem Limit Checks

On 4/24/20 6:35 AM, Wasim Khan via groups.io wrote: -Original Message- From: Ard Biesheuvel Sent: Friday, April 24, 2020 12:27 AM To: Wasim Khan Cc: edk2-devel-groups-io ; Varun Sethi ; Wu, Hao A ; Ni, Ray Subject: Re: [PATCH] MdeModulePkg/PciHostBridge: Update Mem and PMem Limit Ch

Re: [edk2-devel] [PATCH v2 0/6] Edk2 Platform and Core CI for ArmVirtPkg, EmulatorPkg, and OvmfPkg

Thanks for providing feedback. My V10 branch is up which will be sent to the mailing list tomorrow as the V3 patch set unless there are any changes requested. This now includes a 7th patch which converts the edk2 ReadMe.md to ReadMe.rst and shows the Platform CI status. The other package Read

Re: [edk2-devel] [PATCH v3 4/6] Add BhyvePkg, to support the bhyve hypervisor

> On Apr 23, 2020, at 3:42 AM, Laszlo Ersek wrote: > > BUt, I *think* the language seen in "OvmfPkg/License.txt" should > accommodate that too. It goes: > > Some files are subject to the following license, the [...] license. > Those files are located in: > - [directory] > - [directory] >

[edk2-devel] [edk2-platforms: PATCH V1] MinPlatformPkg/PlatformInitPei: Create Library Instance of ReportCpuHobLib.

Create an Library instance of ReportCpuHobLib from PlatformInitPei driver. PA bits reported can be overriden using Library instance in Platform. Initial Patch to create ReportCpuHobLib. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2674 Signed-off-by: Chandana Kumar Cc: Sai Chaganty Cc:

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

I have compare the Image different, the are two image size will be affect before and after move _fltused to BaseLib. One is TcgPei, another is SecurityStubDxe, the detail as below table TcgPei| SecurityStubDxe Before move: 22688(decimal)

Re: [edk2-devel] [PATCH 1/2] Features/Intel/AdvancedFeaturePkg: Remove temporary build workaround

Thanks for the explanation. Make sense to me. > -Original Message- > From: Luo, Heng > Sent: Friday, April 24, 2020 9:06 AM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Michael Kubacki ; Gao, Liming > ; Dong, Eric > > Subject: RE: [PATCH 1/2] Features/Intel/AdvancedFeaturePkg: Remove tem

Re: [edk2-devel] [PATCH] MdeModulePkg/PciHostBridge: Update Mem and PMem Limit Checks

> -Original Message- > From: Ard Biesheuvel > Sent: Friday, April 24, 2020 12:27 AM > To: Wasim Khan > Cc: edk2-devel-groups-io ; Varun Sethi > ; Wu, Hao A ; Ni, Ray > > Subject: Re: [PATCH] MdeModulePkg/PciHostBridge: Update Mem and PMem > Limit Checks > > On Thu, 23 Apr 2020 at 12:4

Re: [edk2-devel] [PATCH edk2-platforms v3 16/24] Silicon/NXP: Add Chassis2 Package

> > > > > > Why would multiple modules need to initialize the serial port? > > > > That's how the DebugLib has been designed. > > DebugLib is used by all modules to print info on console. > > BaseDebugLibSerialPortConstructor calls SerialPortInitialize. > > So SerialPortInitialize is called by all

Re: [edk2-devel] [PATCH 2/2] Platform/Intel: Cleanup temporary build workaround related code

Hi Eric, OK, I will combine them into one patch. Thanks, Heng > -Original Message- > From: Dong, Eric > Sent: Friday, April 24, 2020 8:52 AM > To: Luo, Heng ; devel@edk2.groups.io > Cc: Michael Kubacki ; Gao, Liming > ; Ni, Ray > Subject: RE: [PATCH 2/2] Platform/Intel: Cleanup tempora

Re: [edk2-devel] [PATCH 1/2] Features/Intel/AdvancedFeaturePkg: Remove temporary build workaround

Hi Ray, Option 1, In current implement, the usage of AdvancedFeaturePkg in board DSC is: !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc # invoke section "[Packages]", define default Feature PCD #option: [PcdsFeatureFlag], board can override default Feature PCD here, enable specific

Re: [edk2-devel] [PATCH 1/2] Features/Intel/AdvancedFeaturePkg: Remove temporary build workaround

Michael, Thank you for putting an eye on the remaining issue😊 Thanks, Ray > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael Kubacki > Sent: Friday, April 24, 2020 3:24 AM > To: devel@edk2.groups.io; Luo, Heng > Cc: Michael Kubacki ; Gao, Liming > ; Dong, Eric > ; N

Re: [edk2-devel] [PATCH 2/2] Platform/Intel: Cleanup temporary build workaround related code

Hi Heng, You can't separate these two patches like this. Because in this case, the first patch will cause all platforms which use AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaround.dsc file build error. Please reorg the patches to make all patches can pass build for all platfo

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v5 0/3] Add initial manifest repository support

For the patch series... Reviewed-by: Nate DeSimone -Original Message- From: Desimone, Ashley E Sent: Thursday, April 23, 2020 4:10 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo]

[edk2-devel] [edk2-staging/EdkRepo] [PATCH V5 1/3] EdkRepo: Initial commit of workspace_maintenance.py

Add workspace_maintenance.py including the implementation of generate_name_for_obsolete_backup() Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Bret Barkelew Cc: Prince Agyeman --- .../workspace_maintenance/workspace_maintenance.py | 30 ++

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v5 0/3] Add initial manifest repository support

V5 updates the imports in patch 3/3 to reflect the change in file names resulting from V4 V4 addresses Nate's comments regarding typo of 'maintenance' and added edkrepo.common.workspace_maintenance to setup.py in patch 1/3 V3 Addresses Prince's comments regarding typos in patch 2/3 V2 Replaces u

[edk2-devel] [edk2-staging/EdkRepo] [PATCH V5 2/3] EdkRepo: Add edkrepo/common/workspace_maintenance/manifest_repos_maintenance

Add a directory to edkrepo/common to store workspace maintenance functionatlity. Add edkrepo/common/workspace_maintenance/humble directory to store related strings and included manifest_repos_maintenance_humble.py Add edkrepo/common/workspace_maintenance/manifest_repos_maitenance.py to support the

[edk2-devel] [edk2-staging/EdkRepo] [PATCH V5 3/3] EdkRepo: Update pull_latest_manifest_repo to use pull_single_manifest_repo

Updates the implementation for pull_latest_manifest_repo to call pull_single_manifest repo. Removes definitions of strings used by pull_latest_manifest_repo from common/humble.py and from the imports of common_repo_functions.py Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya

Re: [edk2-devel] [PATCH v3 4/6] Add BhyvePkg, to support the bhyve hypervisor

> On Apr 23, 2020, at 3:19 AM, Laszlo Ersek wrote: > > (2) If you are contributing this new file in "Pluribus Networks, Inc" > colors, then please extend the year to 2020 on that line. Otherwise, if > you are contributing this on your own behalf (as work derived from > Pluribus Networks's earli

Re: [edk2-devel] [PATCH 2/2] Platform/Intel: Cleanup temporary build workaround related code

Reviewed-by: Michael Kubacki On 4/23/2020 1:42 AM, Heng Luo wrote: Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2688 Use AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc instead of AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaround.dsc Cc: Michael Kubacki Cc: Limin

Re: [edk2-devel] [PATCH 1/2] Features/Intel/AdvancedFeaturePkg: Remove temporary build workaround

I think the series cover letter should have been filled out but this seems reasonable to me for removal of the temporary workaround. Reviewed-by: Michael Kubacki On 4/23/2020 1:42 AM, Heng Luo wrote: Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2688 Remove Features/Intel/AdvancedFeatu

[edk2-devel] [edk2-staging/EdkRepo] [PATCH V4 3/3] EdkRepo: Update pull_latest_manifest_repo to use pull_single_manifest_repo

Updates the implementation for pull_latest_manifest_repo to call pull_single_manifest repo. Removes definitions of strings used by pull_latest_manifest_repo from common/humble.py and from the imports of common_repo_functions.py Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya

[edk2-devel] [edk2-staging/EdkRepo] [PATCH V4 2/3] EdkRepo: Add edkrepo/common/workspace_maintenance/manifest_repos_maintenance

Add a directory to edkrepo/common to store workspace maintenance functionatlity. Add edkrepo/common/workspace_maintenance/humble directory to store related strings and included manifest_repos_maintenance_humble.py Add edkrepo/common/workspace_maintenance/manifest_repos_maitenance.py to support the

[edk2-devel] [edkrepo2-staging/EdkRepo] [PATCH V4 0/3] Add initial manifest repository support

V4 addresses Nate's comments regarding typo of 'maintenance' and added edkrepo.common.workspace_maintenance to setup.py in patch 1/3 V3 Addresses Prince's comments regarding typos in patch 2/3 V2 Replaces use of management with maitenance per feedback V2 Introduces patch 1/1 which removes a circu

[edk2-devel] [edk2-stagin/EdkRepo] [PATCH V4 1/3] EdkRepo: Initial commit of workspace_maintenance.py

Add workspace_maintenance.py including the implementation of generate_name_for_obsolete_backup() Signed-off-by: Ashley E Desimone Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Bret Barkelew Cc: Prince Agyeman --- .../workspace_maintenance/workspace

Re: [EXTERNAL] [edk2-devel] EDK2 environment setup

Navdeep, Yes since the 202002 stable tag there have been submodules introduced to the basetools. If you look closely you will see in the CI process this required a change where stuart_setup is run before calling edk2toolsbuild.py. https://github.com/tianocore/edk2/commit/e1fbff3ded87704fb0086f

Re: [edk2-devel] [PATCH] MdeModulePkg/PciHostBridge: Update Mem and PMem Limit Checks

On Thu, 23 Apr 2020 at 12:43, Wasim Khan wrote: > > With Address Translation Support, it is possible and > also correct that Mem and Pmem Limit cross the 4GB boundary. > Update the checks so that Mem/PMem Limit should not cross 4GB > from the Mem/PMem Base address. > > Signed-off-by: Wasim Khan >

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH V3 2/3] EdkRepo: Add edkrepo/common/workspace_maitenance/manifest_repos_maitenance

Hi Ashley, There is a misspelling, "maitenance" should be "maintenance". Also, you need to update the filename at the top of manifest_repos_maitenance_humble.py Other than that, looks good. Thanks, Nate On 4/22/20, 4:29 PM, "Desimone, Ashley E" wrote: Add a directory to edkrepo/common t

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH V3 1/3] EdkRepo: Initial commit of workspace_maitenance.py

Hi Ashley, There is a misspelling, "maitenance" should be "maintenance". Other than that, looks good. Thanks, Nate On 4/22/20, 4:29 PM, "Desimone, Ashley E" wrote: Add workspace_maitenance.py including the implementation of generate_name_for_obsolete_backup() Signed-off-by: Ashl

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH V3 3/3] EdkRepo: Update pull_latest_manifest_repo to use pull_single_manifest_repo

Reviewed-by: Nate DeSimone On 4/22/20, 4:29 PM, "Desimone, Ashley E" wrote: Updates the implementation for pull_latest_manifest_repo to call pull_single_manifest repo. Removes definitions of strings used by pull_latest_manifest_repo from common/humble.py and from the imports of

Re: [EXTERNAL] [edk2-devel] EDK2 environment setup

I’ll play with it a little and see if the pipelines/documentation needs to change. Thanks! - Bret From: Kinney, Michael D Sent: Thursday, April 23, 2020 10:26:32 AM To: devel@edk2.groups.io ; Bret Barkelew ; navdeeppal.si...@dell.com ; Feng, Bob C ; Gao, Limin

Re: [EXTERNAL] [edk2-devel] EDK2 environment setup

I will roll back to 202002 stable tag and try. Thank you Navdeep From: Bret Barkelew Sent: Thursday, April 23, 2020 9:48 PM To: Singh, Navdeeppal; devel@edk2.groups.io Subject: RE: [EXTERNAL] [edk2-devel] EDK2 environment setup [EXTERNAL EMAIL] Yeah, I was noticing some problems with BrotliComp

Re: [EXTERNAL] [edk2-devel] EDK2 environment setup

Hi Bret, Yes PIP requirements are up to date. On further digging through the logging file BASETOOLS_BUILD.txt. INFO - subprocess not exit successfully INFO - Error while execute command 'nmake all' in direcotry C:\edk2\BaseTools\Source\C\BrotliCompress Regards, Navdeep From: Bret Barkelew Sent:

Re: [EXTERNAL] [edk2-devel] EDK2 environment setup

Hello, Yes my Python is 3.7. I am trying to use cygwin to access the GNU tools since I do not have VS. We are a small company. I cannot get the edksetup.bat to execute correctly. It is a problem setting up all the environment. Is there an easier way? Am I on the right path? Jim Slaughter ' On T

Re: [EXTERNAL] [edk2-devel] EDK2 environment setup

Bret, I wonder if this is an order of operations issue. Those 2 commits convert Brotli support to submodules. One for the FW decompress lib, and the other for the compression tool. The patch adds both submodule links to CISettings.py and we know that works for FW components. However, this m

Re: [EXTERNAL] [edk2-devel] EDK2 environment setup

Confirmed that it seems related to these two commits: https://github.com/tianocore/edk2/commit/58802e02c41bd715a5d3586f4bf2a4b1c46e9274 https://github.com/tianocore/edk2/commit/06033f5abad3815e8d80de22c97ba38a05017262 If I roll back to the commit prior, the Tools build works. Anyone involved in B

Re: [EXTERNAL] [edk2-devel] EDK2 environment setup

I don’t personally have any experience using Cygwin, but I have used the Windows Subsystem for Linux successfully with EDK2 (I actually use it somewhat regularly. It has great integration with VSCode, which doesn’t require Visual Studio at all.) https://docs.microsoft.com/en-us/windows/wsl/inst

Re: [EXTERNAL] [edk2-devel] EDK2 environment setup

Yeah, I was noticing some problems with BrotliCompress the other day. Seems like a relatively recent change. I know the 202002 stable tag was fine. I’ll try to dig into this a bit. Thanks for bring it to our attention! - Bret From: navdeeppal.si...@dell.com Sen

Re: [EXTERNAL] [edk2-devel] EDK2 environment setup

Have you installed the up-to-date Python requirements? “pip install –upgrade -r pip-requirements.txt”? That’s the first thing I would check. Otherwise, happy to look at the problem with you. - Bret From: NAVDEEPPAL_SINGH via groups.io Sent: Thursday,

Re: [edk2-devel] [PATCH] MdeModulePkg/PciHostBridge: Update Mem and PMem Limit Checks

> -Original Message- > From: Ni, Ray > Sent: Thursday, April 23, 2020 8:47 PM > To: Wasim Khan ; devel@edk2.groups.io > Cc: ard.biesheu...@linaro.org; Varun Sethi ; Wu, Hao A > > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/PciHostBridge: Update Mem > and PMem Limit Checks > > > >

Re: [edk2-devel] [PATCH edk2-platforms v3 16/24] Silicon/NXP: Add Chassis2 Package

On Thu, Apr 23, 2020 at 14:45:03 +, Pankaj Bansal (OSS) wrote: > > > > > You mean put ChassisLibConstructor() call in SerialPortInitialize () ? > > > > > > > > Or before the call to SerialPortInitialize in ChassisInit. > > > > > > But SerialPortInitialize would be called from each module. > >

Re: [edk2-devel] [PATCH] MdeModulePkg/PciHostBridge: Update Mem and PMem Limit Checks

> -Original Message- > From: Wasim Khan > Sent: Thursday, April 23, 2020 10:54 PM > To: devel@edk2.groups.io; Ni, Ray > Cc: ard.biesheu...@linaro.org; Varun Sethi ; Wu, Hao A > > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/PciHostBridge: Update Mem and > PMem Limit Checks > > > >

Re: [edk2-devel] [PATCH] MdeModulePkg/PciHostBridge: Update Mem and PMem Limit Checks

> -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray via > groups.io > Sent: Thursday, April 23, 2020 7:58 PM > To: devel@edk2.groups.io; Wasim Khan > Cc: ard.biesheu...@linaro.org; Varun Sethi ; Wu, Hao A > > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/PciHostBri

Re: [edk2-devel] [PATCH edk2-platforms v3 16/24] Silicon/NXP: Add Chassis2 Package

> > > > You mean put ChassisLibConstructor() call in SerialPortInitialize () ? > > > > > > Or before the call to SerialPortInitialize in ChassisInit. > > > > But SerialPortInitialize would be called from each module. > > Why would multiple modules need to initialize the serial port? That's how th

[edk2-devel] [PATCH v4 2/3] BaseTools: BaseTools changes for RISC-V platform.

C code changes for building EDK2 RISC-V platform. Signed-off-by: Abner Chang Co-authored-by: Gilbert Chen Co-authored-by: Daniel Helmut Schaefer Reviewed-by: Leif Lindholm Cc: Bob Feng Cc: Liming Gao Cc: Leif Lindholm Cc: Gilbert Chen --- BaseTools/Source/C/Common/PeCoffLib.h |

[edk2-devel] [PATCH v4 3/3] BaseTools: BaseTools changes for RISC-V platform.

Tools definitions template file changes for building EDK2 RISC-V platform. Signed-off-by: Abner Chang Co-authored-by: Gilbert Chen Co-authored-by: Daniel Helmut Schaefer Reviewed-by: Leif Lindholm Cc: Bob Feng Cc: Liming Gao Cc: Leif Lindholm Cc: Gilbert Chen --- BaseTools/Conf/tools_def

[edk2-devel] [PATCH v4 0/3] BaseTools: BaseTools changes for RISC-V platform

BZ for entire RISC-V edk2 port, https://bugzilla.tianocore.org/show_bug.cgi?id=2672 These commits are verified by below PR, https://github.com/tianocore/edk2/pull/512 In v4, GCC5_ASM_FLAGS is replaced by GCC5_RISCV64_ASM_FLAGS in tools_def.template in 3/3 patch. Abner Chang (3): BaseTools: Bas

[edk2-devel] [PATCH v4 1/3] BaseTools: BaseTools changes for RISC-V platform.

Python code changes for building EDK2 RISC-V platform. Signed-off-by: Abner Chang Co-authored-by: Gilbert Chen Co-authored-by: Daniel Helmut Schaefer Reviewed-by: Leif Lindholm Cc: Bob Feng Cc: Liming Gao Cc: Leif Lindholm Cc: Gilbert Chen --- BaseTools/Source/Python/Common/DataType.py

Re: [edk2-devel] [PATCH] MdeModulePkg/PciHostBridge: Update Mem and PMem Limit Checks

> -Original Message- > From: devel@edk2.groups.io On Behalf Of Wasim Khan > Sent: Thursday, April 23, 2020 9:52 PM > To: Ni, Ray ; devel@edk2.groups.io > Cc: ard.biesheu...@linaro.org; Varun Sethi ; Wu, Hao A > > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/PciHostBridge: Update Mem an

Re: [edk2-devel] [PATCH edk2-platforms v3 16/24] Silicon/NXP: Add Chassis2 Package

On Thu, Apr 23, 2020 at 13:41:14 +, Pankaj Bansal (OSS) wrote: > > > > > > The intended usage model for IoAccessLib is to retrieve the function > > > > > > pointer struct once and then always refer to it. Since this is a > > > > > > library, we could have a CONSTRUCTOR function (specified in th

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Silicon/NXP: rework IoAccessLib to use single function pointer struct

> -Original Message- > From: Leif Lindholm > Sent: Thursday, April 23, 2020 3:39 PM > To: devel@edk2.groups.io > Cc: Meenakshi Aggarwal ; Pankaj Bansal > > Subject: [PATCH edk2-platforms 1/1] Silicon/NXP: rework IoAccessLib to use > single function pointer struct > > For whatever reas

Re: [edk2-devel] [PATCH v1 7/7] MdePkg: UEFI JSON Capsule Support

Here is a mantis I opened: https://mantis.uefi.org/mantis/view.php?id=2096 From: Gao, Liming [mailto:liming@intel.com] Sent: Thursday, April 23, 2020 1:45 AM To: Rothman, Michael A; devel@edk2.groups.io; Liu, Zhiguang; Oleksiy Yakovlev Cc: Feng, Bob C; Kinney, Michael D; Felix Polyudov Subjec

Re: [edk2-devel] [PATCH] MdeModulePkg/PciHostBridge: Update Mem and PMem Limit Checks

> -Original Message- > From: Ni, Ray > Sent: Thursday, April 23, 2020 5:07 PM > To: Wasim Khan ; devel@edk2.groups.io > Cc: ard.biesheu...@linaro.org; Varun Sethi ; Wu, Hao A > > Subject: RE: [PATCH] MdeModulePkg/PciHostBridge: Update Mem and PMem > Limit Checks > > Thanks for fixing

Re: [edk2-devel] [PATCH edk2-platforms v3 16/24] Silicon/NXP: Add Chassis2 Package

> -Original Message- > From: Leif Lindholm > Sent: Thursday, April 23, 2020 5:36 PM > To: Pankaj Bansal (OSS) > Cc: Meenakshi Aggarwal ; Michael D Kinney > ; devel@edk2.groups.io; Varun Sethi > ; Samer El-Haj-Mahmoud mahm...@arm.com>; Jon Nettleton ; Ard Biesheuvel > > Subject: Re: [

[edk2-devel] EDK2 environment setup

I am trying to setup EDK2 environment setup from Tianocore/EDK2. While doing the Base Tool setup. After running BaseTool/EDK2ToolsBuild.py -t VS2019 Getting following error :- c:\edk2\BaseTools>python Edk2ToolsBuild.py  -t VS2019 SECTION - Init SDE SECTION - Loading Plugins SECTION - Start Invocab

Re: [edk2-devel] [PATCH 1/1] BaseTools: convert diff.order to LF-only

On Thu, Apr 23, 2020 at 13:01:01 +0200, Philippe Mathieu-Daudé wrote: > On 4/22/20 5:46 PM, Leif Lindholm wrote: > > SetupGit.py sets the git config option diff.orderFile to > > {edk2 directory}/BaseTools/Conf/diff.order, to override the default order > > in which files are shown in a diff/patch/wh

Re: [edk2-devel] [PATCH edk2-platforms v3 16/24] Silicon/NXP: Add Chassis2 Package

On Thu, Apr 23, 2020 at 12:02:16 +, Pankaj Bansal (OSS) wrote: > > > > -Original Message- > > From: Leif Lindholm > > Sent: Thursday, April 23, 2020 5:27 PM > > To: Pankaj Bansal (OSS) > > Cc: Meenakshi Aggarwal ; Michael D Kinney > > ; devel@edk2.groups.io; Varun Sethi > > ; Samer

Re: [edk2-devel] [PATCH edk2-platforms v3 16/24] Silicon/NXP: Add Chassis2 Package

> -Original Message- > From: Leif Lindholm > Sent: Thursday, April 23, 2020 5:27 PM > To: Pankaj Bansal (OSS) > Cc: Meenakshi Aggarwal ; Michael D Kinney > ; devel@edk2.groups.io; Varun Sethi > ; Samer El-Haj-Mahmoud mahm...@arm.com>; Jon Nettleton ; Ard Biesheuvel > > Subject: Re: [

Re: [edk2-devel] [PATCH edk2-platforms v3 16/24] Silicon/NXP: Add Chassis2 Package

On Thu, Apr 23, 2020 at 11:38:12 +, Pankaj Bansal (OSS) wrote: > > > + > > > + @return The value read. > > > +**/ > > > +UINT32 > > > +EFIAPI > > > +DcfgRead32 ( > > > + IN UINTN Address > > > + ) > > > +{ > > > + MMIO_OPERATIONS_32 *DcfgOps; > > > + > > > + DcfgOps = GetMmioOperatio

Re: [edk2-devel] [PATCH 1/2] Features/Intel/AdvancedFeaturePkg: Remove temporary build workaround

Heng, Any reason to create a separate Pcd.dsc file? > -Original Message- > From: Luo, Heng > Sent: Thursday, April 23, 2020 4:43 PM > To: devel@edk2.groups.io > Cc: Michael Kubacki ; Gao, Liming > ; Dong, Eric > ; Ni, Ray > Subject: [PATCH 1/2] Features/Intel/AdvancedFeaturePkg: Remove

Re: [edk2-devel] [PATCH edk2-platforms v3 16/24] Silicon/NXP: Add Chassis2 Package

> > + > > + @return The value read. > > +**/ > > +UINT32 > > +EFIAPI > > +DcfgRead32 ( > > + IN UINTN Address > > + ) > > +{ > > + MMIO_OPERATIONS_32 *DcfgOps; > > + > > + DcfgOps = GetMmioOperations32 (FeaturePcdGet (PcdDcfgBigEndian)); > > + > > + return DcfgOps->Read32 (Address); > >

Re: [edk2-devel] [PATCH] MdeModulePkg/PciHostBridge: Update Mem and PMem Limit Checks

Thanks for fixing the check. PCI_ROOT_BRIDGE_APERTURE.Base/Limit are device address while the memory space in GCD belongs to host domain. So, host address for Mem/Pmem should be below 4GB while device address can across 4GB. Can you enhance the check as below? ASSERT (TO_HOST_ADDRESS (Bridge->

Re: [edk2-devel] [PATCH 1/1] BaseTools: convert diff.order to LF-only

On 4/22/20 5:46 PM, Leif Lindholm wrote: SetupGit.py sets the git config option diff.orderFile to {edk2 directory}/BaseTools/Conf/diff.order, to override the default order in which files are shown in a diff/patch/whatever. This is in imitation of what is done manually in Laszlo's Unkempt Guide.

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Silicon/NXP: rework IoAccessLib to use single function pointer struct

On 4/23/20 12:09 PM, Leif Lindholm wrote: For whatever reason, the function pointer structs (and their retrieval functions) were split up on data size boundary - separate for 16-bit, 32-bit, and 64-bit. This makes the already tedious boilerplate require to deal with these hardware quirks even wo

Re: [edk2-devel] [PATCH v2 1/5] OvmfPkg/OvmfXen: Remove DEBUG_ON_SERIAL_PORT

On 4/23/20 11:53 AM, Anthony PERARD wrote: Remove support for DEBUG_ON_SERIAL_PORT because OvmfXen can't be build with it due to a circular dependency: DebugLib: BaseDebugLibSerialPort -> SerialPortLib : XenConsoleSerialPortLib -> XenHypercallLib : XenHypercallLib -> DebugLi

Re: [edk2-devel] [PATCH v2 3/5] OvmfPkg/PlatformDebugLibIoPort: factor out debug port detection

On 4/23/20 11:53 AM, Anthony PERARD wrote: Factor out debug port detection in PlatformDebugLibIoPort. Signed-off-by: Anthony PERARD --- .../PlatformDebugLibIoPort.inf| 1 + .../PlatformRomDebugLibIoPort.inf | 1 + .../PlatformDebugLibIoPort/DebugLibDetect.h |

[edk2-devel] [PATCH] MdeModulePkg/PciHostBridge: Update Mem and PMem Limit Checks

With Address Translation Support, it is possible and also correct that Mem and Pmem Limit cross the 4GB boundary. Update the checks so that Mem/PMem Limit should not cross 4GB from the Mem/PMem Base address. Signed-off-by: Wasim Khan --- MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c |

Re: [edk2-devel] [edk2-discuss] Load Option passing. Either bugs or my confusion.

> > > > And when the user provides an EDID one should parse it and set the > default > > resolution to match it. But that's a less important feature. > > It's more complex than you might think, and (to me personally) it seems > to require more time than its importance justifies. > > https://bugzill

Re: [edk2-devel] [PATCH edk2-platforms v3 24/24] Platform/NXP/LS1043aRdbPkg: Add PEI Phase

On Wed, Apr 15, 2020 at 17:43:42 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > Add PEI phase to LS1043aRdb. This is needed becuase we need to have > dynamic PCDs support to be able to reserve memory before reporting > memory to UEFI fimrware. > Using PEI phase we are now also dynamically

Re: [edk2-devel] [PATCH edk2-platforms v3 21/24] Platform/NXP: Use FV rules from ArmVirtPkg

On Wed, Apr 15, 2020 at 17:43:39 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > FVRules.fdf.inc is being replaced by the ArmVirtPkg/ArmVirtRules.fdf.inc > at commit hash 746c5b6238f1ee55deb4b3ec32a6d732e27eeeaa This is better - but why? / Leif > Signed-off-by: Pankaj Bansal > --- >

Re: [edk2-devel] [PATCH edk2-platforms v3 20/24] NXP: LS1043aRdbPkg: Use ArmPlatformHelper.S from ArmPlatformPkg

On Wed, Apr 15, 2020 at 17:43:38 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > ArmPlatformHelper.S is being replaced by the ArmPlatformPkg version at > commit hash f4dfad05dda2c7b29e8105605621f2b413f0af2b. > > Signed-off-by: Pankaj Bansal Reviewed-by: Leif Lindholm > --- > > Notes:

Re: [edk2-devel] [PATCH edk2-platforms v3 16/24] Silicon/NXP: Add Chassis2 Package

On Wed, Apr 15, 2020 at 17:43:34 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > A Chassis is a base framework used for building SoCs. > We can think of Chassis/Soc/Platform(a.k.a Borad) in Object model terms. > Chassis is base. Soc is based on some Chassis. > Platform is based on some Soc.

Re: [edk2-devel] [PATCH edk2-platforms v3 15/24] Silicon: NXP: Remove direct calls to SwapMmio* APIs

Actually... On Wed, Apr 15, 2020 at 17:43:33 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > The SwapMmio** APIs are supposed to be called indirectly via > GetMmioOperations** APIs. > Therefore, remove the SwapMmio** APIs from IoAccessLib.h and make > these APIs STATIC to IoAccessLib.c, so

[edk2-devel] [PATCH edk2-platforms 1/1] Silicon/NXP: rework IoAccessLib to use single function pointer struct

For whatever reason, the function pointer structs (and their retrieval functions) were split up on data size boundary - separate for 16-bit, 32-bit, and 64-bit. This makes the already tedious boilerplate require to deal with these hardware quirks even worse, so unify them into a single function po

Re: [edk2-devel] [PATCH V2 0/7] CryptoPkg: Retire the deprecated functions

OK. Here is the main difference VS V1: 1. do not remove the field in the internal protocol structure: a)directly call an assert function and return an error value. b)change the related field value to 0 to indicate the function is unsupported any longer 2. remove the HMAC MD5 and HMAC SHA1 3.

[edk2-devel] [PATCH v2 1/5] OvmfPkg/OvmfXen: Remove DEBUG_ON_SERIAL_PORT

Remove support for DEBUG_ON_SERIAL_PORT because OvmfXen can't be build with it due to a circular dependency: DebugLib: BaseDebugLibSerialPort -> SerialPortLib : XenConsoleSerialPortLib -> XenHypercallLib : XenHypercallLib -> DebugLib Also, if that dependency is fixed, I think it

[edk2-devel] [PATCH v2 5/5] OvmfPkg/OvmfXen: Introduce DEBUG_ON_HYPERVISOR_CONSOLE build flag

Introduce DEBUG_ON_HYPERVISOR_CONSOLE build flag to enable logging debug output to the Xen console. This will work with both Xen HVM guest and Xen PVH guest whereas the default PlatformDebugLibIoPort works only in HVM when QEMU is present. Signed-off-by: Anthony PERARD --- OvmfPkg/OvmfXen.dsc |

[edk2-devel] [PATCH v2 2/5] OvmfPkg/PlatformDebugLibIoPort: Reword QEMU to hypervisor

We are going to reuse PlatformDebugLibIoPort to use debug IO port from hypervisors that aren't QEMU, so reword "QEMU" to "hypervisor" in the descriptions. Signed-off-by: Anthony PERARD --- OvmfPkg/Library/PlatformDebugLibIoPort/DebugLibDetect.h| 2 +- OvmfPkg/Library/PlatformDebugLibIoPort/D

[edk2-devel] [PATCH v2 4/5] OvmfPkg/PlatformDebugLibIoPort: Introduce a Nocheck variant

Introduce PlatformRomDebugLibIoPortNocheck which doesn't try to detect the debug IO port. Instead, debug logs are always written to the IO port. Signed-off-by: Anthony PERARD --- ...f => PlatformRomDebugLibIoPortNocheck.inf} | 15 ++- .../DebugIoPortNocheck.c | 25 ++

[edk2-devel] [PATCH v2 0/5] OvmfXen: Cleanup debug options

Patch series available in this git branch: git://xenbits.xen.org/people/aperard/ovmf.git br.ovmfxen-debug-io-v2 v2: - reuse PlatformDebugLibIoPort rather than duplicate it. Remove non working DEBUG_ON_SERIAL_PORT, then add a new LibIoPort which always writes to the IO port. Issues was discovered

[edk2-devel] [PATCH v2 3/5] OvmfPkg/PlatformDebugLibIoPort: factor out debug port detection

Factor out debug port detection in PlatformDebugLibIoPort. Signed-off-by: Anthony PERARD --- .../PlatformDebugLibIoPort.inf| 1 + .../PlatformRomDebugLibIoPort.inf | 1 + .../PlatformDebugLibIoPort/DebugLibDetect.h | 6 .../PlatformDebugLibIoPort/DebugIoPort

Re: [edk2-devel] [PATCH v3 6/6] BhyvePkg: Add AcpiPlatformDxe

On 04/21/20 05:09, Rebecca Cran wrote: > Make a copy of OvmfPkg/AcpiPlatformDxe under BhyvePkg, with the changes > needed to support the bhyve hypervisor. > > Signed-off-by: Rebecca Cran > --- > BhyvePkg/AcpiPlatformDxe/AcpiPlatform.c | 250 +++ > BhyvePkg/AcpiPlatformDxe/Ac

Re: [edk2-devel] [PATCH v3 4/6] Add BhyvePkg, to support the bhyve hypervisor

On 04/23/20 11:19, Laszlo Ersek wrote: > (10) *However*, in the subsequent patches (#5 and #6), you are > introducing content (PlatformPei and AcpiPlatformDxe) that is under > BSD-2-Clause-Patent. > > Meaning that BhyvePkg needs a License.txt that's similar to > OvmfPkg/License.txt: > > - it sho

Re: [edk2-devel] [PATCH v1 1/1] INF Spec: Add file dependency to [Sources] syntax

Hi Pierre, Sorry for the late response. I have no good idea to resolve the concern about the INF syntax change, but I think the ASL compilation should not be done in AutoGen phase. I summarize the solutions that we have discussed. 1. Put the ASL build target before the C build target. This

Re: [edk2-devel] [PATCH V2 0/7] CryptoPkg: Retire the deprecated functions

Hello I think there are lots of feedback in v1 patch review. Would you please give a summary on how they are addressed in this v2 ? > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gao, > Zhichao > Sent: Thursday, April 23, 2020 4:46 PM > To: devel@edk2.groups.io > Cc: Wan

Re: [edk2-devel] [PATCH edk2-platforms v3 15/24] Silicon: NXP: Remove direct calls to SwapMmio* APIs

On Wed, Apr 15, 2020 at 17:43:33 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > The SwapMmio** APIs are supposed to be called indirectly via > GetMmioOperations** APIs. > Therefore, remove the SwapMmio** APIs from IoAccessLib.h and make > these APIs STATIC to IoAccessLib.c, so that no acci

Re: [edk2-devel] [PATCH edk2-platforms v3 14/24] Silicon/NXP: Use Clock retrieval PPI in modules

On Wed, Apr 15, 2020 at 17:43:32 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > Use NXP_PLATFORM_GET_CLOCK_PPI in various Layerscape IP modules. > > Signed-off-by: Pankaj Bansal > --- > > Notes: > - Added clock retrieval APIs to DUartPortLib Reviewed-by: Leif Lindholm > > Silic

Re: [edk2-devel] [PATCH v3 5/6] BhyvePkg: Add PlatformPei

On 04/21/20 05:09, Rebecca Cran wrote: > Make a copy of OvmfPkg/PlatformPei under BhyvePkg with the changes > that are needed to support the bhyve hypervisor. > > Signed-off-by: Rebecca Cran > --- > BhyvePkg/PlatformPei/AmdSev.c | 106 + > BhyvePkg/PlatformPei/ClearCache.c | 111

Re: [edk2-devel] [PATCH v3 4/6] Add BhyvePkg, to support the bhyve hypervisor

On 04/21/20 05:09, Rebecca Cran wrote: > BhyvePkg supports the bhyve hypervisor, which is a hypervisor/virtual > machine manager available on FreeBSD, macOS and Illumos. > > Signed-off-by: Rebecca Cran > --- > BhyvePkg/AcpiTables/AcpiTables.inf| 42 + > BhyvePkg/AcpiTables/Dsdt.asl

Re: [edk2-devel] [PATCH edk2-platforms v3 13/24] Platform/NXP/LS1043aRdbPkg: Add Clock retrieval APIs

On Wed, Apr 15, 2020 at 17:43:31 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > The SOC takes primary clocking input from the external signal (a clock > generator on board). The input (frequency) is multiplied using multiple > phase locked loops (PLL) to create a variety of frequencies whi

Re: [edk2-devel] [PATCH edk2-platforms v3 12/24] Silicon/NXP: Move RAM retrieval from SocLib

On Wed, Apr 15, 2020 at 17:43:30 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > RAM retrieval using SMC commands is common to all Layerscape SOCs. > Therefore, move it to commom MemoryInit Pei Lib. > > Signed-off-by: Pankaj Bansal > --- > > Notes: > - sort headers alphabetically >

Re: [edk2-devel] [PATCH v1] UefiCpuPkg/MpInitLib: Add missing explicit PcdLib dependency

> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wu, Hao A > Sent: Wednesday, April 22, 2020 2:56 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A; Dong, Eric; Ni, Ray; Laszlo Ersek > Subject: [edk2-devel] [PATCH v1] UefiCpuPkg/MpInitLib: Add missi

[edk2-devel] [PATCH V2 6/7] CryptoPkg/BaseCryptLib: Retire HMAC SHA1 algorithm

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 HMAC SHA1 is not secure any longer. Remove the HMAC SHA1 support from edk2. Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Siyuan Fu Cc: Michael D Kinney Cc: Jiewen Yao Cc: Laszlo Ersek Signed-off-by: Zhichao Gao --- CryptoPkg/CryptoPkg.dsc

[edk2-devel] [PATCH V2 7/7] CryptoPkg/Crypto.h: Update the version of Crypto Driver

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 Update the Crypto Version to 7: 1. Retire below deprecated functions: MD4, ARC4, TDES, AES ECB MODE, HMAC MD5, HMAC SHA1 Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Siyuan Fu Cc: Michael D Kinney Cc: Jiewen Yao Cc: Laszlo Ersek Signed-off-by: Z

[edk2-devel] [PATCH V2 3/7] CryptoPkg/BaseCryptLib: Retire the Tdes algorithm

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 Tdes is not secure any longer. Remove the Tdes support from edk2. Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Siyuan Fu Cc: Michael D Kinney Cc: Jiewen Yao Cc: Laszlo Ersek Signed-off-by: Zhichao Gao --- CryptoPkg/Driver/Crypto.c

[edk2-devel] [PATCH V2 1/7] CryptoPkg/BaseCrpytLib: Retire MD4 algorithm

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 MD4 is not secure any longer. Remove the MD4 support from edk2. Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Siyuan Fu Cc: Michael D Kinney Cc: Jiewen Yao Cc: Laszlo Ersek Signed-off-by: Zhichao Gao --- CryptoPkg/CryptoPkg.dsc

[edk2-devel] [PATCH V2 4/7] CryptoPkg/BaseCryptLib: Retire Aes Ecb mode algorithm

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 Aes Ecb mode is not secure any longer. Remove the Aes Ecb mode support from edk2. Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Siyuan Fu Cc: Michael D Kinney Cc: Jiewen Yao Cc: Laszlo Ersek Signed-off-by: Zhichao Gao --- CryptoPkg/CryptoPkg.ds

  1   2   >