On 4/20/20 4:41 AM, awarken...@vmware.com wrote:
Hi Andrew,
This particular issue revolves around enabling a feature by default in
the DSC for Pi 3/4 platforms - the TFTP Shell command. Clearly, enabling
this for Pi bears no effect on other Tiano platforms. So far I've heard
something about t
I saw this issue too.
The included file is always included no matter the condition is TRUE or FALSE.
```
!if FALSE
!include abc.fdf
!endif
```
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#57597): https://edk2.groups.io/g/devel/message/
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Ard Biesheuvel
> Sent: Thursday, April 16, 2020 5:37 PM
> To: devel@edk2.groups.io; Zhang, Shenglei
> Cc: Gao, Liming ; Wang, Jian J
> ; Wu, Hao A ; Feng, Bob C
>
> Subject: Re: [edk2-devel] [
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Abner Chang
> Sent: Monday, April 20, 2020 1:38 PM
> To: devel@edk2.groups.io; Wu, Hao A
> Cc: Chen, Gilbert; Leif Lindholm; Gao, Liming
> Subject: Re: [edk2-devel] [PATCH v1 2/3]
> MdeModulePkg/C
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Wu, Hao A
> Sent: Monday, April 20, 2020 1:24 PM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
>
> Cc: Chen, Gilbert ; Leif Lindholm
> ; Gao, Liming
> Subject: Re: [edk2-d
Hello,
I am trying to change my top-level FDF file layout by conditionally including
an FDF depending on a build time define being passed or not. The behavior I am
seeing is as follows.
1. I am passing the build time define and the included fdf.inc file gets
included.
2. I am not passin
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Chang, Abner (HPS SW/FW Technologist)
> Sent: Friday, April 10, 2020 3:26 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner (HPS SW/FW Technologist); Chen, Gilbert; Leif Lindholm;
> Wu, Hao A; Gao,
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Zhang, Shenglei
> Sent: Monday, April 20, 2020 10:55 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen ; Wang, Jian J ;
> Zhang, Chao B
> Subject: [PATCH] SecurityPkg/TpmCommLib: Remove TpmCommLib
>
> REF: https://bugzilla.tia
Reviewed-by: Bret Barkelew
- Bret
From: devel@edk2.groups.io on behalf of Zhang, Shenglei
via groups.io
Sent: Sunday, April 19, 2020 7:55:23 PM
To: devel@edk2.groups.io
Cc: Jiewen Yao ; Jian J Wang ;
Chao Zhang
Subject: [EXTERNAL] [edk2-devel] [PATCH] Secur
Reviewed-by: Bret Barkelew
- Bret
From: devel@edk2.groups.io on behalf of Guomin Jiang via
groups.io
Sent: Sunday, April 19, 2020 9:30:57 PM
To: devel@edk2.groups.io ; Jiang, Guomin
Cc: Kun Qin ; Kinney, Michael D
; Sean Brogan ; Bret
Barkelew
Subject: [E
Hi Michael, Sean, Bret,
Please help review the change.
Best Regards
guomin
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Guomin
> Jiang
> Sent: Tuesday, April 14, 2020 9:33 AM
> To: devel@edk2.groups.io
> Cc: kuqin ; Kinney, Michael D
> ; Sean Brogan ;
> Bret Barkelew
Hi Maciej,
Thanks for your friendly reminder. I'll following the rule next time.
Keysound
-Original Message-
From: devel@edk2.groups.io On Behalf Of Maciej Rabeda
via groups.io
Sent: Saturday, April 18, 2020 12:06 AM
To: devel@edk2.groups.io; siyuan...@intel.com; Keysound Chang
Cc: W
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1321
TpmCommLib is no longer used by TcgPei/TcgDxe/Tcg2ConfigPei modules.
So it can be removed from SecurityPkg.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Shenglei Zhang
---
SecurityPkg/Library/TpmCommLib/TisPc.c|
Hi Andrew,
This particular issue revolves around enabling a feature by default in the DSC
for Pi 3/4 platforms - the TFTP Shell command. Clearly, enabling this for Pi
bears no effect on other Tiano platforms. So far I've heard something about the
TFTP code being somehow bad, but what does that
Zhiju:
With this improvement, Reviewed-by: Liming Gao
> -Original Message-
> From: Fan, ZhijuX
> Sent: Monday, April 20, 2020 9:17 AM
> To: Gao, Liming ; devel@edk2.groups.io
> Cc: Feng, Bob C
> Subject: RE: [PATCH V6] BaseTools:Add the spare space FV image size checker
>
> Hi LiMing
Hi LiMing,
I agree with this change and will improve it
Any question, please let me know. Thanks.
Best Regards
Fan Zhiju
> -Original Message-
> From: Gao, Liming
> Sent: Wednesday, April 15, 2020 9:21 PM
> To: Fan, ZhijuX ; devel@edk2.groups.io
> Cc: Feng, Bob C
> Subject: RE: [PA
> On Apr 19, 2020, at 4:50 PM, Andrei Warkentin wrote:
>
> Stepping back, can we do a roll call among stakeholders so we start treating
> contentious issues as a community?
>
> So far:
>
> Samer (implicit, unless he says otherwise, because he proposed the patch): +1
> Ard: -1
> Pete: -1
> An
Hi Jian, Chao, Laszlo,
Can you spend some time for this.
Best Regard
Guomin
> -Original Message-
> From: Jiang, Guomin
> Sent: Thursday, April 16, 2020 9:41 PM
> To: devel@edk2.groups.io; Wang, Jian J ; Yao,
> Jiewen ; Zhang, Chao B ;
> Laszlo Ersek
> Cc: Xu, Shiwei ; Gao, Liming
> Sub
Stepping back, can we do a roll call among stakeholders so we start treating
contentious issues as a community?
So far:
Samer (implicit, unless he says otherwise, because he proposed the patch): +1
Ard: -1
Pete: -1
Andrei: +1
Anyone else?
How many points do folks thing we need for a merge? I'd
-Original Message-
From: Laszlo Ersek
Sent: Thursday, April 16, 2020 7:52 AM
To: Sean Brogan
Cc: devel@edk2.groups.io; Ard Biesheuvel
Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v1 2/6] ArmVirtPkg: Add Platform CI
and configuration for Core CI
My excuse for not polishing it more -- w
It's part of Tiano, no? We didn't develop it. Yet I see it being used in many
Tiano-derived UEFI implementations in the Arm world. I don't see a contract
anywhere that all Tiano implementations ought to avoid components that don't
fit the UEFI/PI/Shell specs. Can someone point me to such a contr
On 2020.04.19 21:21, awarken...@vmware.com wrote:
So if I understood correctly:
* If a random person off the street builds edk2 - they don't get TFTP
command out of the box
Yup. For the reasons that Ard pointed out (current TFTP being a
non-standard hack that should be replaced by somet
So if I understood correctly:
* If a random person off the street builds edk2 - they don't get TFTP
command out of the box
* Our builds retain TFTP command
Correct?
From: devel@edk2.groups.io on behalf of Pete Batard via
groups.io
Sent: Sunday, April 1
Andrei,
In case this is your concern, please note that we are not removing TFTP
support at all, which is enabled for the RELEASE builds we produce and
will remain so (and which anyone can enable with the macro if they wish).
All that will be changed by the updated proposal is that the current
Hi folks,
If we have to choose abstract goodness over functionality, why wouldn't we
choose functionality? Functionality that's part of Tiano? The real world
doesn't care about the TFTP command being an "unsupported hack" or not. So
there's Tiano-specific code here. Big deal? To rephrase differ
On 2020.04.19 14:33, Ard Biesheuvel wrote:
On 4/19/20 3:04 PM, Samer El-Haj-Mahmoud wrote:
Fix an ASSERT with the TFTP dynamic Shell command on the
RPi3 and RPi4 when running DEBUG builds. Also, enable the
command by default for all builds.
Fixing the ASSERT is fine but I am reluctant to enab
On 4/19/20 4:00 PM, Samer El-Haj-Mahmoud wrote:
-Original Message-
From: devel@edk2.groups.io On Behalf Of Ard
Biesheuvel via groups.io
Sent: Sunday, April 19, 2020 9:34 AM
To: Samer El-Haj-Mahmoud ;
devel@edk2.groups.io
Cc: Leif Lindholm ; Pete Batard ; Andrei
Warkentin (awarken...@vmwa
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ard
> Biesheuvel via groups.io
> Sent: Sunday, April 19, 2020 9:34 AM
> To: Samer El-Haj-Mahmoud ;
> devel@edk2.groups.io
> Cc: Leif Lindholm ; Pete Batard ; Andrei
> Warkentin (awarken...@vmware.com)
> Subject: Re: [edk2-deve
On 4/19/20 3:04 PM, Samer El-Haj-Mahmoud wrote:
Fix an ASSERT with the TFTP dynamic Shell command on the
RPi3 and RPi4 when running DEBUG builds. Also, enable the
command by default for all builds.
Fixing the ASSERT is fine but I am reluctant to enable this by default.
It is a non-standard ha
Enable the TFTP dynamic shell command by default.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Pete Batard
Cc: Andrei Warkentin
Signed-off-by: Samer El-Haj-Mahmoud
---
Platform/RaspberryPi/RPi3/RPi3.dsc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/RaspberryPi/RPi3
Enable the TFTP dynamic shell command by default.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Pete Batard
Cc: Andrei Warkentin
Signed-off-by: Samer El-Haj-Mahmoud
---
Platform/RaspberryPi/RPi4/RPi4.dsc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/RaspberryPi/RPi4
Fix an ASSERT with the TFTP dynamic Shell command on the
RPi3 and RPi4 when running DEBUG builds. Also, enable the
command by default for all builds.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Pete Batard
Cc: Andrei Warkentin
Samer El-Haj-Mahmoud (4):
Platform/RaspberryPi/RPi3: Fix TFTP dyn
Set the PcdShellLibAutoInitialize for the TFTP dynamic Shell command.
This fixes an ASSERT observed in https://github.com/pftf/RPi4/issues/38
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Pete Batard
Cc: Andrei Warkentin
Signed-off-by: Samer El-Haj-Mahmoud
---
Platform/RaspberryPi/RPi4/RPi4.dsc |
Set the PcdShellLibAutoInitialize for the TFTP dynamic Shell command.
This fixes an ASSERT observed in https://github.com/pftf/RPi3/issues/11
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Pete Batard
Cc: Andrei Warkentin
Signed-off-by: Samer El-Haj-Mahmoud
---
Platform/RaspberryPi/RPi3/RPi3.dsc |
Tested-By: Samer El-Haj-Mahmoud
I tested on Aarch64 (RPi4) and the command seems to work well.
One question: why is the input arguments "host[:port]" and the remote file
"http_uri" not treated as a single "http_uri" argument?
For example, instead of:
fs0:\> http http://192.168.1.1:8080 di
On 4/19/20 10:29 AM, Sean via groups.io wrote:
Laszlo,
Regarding your comments about disliking the verbosity of the markdown
table/html table for build status both in Core Ci and now these Platform CI
readme files.
As a learning experience I updated the OvmfPkg readme to use reStructuredText
Laszlo,
Regarding your comments about disliking the verbosity of the markdown
table/html table for build status both in Core Ci and now these Platform CI
readme files.
As a learning experience I updated the OvmfPkg readme to use reStructuredText
instead of markdown. Not sure if I like RST b
Ok, thanks Ard!
Reviewed-by: Dandan Bi for this patch.
Thanks,
Dandan
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Ard Biesheuvel
> Sent: Sunday, April 12, 2020 4:22 PM
> To: Bi, Dandan ; devel@edk2.groups.io;
> ler...@redhat.com
> Cc: Ga
38 matches
Mail list logo
