Ok, thanks Ard! Reviewed-by: Dandan Bi <dandan...@intel.com> for this patch.
Thanks, Dandan > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Ard Biesheuvel > Sent: Sunday, April 12, 2020 4:22 PM > To: Bi, Dandan <dandan...@intel.com>; devel@edk2.groups.io; > ler...@redhat.com > Cc: Gao, Zhichao <zhichao....@intel.com>; Ni, Ray <ray...@intel.com>; > Wang, Jian J <jian.j.w...@intel.com>; Wu, Hao A <hao.a...@intel.com> > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/DeviceManagerUiLib: > connect all before creating menu page > > On 4/12/20 9:55 AM, Bi, Dandan wrote: > > Hi Ard, > > > > It seems that the root cause is the 'Network Device List' in the device > manager menu is crated before EfiBootManagerConnectAll () is called in > UiEntry function. > > If we choose to add the EfiBootManagerConnectAll() in > DeviceManagerUiLib with this patch, could we don't call the > EfiBootManagerConnectAll() in UiEntry to avoid it's called twice when enter > UiApp? > > > > DeviceManagerUiLib is optional - this seems to be the purpose of the > modular nature of UiApp with the NULL library class resolution. > > Removing EfiBootManagerConnectAll() from UiApp itself means it may not > ever be called. > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57561): https://edk2.groups.io/g/devel/message/57561 Mute This Topic: https://groups.io/mt/72879609/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
