> -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Monday, April 20, 2020 1:38 PM > To: devel@edk2.groups.io; Wu, Hao A > Cc: Chen, Gilbert; Leif Lindholm; Gao, Liming > Subject: Re: [edk2-devel] [PATCH v1 2/3] > MdeModulePkg/CapsuleRuntimeDxe: Add RISCV64 arch. > > > > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Wu, Hao A > > Sent: Monday, April 20, 2020 1:24 PM > > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > <abner.ch...@hpe.com> > > Cc: Chen, Gilbert <gilbert.c...@hpe.com>; Leif Lindholm > > <leif.lindh...@linaro.org>; Gao, Liming <liming....@intel.com> > > Subject: Re: [edk2-devel] [PATCH v1 2/3] > > MdeModulePkg/CapsuleRuntimeDxe: Add RISCV64 arch. > > > > > -----Original Message----- > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf > Of > > > Chang, Abner (HPS SW/FW Technologist) > > > Sent: Friday, April 10, 2020 3:26 PM > > > To: devel@edk2.groups.io > > > Cc: Chang, Abner (HPS SW/FW Technologist); Chen, Gilbert; Leif > > > Lindholm; Wu, Hao A; Gao, Liming > > > Subject: [edk2-devel] [PATCH v1 2/3] > MdeModulePkg/CapsuleRuntimeDxe: > > > Add RISCV64 arch. > > > > > > Add RISC-V in INF for building CapsuleRuntimeDxe RISCV64 image. > > > > > > Signed-off-by: Abner Chang <abner.ch...@hpe.com> > > > Co-authored-by: Gilbert Chen <gilbert.c...@hpe.com> > > > Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> > > > > > > Cc: Hao A Wu <hao.a...@intel.com> > > > Cc: Liming Gao <liming....@intel.com> > > > Cc: Leif Lindholm <leif.lindh...@linaro.org> > > > Cc: Gilbert Chen <gilbert.c...@hpe.com> > > > --- > > > .../Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf | 9 +++++---- > > > 1 file changed, 5 insertions(+), 4 deletions(-) > > > > > > diff --git > > > a/MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf > > > b/MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf > > > index 942eda235c..8bf5035a69 100644 > > > --- > > a/MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf > > > +++ > > > b/MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf > > > @@ -5,6 +5,7 @@ > > > # the capsule runtime services are ready. > > > # > > > # Copyright (c) 2006 - 2020, Intel Corporation. All rights > > > reserved.<BR> > > > +# Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All > > > +rights > > > reserved.<BR> > > > # SPDX-License-Identifier: BSD-2-Clause-Patent # ## @@ -21,20 > > > +22,20 @@ # # The following information is for reference only and > > > not required by the build tools. > > > # > > > -# VALID_ARCHITECTURES = IA32 X64 EBC ARM AARCH64 > > > +# VALID_ARCHITECTURES = IA32 X64 EBC ARM AARCH64 RISCV64 > > > # > > > > > > [Sources] > > > CapsuleService.c > > > CapsuleService.h > > > > > > -[Sources.Ia32, Sources.EBC, Sources.ARM, Sources.AARCH64] > > > +[Sources.Ia32, Sources.EBC, Sources.ARM, Sources.AARCH64, > > > Sources.RISCV64] > > > SaveLongModeContext.c > > > > > > -[Sources.Ia32, Sources.X64, Sources.ARM, Sources.AARCH64] > > > +[Sources.Ia32, Sources.X64, Sources.ARM, Sources.AARCH64, > > > Sources.RISCV64] > > > CapsuleCache.c > > > > > > -[Sources.Ia32, Sources.X64, Sources.EBC] > > > +[Sources.Ia32, Sources.X64, Sources.EBC, Sources.RISCV64] > > > CapsuleReset.c > > > > > > Hello Abner, > > > > Sorry for the delayed response. > > I saw you added the new arch under sections: > > [Sources.Ia32, Sources.EBC, Sources.ARM, Sources.AARCH64] > [Sources.Ia32, > > Sources.X64, Sources.ARM, Sources.AARCH64] [Sources.Ia32, Sources.X64, > > Sources.EBC] > > > > How about the below section? It is not needed, right? > > [Sources.X64] > No, we don't need [Sources.X64] for architecture specific > saveLongModeContext implementation. > thanks
Got it, thanks for the explanation. Acked-by: Hao A Wu <hao.a...@intel.com> Best Regards, Hao Wu > > > > > Best Regards, > > Hao Wu > > > > > > > > > > [Sources.ARM, Sources.AARCH64] > > > -- > > > 2.25.0 > > > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57595): https://edk2.groups.io/g/devel/message/57595 Mute This Topic: https://groups.io/mt/73143604/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
