On 4/19/20 3:04 PM, Samer El-Haj-Mahmoud wrote:
Fix an ASSERT with the TFTP dynamic Shell command on the RPi3 and RPi4 when running DEBUG builds. Also, enable the command by default for all builds.
Fixing the ASSERT is fine but I am reluctant to enable this by default. It is a non-standard hack that ARM contributed in the past, and is not covered by the EFI of Shell specifications. If RPi4 is intended to be a showcase for UEFI on ARM done right, we should not enable this at all.
Cc: Leif Lindholm <l...@nuviainc.com> Cc: Ard Biesheuvel <ard.biesheu...@arm.com> Cc: Pete Batard <p...@akeo.ie> Cc: Andrei Warkentin <awarken...@vmware.com> Samer El-Haj-Mahmoud (4): Platform/RaspberryPi/RPi3: Fix TFTP dynamic command initialization Platform/RaspberryPi/RPi4: Fix TFTP dynamic command initialization Platform/RaspberryPi/RPi3: Enable TFTP command by default Platform/RaspberryPi/RPi4: Enable TFTP command by default Platform/RaspberryPi/RPi3/RPi3.dsc | 7 +++++-- Platform/RaspberryPi/RPi4/RPi4.dsc | 7 +++++-- 2 files changed, 10 insertions(+), 4 deletions(-)
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57570): https://edk2.groups.io/g/devel/message/57570 Mute This Topic: https://groups.io/mt/73127191/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
