Agree with both 1 & 2. Will update patch to address them.
Best Regards,
Hao Wu
> -Original Message-
> From: Ni, Ray
> Sent: Tuesday, December 24, 2019 11:48 AM
> To: Wu, Hao A; devel@edk2.groups.io
> Cc: Dong, Eric; Laszlo Ersek; Zeng, Star; Fu, Siyuan; Kinney, Michael D
> Subject: RE: [
> -Original Message-
> From: Ni, Ray
> Sent: Tuesday, December 24, 2019 11:32 AM
> To: Wu, Hao A; devel@edk2.groups.io
> Cc: Dong, Eric; Laszlo Ersek; Zeng, Star; Fu, Siyuan; Kinney, Michael D
> Subject: RE: [PATCH v1 2/4] UefiCpuPkg/MpInitLib: Reduce the size when
> loading microcode patch
Reviewed-by: Ray Ni
> -Original Message-
> From: Wang, Sunny (HPS SW)
> Sent: Tuesday, December 24, 2019 12:44 PM
> To: devel@edk2.groups.io; ashishsin...@nvidia.com; Ni, Ray
> ; Wang, Jian J ; Wu, Hao A
> ; Gao, Zhichao ; Kinney,
> Michael D ; af...@apple.com
> Cc: Wang, Sunny (HPS SW)
Reviewed-by: Ray Ni
> -Original Message-
> From: Ashish Singhal
> Sent: Tuesday, December 24, 2019 10:58 AM
> To: devel@edk2.groups.io; Ni, Ray ; Wang, Jian J
> ; Wu, Hao A ; Gao, Zhichao
> ; Kinney, Michael D ;
> af...@apple.com
> Cc: Ashish Singhal
> Subject: [PATCH v7] MdeModulePkg:
Hello all:
Right now the HTTPS Certificates are getting validated during
TlsConfigCertificate()by HTTPDxe Driver.
But during enrollment of certificate via TLSDXE driver, it does not have any
validation and it keep appending the TLSCaCert variable with the certificate
provided.
Assume an inval
Hi Sunny,
For the 3 use cases you suggested, please let me know if you think I am wrong.
1. RefreshAllBootOptions can refresh boot options which are auto created by
BmEnumerateBootOptions as well as NV boot options in the variable store.
Platform implementation of RefreshAllBootOptions can have
Looks good enough to me. Thanks for addressing my comments, Ashish.
Reviewed-by: Sunny Wang
-Original Message-
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ashish
Singhal
Sent: Tuesday, December 24, 2019 10:58 AM
To: devel@edk2.groups.io; ray...@intel.com; jian.j
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2388
Token is new introduced by MM MP Protocol. Current logic allocate Token
every time when need to use it. The logic caused SMI latency raised to
very high. Update logic to allocate Token buffer at driver's entry point.
Later use the token from
Thanks for checking this, Ray.
Platform may want to:
1. Refresh the static boot options (that are not created by
BmEnumerateBootOptions) without a reboot.
2. Update some other static-informational data or configuration data right
after calling EfiBootManagerRefreshAllBootOption.
3. Always
MicrocodeDetect() is called in DXE phase as well.
But it doesn't use the new MicrocodePatch HOB to speed up the
microcode detection. Why?
> -Original Message-
> From: Wu, Hao A
> Sent: Tuesday, December 24, 2019 9:37 AM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Dong, Eric ; Ni,
> Ray ;
> + //
> + // The number of processors within the system.
> + //
> + UINT32ProcessorNumber;
1. Number is a bit confusing here. I also provided comments to other patches.
We could "ProcessorCount" here.
Number can be either count of items, or an index to a specific item.
> + //
> + // An
Sunny had one comment regarding the API name and I replied.
Let's wait for Sunny's further comments as well.
Thanks,
Ray
From: Ashish Singhal
Sent: Tuesday, December 24, 2019 11:00 AM
To: Ni, Ray ; devel@edk2.groups.io; Wang, Jian J
; Wu, Hao A ; Gao, Zhichao
; Kinney, Michael D ;
af...@apple
6 minor comments.
> -Original Message-
> From: Wu, Hao A
> Sent: Tuesday, December 24, 2019 9:37 AM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Dong, Eric ; Ni,
> Ray ; Laszlo Ersek ; Zeng, Star
> ; Fu, Siyuan ; Kinney, Michael
> D
> Subject: [PATCH v1 2/4] UefiCpuPkg/MpInitLib: Reduce
Hi Ray,
Patch 7 has been submitted. Please let me know if there are any other changes
needed. I would wait for your patch acceptance email.
Thanks
Ashish
From: Ni, Ray
Sent: Monday, December 23, 2019 7:38 PM
To: devel@edk2.groups.io ; Ashish Singhal
; Wang, Jia
Add edk2 platform boot manager protocol which would have platform
specific refreshes to the auto enumerated as well as NV boot options
for the platform.
Signed-off-by: Ashish Singhal
---
.../Include/Protocol/PlatformBootManager.h | 82 ++
MdeModulePkg/Library/UefiBoot
> -Original Message-
> From: Albecki, Mateusz
> Sent: Saturday, December 21, 2019 1:13 AM
> To: devel@edk2.groups.io
> Cc: Albecki, Mateusz; Wu, Hao A; Marcin Wojtas; Gao, Zhichao; Gao, Liming
> Subject: [PATCH 1/2] SdMmcPciHcDxe: Send EdkiiSdMmcSwitchClockFreq after
> SD clock start
Hell
> -Original Message-
> From: Albecki, Mateusz
> Sent: Saturday, December 21, 2019 1:13 AM
> To: devel@edk2.groups.io
> Cc: Albecki, Mateusz; Wu, Hao A; Marcin Wojtas; Gao, Zhichao; Gao, Liming
> Subject: [PATCH 0/2] MdeModulePkg/SdMmcPciHcDxe: Send the
> EdkiiSdMmcSwitchClockFreq notificati
> -Original Message-
> From: Albecki, Mateusz
> Sent: Saturday, December 21, 2019 1:13 AM
> To: devel@edk2.groups.io
> Cc: Albecki, Mateusz; Wu, Hao A; Marcin Wojtas; Gao, Zhichao; Gao, Liming
> Subject: [PATCH 2/2] MdeModulePkg/SdMmcPciHcDxe: Add function to start
> SD clock
>
> In SD car
Reviewed-by: Ray Ni
> -Original Message-
> From: Wu, Hao A
> Sent: Tuesday, December 24, 2019 9:37 AM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Dong, Eric ; Ni,
> Ray ; Laszlo Ersek ; Zeng, Star
> ; Fu, Siyuan ; Kinney, Michael
> D
> Subject: [PATCH v1 1/4] UefiCpuPkg/MpInitLib: Coll
Reviewed-by: Ray Ni
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Dong,
> Eric
> Sent: Monday, December 23, 2019 4:11 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Laszlo Ersek
> Subject: [edk2-devel] [PATCH v3 1/2] UefiCpuPkg/PiSmmCpuDxeSmm:
> Remove dependence between
> -Original Message-
> From: Wang, Sunny (HPS SW)
> Sent: Friday, December 20, 2019 7:29 PM
> To: devel@edk2.groups.io; ashishsin...@nvidia.com; Ni, Ray
> ; Wang, Jian J ; Wu, Hao A
> ; Gao, Zhichao ; Kinney,
> Michael D ; 'Andrew Fish (af...@apple.com)'
>
> Cc: Spottswood, Jason ; Wang
> +(EFIAPI *REFRESH_ALL_BOOT_OPTIONS) (
I recommend to rename it to "PLATFORM_BOOT_MANAGER_REFRESH_ALL_BOOT_OPTIONS" to
avoid
future name confliction with other protocols.
With that, Reviewed-by: Ray Ni
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/
Eric,
I am curious how the SMM CPU driver ran well with the buffer overflow issue?
Can you please explain the details?
Thanks,
Ray
> -Original Message-
> From: Dong, Eric
> Sent: Monday, December 23, 2019 4:11 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Laszlo Ersek
> Subject: [PATCH
Hi Guys,
Do we have any feedback on this?
Thanks
Ashish
-Original Message-
From: Ashish Singhal
Sent: Sunday, December 22, 2019 7:27 PM
To: devel@edk2.groups.io; ray...@intel.com; jian.j.w...@intel.com;
hao.a...@intel.com; zhichao@intel.com; michael.d.kin...@intel.com;
af...@appl
Reviewed-by: Ray Ni
> -Original Message-
> From: Tsao, Ethan
> Sent: Monday, December 23, 2019 4:25 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Chaganty, Rangasai V
>
> Subject: [Patch v2] IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h
>
> REF:https://bugzilla.tianocore.org/sho
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2430
This commit will update the MpInitLib to:
A. Collect the base address and size information after microcode patches
being loaded into memory;
B. Collect the applied microcode patch for each processor within system;
C. Based on the collecte
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2429
This commit will collect the CPUID and Platform ID information for each
processor within system. They will be stored in the CPU_AP_DATA structure.
These information will be used in the next commit to decide whether a
microcode patch will be
Series is also available at:
https://github.com/hwu25/edk2/tree/mpinitlib_opt_v1
This series will introduce a couple of optimizations to the MpInitLib with
regard to microcode:
A. Reduce the copy size when loading the microcode patches data from flash
into memory;
B. Produce a HOB to contain m
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2430
This commit will add the definitions for EDKII microcode patch HOB.
The intention of adding this HOB is to provide a scheme to store the below
information:
A. The base address and size of the microcode patches that are being
loaded (from
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2429
This commit will attempt to reduce the copy size when loading the
microcode patches data from flash into memory.
Such optimization is done by a pre-process of the microcode patch headers
(on flash). A microcode patch will be loaded into memo
On Thu, 19 Dec 2019 at 19:15, Sami Mujawar wrote:
>
> Hi Ard,
>
> This is required for loading the AML blob in memory so that we can parse and
> fixup tables.
>
> However, I understand your concern regarding dependency/relying on asl
> compilers for the .hex file.
> The .hex file can be easily g
On Thu, 12 Dec 2019 at 10:05, Ard Biesheuvel wrote:
>
> On Thu, 12 Dec 2019 at 09:59, Ni, Ray wrote:
> >
> > Ard,
> > I still cannot understand it.
> >
> > Since Driver are processed (process = LoadImage + StartImage) after
> > EndOfDxe, they are not deferred.
> > It means the Driver ent
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2318
Create header for BaseConfigBlockLib in InstelSiliconPkg and remove all other
ConfigBlock.h
Signed-off-by: Ethan Tsao
Cc: Ray Ni
Cc: Rangasai V Chaganty
---
Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc
Please update the copyright text to "BSD-2-Clause-Patent" format and start the
year with the year of this file creation.
Thanks,
Sai
-Original Message-
From: Ni, Ray
Sent: Sunday, December 22, 2019 11:50 PM
To: Tsao, Ethan ; devel@edk2.groups.io
Cc: Chaganty, Rangasai V
Subject: RE: [
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2268
In current implementation, when check whether APs called by StartUpAllAPs
or StartUpThisAp, it checks the Tokens value used by other APs. Also the AP
will update the Token value for itself if its task finished. In this
case, the potential ra
This patch serial
1. patch 1 fixed potential race condition issue for PiSmmCpuDxeSmm.
2. Patch 2 fixed a potential buffer overflow issue.
V3 change:
Minor changes based on comments.
Cc: Ray Ni
Cc: Laszlo Ersek
Eric Dong (2):
UefiCpuPkg/PiSmmCpuDxeSmm: Remove dependence between APs
Ue
The size for the array of mSmmMpSyncData->CpuData[] is 0 ~
mMaxNumberOfCpus -1. But current code may use
mSmmMpSyncData->CpuData[mMaxNumberOfCpus].
This patch fixed this issue.
Reviewed-by: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Eric Dong
---
UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 16 +++
Zhichao:
I think the first step is to send RFC on the proposal. If no one rejects RFC,
then work out the detail changes.
Thanks
Liming
> -Original Message-
> From: Gao, Zhichao
> Sent: Monday, December 23, 2019 8:44 AM
> To: Ni, Ray ; devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao
38 matches
Mail list logo
