Agree with both 1 & 2. Will update patch to address them. Best Regards, Hao Wu
> -----Original Message----- > From: Ni, Ray > Sent: Tuesday, December 24, 2019 11:48 AM > To: Wu, Hao A; devel@edk2.groups.io > Cc: Dong, Eric; Laszlo Ersek; Zeng, Star; Fu, Siyuan; Kinney, Michael D > Subject: RE: [PATCH v1 3/4] UefiCpuPkg: Add definitions for EDKII microcode > patch HOB > > > + // > > + // The number of processors within the system. > > + // > > + UINT32 ProcessorNumber; > 1. Number is a bit confusing here. I also provided comments to other patches. > We could "ProcessorCount" here. > Number can be either count of items, or an index to a specific item. > > > > + // > > + // An array with 'ProcessorNumber' elements that stores the offset (with > > + // regard to 'MicrocodePatchAddress') of the applied microcode patch for > > each > > + // processor. > > + // If no microcode patch is applied for certain processor, the relating > > + // element will be set to MAX_UINT64. > > + // > > + UINT64 DetectedPatchOffset[0]; > > 2. "ProcessorSpecificPatchOffset"? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52538): https://edk2.groups.io/g/devel/message/52538 Mute This Topic: https://groups.io/mt/69242655/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
