> -----Original Message----- > From: Wang, Sunny (HPS SW) <[email protected]> > Sent: Friday, December 20, 2019 7:29 PM > To: [email protected]; [email protected]; Ni, Ray > <[email protected]>; Wang, Jian J <[email protected]>; Wu, Hao A > <[email protected]>; Gao, Zhichao <[email protected]>; Kinney, > Michael D <[email protected]>; 'Andrew Fish ([email protected])' > <[email protected]> > Cc: Spottswood, Jason <[email protected]>; Wang, Sunny (HPS > SW) <[email protected]> > Subject: RE: [edk2-devel] [PATCH v4] MdeModulePkg: Add EDK2 Platform > Boot Manager Protocol > > Good point. The way you used is more robust. It can cover a mistake in > function's error handling. Thanks for clarifying this, Ashish. > > In addition, the other naming suggestion just comes to mind. How about we > rename the function to a more generic one (based on location) like > AfterEnumerateBootOptions or a more specific one like > RefreshEnumeratedBootOptions? In the future, we may add the other hook > function in the EfiBootManagerRefreshAllBootOption to deal with the boot > options that are not created by BmEnumerateBootOptions. In this case (two > hook functions in EfiBootManagerRefreshAllBootOption), the original > function name "RefreshAllBootOptions" may cause some confusion.
Sunny, What else feasibility do you think platform may require in future but this RefreshAllBootOptions cannot support? Thanks, Ray -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52518): https://edk2.groups.io/g/devel/message/52518 Mute This Topic: https://groups.io/mt/68802855/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
