Re: [edk2-devel] [PATCH] edksetup.bat: Simplify the step to use CLANGPDB

> +:check_CLANGPDB 1. Would be great if there is comment to explain why "n" is set to CLANG_HOST_BIN. > +@set CLANG_HOST_BIN=n > +if not defined CLANG_BIN ( > +@echo. > +@echo !!! WARNING !!! CLANG_BIN environment variable is not set > +@if exist "C:\Program Files\LLVM\bin\clang.exe"

Re: [edk2-devel] [PATCH] BaseTools/Scripts: Add sendemail.transferEncoding to SetupGit.py

Hi Phil, What I saw the working part of this path is one line, {'section': 'sendemail', 'option': 'transferEncoding', 'value': '8bit'}, other changes are just to adjust alignment. Thanks, Bob -Original Message- From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com] Sent: Thursda

[edk2-devel] [PATCH] edksetup.bat: Simplify the step to use CLANGPDB

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2404 Set the below two environment variables in edksetup.bat: set CLANG_HOST_BIN=n set CLANG_BIN=C:\Program Files\LLVM\bin\ The CLANG_BIN is only be set if it is not defined. Cc: Liming Gao Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Zhigu

Re: [edk2-devel] [PATCH V3 0/2] *MdePkg/UefiDevicePathLib: Separate the lib instances

Zhichao, I prefer to have one patch serial which include: 1. Adds new mandatory instance 2. Update consumers to use the new instance 2. Removes the old mandatory instance Otherwise, adding a new mandatory instance introduces more code duplication IMO. Thanks, Ray > -Original Message- > F

Re: [edk2-devel] [PATCH V3 0/2] *MdePkg/UefiDevicePathLib: Separate the lib instances

For open source, it would impact fsp2 package, ovmf package and some open platform packages. Not sure for others. I didn't plan the removal of UefiDevicePathLibDevicePathProtocol yet. Thanks, Zhichao > -Original Message- > From: Ni, Ray > Sent: Friday, December 20, 2019 2:20 PM > To: Gao,

Re: [edk2-devel] [PATCH 06/79] EmulatorPkg/Unix: Fix various typos

Reviewed-by: Ray Ni > -Original Message- > From: Philippe Mathieu-Daude > Sent: Wednesday, December 4, 2019 12:15 AM > To: devel@edk2.groups.io > Cc: Antoine Coeur ; Justen, Jordan L > ; Andrew Fish ; Ni, Ray > ; Philippe Mathieu-Daude > Subject: [PATCH 06/79] EmulatorPkg/Unix: Fix vari

Re: [edk2-devel] [PATCH 09/79] FatPkg/FatPei: Fix few typos

Reviewed-by: Ray Ni > -Original Message- > From: Philippe Mathieu-Daude > Sent: Wednesday, December 4, 2019 12:15 AM > To: devel@edk2.groups.io > Cc: Antoine Coeur ; Ni, Ray ; Philippe > Mathieu-Daude > Subject: [PATCH 09/79] FatPkg/FatPei: Fix few typos > > From: Antoine Coeur > > F

Re: [edk2-devel] [PATCH V3 0/2] *MdePkg/UefiDevicePathLib: Separate the lib instances

Removing code duplication is great. But your patch introduces more code duplication: the mandatory one in UefiDevicePathLib directory and the other one in UefiDevicePathLibDevicePathProtocol directory. Do you have a plan to remove the one in UefiDevicePathLibDevicePathProtocol directory? Have y

Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Remove dependence between APs.

> > + if (!Token->SingleAp) { > > +ReleaseSemaphore (&Token->FinishedApCount); 1. If the FinishedApCount is renamed to RunningApCount and InterlockedDecrement() is called for it. SingleAp flag is unneeded. For StartupAllAps(), RunningApCount = mMaxNumberOfCpus - 1; For StartupThisAps(), R

Re: [edk2-devel] [PATCH] [edk2/BaseTools] edksetup.bat stuck on unicode locale Windows

Hi Aiden, I'd like to know why need to call 'edksetup.bat forcerebuild' with python subprocess.call(). Is there other way to execute edksetup.bat? Thanks, Bob -Original Message- From: Park, Aiden Sent: Friday, December 20, 2019 8:23 AM To: Feng, Bob C ; devel@edk2.groups.io Subject: RE:

Re: [edk2-devel] [PATCH v1] MdePkg: Use __builtin_offset with CLANGPDB toolchain

merge@796b380ca7d263ca504b82fe5317a78d3546d537 >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Liming Gao >Sent: Wednesday, December 18, 2019 10:07 AM >To: devel@edk2.groups.io; Gao, Liming ; Alex James > >Cc: Kinney, Michael D ; Liu, Zhiguang >

Re: [edk2-devel] [PATCH V3 0/2] *MdePkg/UefiDevicePathLib: Separate the lib instances

Ray, I knew there is one in MdePkg. But it has duplicate code with UefiDevicePathLib. That is why I add the Mandatory one. And it is recommended to use the one in UefiDevicePathLib path. Thanks, Zhichao > -Original Message- > From: Ni, Ray > Sent: Friday, December 20, 2019 1:50 PM > To:

Re: [edk2-devel] [PATCH V3 0/2] *MdePkg/UefiDevicePathLib: Separate the lib instances

Zhichao, \MdePkg\Library\UefiDevicePathLibDevicePathProtocol\ contains the version that hard-depends on the protocol. I don't think you need to add another version. Thanks, Ray > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gao, > Zhichao > Sent: Wednesday, December 18,

[edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Remove dependence between APs.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2268 In current implementation, when check whether APs called by StartUpAllAPs or StartUpThisAp, it checks the Tokens value used by other APs. Also the AP will update the Token value for itself if its task finished. In this case, the potential ra

Re: [edk2-devel] reg: HTTPS Certificate Update

Hello Jiaxin / Siyuan: Would you please feedback on this. -Siva From: Sivaraman Nainar Sent: Monday, December 16, 2019 4:42 PM To: 'devel@edk2.groups.io'; 'Wu, Jiaxin'; 'Fu, Siyuan' Cc: Madhan B. Santharam; Arun Subramanian B; Arun Sura Soundara Pandian; Bhuvaneshwari M R Subject: reg: HTTPS Cer

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 03/39] RiscVPkg/opensbi: EDK2 RISC-V OpenSBI support

> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Thursday, December 19, 2019 10:48 PM > To: Leif Lindholm ; devel@edk2.groups.io > Cc: Chen, Gilbert ; Kinney, Michael D > > Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V

Re: [edk2-devel] [PATCH] MdePkg/Tcg: Add new definition in TCG PFP spec.

That's good. Reviewed-by: Liming Gao >-Original Message- >From: Yao, Jiewen >Sent: Thursday, December 19, 2019 10:54 PM >To: Gao, Liming >Cc: devel@edk2.groups.io; Kinney, Michael D >Subject: Re: [edk2-devel] [PATCH] MdePkg/Tcg: Add new definition in TCG >PFP spec. > >no impact. >the ol

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Build ASL files before C files

Hi Ard, This is required for loading the AML blob in memory so that we can parse and fixup tables. However, I understand your concern regarding dependency/relying on asl compilers for the .hex file. The .hex file can be easily generated by a post-processing python script (20-30 lines of code)

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RPi: Inhibit serial output for all runtime drivers

On Mon, 16 Dec 2019 at 17:11, Leif Lindholm wrote: > > On Wed, Dec 11, 2019 at 17:04:01 +, Pete Batard wrote: > > From: Ard Biesheuvel > > Oops - sorry, I missed the From: - thanks for the poke. > > Yeah, I'm good with this change: > Reviewed-by: Leif Lindholm > Thanks Pushed as e9395c53ba

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/7] Platform/RPi4: ACPI improvements

On 2019.12.19 16:55, Ard Biesheuvel wrote: On Thu, 19 Dec 2019 at 14:14, Pete Batard wrote: Changes from v1 (https://edk2.groups.io/g/devel/message/52342 - 52348): * Add PL011 and miniUART constants in Silicon/.../Bcm2836.h and use those in the SPCR and DBG2 tables * Use default values in F

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Build ASL files before C files

(+ Leif) On Thu, 19 Dec 2019 at 13:19, Pierre Gondois wrote: > > Hello Ard, > I cannot find any documentation more than what the iASL compiler does with > the '-tc' argument: > -tc Create hex AML table in C (*.hex) > > The '.hex' file looks like this: > > #ifndef __ASL_SOURCE_FI

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/7] Platform/RPi4: ACPI improvements

On Thu, 19 Dec 2019 at 14:14, Pete Batard wrote: > > Changes from v1 (https://edk2.groups.io/g/devel/message/52342 - 52348): > * Add PL011 and miniUART constants in Silicon/.../Bcm2836.h and use > those in the SPCR and DBG2 tables > * Use default values in FADT wherever possible > * Drop MCFG ta

Re: [edk2-devel] [PATCH v4] MdeModulePkg: Add EDK2 Platform Boot Manager Protocol

Hi Sunny, I thought about keeping the arguments the way you suggested but then decided against it so that the auto enumerated boot options list is not tampered with in case the function implementation hits an error in between. This way, if the function returns an error, we can use the list we p

Re: [edk2-devel] [Patch] MdePkg PciExpress21: PCI_REG_PCIE_DEVICE_CONTROL2 struct has 17 bits

Merge @665afccc52e1a02ee329147e02f04b8e9cf1d571 From: Ni, Ray Sent: Thursday, December 19, 2019 10:22 AM To: Gao; Gao, Liming ; devel@edk2.groups.io Subject: Re: [edk2-devel] [Patch] MdePkg PciExpress21: PCI_REG_PCIE_DEVICE_CONTROL2 struct has 17 bits Reviewed-by: Ray Ni ray...@intel.com

Re: [edk2-devel] [PATCH] MdePkg/Tcg: Add new definition in TCG PFP spec.

no impact. the old definition is totally wrong according to the spec. No code is using that. thank you! Yao, Jiewen > 在 2019年12月19日，下午10:27，Gao, Liming 写道： > > Jiewen: > I see this patch removes some old definitions. Is there any impact on this > change? > > Thanks > Liming >> -Origi

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 03/39] RiscVPkg/opensbi: EDK2 RISC-V OpenSBI support

> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Thursday, December 19, 2019 9:22 PM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > Cc: Chen, Gilbert ; Kinney, Michael D > > Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PAT

Re: [edk2-devel] [PATCH] MdePkg/Tcg: Add new definition in TCG PFP spec.

Jiewen: I see this patch removes some old definitions. Is there any impact on this change? Thanks Liming > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Wednesday, December 18, 2019 3:17 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Limi

Re: [edk2-devel] [PATCH v4] MdeModulePkg: Add EDK2 Platform Boot Manager Protocol

1. Is it a proper solution to the problem? Yes, it already solved my concern discussed in the other email. 2. Is the new protocol/function name proper? Yes, but I'm not good at naming. We may need others' feedback. :) 3. Are the parameters in the function proper? How about we only have

[edk2-devel] [PATCH 1/1] BaseTools/PatchCheck.py: Ignore CR and LF characters in subject length

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=113 Strip the trailing characters before checking the subject line is less than 72 characters. Fixes: e61406708c83f Cc: Liming Gao Cc: Jordan Justen Signed-off-by: Philippe Mathieu-Daude --- Cc: Yonghong Zhu Cc: Zhichao Gao --- BaseTools/S

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/7] Silicon/Bcm283x: Add UART constants for PL011 and miniUART

On 12/19/19 2:32 PM, Ard Biesheuvel wrote: On Thu, 19 Dec 2019 at 15:27, Philippe Mathieu-Daudé wrote: On 12/19/19 1:14 PM, Pete Batard wrote: This adds offset, base address, interrupt and register-space length for the 2 UARTs that the Bcm283x SoC provides. To be consistent, we simplify the

[edk2-devel] [PATCH v2 0/2] ShellPkg: Document the use of EFI_INVALID_PARAMETER by two functions

Complete the list of values the functios ParseCommandLineToArgs() and UpdateArgcArgv() can return. The documentation was found to be incomplete while reviewing BZ#2395: https://edk2.groups.io/g/devel/message/51512 v2: - Shortened patch #1 subject to fit 72 chars - Added Zhichao Gao R-b tag Regar

Re: [edk2-devel] [PATCH 0/2] ShellPkg: Document the use of EFI_INVALID_PARAMETER by two functions

On 12/19/19 6:00 AM, Gao, Zhichao wrote: Sorry for missing do the script check. The patch #1 's title length is too long. We should make sure the title length is less than 72 (not include 72). Can you change that and resend the patch set? Will do. Thanks, Zhichao -Original Message

[edk2-devel] [PATCH v2 2/2] ShellPkg: Document UpdateArgcArgv returns EFI_INVALID_PARAMETER

ShellParametersProtocol::UpdateArgcArgv() can return a EFI_INVALID_PARAMETER value. Document it. Reviewed-by: Zhichao Gao Signed-off-by: Philippe Mathieu-Daude --- ShellPkg/Application/Shell/ShellParametersProtocol.h | 1 + ShellPkg/Application/Shell/ShellParametersProtocol.c | 1 + 2 files cha

[edk2-devel] [PATCH v2 1/2] ShellPkg: Document ParseCommandLineToArgs returns EFI_INVALID_PARAMETER

ShellParametersProtocol::ParseCommandLineToArgs() can return a EFI_INVALID_PARAMETER value. Document it. Reviewed-by: Zhichao Gao Signed-off-by: Philippe Mathieu-Daude --- ShellPkg/Application/Shell/ShellParametersProtocol.h | 1 + ShellPkg/Application/Shell/ShellParametersProtocol.c | 1 + 2 f

Re: [edk2-devel] [edk2-platforms][PATCH v2 6/7] Platform/RPi4: Add XHCI ACPI table

On Thu, 19 Dec 2019 at 15:32, Pete Batard wrote: > > Hi Ard, > > On 2019.12.19 13:12, Ard Biesheuvel wrote: > > Hi Pete, > > > > On Thu, 19 Dec 2019 at 14:14, Pete Batard wrote: > >> > >> From: Andrei Warkentin > >> > >> Since the RPi4 PCIe host bridge is not ECAM compliant, we can > >> not expo

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/7] Silicon/Bcm283x: Add UART constants for PL011 and miniUART

On Thu, 19 Dec 2019 at 15:27, Philippe Mathieu-Daudé wrote: > > On 12/19/19 1:14 PM, Pete Batard wrote: > > This adds offset, base address, interrupt and register-space length > > for the 2 UARTs that the Bcm283x SoC provides. > > > > To be consistent, we simplify the two other existing base addre

Re: [edk2-devel] [edk2-platforms][PATCH v2 6/7] Platform/RPi4: Add XHCI ACPI table

Hi Ard, On 2019.12.19 13:12, Ard Biesheuvel wrote: Hi Pete, On Thu, 19 Dec 2019 at 14:14, Pete Batard wrote: From: Andrei Warkentin Since the RPi4 PCIe host bridge is not ECAM compliant, we can not expose it as a host bridge to the OS via ACPI. However, given the hardwired nature of this p

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/7] Silicon/Bcm283x: Add UART constants for PL011 and miniUART

On 12/19/19 1:14 PM, Pete Batard wrote: This adds offset, base address, interrupt and register-space length for the 2 UARTs that the Bcm283x SoC provides. To be consistent, we simplify the two other existing base address definitions to a more legible equivalent since there is no point in explici

[edk2-devel] [PATCH V3] SbsaQemu: EFI implementation for SbsaQemu platform

From: Radoslaw Biernacki Linaro enterprise group is coordinating work for adding SBSA compliant virtual platform for QEMU. This patch adds initial support for platform with nondiscoverable AHCI, VGA and single DRAM window over 32bit address space. We are using FDF to compose EFI flash images wit

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 03/39] RiscVPkg/opensbi: EDK2 RISC-V OpenSBI support

On Thu, Dec 19, 2019 at 04:09:22 +, Abner Chang wrote: > > > diff --git a/RiscVPkg/Include/sbi/sbi.h b/RiscVPkg/Include/sbi/sbi.h > > > new file mode 100644 index 000..04e7f18 > > > --- /dev/null > > > +++ b/RiscVPkg/Include/sbi/sbi.h > > > @@ -0,0 +1,52 @@ > > > +/** @file > > > + SBI inl

Re: [edk2-devel] [edk2-platforms][PATCH v2 6/7] Platform/RPi4: Add XHCI ACPI table

Hi Pete, On Thu, 19 Dec 2019 at 14:14, Pete Batard wrote: > > From: Andrei Warkentin > > Since the RPi4 PCIe host bridge is not ECAM compliant, we can > not expose it as a host bridge to the OS via ACPI. However, > given the hardwired nature of this platform, we can expose the > xHCI controller

[edk2-devel] [edk2-platforms][PATCH v2 6/7] Platform/RPi4: Add XHCI ACPI table

From: Andrei Warkentin Since the RPi4 PCIe host bridge is not ECAM compliant, we can not expose it as a host bridge to the OS via ACPI. However, given the hardwired nature of this platform, we can expose the xHCI controller that is guaranteed to live at the base of the MMIO32 BAR window as a plat

[edk2-devel] [edk2-platforms][PATCH v2 7/7] Platform/RPi4: Add ACPI basic mode build option

From: Ard Biesheuvel Add an ACPI_BASIC_MODE_ENABLE flag to produces builds intended to run in ACPI mode without any additional requirements (memory limits, acpi=force, etc). This flag is disabled by default. Signed-off-by: Pete Batard Reviewed-by: Leif Lindholm --- Platform/RaspberryPi/Libra

[edk2-devel] [edk2-platforms][PATCH v2 4/7] Platform/RPi4: Improve SPCR and DBG2 ACPI table generation

Use code derived from JunoPkg to generate our serial tables and also use PCDs where possible. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi4/AcpiTables/AcpiTables.inf | 5 +- Platform/RaspberryPi/RPi4/AcpiTables/Dbg2.aslc | 98 +--- Platform/RaspberryPi/RPi4/AcpiT

[edk2-devel] [edk2-platforms][PATCH v2 3/7] Platform/RPi4: Improve FADT ACPI table generation

Use a proper aslc source to build the table. Note that we use ACPI 5.1 for this table to match the MADT constraints. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi4/AcpiTables/Fadt.aslc | 99 ++-- 1 file changed, 71 insertions(+), 28 deletions(-) diff --git a/Platform/

[edk2-devel] [edk2-platforms][PATCH v2 5/7] Platform/RPi4: Add switch to select between PL011 and miniUART

The PL011 can be a better choice for the serial console on the RPi4, given that its baud clock is not derived from the CPU clock (which may change under our feet unless we keep it fixed at a low rate), and given the fact that the SBSA/SBBR specs that describe ARM specific architectural requirements

[edk2-devel] [edk2-platforms][PATCH v2 2/7] Platform/RPi4: Clean up ACPI definitions

* Use ACPI 5.1 everywhere, since we are constrained to use v5.x for MADT compatibility. * Clean up whitespaces and reorganize header declaration. * Prefix all RPi related constant with RPI_ to make them clearer to differentiate from regular EDK2 ones. * Reference IndustryStandard/Acpi.h always.

[edk2-devel] [edk2-platforms][PATCH v2 0/7] Platform/RPi4: ACPI improvements

Changes from v1 (https://edk2.groups.io/g/devel/message/52342 - 52348): * Add PL011 and miniUART constants in Silicon/.../Bcm2836.h and use those in the SPCR and DBG2 tables * Use default values in FADT wherever possible * Drop MCFG table * Improve computation of MMIO window in XHCI table * Impro

[edk2-devel] [edk2-platforms][PATCH v2 1/7] Silicon/Bcm283x: Add UART constants for PL011 and miniUART

This adds offset, base address, interrupt and register-space length for the 2 UARTs that the Bcm283x SoC provides. To be consistent, we simplify the two other existing base address definitions to a more legible equivalent since there is no point in explicit refs to FixedPcdGet64 (PcdBcm283xRegiste

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Build ASL files before C files

Hello Ard, I cannot find any documentation more than what the iASL compiler does with the '-tc' argument: -tc Create hex AML table in C (*.hex) The '.hex' file looks like this: #ifndef __ASL_SOURCE_FILE_HEX__ #define __ASL_SOURCE_FILE_HEX__ unsigned char ASL_SOURCE_FILE[] = {

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] Features/Intel/AcpiDebugFeaturePkg: Add feature active PCD

Reviewed-by: Sai Chaganty -Original Message- From: Kubacki, Michael A Sent: Wednesday, December 18, 2019 11:58 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Dong, Eric ; Gao, Liming Subject: [edk2-platforms][PATCH V1 1/1] Features/Intel/AcpiDebugFeaturePkg: Add

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] Features/Intel/AcpiDebugFeaturePkg: Add feature active PCD

Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Kubacki, > Michael A > Sent: Thursday, December 19, 2019 3:58 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Dong, Eric ; Gao, Liming > > Subject: [edk2-devel] [edk2-plat