On 12/19/19 6:00 AM, Gao, Zhichao wrote:
Sorry for missing do the script check. The patch #1 's title length is too 
long. We should make sure the title length is less than 72 (not include 72).
Can you change that and resend the patch set?

Will do.


Thanks,
Zhichao

-----Original Message-----
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
Gao, Zhichao
Sent: Wednesday, December 4, 2019 9:47 AM
To: Philippe Mathieu-Daude <phi...@redhat.com>; devel@edk2.groups.io
Cc: Ni, Ray <ray...@intel.com>
Subject: Re: [edk2-devel] [PATCH 0/2] ShellPkg: Document the use of
EFI_INVALID_PARAMETER by two functions

Series, Reviewed-by: Zhichao Gao <zhichao....@intel.com>

Thanks,
Zhichao

-----Original Message-----
From: Philippe Mathieu-Daude [mailto:phi...@redhat.com]
Sent: Tuesday, December 3, 2019 1:41 AM
To: devel@edk2.groups.io
Cc: Ni, Ray <ray...@intel.com>; Gao, Zhichao <zhichao....@intel.com>;
Philippe Mathieu-Daude <phi...@redhat.com>
Subject: [PATCH 0/2] ShellPkg: Document the use of
EFI_INVALID_PARAMETER by two functions

Complete the list of values the functios ParseCommandLineToArgs() and
UpdateArgcArgv() can return.

The documentation was found to be incomplete while reviewing BZ#2395:
https://edk2.groups.io/g/devel/message/51512

Regards,

Phil.

Philippe Mathieu-Daude (2):
   ShellPkg: Document ParseCommandLineToArgs returns
     EFI_INVALID_PARAMETER
   ShellPkg: Document UpdateArgcArgv returns EFI_INVALID_PARAMETER

  ShellPkg/Application/Shell/ShellParametersProtocol.h | 2 ++
ShellPkg/Application/Shell/ShellParametersProtocol.c | 2 ++
  2 files changed, 4 insertions(+)

--
2.21.0






-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#52423): https://edk2.groups.io/g/devel/message/52423
Mute This Topic: https://groups.io/mt/65089802/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to