Re: [edk2-devel] [RFC] Propose update of security bug handling process

2019-04-15 Thread Andrew Fish via Groups.Io
> On Apr 15, 2019, at 11:06 PM, Wang, Jian J wrote: > > Laszlo, > > I got your point, and understood the requirements for source released > platforms. > I think it's something needing all vendors who have concerns to get agreement > with. It's part of 'optimization' Vincent mentioned in anoth

[edk2-devel] [PATCH] Edk2\NetworkPkg\UefiPxeBcDxe : Open a method to Enabled/Disabled IPV6/IPV6 PXE Support.

2019-04-15 Thread Xue, ShengfengX
Please refer this link for defail. https://bugzilla.tianocore.org/show_bug.cgi?id=1695 Some Platform setup need provide a item for user to Enabled/Disabled IPV4/IPV6 PXE boot, but Origin UefiPxeBcDxe driver doesn't have such interface. So attached code review added two PCD to control IPV4/IPV6

Re: [edk2-devel] [RFC] Propose update of security bug handling process

2019-04-15 Thread Wang, Jian J
Laszlo, I got your point, and understood the requirements for source released platforms. I think it's something needing all vendors who have concerns to get agreement with. It's part of 'optimization' Vincent mentioned in another email. Stephano will set up meetings to drive related discussions.

Re: [edk2-devel] [PATCH v6 3/7] MdeModulePkg/PciBusDxe: dispatch option ROMs for foreign architectures

2019-04-15 Thread Gary Lin
On Sun, Apr 14, 2019 at 12:52:29PM -0700, Ard Biesheuvel wrote: > Delete the explicit machine type check for option ROM images, and instead, > rely on the LoadImage() boot service to decide whether an option ROM can > be dispatched or not. This permits platforms to ship with emulators to > execute

Re: [edk2-devel] [edk2-platforms: PATCH 3/6] Marvell/Armada7k8k: Implement custom DtLoaderLib

2019-04-15 Thread Marcin Wojtas
wt., 16 kwi 2019 o 07:01 Ard Biesheuvel napisał(a): > > On Mon, 15 Apr 2019 at 21:54, Marcin Wojtas wrote: > > > > Hi Ard, > > > > pon., 15 kwi 2019 o 21:01 Ard Biesheuvel > > napisał(a): > > > > > > On Mon, 15 Apr 2019 at 02:52, Marcin Wojtas wrote: > > > > > > > > Hi Ard, > > > > > > > > > >

Re: [edk2-devel] [PATCH V2 0/2] MdeModulePkg/CapsulePei: Update the debug code to print 64bit data

2019-04-15 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wu, > Hao A > Sent: Friday, April 12, 2019 12:45 PM > To: devel@edk2.groups.io; Gao, Zhichao > Cc: Wang, Jian J; Ni, Ray; Zeng, Star; Gao, Liming; Sean Brogan; Michael > Turner; > Bret Barkelew > S

Re: [edk2-devel] [edk2-platforms: PATCH 3/6] Marvell/Armada7k8k: Implement custom DtLoaderLib

2019-04-15 Thread Ard Biesheuvel
On Mon, 15 Apr 2019 at 21:54, Marcin Wojtas wrote: > > Hi Ard, > > pon., 15 kwi 2019 o 21:01 Ard Biesheuvel > napisał(a): > > > > On Mon, 15 Apr 2019 at 02:52, Marcin Wojtas wrote: > > > > > > Hi Ard, > > > > > > > > > pt., 12 kwi 2019 o 23:15 Ard Biesheuvel > > > napisał(a): > > > > > > > >

Re: [edk2-devel] [edk2-platforms: PATCH 3/6] Marvell/Armada7k8k: Implement custom DtLoaderLib

2019-04-15 Thread Marcin Wojtas
Hi Ard, pon., 15 kwi 2019 o 21:01 Ard Biesheuvel napisał(a): > > On Mon, 15 Apr 2019 at 02:52, Marcin Wojtas wrote: > > > > Hi Ard, > > > > > > pt., 12 kwi 2019 o 23:15 Ard Biesheuvel > > napisał(a): > > > > > > On Fri, 12 Apr 2019 at 03:20, Marcin Wojtas wrote: > > > > > > > > In order to pr

[edk2-devel] [PATCH] BaseTools/tools_def.template: Remove tools chain with ASL tool

2019-04-15 Thread Zhang, Shenglei
Microsoft ASL is not verified now. So remove tool chain with ASL tool. They are: VS2008xASL, VS2008x86xASL, VS2010xASL, VS2010x86xASL, VS2012xASL, VS2012x86xASL, VS2013xASL, VS2013x86xASL, VS2015xASL, VS2015x86xASL and CYGGCCxASL. https://bugzilla.tianocore.org/show_bug.cgi?id=1667 Cc: Bob Feng C

[edk2-devel] [Staging/Bug_1525_FmpDevicePkg_MultipleControllers][PATCH] MdeModulePkg/EsrtFmpDxe: Correct the LastAttemptVersion algorithm in ESRT entry

2019-04-15 Thread Eric Jin
Fix the 1nd issue mentioned in https://bugzilla.tianocore.org/show_bug.cgi?id=1525 Update the ESRT entry with the last attempt status and last attempt version from the first FMP instance whose last attempt status is not SUCCESS. If all FMP instances are SUCCESS, then set last attempt version to t

Re: [edk2-devel] [PATCH edk2-platforms 3/3] Platform/MacchiatoBin: conditionally include the X64 PE/COFF emulator

2019-04-15 Thread Marcin Wojtas
Hi Ard, wt., 16 kwi 2019 o 00:43 Ard Biesheuvel napisał(a): > > Add the X64 emulator to the build if '-D X64EMU_ENABLE=TRUE' is passed > on the build command line. Note that this only works on AARCH64 builds. > Also note that the edk2-non-osi repository needs to be listed in the > PACKAGES_PATH

[edk2-devel] [PATCH V3] BaseTools:Enable the /MP option of MSVC compiler

2019-04-15 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1672 The /MP option of MSVC compiler can reduce the total time to compile the source files on the command line. This patch is going to enable this MSVC option in BaseTools. Cc: Bob Feng Cc: Liming Gao Contributed-under: TianoCore Contribution Ag

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH 0/5] Add a new API ResetSystem for ResetSystemLib instances

2019-04-15 Thread Kubacki, Michael A
Reviewed-by: Michael Kubacki > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Gao, > Zhichao > Sent: Sunday, April 14, 2019 8:08 PM > To: devel@edk2.groups.io > Cc: Piwko; Piwko, Maciej ; Bu; Bu, Daocheng > ; Oram; Oram, Isaac W ; > Chiu, Chasel

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH 4/5] KabylakeSiliconPkg/PeiResetSystemLib: Add a new API ResetSystem

2019-04-15 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Gao, Zhichao > Sent: Monday, April 15, 2019 11:08 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Gao, Liming > Subject: [edk2-platforms/devel-MinPlatform][PATCH 4/5] > KabylakeSiliconPkg/PeiResetSystemLib:

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH 1/5] KabylakeSiliconPkg/BaseResetSystemLib: Add a new API ResetSystem

2019-04-15 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Gao, Zhichao > Sent: Monday, April 15, 2019 11:08 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > > Subject: [edk2-platforms/devel-MinPlatform][PATCH 1/5] > KabylakeSiliconPkg/BaseResetSystemLib: Add a new A

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH 2/5] KabylakeSiliconPkg/DxeResetSystemLib: Add a new API ResetSystem

2019-04-15 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Gao, Zhichao > Sent: Monday, April 15, 2019 11:08 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Gao, Liming > Subject: [edk2-platforms/devel-MinPlatform][PATCH 2/5] > KabylakeSiliconPkg/DxeResetSystemLib:

Re: [edk2-devel] [PATCH 0/2] MdeModulePkg: Make the screen seamless

2019-04-15 Thread Gao, Zhichao
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, April 15, 2019 11:56 PM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Ni, Ray ; Zeng, Star ; Gao, Liming > ; Sean Brogan ; > Michael Turner ; Bret Barkelew > > Subject: Re:

[edk2-devel] [RFC] Remove unused tool chain configuration in BaseTools/Conf/tools_def.template

2019-04-15 Thread Zhang, Shenglei
Hi All, There is no Intel compiler test. I suggest to remove ICC tool chain from tools_def.template. After this update, INTEL tool family is not used. So, MdePkg library can be updated to remove it. And also MS ASL is not verified now. I suggest to remove tool chain with ASL tool. They are: VS2

Re: [edk2-devel] [RFC] Propose update of security bug handling process

2019-04-15 Thread Vincent Zimmer
I agree w/ your comments Jian. Great input from Lazlo, too. I also want to let the community know that this specific process posting has 2 parts. This first was to post the process used by infosec bz team today, which Jian did well with https://github.com/jwang36/tianocore.github.io/wiki/Propo

Re: Commit Partitioning - Re: [edk2-devel] [edk2] [PATCH V2] UefiPayloadPkg: Enhance UEFI payload for coreboot and Slim Bootloader

2019-04-15 Thread Guo Dong
Thanks Jordan for the comments. This patch adds a new package instead of updating existing code. I thought it was difficult to separate this patch into multiple sub-patches while keeping each chunk to be able to compile and function. Will consider this in the future. Thanks, Guo > -Original

Re: Commit Partitioning - Re: [edk2-devel] [edk2] [PATCH V2] UefiPayloadPkg: Enhance UEFI payload for coreboot and Slim Bootloader

2019-04-15 Thread Ma, Maurice
Hi, Jordan That is a good point. Smaller patch will always help the review easier. Thank you for pointing it out. Thanks Maurice > -Original Message- > From: Justen, Jordan L > Sent: Monday, April 15, 2019 15:28 > To: Dong, Guo ; Ma, Maurice > ; devel@edk2.groups.io > Cc: Agyeman,

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH 1/5] KabylakeSiliconPkg/BaseResetSystemLib: Add a new API ResetSystem

2019-04-15 Thread Gao, Zhichao
For now, no driver consumes ResetSystem. But some drivers in edk repo, such as CapsuleRuntimeDxe would use it in the further. If the platform support this driver and do not use the ResetSystemLib instance in MdeModulePkg, a link error would be caused. Thanks, Zhichao > -Original Message---

[edk2-devel] [PATCH edk2-platforms 2/3] Platform/Overdrive: conditionally include the X64 PE/COFF emulator

2019-04-15 Thread Ard Biesheuvel
Add the X64 emulator to the build if '-D X64EMU_ENABLE=TRUE' is passed on the build command line. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 5 +++-- Platform/AMD/OverdriveBoard/OverdriveBoard.fdf | 3

[edk2-devel] [PATCH edk2-platforms 0/3] add X64 PE/COFF emulator to PCI systems

2019-04-15 Thread Ard Biesheuvel
Add a conditional build time include of the prebuild X64 PE/COFF emulator binary to some platforms that will be able to make use of it (i.e., have usable PCI slots) Ard Biesheuvel (3): Platform/DeveloperBox: conditionally include the X64 PE/COFF emulator Platform/Overdrive: conditionally inclu

[edk2-devel] [PATCH edk2-platforms 1/3] Platform/DeveloperBox: conditionally include the X64 PE/COFF emulator

2019-04-15 Thread Ard Biesheuvel
Add the X64 emulator to the build if '-D X64EMU_ENABLE=TRUE' is passed on the build command line. Note that this only works on AARCH64 builds. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 + Platfor

[edk2-devel] [PATCH edk2-platforms 3/3] Platform/MacchiatoBin: conditionally include the X64 PE/COFF emulator

2019-04-15 Thread Ard Biesheuvel
Add the X64 emulator to the build if '-D X64EMU_ENABLE=TRUE' is passed on the build command line. Note that this only works on AARCH64 builds. Also note that the edk2-non-osi repository needs to be listed in the PACKAGES_PATH environment variable. Contributed-under: TianoCore Contribution Agreemen

Re: [edk2-devel] [edk2-platforms: PATCH] Marvell/Armada7k8k: Set SPCR RegisterBitWidth back to 32

2019-04-15 Thread Ard Biesheuvel
On Mon, 15 Apr 2019 at 08:20, Marcin Wojtas wrote: > > Recent modification of the Armada7k8k SPCR to ARM_GAS8 broke the OpenBSD > booting with ACPI, as the initial console could mistakenly > interpret (with the reg-shift=0), that the registers are 8-bits apart. > > Fix that by restoring 32-bit reg

Commit Partitioning - Re: [edk2-devel] [edk2] [PATCH V2] UefiPayloadPkg: Enhance UEFI payload for coreboot and Slim Bootloader

2019-04-15 Thread Jordan Justen
On 2019-04-11 08:51:22, Guo Dong wrote: > CorebootModulePkg and CorebootPayloadPkg originally supports coreboot only. > In order to support other bootloaders, such as Slim Bootloader, they need > be updated to be more generic. > UEFI Payload (UefiPayloadPkg) a converged package from CorebootModuleP

[edk2-devel] [edk2] [RFC] Remove CorebootModulePkg and CorebootPayloadPkg

2019-04-15 Thread Guo Dong
Hi All, In order to support generic UEFI payload for more different bootloader solutions, CorebootModulePkg and CorebootPayloadPkg were replaced by UefiPayloadPkg, and it is now merged into EDK2 repo. Since UefiPayloadPkg in latest EDK2 supports both coreboot and Slim bootloader to build U

Re: [edk2-devel] [PATCH v6 1/7] MdeModulePkg: introduce PE/COFF image emulator protocol

2019-04-15 Thread Michael D Kinney
Leif, How about using the following pragma instead if include guards? #pragma once https://en.wikipedia.org/wiki/Pragma_once This appears to be supports by GCC 3.4 and higher, clang, and VS. Might even speed up builds a bit. Mike > -Original Message- > From: Kinney, M

[edk2-devel] ACPI 6.3 header update

2019-04-15 Thread Sami Mujawar
Hi Mike, Liming, With the ACPI 6.3 specification now published, we are looking into adding an ACPI 6.3 header file at 'edk2\MdePkg\Include\IndustryStandard\Acpi63.h' I thought I should check if you already have one in place, before we go and create one. Please let me know so that we can plan ac

[edk2-devel] [edk2-CCodingStandardsSpecification Patch] Change preferred license of EDK II to BSD+Patent

2019-04-15 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=1656 Change the EDK II C Coding Standards Specification to state that the preferred license of the EDK II is the BSD+Patent License and that file headers should use SPDX license identifiers. Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Contr

[edk2-devel] [WebSite Patch] Change preferred license of EDK II to BSD+Patent

2019-04-15 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=1656 Change the web page documentation to state that the preferred license of the EDK II is the BSD+Patent License. Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Signed-off-by: Michael D Kinney --- edk2/index.md | 3 +-- legalese.md | 3 +

Re: [edk2-devel] [PATCH v6 3/7] MdeModulePkg/PciBusDxe: dispatch option ROMs for foreign architectures

2019-04-15 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Ard Biesheuvel > Sent: Sunday, April 14, 2019 12:52 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Kinney, Michael D > ; Andrew Fish ; Leif > Lindholm ; Zeng, Star ; >

Re: [edk2-devel] [PATCH v6 4/7] MdeModulePkg/UefiBootManagerLib: allow foreign Driver#### images

2019-04-15 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Ard Biesheuvel > Sent: Sunday, April 14, 2019 12:53 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Kinney, Michael D > ; Andrew Fish ; Leif > Lindholm ; Zeng, Star ; >

Re: [edk2-devel] [PATCH] Marvell/Armada7k8k: Remove SPCR baud rate setting

2019-04-15 Thread Ard Biesheuvel
On Mon, 8 Apr 2019 at 17:33, Jeremy Linton wrote: > > The mcbin (and likely others) have a nonstandard uart clock. > This means that the earlycon programming will incorrectly set > the baud rate if it is specified. The way around this is to tell > the kernel to continue using the preprogrammed bau

Re: [edk2-devel] [PATCH v2 edk2-non-osi] Emulator: add binary AARCH64 build of X64 PE/COFF emulator

2019-04-15 Thread Ard Biesheuvel
On Mon, 15 Apr 2019 at 12:06, Leif Lindholm wrote: > > On Mon, Apr 15, 2019 at 11:22:59AM -0700, Ard Biesheuvel wrote: > > Add a binary RELEASE build targeting AARCH64 systems, created with > > Ubuntu's gcc 7.3.0 using the GCC5 profile. This permits such systems > > to dispatch and execute option

Re: [edk2-devel] [PATCH v2 edk2-non-osi] Emulator: add binary AARCH64 build of X64 PE/COFF emulator

2019-04-15 Thread Leif Lindholm
On Mon, Apr 15, 2019 at 11:22:59AM -0700, Ard Biesheuvel wrote: > Add a binary RELEASE build targeting AARCH64 systems, created with > Ubuntu's gcc 7.3.0 using the GCC5 profile. This permits such systems > to dispatch and execute option ROMs and other drivers built for the > X64 architecture. > >

Re: [edk2-devel] [edk2-platforms: PATCH 3/6] Marvell/Armada7k8k: Implement custom DtLoaderLib

2019-04-15 Thread Ard Biesheuvel
On Mon, 15 Apr 2019 at 02:52, Marcin Wojtas wrote: > > Hi Ard, > > > pt., 12 kwi 2019 o 23:15 Ard Biesheuvel > napisał(a): > > > > On Fri, 12 Apr 2019 at 03:20, Marcin Wojtas wrote: > > > > > > In order to provide special handling for DT environment, > > > implement custom version of DtLoaderLi

Re: [edk2-devel] [PATCH edk2-platforms] Silicon/AMD: drop unused/orphaned Styx ResetSystemLib

2019-04-15 Thread Ard Biesheuvel
On Mon, 15 Apr 2019 at 03:15, Leif Lindholm wrote: > > All Styx platforms in the tree (and the world) use > ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf > these days, but somehow this orphaned .inf was left around - drop it. > > Contributed-under: TianoCore Contribution Agr

[edk2-devel] [PATCH v2 edk2-non-osi] Emulator: add binary AARCH64 build of X64 PE/COFF emulator

2019-04-15 Thread Ard Biesheuvel
Add a binary RELEASE build targeting AARCH64 systems, created with Ubuntu's gcc 7.3.0 using the GCC5 profile. This permits such systems to dispatch and execute option ROMs and other drivers built for the X64 architecture. Repo: http://github.com/ardbiesheuvel/X86EmulatorPkg.git Commit: 5f4deb30e

Re: [edk2-devel] [PATCH] Edk2\NetworkPkg\UefiPxeBcDxe : Open a method to Enabled/Disabled IPV6/IPV6 PXE Support.

2019-04-15 Thread Laszlo Ersek
On 04/15/19 11:37, Xue, ShengfengX wrote: > Please refer this link for defail. > https://bugzilla.tianocore.org/show_bug.cgi?id=1695 > > Some Platform setup need provide a item for user to Enabled/Disabled > IPV4/IPV6 PXE boot, but Origin UefiPxeBcDxe driver doesn't have such > interface. > So

Re: [edk2-devel] [RFC PATCH edk2-non-osi] Emulator: add binary AARCH64 build of X86 PE/COFF emulator

2019-04-15 Thread Leif Lindholm
On Mon, Apr 15, 2019 at 10:57:53AM -0700, Ard Biesheuvel wrote: > On Mon, 15 Apr 2019 at 02:17, Leif Lindholm wrote: > > > > Some bikeshedding below: > > > > On Sun, Apr 14, 2019 at 07:41:56PM -0700, Ard Biesheuvel wrote: > > > Repo: http://github.com/ardbiesheuvel/X86EmulatorPkg.git > > > Commi

Re: [edk2-devel] [RFC PATCH edk2-non-osi] Emulator: add binary AARCH64 build of X86 PE/COFF emulator

2019-04-15 Thread Ard Biesheuvel
On Mon, 15 Apr 2019 at 02:17, Leif Lindholm wrote: > > Some bikeshedding below: > > On Sun, Apr 14, 2019 at 07:41:56PM -0700, Ard Biesheuvel wrote: > > Repo: http://github.com/ardbiesheuvel/X86EmulatorPkg.git > > Commit: 5f4deb30eb935f9004b93d97712cc3ac3ae1ca97 > > Does this permit execution of

Re: [edk2-devel] [PATCH 10/10] OvmfPkg/BasePciCapLib: suppress invalid "nullptr deref" warning

2019-04-15 Thread Philippe Mathieu-Daudé
On 4/13/19 1:31 AM, Laszlo Ersek wrote: > RH covscan reports the following "nullptr deref" warning: > >> Error: CLANG_WARNING: >> edk2-89910a39dcfd/OvmfPkg/Library/BasePciCapLib/BasePciCapLib.c:312:5: >> warning: Dereference of null pointer >> #InstanceZero->NumInstancesUnion.NumInstances++; >

Re: [edk2-devel] [PATCH 09/10] OvmfPkg/AcpiPlatformDxe: catch theoretical nullptr deref in Xen code

2019-04-15 Thread Philippe Mathieu-Daudé
On 4/13/19 1:31 AM, Laszlo Ersek wrote: > RH covscan justifiedly reports a path through InstallXenTables() where > DsdtTable can technically remain NULL. > > If this occurs in practice, then the guest and the VMM are out of sync on > the interface contract. Catch the situation with a code snippet

Re: [edk2-devel] [PATCH 07/10] OvmfPkg/AcpiPlatformDxe: suppress invalid "deref of undef pointer" warning

2019-04-15 Thread Philippe Mathieu-Daudé
On 4/13/19 1:31 AM, Laszlo Ersek wrote: > RH covscan emits the following false positive: > >> Error: CLANG_WARNING: >> edk2-89910a39dcfd/OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c:182:14: >> warning: Dereference of undefined pointer value >> #Status = FwVol->ReadSection ( >> # ^~~~

Re: [edk2-devel] [PATCH 05/10] OvmfPkg/Sec: fix out-of-bounds reads

2019-04-15 Thread Philippe Mathieu-Daudé
On 4/13/19 1:31 AM, Laszlo Ersek wrote: > RH covscan justifiedly reports that accessing "EFI_FFS_FILE_HEADER.Size" > and "EFI_COMMON_SECTION_HEADER.Size", which both are of type UINT8[3], > through (UINT32*), is undefined behavior: > >> Error: OVERRUN (CWE-119): >> edk2-89910a39dcfd/OvmfPkg/Sec/Se

Re: [edk2-devel] [PATCH 04/10] MdePkg/PiFirmwareFile: fix undefined behavior in FFS_FILE_SIZE

2019-04-15 Thread Philippe Mathieu-Daudé
On 4/13/19 1:31 AM, Laszlo Ersek wrote: > Accessing "EFI_FFS_FILE_HEADER.Size", which is of type UINT8[3], through a > (UINT32*), is undefined behavior. Fix it by accessing the array elements > individually. > > (We can't use a union here, unfortunately, as easily as with > "EFI_COMMON_SECTION_HEA

Re: [edk2-devel] [RFC] Propose update of security bug handling process

2019-04-15 Thread Laszlo Ersek
On 04/15/19 07:36, Wang, Jian J wrote: > Laszlo, > > >> -Original Message- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> Laszlo Ersek >> Sent: Friday, April 12, 2019 8:52 PM >> To: Wang, Jian J >> Cc: devel@edk2.groups.io; Zimmer, Vincent ; >> Cetola, Stepha

Re: [edk2-devel] [PATCH 01/10] MdePkg/PiFirmwareFile: express IS_SECTION2 in terms of SECTION_SIZE

2019-04-15 Thread Philippe Mathieu-Daudé
On 4/13/19 1:31 AM, Laszlo Ersek wrote: > The IS_SECTION2() function-like macro duplicates the SECTION_SIZE() > calculation, just to compare the computed size against 0xFF. Invoke > SECTION_SIZE() instead; only preserve the comparison. > > Cc: Liming Gao > Cc: Michael D Kinney > Bugzilla: ht

Re: [edk2-devel] [PATCH v2] IntelFsp2WrapperPkg: Perform post FSP-S process.

2019-04-15 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Chiu, Chasel Sent: Sunday, April 14, 2019 11:09 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Zeng, Star Subject: [PATCH v2] IntelFsp2WrapperPkg: Perform post FSP-S process. From: "Chasel, Chiu" REF: https:

Re: [edk2-devel] [PATCH 18/25] OvmfPkg/ResetSystemLib: Add new API ResetSystem

2019-04-15 Thread Laszlo Ersek
On 04/15/19 05:06, Zhichao Gao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 > > Add a new API ResetSystem to this ResetSystemLib instance. > It only adds the basic functions from ResetSystemRuntimeDxe. > Lacking of this interface may cause link error, if some drivers > use thi

Re: [edk2-devel] [PATCH 08/10] OvmfPkg: suppress "Value stored to ... is never read" analyzer warnings

2019-04-15 Thread Laszlo Ersek
On 04/14/19 10:03, Jordan Justen wrote: > On 2019-04-12 16:31:26, Laszlo Ersek wrote: >> RH covscan warns about assignments that it can determine are never >> "consumed" later ("dead stores"). The idea behind the warning is >> presumably that the programmer forgot to implement a dependent check >>

Re: [edk2-devel] [PATCH 00/10] patches for some warnings raised by "RH covscan"

2019-04-15 Thread Laszlo Ersek
On 04/13/19 01:36, Ard Biesheuvel wrote: > On Fri, 12 Apr 2019 at 16:31, Laszlo Ersek wrote: >> >> Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1710 >> Repo: https://github.com/lersek/edk2.git >> Branch: covscan_bz_1710 >> >> "covscan" is an internal service at Red Hat that lets

Re: [edk2-devel] [PATCH 02/10] MdePkg/PiFirmwareFile: fix undefined behavior in SECTION_SIZE

2019-04-15 Thread Laszlo Ersek
On 04/14/19 09:19, Jordan Justen wrote: > On 2019-04-12 16:31:20, Laszlo Ersek wrote: >> RH covscan justifiedly reports that accessing >> "EFI_COMMON_SECTION_HEADER.Size", which is of type UINT8[3], through a >> (UINT32*), is undefined behavior: >> >>> Error: OVERRUN (CWE-119): >>> edk2-89910a39dcf

Re: [edk2-devel] [staging/UEFI_CapsuleOnDisk][PATCH] Announce to create "UEFI_CapsuleOnDisk" branch in edk2-staging.

2019-04-15 Thread Michael D Kinney
Wei Xu, Thanks for providing this request for a new edk2-staging branch. Please add the branch maintainers to the Readme along with the criteria that must be met for the feature to be considered a candidate for edk2/master. With those updates, Reviewed-by: Michael D Kinney michael.d.kin...@int

Re: [edk2-devel] [PATCH 0/2] MdeModulePkg: Make the screen seamless

2019-04-15 Thread Laszlo Ersek
Hi Zhichao, On 04/13/19 09:52, Gao, Zhichao wrote: > > >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Friday, April 12, 2019 4:06 PM >> To: devel@edk2.groups.io; Gao, Zhichao >> Cc: Wang, Jian J ; Wu, Hao A ; >> Ni, Ray ; Zeng, Star ; Gao, Liming >> ; Sean

Re: [edk2-devel] [PATCH v6 1/7] MdeModulePkg: introduce PE/COFF image emulator protocol

2019-04-15 Thread Michael D Kinney
Hi Leif, This is not a macro that is to be used by C code. It is a technique to prevent recursive includes on a .h file. As a result, we do not want to use the C Coding Standard macro style. Are there other techniques to prevent recursive includes? I agree that macros/symbols that start with s

[edk2-devel] [edk2-platforms: PATCH] Marvell/Armada7k8k: Set SPCR RegisterBitWidth back to 32

2019-04-15 Thread Marcin Wojtas
Recent modification of the Armada7k8k SPCR to ARM_GAS8 broke the OpenBSD booting with ACPI, as the initial console could mistakenly interpret (with the reg-shift=0), that the registers are 8-bits apart. Fix that by restoring 32-bit register width, however leaving the AccessSize field EFI_ACPI_5_0_

Re: [edk2-devel] [edk2] [RFC] Plan to delete ShellBinPkg from edk2/master

2019-04-15 Thread Liming Gao
Ard: I see IA32/X64 Shell binary has been updated for 201903 stable tag. But, ARM/ARCH64 version shell binary is not updated. Could you upload new version binaries? Then, I can upload them into 2019 stable tag Assets. Thanks Liming From: Bi, Dandan Sent: Monday, April 8, 2019 4:08 PM To: af...

Re: [edk2-devel] [PATCH v6 1/7] MdeModulePkg: introduce PE/COFF image emulator protocol

2019-04-15 Thread Liming Gao
Leif: How about submit one BZ to catch it first? Then, revisit it later. Thanks Liming > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Leif > Lindholm > Sent: Monday, April 15, 2019 5:02 PM > To: Wu, Hao A > Cc: Ard Biesheuvel ; devel@edk2.

Re: [edk2-devel] [staging/UEFI_CapsuleOnDisk][PATCH] Announce to create "UEFI_CapsuleOnDisk" branch in edk2-staging.

2019-04-15 Thread Xu, Wei6
Due to the tight schedule, we plan to upstream code to staging earlier if there is no more comments. The due date will change to Apr 16th. You can continue to evaluate the feature and provide feedback when this feature stays in staging. BR, Wei Xu From: Xu, Wei6 Sent: Friday, April 12, 2019 5:05

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH 3/5] LewisburgPkg/DxeRuntimeResetSystemLib: Add a new API ResetSystem

2019-04-15 Thread Bu, Daocheng
Hi Maciej, Please help review this code from PCH perspective. If you approve this change , please also help cherry pick this change to ServerSiliconPkg\Pch\SouthClusterLbg pkg @10nm trunk. Thanks, Amos UEFI FW, IAFW or System Firmware is more generic & accurate it's not BIOS anymore! -

Re: [edk2-devel] [PATCH] Edk2\NetworkPkg\UefiPxeBcDxe : Open a method to Enabled/Disabled IPV6/IPV6 PXE Support.

2019-04-15 Thread Siyuan, Fu
Hi, Shengfeng I gave 4 review comments to your V1 patch, but you only fixed the patch description. Also, an updated patch should be prefixed with [PATCH v2] BestRegards Fu Siyuan > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Xue, > Shengf

Re: [edk2-devel] [edk2-platforms PATCH] Platform/ResetSystemLib: Add a new API ResetSystem

2019-04-15 Thread Leif Lindholm
+Thomas for info Zhichao - please update subject line to Platform/ARM: Add a new API ResetSystem to VExpress ResetSystemLib and drop the spaces before ;. With that: Reviewed-by: Leif Lindholm On Mon, Apr 15, 2019 at 11:07:35AM +0800, Zhichao Gao wrote: > REF: https://bugzilla.tianocore.org/sho

[edk2-devel] [PATCH edk2-platforms] Silicon/AMD: drop unused/orphaned Styx ResetSystemLib

2019-04-15 Thread Leif Lindholm
All Styx platforms in the tree (and the world) use ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf these days, but somehow this orphaned .inf was left around - drop it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leif Lindholm --- Silicon/AMD/Styx/

Re: [edk2-devel] [edk2-platforms: PATCH 3/6] Marvell/Armada7k8k: Implement custom DtLoaderLib

2019-04-15 Thread Marcin Wojtas
Hi Ard, pt., 12 kwi 2019 o 23:15 Ard Biesheuvel napisał(a): > > On Fri, 12 Apr 2019 at 03:20, Marcin Wojtas wrote: > > > > In order to provide special handling for DT environment, > > implement custom version of DtLoaderLib, which registers > > ExitBootServices event upon generic 'DtAcpiPref' v

Re: [edk2-devel] [PATCH 22/25] ArmPkg/ArmSmcPsciResetSystemLib: Add a new API ResetSystem

2019-04-15 Thread Leif Lindholm
Same as previous patch - if you drop the space before ;, Reviewed-by: Leif Lindholm On Mon, Apr 15, 2019 at 11:06:08AM +0800, Zhichao Gao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 > > Add a new API ResetSystem to this ResetSystemLib instance. > It only adds the basic func

Re: [edk2-devel] [PATCH 15/25] BeagleBoardPkg/ResetSystemLib: Add new API ResetSystem

2019-04-15 Thread Leif Lindholm
Hi Zhichao, Thanks for this. On Mon, Apr 15, 2019 at 11:06:01AM +0800, Gao, Zhichao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 > > Add a new API ResetSystem to this ResetSystemLib instance. > It only adds the basic functions from ResetSystemRuntimeDxe. > Lacking of this in

[edk2-devel] [PATCH] Edk2\NetworkPkg\UefiPxeBcDxe : Open a method to Enabled/Disabled IPV6/IPV6 PXE Support.

2019-04-15 Thread Xue, ShengfengX
Please refer this link for defail. https://bugzilla.tianocore.org/show_bug.cgi?id=1695 Some Platform setup need provide a item for user to Enabled/Disabled IPV4/IPV6 PXE boot, but Origin UefiPxeBcDxe driver doesn't have such interface. So attached code review added two PCD to control IPV4/IPV6

Re: [edk2-devel] [PATCH v2] IntelFsp2WrapperPkg: Perform post FSP-S process.

2019-04-15 Thread Zeng, Star
Small comments are added inline. With them handled, Reviewed-by: Star Zeng . You do not need to send an extra patch for them specifically if no other comment will be received from other. > -Original Message- > From: Chiu, Chasel > Sent: Monday, April 15, 2019 2:09 PM > To: devel@edk2.gro

Re: [edk2-devel] [RFC PATCH edk2-non-osi] Emulator: add binary AARCH64 build of X86 PE/COFF emulator

2019-04-15 Thread Leif Lindholm
Some bikeshedding below: On Sun, Apr 14, 2019 at 07:41:56PM -0700, Ard Biesheuvel wrote: > Repo: http://github.com/ardbiesheuvel/X86EmulatorPkg.git > Commit: 5f4deb30eb935f9004b93d97712cc3ac3ae1ca97 Does this permit execution of both IA32 and X64 code? If so, the name makes sense (but the READM

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH 1/5] KabylakeSiliconPkg/BaseResetSystemLib: Add a new API ResetSystem

2019-04-15 Thread Chiu, Chasel
Please see below comments inline. > -Original Message- > From: Gao, Zhichao > Sent: Monday, April 15, 2019 11:08 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > > Subject: [edk2-platforms/devel-MinPlatform][PATCH 1/5] > KabylakeSiliconPkg/BaseResetSystemLib: Add

Re: [edk2-devel] [PATCH v6 1/7] MdeModulePkg: introduce PE/COFF image emulator protocol

2019-04-15 Thread Leif Lindholm
On Mon, Apr 15, 2019 at 01:23:11AM +, Wu, Hao A wrote: > > + This program and the accompanying materials are licensed and made > > available > > + under the terms and conditions of the BSD License which accompanies this > > + distribution. The full text of the license may be found at > > +

[edk2-devel] [PATCH V2] BaseTools:update ConvertFceToStructurePcd.py with the char order PCD name.

2019-04-15 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1718 BaseTools\Scripts\ConvertFceToStructurePcd.py This script is for sorting the PCD order them base on PcdName, then base on Pcd field name. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhiju.Fan --- B

Re: [edk2-devel] [PATCH] Edk2\NetworkPkg\UefiPxeBcDxe : Open a method to Enabled/Disabled IPV6/IPV6 PXE Support.

2019-04-15 Thread Siyuan, Fu
Hi, Shengfeng > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Xue, > ShengfengX > Sent: Monday, April 15, 2019 4:14 PM > To: devel@edk2.groups.io > Cc: Xue; Xue, ShengfengX > Subject: [edk2-devel] [PATCH] Edk2\NetworkPkg\UefiPxeBcDxe : Open a m

Re: [edk2-devel] [PATCH] Edk2\NetworkPkg\UefiPxeBcDxe : Open a method to Enabled/Disabled IPV6/IPV6 PXE Support.

2019-04-15 Thread Xue, ShengfengX
Hi Siyuan, Please help to review this? Thanks -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Xue, ShengfengX Sent: Monday, April 15, 2019 4:14 PM To: devel@edk2.groups.io Cc: Xue; Xue, ShengfengX Subject: [edk2-devel] [PATCH] Edk2\NetworkPkg\Ue

[edk2-devel] [PATCH] Edk2\NetworkPkg\UefiPxeBcDxe : Open a method to Enabled/Disabled IPV6/IPV6 PXE Support.

2019-04-15 Thread Xue, ShengfengX
Please refer this link for defail. https://bugzilla.tianocore.org/show_bug.cgi?id=1695 Some Platform Developer want IPv4 and IPv6 PXE support separately. So it need open a method Enabled/Disabled IPV6/IPV6 PXE Support in PxeBcSupported(). Contributed-under: TianoCore Contribution Agreement 1.1

[edk2-devel] [PATCH v2] IntelFsp2WrapperPkg: Perform post FSP-S process.

2019-04-15 Thread Chiu, Chasel
From: "Chasel, Chiu" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1716 In API mode FSP wrapper will perform some post FSP-S process but such process was skipped in Dispatch mode which may impact some of the boot loaders. To align behavior between API and Dispatch, an End-of-Pei callback i

[edk2-devel] [edk2][PATCH] BaseTools:update ConvertFceToStructurePcd.py output sequence.

2019-04-15 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1718 BaseTools\Scripts\ConvertFceToStructurePcd.py This script is for sorting the PCD order them base on PcdName, then base on Pcd field name. Cc: Bob Feng Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhi