On Mon, Apr 15, 2019 at 10:57:53AM -0700, Ard Biesheuvel wrote: > On Mon, 15 Apr 2019 at 02:17, Leif Lindholm <leif.lindh...@linaro.org> wrote: > > > > Some bikeshedding below: > > > > On Sun, Apr 14, 2019 at 07:41:56PM -0700, Ard Biesheuvel wrote: > > > Repo: http://github.com/ardbiesheuvel/X86EmulatorPkg.git > > > Commit: 5f4deb30eb935f9004b93d97712cc3ac3ae1ca97 > > > > Does this permit execution of both IA32 and X64 code? If so, the name > > makes sense (but the README.md in the above repo suggests otherwise, > > and the readme here says nothing on the topic). > > > > I don't know whether the emulator itself supports IA32 execution, but > the driver definitely only registers itself for the X64 machine type. > > But since the naming of the upstream repo is not really under review > here, I will add a mention that only X64 is supported.
Thanks. (Yes, what I meant was that since the name is ambiguous, more detail may be required in the commit message.) > > > Repo: http://github.com/tiancore/edk2.git > > > Commit: 2e21e8c4b89656897797019a9c56bc5ccbf12df1 > > > > > > Note that the X86EmulatorPkg project's license is _L_GPL not GPL, > > > and so it could arguably be incorporated into edk2-non-osi in source > > > form. However, the emulator is a rather sizable chunk of code, and > > > providing a known working binary is preferred over having each > > > platform build it from scratch, so providing just the binary should > > > be sufficient for the time being. > > > > > > Cc: Andrew Fish <af...@apple.com> > > > Cc: Laszlo Ersek <ler...@redhat.com> > > > Cc: Leif Lindholm <leif.lindh...@linaro.org> > > > Cc: Michael D Kinney <michael.d.kin...@intel.com> > > > Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > > > --- > > > Note that this patch is against the edk2-non-osi repository, not EDK2 > > > itself. > > > > > > Binaries are omitted from this patch. The complete patch can be found > > > here: > > > https://git.linaro.org/leg/noupstream/edk2-non-osi.git/commit/?h=upstream > > > > > > Emulator/X86EmulatorDxe/LICENSE | 504 ++++++++++++++++++++ > > > Emulator/X86EmulatorDxe/README | 9 + > > > > Could this be Readme.md? > > > > Of course. What does the .md stand for actually? MarkDown (I.e. https://en.wikipedia.org/wiki/Markdown) Doesn't make a difference for this version, but could for future ones. Also means you get it auto-displayed on the github page. / Leif > > > Emulator/X86EmulatorDxe/X86EmulatorDxe.depex | Bin 0 -> 54 bytes > > > Emulator/X86EmulatorDxe/X86EmulatorDxe.efi | Bin 0 -> 913408 bytes > > > Emulator/X86EmulatorDxe/X86EmulatorDxe.inf | 21 + > > > 5 files changed, 534 insertions(+) > > > > / > > Leif -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39112): https://edk2.groups.io/g/devel/message/39112 Mute This Topic: https://groups.io/mt/31137158/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
