Hi Zhichao, Thanks for this.
On Mon, Apr 15, 2019 at 11:06:01AM +0800, Gao, Zhichao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460 > > Add a new API ResetSystem to this ResetSystemLib instance. > It only adds the basic functions from ResetSystemRuntimeDxe. > Lacking of this interface may cause link error, if some drivers > use this new API and link to this library instance. > Notes: > This library API only provide a basic function of reset. Full > function should use the instance in the MdeModulePkg and make > sure the depex driver is dispatched. > > Cc: Leif Lindholm <leif.lindh...@linaro.org> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Cc: Liming Gao <liming....@intel.com> > Signed-off-by: Zhichao Gao <zhichao....@intel.com> > --- > .../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++ > 1 file changed, 43 insertions(+) > > diff --git a/BeagleBoardPkg/Library/ResetSystemLib/ResetSystemLib.c > b/BeagleBoardPkg/Library/ResetSystemLib/ResetSystemLib.c > index 9fc572957f..e2a9d2469c 100644 > --- a/BeagleBoardPkg/Library/ResetSystemLib/ResetSystemLib.c > +++ b/BeagleBoardPkg/Library/ResetSystemLib/ResetSystemLib.c > @@ -103,3 +103,46 @@ ResetPlatformSpecific ( > { > ResetCold (); > } > + > +/** > + The ResetSystem function resets the entire platform. > + > + @param[in] ResetType The type of reset to perform. > + @param[in] ResetStatus The status code for the reset. > + @param[in] DataSize The size, in bytes, of ResetData. > + @param[in] ResetData For a ResetType of EfiResetCold, EfiResetWarm, > or EfiResetShutdown > + the data buffer starts with a Null-terminated > string, optionally > + followed by additional binary data. The string > is a description > + that the caller may use to further indicate the > reason for the > + system reset. > +**/ > +VOID > +EFIAPI > +ResetSystem ( > + IN EFI_RESET_TYPE ResetType, > + IN EFI_STATUS ResetStatus, > + IN UINTN DataSize, > + IN VOID *ResetData OPTIONAL > + ) > +{ > + switch (ResetType) { > + case EfiResetWarm: > + ResetWarm (); > + break; > + > + case EfiResetCold: > + ResetCold (); > + break; > + > + case EfiResetShutdown: > + ResetShutdown (); > + return ; Please drop the spurious space before ; > + > + case EfiResetPlatformSpecific: > + ResetPlatformSpecific (DataSize, ResetData); > + return; > + > + default: > + return ; Please drop the spurious space before ; (Unfortunately, this snippet has been copied around many places in many of the patches in this series - they should all be updated.) With that done: Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> > + } > +} > -- > 2.21.0.windows.1 > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39069): https://edk2.groups.io/g/devel/message/39069 Mute This Topic: https://groups.io/mt/31137351/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
