Reviewed-by: Ray Ni <ray...@intel.com> > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Ard Biesheuvel > Sent: Sunday, April 14, 2019 12:52 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>; Kinney, Michael D > <michael.d.kin...@intel.com>; Andrew Fish <af...@apple.com>; Leif > Lindholm <leif.lindh...@linaro.org>; Zeng, Star <star.z...@intel.com>; > Dong, Eric <eric.d...@intel.com>; Ni, Ray <ray...@intel.com>; Gao, Liming > <liming....@intel.com>; Carsey, Jaben <jaben.car...@intel.com>; Shi, > Steven <steven....@intel.com>; Wang, Jian J <jian.j.w...@intel.com>; Wu, > Hao A <hao.a...@intel.com> > Subject: [edk2-devel] [PATCH v6 3/7] MdeModulePkg/PciBusDxe: dispatch > option ROMs for foreign architectures > > Delete the explicit machine type check for option ROM images, and instead, > rely on the LoadImage() boot service to decide whether an option ROM can > be dispatched or not. This permits platforms to ship with emulators to > execute option ROMs that are not native to the processor architecture. > > Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > Reviewed-by: Michael D Kinney <michael.d.kin...@intel.com> > --- > MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c > index c75ef1a82505..54cf4251cc86 100644 > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c > @@ -699,13 +699,6 @@ ProcessOpRomImage ( > goto NextImage; > } > > - // > - // Skip the EFI PCI Option ROM image if its machine type is not > supported > - // > - if (!EFI_IMAGE_MACHINE_TYPE_SUPPORTED (EfiRomHeader- > >EfiMachineType)) { > - goto NextImage; > - } > - > // > // Ignore the EFI PCI Option ROM image if it is an EFI application > // > -- > 2.17.1 > > >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39121): https://edk2.groups.io/g/devel/message/39121 Mute This Topic: https://groups.io/mt/31133142/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
