New macro: NS_INLINE_DECL_PURE_VIRTUAL_REFCOUNTING

2017-01-26 Thread Kartikaya Gupta
Just a heads-up that I pushed bug 1312319 which adds a new NS_INLINE_DECL_PURE_VIRTUAL_REFCOUNTING macro to nsISupportsImpl.h. This macro just defines pure-virtual AddRef/Release functions. It's intended for use if you're creating a non-nsISupports interface where you want the implementing classes

Fwd: Merging Quantum Render into mozilla-central

2017-01-30 Thread Kartikaya Gupta
(Explicitly forwarding to dev-tech-gfx and dev-platform, since apparently bcc'ing lists gets messages stuck in moderation. Please reply on dev-tree-management. Sorry for my mail-fail!) -- Forwarded message -- From: Kartikaya Gupta Date: Mon, Jan 30, 2017 at 2:22 PM Su

Quantum Render builds now on m-c

2017-02-10 Thread Kartikaya Gupta
(cross-posted to dev-platform and dev-tech-gfx) This is just a heads up that earlier today we merged the graphics branch to m-c, so Quantum Render builds can now be done on central if you put --enable-webrender in your mozconfig. We will be running a limited set of builds (linux64 only) and tests

Re: Should cheddar-generated headers be checked in?

2017-02-27 Thread Kartikaya Gupta
On Mon, Feb 27, 2017 at 1:57 PM, Henri Sivonen wrote: > Now that the build.rs in commented out in the crates.io crate and the > generated header is shipped in the crates.io crate: > Considering that editing the vendored crates is not allowed, so I > can't put moz.build files on the path to the hea

Re: Heads up: archive.m.o is no longer updating tinderbox builds, AWSY is effectively dead

2017-03-06 Thread Kartikaya Gupta
It looks like it's just the Linux builds that are no longer there. I'm guessing this has to do with them being on TaskCluster rather than BuildBot. On Mon, Mar 6, 2017 at 4:23 PM, Boris Zbarsky wrote: > On 3/6/17 4:17 PM, Eric Rahm wrote: >> >> I'm unaware of a bug for this decision, but https://

Re: All the processes

2017-03-06 Thread Kartikaya Gupta
On Mon, Mar 6, 2017 at 7:08 PM, Eric Rahm wrote: > I assume WebRenderer will have it's own process, but maybe that just gets > lumped in with the GPU process. WebRender will live in the GPU process, if there is one. The UI process otherwise. Cheers, kats _

Re: Project Stockwell (reducing intermittents) - March 2017 update

2017-03-08 Thread Kartikaya Gupta
I've been reading this thread with much sadness, but refraining from commenting because I have nothing good to say. But I feel like I should probably comment regardless. What makes me sad is all the developers in this thread trying to push back against disabling of clearly problematic tests, asking

Re: Project Stockwell (reducing intermittents) - March 2017 update

2017-03-08 Thread Kartikaya Gupta
On Wed, Mar 8, 2017 at 4:01 PM, wrote: > In the past I have not always been made aware when my tests were disabled, > which has lead to me feeling jaded. We have a process (in theory) that ensures the relevant people get notified of tests. The process involves these steps: 1) There is a moz.bui

Re: Project Stockwell (reducing intermittents) - March 2017 update

2017-03-09 Thread Kartikaya Gupta
On Wed, Mar 8, 2017 at 6:02 PM, L. David Baron wrote: > As of 5 days ago, "Treeherder Bug Filer" was not using BUG_COMPONENT > information. I say this based on: > https://bugzilla.mozilla.org/show_bug.cgi?id=1344304 > being filed in Core :: Layout despite: > > $ ./mach file-info bugzilla-compon

Intent to build (but not enable) WebRender by default on some Nightly platforms

2017-03-13 Thread Kartikaya Gupta
(Cross-posted to dev-platform and dev-tech-gfx, please reply to dev-platform) In the near future I'm planning to make a change so that WebRender will be built (but not enabled) by default in most Nightly/local builds [1]. This will allow anybody running a stock nightly to turn on The QuantumRender

Re: Project Stockwell (reducing intermittents) - March 2017 update

2017-03-23 Thread Kartikaya Gupta
On Thu, Mar 9, 2017 at 10:31 AM, Kartikaya Gupta wrote: > On Wed, Mar 8, 2017 at 6:02 PM, L. David Baron wrote: >> As of 5 days ago, "Treeherder Bug Filer" was not using BUG_COMPONENT >> information. I say this based on: >> https://bugzilla.mozilla.org/show_bug.c

Re: Intent to build (but not enable) WebRender by default on some Nightly platforms

2017-03-23 Thread Kartikaya Gupta
, but please file a bug as well and mark it blocking bug 1342450. Thanks! On Mon, Mar 13, 2017 at 6:08 PM, Kartikaya Gupta wrote: > (Cross-posted to dev-platform and dev-tech-gfx, please reply to dev-platform) > > In the near future I'm planning to make a change so that WebRender &

PSA: git mirrors are not updating

2017-03-28 Thread Kartikaya Gupta
Just a heads-up that the git mirrors of m-c (e.g. github.com/mozilla/gecko-dev and github.com/mozilla/gecko-projects) are not updating, and are stuck on a changeset from sometime on March 24. Bug 1350696 is open for the investigation. Cheers, kats ___ de

Re: Editing vendored crates take #2

2017-04-28 Thread Kartikaya Gupta
At one point the steps at https://wiki.mozilla.org/Platform/GFX/Quantum_Render#Testing_third-party_rust_library_changes were known to work. I don't know if they have since been broken. On Fri, Apr 28, 2017 at 3:07 PM, Boris Zbarsky wrote: > On 4/28/17 1:05 PM, Josh Matthews wrote: >> >> Has anybo

Re: Updating a particular vendored crate by minor version

2017-05-02 Thread Kartikaya Gupta
You can update a specific crate to a specific version like so: cd toolkit/library/rust cargo update -p encoding_rs --precise cd ../gtest/rust cargo update -p encoding_rs --precise cd ../../../../ mach vendor rust On Tue, May 2, 2017 at 4:38 AM, Henri Sivonen wrote: > I have toolkit/library/ru

Making QuantumRender tier-1

2017-05-10 Thread Kartikaya Gupta
(cross-posted to dev-tech-gfx and dev-tree-management, please direct replies to dev-platform) I just landed a change on inbound (bug 1363344) that enables various test jobs (reftests, jsreftests, crashtests, webgl mochitests, gpu mochitests) on the Linux64 QuantumRender (aka "linux64-qr") platform

Reftest "fuzzy" and "fuzzy-if" annotations now take ranges

2017-06-02 Thread Kartikaya Gupta
This morning I pushed bug 1252361 to inbound, which modifies the "fuzzy" and "fuzzy-if" reftest annotations to accept ranges in addition to single values for the fuzziness parameters. If a single value "x" is provided, it by default maps to the range "0..x", so it preserves the existing semantics i

Re: Proposal for informing Developers and Sheriffs about new Testsuites

2017-06-14 Thread Kartikaya Gupta
This sounds good to me. What mailing lists should the intent email be sent to? It might help to have a template somewhere as well. On Wed, Jun 14, 2017 at 4:58 AM, Carsten Book wrote: > Hi, > > we had the case that a new testsuite was enabled and one test of that suite > resulted in a new perma o

Re: How are events passed between chrome and content?

2017-06-15 Thread Kartikaya Gupta
On Thu, Jun 15, 2017 at 4:16 PM, Jim Porter wrote: > From what I can tell, if I click inside a webpage, the event starts out > in chrome and then propagates down into content. I assume there's some > sort of magic happening in the message manager that pushes the event > across process boundaries.

Re: Bulk Closing Intermittents

2017-07-10 Thread Kartikaya Gupta
It might be a good idea to integrate this process with the OrangeFactor Robot, to avoid race conditions like what happened on bug 1328486 (it was bulk-closed, and then a couple of hours later the OF robot reported that there were two failures this week - but the bug remained closed). Cheers, kats

Re: git mirror

2017-07-22 Thread Kartikaya Gupta
https://github.com/mozilla/gecko-dev is generally pretty up-to-date. It should have a branch for ESR as well. Cheers, kats On Jul 22, 2017 15:43, "Enrico Weigelt, metux IT consult" < enrico.weig...@gr13.net> wrote: Hi folks, are there any official git mirrors (at least for the esr branches), t

Re: Correct format specifier for size_t

2017-07-25 Thread Kartikaya Gupta
I filed bug 1384233 for removing the header and unnecessary defines. On Tue, Jul 25, 2017 at 2:13 PM, Honza Bambas wrote: > Thanks! OTOH, I think we no longer need it. Since VS2015 (our minimal > toolchain version on Win) supports %z modifier. Only VS2013 and down only > defines %I. > -hb- > >

PSA: pushing to try is broken right now

2017-08-04 Thread Kartikaya Gupta
Pushes to try appear to succeed, but the pushlog is somehow busted and so TreeHerder won't pick them up and the csets on hg.m.o will show "unknown" for push info. This is being tracked in https://bugzil.la/1387407. I've closed the try tree for now since it's not clear if these pushes will just get

Re: PSA: pushing to try is broken right now

2017-08-04 Thread Kartikaya Gupta
gps did some magic and things seem to be working again. Pushes that occurred previously are now showing up on try, so I've reopened the tree. On Fri, Aug 4, 2017 at 11:02 AM, Kartikaya Gupta wrote: > Pushes to try appear to succeed, but the pushlog is somehow busted and > so TreeH

Heads-up: WebRender now requires HWA enabled

2017-08-09 Thread Kartikaya Gupta
TLDR: Once bug 1387764 merges to mozilla-central, anybody running with WebRender enabled on Linux will need to force-enable hardware acceleration (layers.acceleration.force-enabled=true) to keep WebRender enabled. Long version: Previously the check for enabling WebRender ignored the status of hard

Re: Debugging Firefox e10s with rr?

2017-08-29 Thread Kartikaya Gupta
rr works just fine with multiple processes. Once you have a recording you can use `rr ps` to show all the process that were recorded and `rr replay -p ` to attach to a particular process. You can combine -p with -g as Cameron mentioned to jump to a particular point in a particular process' lifetime

Re: New minimum Rust version policy for Firefox

2017-08-31 Thread Kartikaya Gupta
Do we have a policy on CI coverage for vendored rust libraries? I'm concerned for example that we depend on a number of third-party rust libraries that don't do CI builds against rust stable and so it's possible they might break. I discovered that webrender CI for example is currently only building

Re: New minimum Rust version policy for Firefox

2017-09-01 Thread Kartikaya Gupta
There was a bit of discussion on the PR I submitted yesterday: https://github.com/servo/webrender/pull/1644#discussion_r136424367 - we decided to just manually bump it once in a while instead of making it track `stable`. On Thu, Aug 31, 2017 at 5:54 PM, Mike Hommey wrote: > On Thu, Aug 31, 2017 a

Canonical cinnabar repository

2017-09-18 Thread Kartikaya Gupta
This message was inspired by the `mach try` thread but is off-topic there so I think deserves its own thread. It seems to me that a lot of people are now assuming a cinnabar repo is the canonical way for git users to develop on mozilla-central. If we want to make this mozilla policy I don't really

Re: Canonical cinnabar repository

2017-09-18 Thread Kartikaya Gupta
On Mon, Sep 18, 2017 at 11:04 AM, Myk Melez wrote: > Having said that, I agree that it's worth enabling developers to clone a > canonical Git repo. I've been syncing mozilla/gecko using cinnabar for a > while to experiment with ways of doing this. That's great, thanks. If we can do something like

Re: Canonical cinnabar repository

2017-09-26 Thread Kartikaya Gupta
So from the discussion here it sounds like using a full (i.e. non-grafted) cinnabar repository "just works" for most people. It has the problem of missing CVS history but it seems like people who need that often can use searchfox and/or a gecko-dev branch in a cinnabar repo to get it. And we have

Re: Pulsebot in #developers

2017-11-04 Thread Kartikaya Gupta
+1. I also find myself less likely to read the backscroll because of the high volume of pulsebot messages. Thanks for bringing this up! On Nov 4, 2017 07:45, "Philipp Kewisch" wrote: > Hey Folks, > > I'm a big fan of having development discussions in the open, and in the > past #developers has

Re: Intent to Enable: Automated Static Analysis feedback in MozReview

2017-11-07 Thread Kartikaya Gupta
It's being investigated: https://github.com/mozilla-releng/services/issues/707 On Nov 7, 2017 19:05, "Boris Zbarsky" wrote: On 10/4/17 10:32 AM, Jan Keromnes wrote: > We've already disabled this "no defects" comment, and are currently > deploying the fix to production, so the bot should stop se

Re: Next year in web-platform-tests

2017-12-15 Thread Kartikaya Gupta
On Fri, Dec 15, 2017 at 4:59 PM, Andreas Tolfsen wrote: > I would be interested to hear more about what primitives for user > input emulation are required. Touch input emulation would also be good. There are some CSS properties like touch-action which require emulating user touch input for proper

PSA: searchfox now indexes rust

2018-01-08 Thread Kartikaya Gupta
Just a heads-up, thanks to a bunch of work by Emilio, searchfox.org now indexes rust code as well, so you can do things like jump to function definitions and call sites and whatnot. Please use it and file bugs under Webtools :: Searchfox for defects or feature requests. I'm not sure how quickly we'

Inheriting annotations into included reftest.list files

2018-01-10 Thread Kartikaya Gupta
This will probably come as a surprise to many (as it does to me each time I rediscover it), but if, in a reftest.list file, you do something like this (real example from [1]): skip-if(browserIsRemote) include ogg-video/reftest.list this may not do what you expect. My expectation, at least, is tha

Re: Inheriting annotations into included reftest.list files

2018-01-10 Thread Kartikaya Gupta
Another option would be to keep allowing this syntax of "skip-if(x) include some/reftest.list" but actually make it skip the entire include if the condition "x" is true. On Wed, Jan 10, 2018 at 10:49 AM, Kartikaya Gupta wrote: > This will probably come as a surprise to

Re: Inheriting annotations into included reftest.list files

2018-01-10 Thread Kartikaya Gupta
On Wed, Jan 10, 2018 at 3:40 PM, Daniel Holbert wrote: > I'd lean slightly towards allowing the syntax and making it actually skip > the include expression. This construct seems valuable to have in our > toolbox (to be used only sparingly, e.g. for cases of platform-specific > features). Yeah I'

Re: Inheriting annotations into included reftest.list files

2018-01-12 Thread Kartikaya Gupta
8-01-10 10:49 -0500, Kartikaya Gupta wrote: >> This will probably come as a surprise to many (as it does to me each >> time I rediscover it), but if, in a reftest.list file, you do >> something like this (real example from [1]): >> >> skip-if(browserIsRemote) include ogg-vi

Re: PSA: searchfox now indexes rust

2018-01-12 Thread Kartikaya Gupta
On Fri, Jan 12, 2018 at 2:03 PM, Nicholas Alexander wrote: > Does SF index non-trunk trees? I can't find a way to search > mozilla-{release,beta} right now. Please correct me if it does? It does not. ___ dev-platform mailing list dev-platform@lists.mo

PSA: Core::Build Config has moved

2018-03-13 Thread Kartikaya Gupta
I was looking to file a bug in Core::Build Config and discovered it doesn't exist any more. :mccr8 told me there is now a "Firefox Build System" product that encompasses what used to be Core::Build Config. I'm not a build peer so I don't know anything more than this; if anybody wants more context

Re: Intent to ship: Pointer Events (Desktop)

2018-03-15 Thread Kartikaya Gupta
Looks like it was enabled in https://bugzilla.mozilla.org/show_bug.cgi?id=1411467 On Thu, Mar 15, 2018 at 1:23 PM, wrote: > Is there a specific bug for enabling this, aside from the meta implement bug? > ___ > dev-platform mailing list > dev-platform@l

Re: redundant(?) code churn and code style issues in bug 525063

2018-04-13 Thread Kartikaya Gupta
On Fri, Apr 13, 2018 at 6:18 AM, Jonathan Kew wrote: > It's presumably auto-generated by a static-analysis tool or something like > that, but ISTM it has been overly aggressive, adding a lot more code churn > than necessary (as well as committing some pretty extreme style violations > such as over

Re: Coding style: brace initialization syntax

2018-04-13 Thread Kartikaya Gupta
On Fri, Apr 13, 2018 at 11:06 AM, Emilio Cobos Álvarez wrote: > I'd be ok with that I guess, though it's more common each time? Also, is > there any case where you could use braces but not parenthesis? (I'm not a > C++ expert in this regard). I think there are. In particular if you're initializin

Re: New policy: 48-hour backouts for major Talos regressions

2015-08-14 Thread Kartikaya Gupta
In general I'm in favour of this proposal, although it will probably come back to haunt me in the not-too-distant future. That being said I would like to know what criteria you used to distinguish "reliable" talos tests from the rest. kats On Fri, Aug 14, 2015 at 5:26 PM, Vladan Djeric wrote: >

Re: Proposal: Turning off Eideticker perf testing

2015-08-17 Thread Kartikaya Gupta
FWIW one of the original driver behind Eideticker (tuning Fennec for checkerboarding during scrolling) will become relevant again in the next couple of months as we transition Fennec to using the C++ APZ code and off the old Java pan/zoom code. While it would be nice to have Eideticker around to gi

Re: Decreasing quality?

2015-08-20 Thread Kartikaya Gupta
There are some bugs about this (1189565 and 1193933 are the ones I'm aware of), but please do file bugs if you haven't already and if your symptoms don't match the existing bugs. kats On Thu, Aug 20, 2015 at 2:52 PM, Dirkjan Ochtman wrote: > On Thu, Aug 20, 2015 at 8:45 PM, Mike Hoye wrote: >>

Re: Is APZ meant to be a permanent part of the platform?

2015-10-05 Thread Kartikaya Gupta
I think that as it stands, yes, APZ is going to be a "permanent" part of the platform. You're right that having higher-latency scroll events creates some problems and makes it harder to drive animations off it. We do have plans to provide more APIs for controlling things in the compositor which sho

Re: Date, time, week, month and datetime attributes in the in Firefox

2015-11-01 Thread Kartikaya Gupta
IMO given the number of people who have complained about the lack of this feature on bug 825294, we should assume it is desirable to have even if unstylable. If somebody claims otherwise the burden of proof should be on them to show data that falsifies the assumption. kats On Sun, Nov 1, 2015 at 3

Re: Dan Stillman's concerns about Extension Signing

2015-11-26 Thread Kartikaya Gupta
On Thu, Nov 26, 2015 at 8:50 AM, Thomas Zimmermann wrote: > For anything non-AMO, the user is on > their own. > I don't know if that would fly. As I understand it, a large part of the purpose of extension signing is to protect users from malicious add-ons that get installed by non-AMO means - sid

Re: Dan Stillman's concerns about Extension Signing

2015-11-28 Thread Kartikaya Gupta
So it seems to me that people are actually in general agreement about what the validator can and cannot do, but have different evaluations of the cost-benefit tradeoff. On the one hand we have the camp (let's say camp A) that believes the validator provides negligible actual benefit, because it is

APZ enabled on Fennec nightly

2015-11-30 Thread Kartikaya Gupta
Hi all, Just a heads up that I landed the patch to enable APZ on Fennec (nightly channel only for now). It should be in the Dec 1 nightly and onwards. This will make scrolling around, and general touch input handling, feel different on Fennec. The main improvement should be that scrolling of ifram

Re: Better mach support for Firefox for Android

2015-11-30 Thread Kartikaya Gupta
Thanks for all your work in making this happen! I've used some of these commands recently and they work much better than they used to for Fennec :) On Mon, Nov 30, 2015 at 12:32 PM, Geoffrey Brown wrote: > In recent months, many improvements have been made to mach commands to > support running, t

Re: APZ enabled on Fennec nightly

2015-12-01 Thread Kartikaya Gupta
oth scrolling and scroll snapping for > fennec. > > Cheers, > - Kearwood “Kip” Gilbert > >> On Nov 30, 2015, at 8:37 AM, Kartikaya Gupta wrote: >> >> Hi all, >> >> Just a heads up that I landed the patch to enable APZ on Fennec >> (nightly channel

Re: APZ enabled on Fennec nightly

2015-12-02 Thread Kartikaya Gupta
Thanks for trying it out and reporting these issues! I've filed them as separate bugs - bug 1229840, bug 1229839, and bug 1229841. We should be able to address 2 and 3 by tuning some prefs, 1 will take a bit more investigation. Cheers, kats On Wed, Dec 2, 2015 at 11:31 AM, wrote: > Thanks for h

Re: SPS Profiles are now captured for entire subprocess lifetime

2015-12-03 Thread Kartikaya Gupta
\o/ Does this get us all the way to "profile talos runs with e10s enabled", or are there still pieces missing for that? IIRC this set of patches was a prerequisite for being able to do that. On Thu, Dec 3, 2015 at 4:52 PM, Mike Conley wrote: > Just a heads up that there have been recent developm

Re: [webkit] More Responsive Tapping on iOS

2015-12-17 Thread Kartikaya Gupta
FWIW we support the fast-click on unzoomable pages and pages with width<=device-width in the meta-viewport tag. We don't support touch-action fully yet. Cheers, kats On Dec 16, 2015 9:55 PM, "Karl Dubost" wrote: > Just a heads up about WebKit changing behavior on a couple of things. > > Bugs her

Re: about:profiles and the new profile manager

2015-12-18 Thread Kartikaya Gupta
Note that there are add-ons such as "Profile Switcher" which allow you to display the profile manager dialog without touching the command-line. I don't know if that qualifies as "user facing" or not. It's certainly an advanced user feature that most people will never see. kats On Fri, Dec 18, 201

Too many oranges!

2015-12-21 Thread Kartikaya Gupta
Is it just me, or has the number of intermittent oranges gone up quite a lot in the last couple of months? It seems like every try push I do has a lot of oranges which are completely unrelated to may patch. Clearly everbody has more urgent things to do than fix intermittent failures (myself include

Re: Too many oranges!

2015-12-22 Thread Kartikaya Gupta
On Mon, Dec 21, 2015 at 3:11 PM, L. David Baron wrote: > I agree it's definitely gone up recently, and agree that it causes a > lot of wasted time. I'm not convinced about closing the tree, > though; keeping the tree closed for extended periods just leads to > big backups. > > How about everybody

Re: Too many oranges!

2015-12-22 Thread Kartikaya Gupta
rcuts, >> refactoring, etc. >> >> On 21 December 2015 at 17:35, wrote: >> >> > On Monday, December 21, 2015 at 1:16:13 PM UTC-6, Kartikaya Gupta wrote: >> > > So, I propose that we create an orangefactor threshold above which the >> > > tre

Re: Too many oranges!

2015-12-22 Thread Kartikaya Gupta
On Tue, Dec 22, 2015 at 11:16 AM, Douglas Turner wrote: > Mike -- totally supportive of this. I would *love* to see a release cycle > completely dedicated to quality. We branch again on January 26. We could > use that cycle to focus on nothing but quality (fixing tests, bug triaging, > no featur

Re: Adding jobs to pushes having some issues

2015-12-23 Thread Kartikaya Gupta
For the record it seems like even if adding new jobs via TH fails, the old try-extender tool at http://try-extender.herokuapp.com/ still works (at least for try pushes). On Tue, Dec 22, 2015 at 2:56 PM, Armen Zambrano G. wrote: > Hello team, > Thanks for using the ability of adding jobs to your p

Re: Thanks for all the great teamwork with the Sheriffs in 2015!

2015-12-30 Thread Kartikaya Gupta
Yes, thank you to all the sheriffs for all their hard work! On Wed, Dec 30, 2015 at 9:19 AM, Carsten Book wrote: > Hi, > > Sheriffing is not just about Checkins, Uplifts and Backouts - its also a > lot of teamwork with different Groups and our Community like Developers, IT > Teams and Release Eng

APZ on desktop: riding the trains on Gecko 46

2015-12-30 Thread Kartikaya Gupta
Just a heads up that APZ for desktop, which has been enabled in Nightly for a few releases now, will be riding the trains on Gecko 46. There are still a few open blockers hanging off bug 1178298 but we expect to have them fixed shortly. APZ being enabled is still conditional at runtime on e10s bei

Re: Adding new jobs to pushes in better shape

2016-01-21 Thread Kartikaya Gupta
Thanks! I just used this on inbound and it seems to be working well. :) On Thu, Jan 21, 2016 at 9:26 AM, Armen Zambrano G. wrote: > I've spent the last two days fixing most issues affecting adding jobs on > Treeherder. > I believe it is now working properly. > You don't need to try multiple times

Re: Does SSE2 usage still need to be conditional?

2016-01-29 Thread Kartikaya Gupta
I also want to highlight the thing at the end of the gist linked above - the majority of the non-SSE2 population are on 43.0.4. That is, they're keeping up-to-date, and would likely be affected by this more than somebody stranded on an old version. On Fri, Jan 29, 2016 at 3:29 PM, Chris H-C wrote

Touch events enabled on Windows desktop (nightly only)

2016-02-01 Thread Kartikaya Gupta
In bug 1180706 I turned on the dom.w3c_touch_events.enabled pref for Windows desktop builds. This should be in Jan 31 nightly. For devices that have touchscreens, this has two effects: 1) Touch scrolling now uses APZ. The physics will probably need some tuning, but if you see correctness issues wi

Re: Touch events enabled on Windows desktop (nightly only)

2016-02-01 Thread Kartikaya Gupta
bugs in this configuration, again, please file. If you want to force-enable e10s (and therefore APZ), you can set the browser.tabs.remote.force-enable pref to true. On Mon, Feb 1, 2016 at 12:46 PM, Kartikaya Gupta wrote: > In bug 1180706 I turned on the dom.w3c_touch_events.enabled pref

Re: Touch events enabled on Windows desktop (nightly only)

2016-02-03 Thread Kartikaya Gupta
them fixed because we can't not support touch forever. On Wed, Feb 3, 2016 at 10:01 AM, Jim Mathies wrote: > On Monday, February 1, 2016 at 11:50:44 AM UTC-6, Kartikaya Gupta wrote: >> In bug 1180706 I turned on the dom.w3c_touch_events.enabled pref for >> Windows desktop builds.

Re: Gecko/Firefox stats and diagrams wanted

2016-02-09 Thread Kartikaya Gupta
+ Sotaro, who has over the years created a lot of different architecture/class diagrams of different parts of Gecko. They might be too detailed for your needs but worth checking. On Tue, Feb 9, 2016 at 12:31 PM, Nicholas Alexander wrote: > +Kyle, +Nathan > > On Tue, Feb 9, 2016 at 9:00 AM, Chris

Re: Intent to deprecate: MacOS 10.6-10.8 support

2016-03-14 Thread Kartikaya Gupta
On Thu, Mar 10, 2016 at 5:45 PM, Anthony Jones wrote: > My understanding is that the reason people stick to 10.6 is because of > Rosetta[1] which offers PowerPC compatibility. I have a laptop on 10.6. The hardware can theoretically support newer OS X versions, and I've upgraded it, but newer OS X

Re: Testing Wanted: APZ Scrollbar dragging

2016-04-01 Thread Kartikaya Gupta
On Apr 1, 2016 2:45 AM, "Sam Harrington" wrote: > I've been seeing some rather weird middle-click scrolling behavior in recent nightlies, and your test page seems to be a good way to reproduce it (see https://gfycat.com/FarflungCoarseBoutu for a video). Is this a known issue, or should I file it?

Re: Triage Plan for Firefox Components

2016-04-01 Thread Kartikaya Gupta
It seems to me that when this bug program was started, it had these two goals (quoted from Emma's previous email): "First, we want to make better assertions about the quality of our releases by making clear decisions about which bugs must be fixed for each release (urgent) and actively tracking th

Coding style for C++ enums

2016-04-08 Thread Kartikaya Gupta
Is there a recommendation for what enum values in C++ code should be styled as? The coding style doesn't say and we use a variety of things in existing code, so I was wondering if we should settle on something for new enums being added to the code, and update the style guide accordingly. enum Opti

Re: Triage Plan for Firefox Components

2016-04-08 Thread Kartikaya Gupta
On Fri, Apr 8, 2016 at 10:54 AM, Benjamin Smedberg wrote: > On Thu, Apr 7, 2016 at 2:50 AM, L. David Baron wrote: >> Why it's important >> What makes this problem important or urgent to fix? >> > > Yes! If this isn't clear, who owns this? Either the module owner/peer, or a > product m

Re: Coding style for C++ enums

2016-04-11 Thread Kartikaya Gupta
Based on all the feedback so far I think the best compromise is to use enum classes with the "e" prefix on the values. As was mentioned, the "e" prefix is useful to distinguish between enum values and function pointer passing at call sites, but is a small enough prefix that it shouldn't be too much

Re: Coding style for C++ enums

2016-04-11 Thread Kartikaya Gupta
On Mon, Apr 11, 2016 at 1:46 PM, Seth Fowler wrote: > I'd honestly prefer to see this discussion drag on a little longer. The > original email was on Friday, so given that most participants on this list > aren't actively debating C++ coding style on the weekend, we've actually had > less than one

Re: [Bug 1224726] High memory consumption when opening and searching a large Javascript file in debugger.

2016-04-11 Thread Kartikaya Gupta
He seems to have gotten the message: https://bugzilla.mozilla.org/show_bug.cgi?id=1255526#c21 On Mon, Apr 11, 2016 at 6:47 PM, Mark Côté wrote: > Tagging the comments as spam will autoban the account after a certain > number. It will also autocollapse the comments. > > Mark > > > On 2016-04-11 6

Re: PSA: Cancel your old Try pushes

2016-04-15 Thread Kartikaya Gupta
I also often have multiple pushes going at the same time. My suggestion to solve this problem is: have a cron job that detects users who have more than N pushes with jobs still going, and send them an email saying "you have a lot of jobs going, here's the list; you might find something you should c

Re: PSA: Cancel your old Try pushes

2016-04-17 Thread Kartikaya Gupta
On Apr 17, 2016 1:55 PM, "Steve Fink" wrote: > > Generally speaking, Firefox's stability has not been good for me for 2-3 months. I'd like to file a bug, but I've already used up my quota of unactionable bugs, and if I dug into all of my idiosyncratic issues I'd never get any work done. Also (and

Re: Moving XP to ESR?

2016-04-18 Thread Kartikaya Gupta
On Mon, Apr 18, 2016 at 2:02 PM, Chris Peterson wrote: > > OTOH, if an XP users doesn't mind running an unpatched OS, then they > probably won't care/know about running an unpatched Chrome browser. > >From data that Chris H-C posted in some previous thread, we know that Firefox users on XP are us

Telemetry experiments need to be easier (on Nightly)

2016-04-19 Thread Kartikaya Gupta
(Cross-posted to dev-platform and release-management) Hi all, Not too long ago I ran a telemetry experiment [1] to figure out how to tune some of our code to get the best in-the-wild behaviour. While I got the data I wanted, I found the process of getting the experiment going to be very heavyweig

Re: Telemetry experiments need to be easier (on Nightly)

2016-04-20 Thread Kartikaya Gupta
o go and update the page to reflect what you've said here, provided you're willing to review my changes to make sure I don't go overboard :) Cheers, kats > On Tue, Apr 19, 2016 at 4:43 PM, Kartikaya Gupta wrote: >> (Cross-posted to dev-platform and release-management) >>

Re: PSA: Cancel your old Try pushes

2016-04-26 Thread Kartikaya Gupta
Running that mach try command with the additional --no-push argument produces this mouthful: try: -b do -p linux64 -u crashtest,crashtest-e10s,mochitest-1,mochitest-browser-chrome-1,mochitest-e10s-1,mochitest-e10s-browser-chrome-1,mochitest-o,reftest,reftest-e10s,xpcshell -t none --try-test-paths

Intent to implement and ship: "passive" option for AddEventListenerOptions

2016-05-05 Thread Kartikaya Gupta
Summary: Authors can declare in their addEventListener call that the listener will not be calling preventDefault() on the event. This unlocks certain performance optimizations. Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1266066 Link to standard: https://dom.spec.whatwg.org/#dom-addeventlis

Re: Intent to implement and ship: "passive" option for AddEventListenerOptions

2016-05-05 Thread Kartikaya Gupta
; Justin > > On Wed, May 4, 2016 at 3:19 PM, Kartikaya Gupta wrote: >> >> Summary: Authors can declare in their addEventListener call that the >> listener will not be calling preventDefault() on the event. This >> unlocks certain performance optimizations. >> &

Re: Intent to implement and ship: "passive" option for AddEventListenerOptions

2016-05-06 Thread Kartikaya Gupta
Correct, the preventDefault() is ignored from a passive listener, and we will probably log a warning to the console (I have a patch up for review that does that, let's see what smaug says). On Fri, May 6, 2016 at 1:01 AM, Anne van Kesteren wrote: > On Fri, May 6, 2016 at 4:43 AM, Eric Shepherd w

Re: Telemetry experiments need to be easier (on Nightly)

2016-05-10 Thread Kartikaya Gupta
for me > and evidently for Kats as well). > > I hope these suggestions are helpful. > > Cheers, > > Jared > > > [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1174937 > [2] https://wiki.mozilla.org/QA/Telemetry > [3] > http://hg.mozilla.org/webtools/telemetry-experiment-server/

Re: Telemetry experiments need to be easier (on Nightly)

2016-05-10 Thread Kartikaya Gupta
err [1] is https://wiki.mozilla.org/Telemetry/Experiments and [2] is https://wiki.mozilla.org/QA/Telemetry/Developing_a_Telemetry_Experiment :) On Tue, May 10, 2016 at 10:53 AM, Kartikaya Gupta wrote: > Just to close the loop on this, I went ahead and updated the wiki > pages at [1] and

Re: FF49a1: Page load of jumping points doesn't work like it should in Wikipedia

2016-05-20 Thread Kartikaya Gupta
Note that this might get fixed in chrome with their new "scroll anchoring" feature - https://developers.google.com/web/updates/2016/04/scroll-anchoring?hl=en kats On Fri, May 20, 2016 at 12:15 PM, Adam Roach wrote: > On 5/20/16 10:13, Gijs Kruitbosch wrote: >> >> On 20/05/2016 16:11, Tobias B. B

Re: All about crashes

2016-05-26 Thread Kartikaya Gupta
On Wed, May 25, 2016 at 9:45 PM, Nicholas Nethercote wrote: > On Wed, May 25, 2016 at 6:58 AM, Lawrence Mandel wrote: >> "Crashes are caused by defects" >> >> Reading this I think it implies defects in Firefox. This is not always the >> case. Crashes are also the result of interactions with third

Re: How badly out of date is this?

2016-06-01 Thread Kartikaya Gupta
Or make the warning a fixed-position item, so it's on-screen regardless of where on the page you are. On Wed, Jun 1, 2016 at 10:06 AM, Mike Hoye wrote: > On 2016-06-01 5:02 AM, L. David Baron wrote: >> >> >> So I tend to think it's worth keeping, but with a preface that >> clearly labels it as hi

Re: The Whiteboard Tag Amnesty

2016-06-08 Thread Kartikaya Gupta
What happens after June 24? Is the whiteboard field going to be removed? On Wed, Jun 8, 2016 at 4:32 PM, Emma Humphries wrote: > tl;dr -- nominate whiteboard tags you want converted to keywords. Do it by > 24 June 2016. > > We have a love-hate relationship with the whiteboard field in bugzilla. O

Re: Triage for Component Leads

2016-06-16 Thread Kartikaya Gupta
The wiki says everything from July 1 onwards should be triaged, but the triage-center tool produces bugzilla links from June 1 onwards (when you select the "no priority decision" link). Is this intentional, or just a mix-up? On Thu, Jun 16, 2016 at 5:17 PM, Emma Humphries wrote: > This afternoon

Intent to enable: touch-action (on Nightly)

2016-07-05 Thread Kartikaya Gupta
In the next few days, I intend to enable support for touch-action on Nightly (#ifdef NIGHTLY_BUILD), for all platforms. The implementation is behind the layout.css.touch_action.enabled property. touch-action is spec'd as part of the Pointer Events spec [1] - the rest of the spec is currently being

Intent to ship: TouchEvents (Windows), touch-action (all platforms), accessible caret

2016-10-04 Thread Kartikaya Gupta
In Firefox 52 I intend to ship support for TouchEvents on Windows e10s. TouchEvent support has already been enabled on Android for a long time and has been enabled on Linux e10s as well (if you have MOZ_USE_XINPUT2=1 in your environment). The pref that controls this feature is dom.w3c_touch_events.

Re: Adding Rust code to Gecko, now documented

2016-11-09 Thread Kartikaya Gupta
I'm actually trying to debug a rust issue right now and have some questions. I've done the |mach vendor rust| step and got all the vendored crates. Now let's say that in one of the dependencies (the 'cmake' crate in my case) there's some sort of behaviour that I'd like to investigate/debug. If I ed

Re: Adding Rust code to Gecko, now documented

2016-11-09 Thread Kartikaya Gupta
On Wed, Nov 9, 2016 at 11:51 AM, Ralph Giles wrote: > On Wed, Nov 9, 2016 at 8:41 AM, Kartikaya Gupta wrote: > >> If I edit the third_party/rust/cmake/src/lib.rs >> in-place, the build fails because of a hash mismatch. > > Interesting! This is supposed to happen as a

Re: Async scrollbar dragging enabled on Nightly

2016-12-21 Thread Kartikaya Gupta
On Wed, Dec 21, 2016 at 6:19 AM, Gervase Markham wrote: > Why do we paint a checkerboard We don't actually paint a checkerboard pattern. > rather than the default single background > colour of the page? This is what we do. It's still *called* checkerboarding though. The behaviour has changed, t

  1   2   >