On Wed, Nov 9, 2016 at 11:51 AM, Ralph Giles <gi...@mozilla.com> wrote: > On Wed, Nov 9, 2016 at 8:41 AM, Kartikaya Gupta <kgu...@mozilla.com> wrote: > >> If I edit the third_party/rust/cmake/src/lib.rs >> in-place, the build fails because of a hash mismatch. > > Interesting! This is supposed to happen as a check against corruption > and/or non-reproducible builds, but I can't reproduce by modifying > third_party/rust/byteorder/src/lib.rs. Is this the full gecko `mach > build` or a local `cargo build` of the crate you're working on?
This is with a full gecko `mach build`. And it's weird - a couple of times when I modified the lib.rs and ran the build it didn't error out, but it also didn't pick up my changes to lib.rs. So maybe it's short-circuiting the rebuild in some cases? >> However if I do that the force-cargo-build step in the >> build fails saying the lock file needs updating but --locked was >> passed. > > Try running 'cargo update' in toolkit/library/rust I did this, and it updated the Cargo.lock file, but it produces the same hash mismatch error, because the modified lib.rs in my cmake-fork folder doesn't match the hash stored in the cmake-fork/.cargo-checksum.json file. Removing that .cargo-checksum.json file from the fork doesn't work either, since the build requires it to be there. In the end I just manually modified the checksum file to have the new hash (which thankfully the error message provided). kats _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
