Re: JavaScript Style Guide. Emacs mode line.

2013-09-11 Thread Scott Johnson
Thus Spoke ishikawa: > On (2013年09月10日 00:08), Scott Johnson wrote: >> Thus Spoke ishikawa: >> >> So you are suggesting something like >> step 1 - request for formatting a file indented in an arcane format, i.e., >> reformat it according to the currently adopted

Re: JavaScript Style Guide. Emacs mode line.

2013-09-09 Thread Scott Johnson
Thus Spoke ishikawa: > > I wonder if trying to re-indent legacy code according to the current style > is a good idea or not. (It is a little irritating to modify a part of legacy > code and find my editor trying to follow the current style while the rest of > the file is in different style.) I'd r

Re: Code Review Session

2013-06-04 Thread Scott Johnson
Also, for those who are interested, I'm working on a script that will (hopefully) be a pre-commit hook for checking that IDL changes have corresponding IID changes (if needed): https://github.com/jwir3/checkiid Feel free to use it if you want to test your patches for compliance, and also to te

Code Review Session

2013-05-23 Thread Scott Johnson
Members of dev-platform: As part of the Web Rendering work-week in Taiwan, we had a discussion of the process of code review, graciously led by roc. If you were unable to attend, or were able to attend and would like to review the proceedings, notes are available here: https://etherpad.mozilla.org

Re: reorganizing some test directories

2013-04-11 Thread Scott Johnson
Thus Spoke jmaher: > There are a couple common directory structures used for storing tests in the > tree: > 1) /tests > 2) /tests/ > > I have a series of patches which will move most of the directory structures > from #1 to a format of #2. This means we would see: > /tests/mochitest > /tests/bro

Re: IID Change Hook

2013-01-22 Thread Scott Johnson
> Note that we previously added a hook[1] to check that > binary-compat-breaking changes on Beta didn't land without explicit > approval. I suspect we could extend that hook to do what we want for > mozilla-central. True, but this hook actually (IIUC) checks to see if an IID changed, given a patc

IID Change Hook

2013-01-22 Thread Scott Johnson
Hello Dev-Platform: tl;dr: As discussed in the platform meeting today, we're looking at adding a checking script to verify that IIDs are changed along with interfaces from now on. The relevant bug is https://bugzilla.mozilla.org/show_bug.cgi?id=477166 Full Text: In light of recent breakages of p

Fwd: Re: Planning to turn off Talos tdhtml

2012-10-16 Thread Scott Johnson
Meant to send this to the list also. Original Message Subject:Re: Planning to turn off Talos tdhtml Date: Tue, 16 Oct 2012 12:35:40 -0500 From: Scott Johnson Organization: Mozilla Corporation To: jmaher Joel: I recall getting value from these tests when

Re: Adding mozilla-inbound hg links to bugs

2012-10-09 Thread Scott Johnson
On 10/08/2012 08:42 AM, thus spoke Justin Lebar: > Having said that, I don't think it would be hard to write an hg hook > which comments in the relevant bugs when a push is made to m-i. Maybe > that would be a reasonable way to get uniformity and immediate > notification in the bug when a patch i

Re: Disabling tests

2012-08-02 Thread Scott Johnson
Maybe we should take a different approach to the problem... Have an all-developer "fix orange tests" day where developers work ONLY on fixing random oranges (maybe once you've successfully fixed 1 or 2 random oranges, you can go back to your other work?) Not meant as a criticism, but rather jus

Re: Switching nsnull to nullptr

2012-08-02 Thread Scott Johnson
On 07/28/2012 05:19 PM, thus spoke Jonas Sicking: > When are we doing PRUint32? ;-) +1! ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform