[GitHub] [zeppelin] Reamer commented on pull request #4212: [ZEPPELIN-5395] Address tab nabbing vulnerability

2021-09-07 Thread GitBox
Reamer commented on pull request #4212: URL: https://github.com/apache/zeppelin/pull/4212#issuecomment-914048005 > I have applied this fix for all the links apart from the angular rendered. For angular rendered links the more general solution can be applied (https://coryrylan.com/blog/mana

[jira] [Created] (ZEPPELIN-5511) The incorrect use of Immediate

2021-09-07 Thread Jira
李观华 created ZEPPELIN-5511: - Summary: The incorrect use of Immediate Key: ZEPPELIN-5511 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5511 Project: Zeppelin Issue Type: Improvement Com

[GitHub] [zeppelin] izeren-amzn commented on pull request #4212: [ZEPPELIN-5395] Address tab nabbing vulnerability

2021-09-07 Thread GitBox
izeren-amzn commented on pull request #4212: URL: https://github.com/apache/zeppelin/pull/4212#issuecomment-914202516 > > I have applied this fix for all the links apart from the angular rendered. For angular rendered links the more general solution can be applied (https://coryrylan.com/bl

[GitHub] [zeppelin] Reamer commented on pull request #4212: [ZEPPELIN-5395] Address tab nabbing vulnerability

2021-09-07 Thread GitBox
Reamer commented on pull request #4212: URL: https://github.com/apache/zeppelin/pull/4212#issuecomment-914222922 Do you need isPlatformBrowser because of the tests? Do we need the changes in `zeppelin-web-angular/src/app/share/about-zeppelin/about-zeppelin.component.html` and `zeppelin

[GitHub] [zeppelin] asfgit closed pull request #4172: [ZEPPELIN-5444] Allow users to set service account for interpreter

2021-09-07 Thread GitBox
asfgit closed pull request #4172: URL: https://github.com/apache/zeppelin/pull/4172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[GitHub] [zeppelin] Reamer commented on pull request #4172: [ZEPPELIN-5444] Allow users to set service account for interpreter

2021-09-07 Thread GitBox
Reamer commented on pull request #4172: URL: https://github.com/apache/zeppelin/pull/4172#issuecomment-914261464 Thanks @rickchengx for your good code contribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [zeppelin] izeren-amzn commented on pull request #4212: [ZEPPELIN-5395] Address tab nabbing vulnerability

2021-09-07 Thread GitBox
izeren-amzn commented on pull request #4212: URL: https://github.com/apache/zeppelin/pull/4212#issuecomment-914332151 > Do you need isPlatformBrowser because of the tests? > Do we need the changes in `zeppelin-web-angular/src/app/share/about-zeppelin/about-zeppelin.component.html` and

[GitHub] [zeppelin] Reamer commented on pull request #4212: [ZEPPELIN-5395] Address tab nabbing vulnerability

2021-09-07 Thread GitBox
Reamer commented on pull request #4212: URL: https://github.com/apache/zeppelin/pull/4212#issuecomment-914337983 > So, I can remove isPlatform check to support simplicity Yes, please remove this. -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [zeppelin] izeren-amzn commented on pull request #4212: [ZEPPELIN-5395] Address tab nabbing vulnerability

2021-09-07 Thread GitBox
izeren-amzn commented on pull request #4212: URL: https://github.com/apache/zeppelin/pull/4212#issuecomment-914339995 > > So, I can remove isPlatform check to support simplicity > > Yes, please remove this. I have already removed it in the last commit -- This is an automated

[jira] [Created] (ZEPPELIN-5512) 配置了多个zeppelin.notebook.storage

2021-09-07 Thread Jack Chen (Jira)
Jack Chen created ZEPPELIN-5512: --- Summary: 配置了多个zeppelin.notebook.storage Key: ZEPPELIN-5512 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5512 Project: Zeppelin Issue Type: Improvement