izeren-amzn commented on pull request #4212: URL: https://github.com/apache/zeppelin/pull/4212#issuecomment-914332151
> Do you need isPlatformBrowser because of the tests? > Do we need the changes in `zeppelin-web-angular/src/app/share/about-zeppelin/about-zeppelin.component.html` and `zeppelin-web-angular/src/app/pages/workspace/notebook/paragraph/paragraph.component.ts`? I thought that `ExternalLinkDirective` applies to all links. I put it here just in case of some future SSR, it is not necessary right now. `component.html & component.ts`: my bad, missed to revert these files, we don't have to do manual fixes for it. So, I can remove isPlatform check to support simplicity -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
