izeren-amzn commented on pull request #4212: URL: https://github.com/apache/zeppelin/pull/4212#issuecomment-914202516
> > I have applied this fix for all the links apart from the angular rendered. For angular rendered links the more general solution can be applied (https://coryrylan.com/blog/managing-external-links-safely-in-angular), but before I will do this workaround, I would like to confirm it with the maintainers > > I would prefer a general solution for Angular. I took a look at the blog post and it seems that the solution works without third party dependencies. > > I can confirm that you added the `rel="noopener noreferrer"` to all other links (except in zeppelin-web-angular) with `target="_blank"`. I have added this solution to angular based links and I have run tests locally accordingly to https://zeppelin.apache.org/contribution/contributions.html I also have started zeppelin locally to check a couple of angular generated links in firefox and chrome, so it is ready to review and PR checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
