Re: Signed Apache ICLA

2017-11-16 Thread Myrle Krantz
On Fri, Nov 17, 2017 at 12:05 AM, Craig Russell wrote: > Hi Myrle, > > Thanks for the feedback. A bit more information if you please. Does the > following message show up before you press Preview Invitation? > > Fill the following field only if the person was voted by the PMC to become a > commi

Re: Check validity for project/icla

2017-11-16 Thread Sam Ruby
About to call it a night, but two pointers for you to explore. On Thu, Nov 16, 2017 at 10:54 PM, Craig Russell wrote: > >> On Nov 16, 2017, at 7:45 PM, Sam Ruby wrote: >> >> On Thu, Nov 16, 2017 at 6:27 PM, Craig Russell wrote: >>> There are two validity checks: one is on the front end, and the

Re: More high level design on project/icla

2017-11-16 Thread Sam Ruby
On Thu, Nov 16, 2017 at 10:47 PM, Craig Russell wrote: > I found this: > > http://geoiplookup.net/xml-api/ > > http://api.geoiplookup.net/?query=73.15.26.163 > The XML result is as follows: > > > > 73.15.26.163 > 73.15.26.163 > Comcast Cable > San José > US > United States > 37.34220 > -121.883

Re: Check validity for project/icla

2017-11-16 Thread Craig Russell
> On Nov 16, 2017, at 7:45 PM, Sam Ruby wrote: > > On Thu, Nov 16, 2017 at 6:27 PM, Craig Russell wrote: >> There are two validity checks: one is on the front end, and the other is on >> the server. > > As a general rule, it is best practice to do the validity checks in both > places. > > C

Re: More high level design on project/icla

2017-11-16 Thread Craig Russell
I found this: http://geoiplookup.net/xml-api/ http://api.geoiplookup.net/?query=73.15.26.163 The XML result is as follows: 73.15.26.163 73.15.26.163 Comcast Cable San José US United States 37.34220 -121.88330 Sounds exactly like what we (I) want. Just need to figure out how to change San

Re: Check validity for project/icla

2017-11-16 Thread Sam Ruby
On Thu, Nov 16, 2017 at 6:27 PM, Craig Russell wrote: > There are two validity checks: one is on the front end, and the other is on > the server. As a general rule, it is best practice to do the validity checks in both places. Checks in the front end can result in a more user friendly and immed

Re: More high level design on project/icla

2017-11-16 Thread Sam Ruby
On Thu, Nov 16, 2017 at 7:36 PM, Craig Russell wrote: > > I'd like to get as much information about the invitee as is possible from the > browser. I understand we can get IP address. Can we get country, city, GPS? There appears to be a tool named 'geoiplookup' that can be installed on macs with

Re: Bug in roster/pmc

2017-11-16 Thread Craig Russell
> On Nov 16, 2017, at 4:39 PM, sebb wrote: > > On 16 November 2017 at 23:12, Craig Russell wrote: >> Hi Sebb, >> >>> On Nov 16, 2017, at 1:40 PM, sebb wrote: >>> >>> On 16 November 2017 at 19:40, Craig Russell wrote: The roster/pmc display validates email addresses for subscribers, and

Re: Bug in roster/pmc

2017-11-16 Thread sebb
On 16 November 2017 at 23:12, Craig Russell wrote: > Hi Sebb, > >> On Nov 16, 2017, at 1:40 PM, sebb wrote: >> >> On 16 November 2017 at 19:40, Craig Russell wrote: >>> The roster/pmc display validates email addresses for subscribers, and flags >>> Asf Members who are subscribed who are not PMC

Re: [whimsy] branch master updated: Separate out ASF members

2017-11-16 Thread Craig Russell
I like this A LOT! Craig > On Nov 16, 2017, at 4:31 PM, s...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > sebb pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/whimsy.git > > > The following commit(s) were ad

More high level design on project/icla

2017-11-16 Thread Craig Russell
I think the invitation form is pretty much done. The interview is next on my list. The inviter has provided the email address and public name. It's important that the email address be valid, and many times the email known to the inviter is not the email that the invitee wants to use. So the fir

Check validity for project/icla

2017-11-16 Thread Craig Russell
There are two validity checks: one is on the front end, and the other is on the server. The front end code: def setVoteLink(event) @votelink = event.target.value self.checkValidity() end I cannot find the self.checkValidity code. What I think we should do is to put these validity

Re: Signed Apache ICLA

2017-11-16 Thread Sam Ruby
On Nov 16, 2017 6:05 PM, "Craig Russell" wrote: > Hi Myrle, > > Thanks for the feedback. A bit more information if you please. Does the > following message show up before you press Preview Invitation? > > Fill the following field only if the person was voted by the PMC to become > a committer. Li

Re: Bug in roster/pmc

2017-11-16 Thread Craig Russell
Hi Sebb, > On Nov 16, 2017, at 1:40 PM, sebb wrote: > > On 16 November 2017 at 19:40, Craig Russell wrote: >> The roster/pmc display validates email addresses for subscribers, and flags >> Asf Members who are subscribed who are not PMC members. >> >> Is this really necessary? First impressio

Re: Signed Apache ICLA

2017-11-16 Thread Craig Russell
Hi Myrle, Thanks for the feedback. A bit more information if you please. Does the following message show up before you press Preview Invitation? Fill the following field only if the person was voted by the PMC to become a committer. Link to the [RESULT][VOTE] message in the mail archives. Whi

Re: Bug in roster/pmc

2017-11-16 Thread sebb
On 16 November 2017 at 19:40, Craig Russell wrote: > The roster/pmc display validates email addresses for subscribers, and flags > Asf Members who are subscribed who are not PMC members. > > Is this really necessary? First impression is that it's an error. Previously the display only showed the

Re: Bug in secretary workbench

2017-11-16 Thread Sam Ruby
On Thu, Nov 16, 2017 at 2:48 PM, Craig Russell wrote: > The icla message now appears but I'll leave it unprocessed for now until > someone can figure out why it is flaky. Fixed. Reproduced and fixed. The problem was with the latest email; new emails would move the problem. And often the new e

Re: Bug in secretary workbench

2017-11-16 Thread Craig Russell
The icla message now appears but I'll leave it unprocessed for now until someone can figure out why it is flaky. Craig > On Nov 16, 2017, at 11:29 AM, Craig Russell wrote: > > There is a new icla from Awasum to be processed for the fineract project but > it cannot be accessed. > > The icla s

Bug in roster/pmc

2017-11-16 Thread Craig Russell
The roster/pmc display validates email addresses for subscribers, and flags Asf Members who are subscribed who are not PMC members. Is this really necessary? First impression is that it's an error. Perhaps it could be in a different part of the display. I'm all for transparency, but this is co

Bug in secretary workbench

2017-11-16 Thread Craig Russell
There is a new icla from Awasum to be processed for the fineract project but it cannot be accessed. The icla shows up briefly in the main page but immediately is erased so it cannot be processed. I have seen this behavior in other cases where the subject is identical to another message. I ju

Re: [whimsy] branch master updated: Look up emails to see if they are known

2017-11-16 Thread sebb
On 16 November 2017 at 05:14, Sam Ruby wrote: > On Wed, Nov 15, 2017 at 8:24 PM, sebb AT ASF wrote: >> I copied some code from committerSearch.js.rb. >> >> Could this code be shared somehow? > > https://vuejs.org/v2/guide/mixins.html > > Examples: > > https://github.com/apache/whimsy/tree/master/