On Nov 16, 2017 6:05 PM, "Craig Russell" <apache....@gmail.com> wrote:
> Hi Myrle,
>
> Thanks for the feedback. A bit more information if you please. Does the
> following message show up before you press Preview Invitation?
>
> Fill the following field only if the person was voted by the PMC to become
> a committer. Link to the [RESULT][VOTE] message in the mail archives.
>
>
> Whimsydevs,
>
> This is not the behavior I see in testing. I have no access to the
> fineract project to test this, but see the PMC and PPMC text properly show
> up in the invite message based on this code:
>
> pmc = ASF::Committee.find(@pmc)
> ppmc = ASF::Podling.find(@pmc)
> pmc_type = if ppmc then 'PPMC' else 'PMC' end
> ...
> "Congratulations! The #{pmc.name} #{pmc_type} hereby offers you committer
> privileges
> to the #{pmc.name} project.
>
> Is it possible that ASF::Podling finds fineract?
>
Yes.
irb(main):001:0> ASF::Podling.find('fineract').status
=> "graduated"
Also, ASF::Committee.find is poorly designed (my bad). LDAP is a database,
and ASF::Committee.find returns an object will perform queries. Which
means that find will always return something non-nil. ASF::Committee[@pmc]
is an alternative that will do an additional check and return nil if not
found.
https://whimsy.apache.org/docs/api/ASF/Committee.html
ASF::Podling.find doesn't replicate this surprising behavior, but will
return any data that can be found in podlings.xml.
Possible fix: change ASF::Committee.find to ASF::Committee[]. Change the
if to if pmc then 'PMC' else 'PPMC' end
Alternate fix: change the if to if ppmc and ppmc.status == 'current'
> Craig
>
- Sam Ruby
> > On Nov 16, 2017, at 12:01 PM, Myrle Krantz <my...@apache.org> wrote:
> >
> > Hey Craig,
> >
> > Before I start: Is there a more appropriate forum for this? It doesn't
> > really seem to be in Fineract's charter, and I imagine the Fineract
> > PMC members are getting good at deleting my mails at this point.
> >
> > Answer inline:
> >
> > On Thu, Nov 16, 2017 at 8:36 PM, Craig Russell <apache....@gmail.com>
> wrote:
> >>> 2.) The committer
> >>> invitation mail references a PPMC rather than a PMC.
> >>
> >> Which part of the demo is this? Can you copy the entire invitation
> email and send it here?
> >
> > When I hit the "Send Invitation" button. The first button in the
> > workflow. Here's the invitation I see:
> >
> > (I'd be happier with a capitalized "Fineract" as well.)
> >
> > "Dear Howdy Doody,
> >
> > Congratulations! The fineract PPMC hereby offers you committer privileges
> > to the fineract project.
> >
> > You can read more about what the expectations are for committers here:
> > http://www.apache.org/dev/committers.html#committer-responsibilities
> >
> > These privileges are offered on the understanding that you'll use them
> > reasonably and with common sense. We like to work on trust rather than
> > unnecessary constraints.
> >
> > Being a committer enables you to more easily make changes without
> needing to
> > go through the patch submission process.
> >
> > Being a committer does not require you to participate any more than you
> already
> > do, but it does tend to make one even more committed ;-) You will
> probably find
> > that you spend more time here.
> >
> > Of course, you can decline and instead remain as a contributor,
> participating
> > as you do now.
> >
> > This personal invitation is a chance for you to accept or decline in
> private.
> > Either way, please let us know in reply to the private@ address only.
> >
> > Click on this link to accept:
> > https://whimsy.apache.org/project/icla/form?token=cf9b17543d86280c
> >
> > Regards,
> > Myrle Krantz
> > On behalf of the fineract project"
> >
> > Regards,
> > Myrle
>
> Craig L Russell
> Secretary, Apache Software Foundation
> c...@apache.org http://db.apache.org/jdo
>
>
