Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/216#issuecomment-112223076
There should be a new Jira ticket created for this and not try to use the
perviously closed ticket TS-1125.
Is this needed for intercept or server
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/68#issuecomment-112868365
https://issues.apache.org/jira/browse/TS-2666
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/85#issuecomment-112869333
This is the Jira ticket for it
https://issues.apache.org/jira/browse/TS-2803
---
If your project is set up for it, you can reply to this email and have
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/87#issuecomment-112869586
This was closed won't fix:
https://issues.apache.org/jira/browse/TS-2803
---
If your project is set up for it, you can reply to this email and have
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/122#issuecomment-112870570
There is a related Jira for this:
Desire support for client TLS cipher in custom log format
https://issues.apache.org/jira/browse/TS-3648
---
If your
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/123#issuecomment-112871079
The kernel's measured RTT times are inaccurate do to delayed ACKs.
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/164#issuecomment-112871692
Jira ticket open for this:
https://issues.apache.org/jira/browse/TS-3235
---
If your project is set up for it, you can reply to this email and have your
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/181#issuecomment-112871952
This was closed:
https://issues.apache.org/jira/browse/TS-3447
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/185#issuecomment-112872433
https://issues.apache.org/jira/browse/TS-1774
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/194#issuecomment-112873930
https://issues.apache.org/jira/browse/TS-3534
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/210#issuecomment-112875075
https://issues.apache.org/jira/browse/TS-3607
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/229#issuecomment-114593823
We shouldn't be using std:map in the first place. It would duplicate the
string object, but not the string bytes.
---
If your project is set up for it
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/229#issuecomment-115746373
I think it would be better at the creation of the LogField store the index
into the milestone array instead of looking it up every time you log. You can
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/276#issuecomment-130838839
Looks good so far, I am going to test it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/276#issuecomment-131255416
I have been testing with all the recent changes to HTTP/2 and this patch in
production and everything looks good.
---
If your project is set up for it, you
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/276#issuecomment-131468753
I committed this to master, but didn't add This closes #276. Can you
please close the pull request?
---
If your project is set up for it, you can rep
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/265#issuecomment-131468830
Master was merged into the 6.0.x branch on 8/4. Can this be closed?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/270#issuecomment-134705705
I am for putting these methods into ipallow.config. You are able to expand
on the set of common methods as defined in section 9 of RFC2616. Also, we
already
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/270#issuecomment-134748136
Looking at isNonstandardMethodAllowed I am OK with just using that.
However it should be modified without using std::string. Also, there should be
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/277#discussion_r39700318
--- Diff: ci/tsqa/tests/test_http2_spec.py ---
@@ -0,0 +1,114 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/277#discussion_r39705696
--- Diff: ci/tsqa/tests/test_http2_spec.py ---
@@ -0,0 +1,114 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/316#issuecomment-153545093
I got a bunch of errors applying this patch:
dispatch.cc:46:26: error: comparison between NULL and non-pointer
('std::auto_ptr' and NULL) [-Wer
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/316#issuecomment-153580444
Compile with -Werror or look at the warnings.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/330#discussion_r44372265
--- Diff: proxy/http/HttpTransactCache.cc ---
@@ -1299,7 +1299,7 @@
HttpTransactCache::match_response_to_request_conditionals(HTTPHdr *request, HTTP
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/330#discussion_r44432922
--- Diff: proxy/http/HttpTransactCache.cc ---
@@ -1299,7 +1299,7 @@
HttpTransactCache::match_response_to_request_conditionals(HTTPHdr *request, HTTP
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/330#discussion_r44594400
--- Diff: proxy/http/HttpTransactCache.cc ---
@@ -1299,7 +1299,7 @@
HttpTransactCache::match_response_to_request_conditionals(HTTPHdr *request, HTTP
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/330#discussion_r44595605
--- Diff: proxy/http/HttpTransactCache.cc ---
@@ -1299,7 +1299,7 @@
HttpTransactCache::match_response_to_request_conditionals(HTTPHdr *request, HTTP
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/334#discussion_r44731109
--- Diff: proxy/hdrs/MIME.h ---
@@ -852,6 +872,23 @@ MIMEField::value_append(HdrHeap *heap, MIMEHdrImpl
*mh, const char *value, int l
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/334#discussion_r44731073
--- Diff: proxy/hdrs/MIME.h ---
@@ -765,6 +768,23 @@ MIMEField::name_set(HdrHeap *heap, MIMEHdrImpl *mh,
const char *name, int length
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/334#discussion_r44732079
--- Diff: proxy/http2/HTTP2.cc ---
@@ -461,6 +461,15 @@ convert_from_2_to_1_1_header(HTTPHdr *headers)
headers->field_del
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/334#discussion_r44732321
--- Diff: proxy/http2/HTTP2.cc ---
@@ -448,7 +448,7 @@ convert_from_2_to_1_1_header(HTTPHdr *headers)
// Combine Cookie headers ([RFC
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/334#discussion_r44732404
--- Diff: proxy/http2/HTTP2.cc ---
@@ -448,7 +448,7 @@ convert_from_2_to_1_1_header(HTTPHdr *headers)
// Combine Cookie headers ([RFC
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/334#issuecomment-156597223
You don't need to squash. I will use a patch to commit it.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/354#issuecomment-160761247
There are conflicts with the patch after applying previous pull requests.
Please update.
---
If your project is set up for it, you can reply to this email
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/350#issuecomment-161370254
@ushachar I added support for debugging in header_rewrite and it has the
ability to do client ip matching. As @SolidWallOfCode pointed out there may be
some
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/362#discussion_r46776397
--- Diff: proxy/http2/HPACK.cc ---
@@ -332,18 +332,41 @@ int64_t
encode_string(uint8_t *buf_start, const uint8_t *buf_end, const char
*value
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/362#discussion_r46776556
--- Diff: proxy/http2/HPACK.cc ---
@@ -332,18 +332,41 @@ int64_t
encode_string(uint8_t *buf_start, const uint8_t *buf_end, const char
*value
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/386
TS-4088: Add support for BoringSSL
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver master
Alternatively you
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/395#issuecomment-166713566
I am getting this ASAN error running regressions with this pull request:
REGRESSION TEST HPACK_EncodeString started
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/400#issuecomment-169395997
Both HTTPD and NGiNX return a 0 in this case:
https://svn.apache.org/repos/asf/httpd/httpd/tags/2.4.9/modules/ssl/ssl_engine_kernel.c
- search for
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/400#issuecomment-170997750
@oknet What log are you referring too? I ran ATS with traffic_server -T
ssl and didn't see a difference in the debug messages.
---
If your project is s
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/400#issuecomment-172061089
With and without the return code change I get:
[Jan 15 11:27:31.471] Server {0x7f231793e840} DEBUG: (ssl) create ticket for a new session.
[Jan 15 11:27
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/434
TS-4131: InactivityCop doesn't close active connections that have timâ¦
â¦edout
You can merge this pull request into a Git repository by running:
$ git pull https://githu
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/445
TS-4166: Memory leak in traffic_top
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver ts-4166
Alternatively you
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/447
TS-4168: Only close inactive and active connections that have a non-zâ¦
â¦ero timeout
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/450
TS-4170: Error receiving data frame on closed connection for HTTP/2
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/444#issuecomment-178294038
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/453
TS-3863: Add support for ASAN leak detection
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver ts-3863
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/456
TS-4177: Memory leak in LogFieldAliasTable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver ts-4177
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/456#issuecomment-180567023
No, I didn't run clang-format on the pull request before pushing it to
github. I have a script that automates committing pull requests and it will
form
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/457
TS-4178: Memory leak in SplitDNSConfig
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver ts-4178
Alternatively
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/457#issuecomment-180924573
I rebased it off of master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/457#issuecomment-180928028
I rebased it on master and move the static to be a member of SplitDNSConfig.
---
If your project is set up for it, you can reply to this email and have your
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/457
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/456#issuecomment-181455689
If we want to go down the path of managed pointers then unique_ptr would be
the way to go.
I don't see a benefit of ats_scopted_str. It not a ge
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/462
Ts 4188
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver ts-4188
Alternatively you can review and apply these
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/462#issuecomment-181983212
@jpeach Http2::initial_window_size is used to store the configured value.
HTTP2_INITIAL_WINDOW_SIZE can't be changed.
---
If your project is set up f
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/459#issuecomment-182093202
I reviewed this before in our work repository and I am happy with it.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/454#issuecomment-182151443
I think it would make sense to have a DebugHttp2Stream that would be used
at the stream level and format both ids, which is most of the debugging.
---
If your
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/463
TS-4181: Memory leak in aio threads when shutting down
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-4188
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/464
TS-4178: Memory leak in SplitDNSConfig when shutting down
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/466
TS-3917: Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/467
TS-4196: Memory leak from main_thread on shutdown
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-4196
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/466#issuecomment-183174731
@masaori335 I am pretty sure the compare when setting the settings uses
this value to compare with.
---
If your project is set up for it, you can reply to
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/468
TS-4066: Memory leaks in gmake check tests
This fixes leaks in test_List
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/466#issuecomment-183178115
@masaori335 You are right :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/469
Ts 3917
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-3917
Alternatively you can review and apply these
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/469
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/470#issuecomment-183182412
Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/471
TS-3917: Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/474
TS-4066: Fixed most of the leaks in test_X509HostnameValidator
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/475
TS-4200: Wrong return value for TSHashTable::ExpansionPolicy
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/475#issuecomment-183515655
Yes, nothing uses it right now. It was showing up as an error in my editor.
---
If your project is set up for it, you can reply to this email and have your
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/480#issuecomment-184756069
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/454#issuecomment-184758654
+1 - Debugging code looks better now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/489
Ts 4212
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-4212
Alternatively you can review and apply these
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/489#issuecomment-186449042
I am planning on having and option for {{ats_malloc}} to call the track
functions in the future. Still thinking about how to do it cleanly.
---
If your
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/489#discussion_r53533502
--- Diff: lib/ts/ink_memory.cc ---
@@ -209,6 +210,46 @@ ats_mlock(caddr_t addr, size_t len)
return res;
}
+void
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/489#issuecomment-186454283
I updated it with Phil's suggestion.
I can figure out later what to do about calling ats_malloc like function
within these tracking functions w
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/489#issuecomment-187310269
@jpeach
I don't think it can get less ugly. I tried to clean it up as much as
possible.
What do you mean by duplicates the memory tracking
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/489#issuecomment-187312131
@jpeach
Do you know what the overhead is on malloc_usable_size(). Maybe switching
over to that would be a better idea.
---
If your project is set up for
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/489#issuecomment-187355127
Updated to use malloc_usable_size()
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/489#issuecomment-187401764
@jpeach They are both counters.
@PSUdaemon Yes, old_size > new_size :)
---
If your project is set up for it, you can reply to this email and h
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/35#issuecomment-187793606
Can you please rebase this? Besides that it looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/123#issuecomment-187795680
Talking at the github meeting on this. This logs two fields from tcp_info
and we would like to have access to log all the fields from tcp_info.
---
If your
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/199#issuecomment-187798229
Talking at the github meeting on this. It shouldn't use boost and the code
needs some cleanup.
---
If your project is set up for it, you can reply to
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/199#issuecomment-187798569
@zwoop volunteered to shepard this pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/228#issuecomment-187799137
This pull request is for https://issues.apache.org/jira/browse/TS-3407
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/210#issuecomment-187799694
@oschaaf can you please work on this and get it committed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/272#issuecomment-187800809
@SolidWallOfCode said he would work on it this quarter.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/304#issuecomment-187804291
This needs to be investigated more to completely solve this issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/308#issuecomment-187805341
Please close and moving this over to #309
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/309#issuecomment-187805696
@ftarnell Can you please rebase this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/330#issuecomment-187811485
We talked about this at the github meeting. As a workaround you can adjust
the Last-Modified with header rewrite. We feel this is the best solution to
only
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/343#issuecomment-187814680
@SolidWallOfCode and @dragon512 are going to take ownership of this.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/351#issuecomment-187818009
Talking at the github meeting. We should have a maximum size that will be
buffered in memory. This should go through API review. Please provide
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/374#issuecomment-187818415
@shinrich is going to shepard this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/373#issuecomment-187818356
@shinrich is going to shepard this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/407#issuecomment-187821803
Talking at the github meeting. The consensus is that we should split the
pull request into two pull requests. One for multi origin and the other for
retry
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/408#issuecomment-187822028
@bgaff can you shepard this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
1 - 100 of 192 matches
Mail list logo
