Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/330#discussion_r44432922
--- Diff: proxy/http/HttpTransactCache.cc ---
@@ -1299,7 +1299,7 @@
HttpTransactCache::match_response_to_request_conditionals(HTTPHdr *request, HTTP
ink_time_t lm_value = response->get_last_modified();
// we won't return NOT_MODIFIED if Last-modified is too recent
- if ((lm_value == 0) || (request->get_if_modified_since() <
lm_value)) {
--- End diff --
The logic that exist in ATS is correct it should pass back a 304 if the
last modified and if-modified-since match. This is how HTTP/1.1 clients should
work.
This change would break everyone else. I will comment more in the bug
TS-3995.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
