Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/334#discussion_r44732079
--- Diff: proxy/http2/HTTP2.cc ---
@@ -461,6 +461,15 @@ convert_from_2_to_1_1_header(HTTPHdr *headers)
headers->field_delete(HPACK_VALUE_METHOD, HPACK_LEN_METHOD);
headers->field_delete(HPACK_VALUE_AUTHORITY, HPACK_LEN_AUTHORITY);
headers->field_delete(HPACK_VALUE_PATH, HPACK_LEN_PATH);
+
+ // Check validity of all names and values
+ MIMEFieldIter iter;
+ for (const MIMEField *field = headers->iter_get_first(&iter); field !=
NULL; field = headers->iter_get_next(&iter)) {
+ if (!field->name_validate() || !field->value_validate()) {
+ return PARSE_ERROR;
+ }
+ }
+
--- End diff --
The code below is the same as this one section. Put it after the if else.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
