Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/334#discussion_r44732321
--- Diff: proxy/http2/HTTP2.cc ---
@@ -448,7 +448,7 @@ convert_from_2_to_1_1_header(HTTPHdr *headers)
// Combine Cookie headers ([RFC 7540] 8.1.2.5.)
field = headers->field_find(MIME_FIELD_COOKIE, MIME_LEN_COOKIE);
- if (field) {
--- End diff --
This shouldn't be necessary since you are going to check all the header
below. You would be validating the cookies two times.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
