Re: [PROPOSAL] Make atscppapi::RegisterGlobalPlugin return a value

2018-06-21 Thread Bryan Call
+1 -Bryan > On Jun 18, 2018, at 8:06 AM, David Calavera wrote: > > I noticed that atscppapi::RegisterGlobalPlugin doesn't return any value. > This makes impossible for plugins that use to to know whether they need to > abort initialization or continue after registering

Re: [PROPOSAL] Make atscppapi::RegisterGlobalPlugin return a value

2018-06-18 Thread Masakazu Kitajo
com > > > > > wrote: > > > > > I noticed that atscppapi::RegisterGlobalPlugin doesn't return any > value. > > > This makes impossible for plugins that use to to know whether they need > > to > > > abort initialization or continue after registe

Re: [PROPOSAL] Make atscppapi::RegisterGlobalPlugin return a value

2018-06-18 Thread Derek Dagit
+1 On Mon, Jun 18, 2018 at 10:09 AM, Alan Carroll < solidwallofc...@oath.com.invalid> wrote: > +1 > > On Mon, Jun 18, 2018 at 10:06 AM, David Calavera > > wrote: > > > I noticed that atscppapi::RegisterGlobalPlugin doesn't return any value. > > This ma

Re: [PROPOSAL] Make atscppapi::RegisterGlobalPlugin return a value

2018-06-18 Thread Alan Carroll
+1 On Mon, Jun 18, 2018 at 10:06 AM, David Calavera wrote: > I noticed that atscppapi::RegisterGlobalPlugin doesn't return any value. > This makes impossible for plugins that use to to know whether they need to > abort initialization or continue after registering the plugin. >

[PROPOSAL] Make atscppapi::RegisterGlobalPlugin return a value

2018-06-18 Thread David Calavera
I noticed that atscppapi::RegisterGlobalPlugin doesn't return any value. This makes impossible for plugins that use to to know whether they need to abort initialization or continue after registering the plugin. I'm proposing to change the method signature to return a boolean value, so p

Re: atscppapi: AsyncHttpFetch question

2017-03-27 Thread Bryan Call
blic AsyncProvider > { > ... > } > > > On Wed, Mar 22, 2017 at 1:37 PM, Dk Jack wrote: > >> Hi, >> In the file lib/atscppapi/examples/async_http_fetch/AsyncHttpFetch.cc, >> there is this code: >> >> --

Re: atscppapi: AsyncHttpFetch question

2017-03-27 Thread Alan M. Carroll
provider automatically > * self-destructs after the completion of the request. > * > * See example async_http_fetch{,_streaming} for sample usage. > */ > class AsyncHttpFetch : public AsyncProvider > { > ... > } > On Wed, Mar 22, 2017 at 1:37 PM, Dk Jack wrote: >&

Re: atscppapi: AsyncHttpFetch question

2017-03-22 Thread Dk Jack
omatically * self-destructs after the completion of the request. * * See example async_http_fetch{,_streaming} for sample usage. */ class AsyncHttpFetch : public AsyncProvider { ... } On Wed, Mar 22, 2017 at 1:37 PM, Dk Jack wrote: > Hi, > In the file lib/atscppapi/examples/

atscppapi: AsyncHttpFetch question

2017-03-22 Thread Dk Jack
Hi, In the file lib/atscppapi/examples/async_http_fetch/AsyncHttpFetch.cc, there is this code: --- // we'll add some custom headers for this request AsyncHttpFetch2 *provider2

Re: atscppapi questions

2016-11-29 Thread Alan Carroll
1) I would expect some changes in the CPP API but it will remain compile compatible during a major version. It is used in production in multiple deployments. 2) I am unfortunately not familiar with the TransformPlugin class. 3) Your changes seem sensible. Certainly it is a thing that's been done

atscppapi questions

2016-11-29 Thread Christopher Reynolds
Hi, I have been investigating this API (primarily the transformation class) to see whether it could be used rather than the lower level functions. I have a few questions. 1. Is this API ready for production use? I.e. is it still being updated regularly and will the interface change? 2.

Re: atscppapi question

2016-05-27 Thread Dk Jack
Alan, I have web-server behind ats. I was trying print various request attributes in my plugin. curl -v showed that it's sending the correct headers. I even collected tcpdump of the exchange and I see the complete URL being sent. The host header has the correct info. When I use the getHost API

Re: atscppapi question

2016-05-27 Thread Alan Carroll
curl --proxy localhost:8080 http://trafficserver.apache.org Thank you, helpful mail program.

Re: atscppapi question

2016-05-27 Thread Alan Carroll
I'm not sure what you're trying to do with that curl command. ATS is a proxy which means it has no content, it expects to forward any request on to an origin server. What origin server are you trying to reach via ATS? Normally I would do something like curl --proxy localhost:8080 Apache Traffic

atscppapi question

2016-05-26 Thread Dk Jack
Hi, I am using atscppapi in my plugin. I send a curl request as follows to ATS: curl 'http://localhost:8080/abcdef?a=1&b=2' In my plugin code, in handleReadRequestHeadersPreRemap function, I am printing the following: logInfo("effective-url: %s", txn

Re: writing plugins using atscppapi

2016-05-06 Thread Leif Hedstrom
> On May 6, 2016, at 10:32 AM, Akbar Said wrote: > > Figured out that you need to: ./configure --enable-cppapi when > configuring the trafficserver build. > > But still the question remains, is using atscppapi lib to develop plugins > the way of the future? It’s an a

Re: writing plugins using atscppapi

2016-05-06 Thread Akbar Said
Figured out that you need to: ./configure --enable-cppapi when configuring the trafficserver build. But still the question remains, is using atscppapi lib to develop plugins the way of the future? On Thu, May 5, 2016 at 9:32 AM, Akbar Said wrote: > Hi folks, > > Just wanted to

writing plugins using atscppapi

2016-05-05 Thread Akbar Said
Hi folks, Just wanted to check, is using atscppapi a current or "future" way of coding plugins in trafficserver? If so, is there a proper documentation for that? I am sure one can still do it by reading the example code, and understanding the API classes. But I couldn't find an

Re: atscppapi question

2016-03-10 Thread Sudheer Vinukonda
9, 2016 12:43 PM, Dk Jack wrote:  Hi, I am using atscppapi in my plugin. Specifically, I am using AsyncHttpFetch api. When I use the AsyncHttpFetch with a regular url say like ' http://www.foo.com:/' it works. However, if I use the fetch api with a url that includes query args i

Re: atscppapi question

2016-03-10 Thread Dk Jack
nc.com.invalid> wrote: > >> Can you check your remap rule? Perhaps, you may need to add trailing / in >> the source URL in the remap rule. >> Thanks, >> Sudheer >> >> On Wednesday, March 9, 2016 12:43 PM, Dk Jack >> wrote: >> >> >

Re: atscppapi question

2016-03-09 Thread Dk Jack
e remap rule. > Thanks, > Sudheer > > On Wednesday, March 9, 2016 12:43 PM, Dk Jack > wrote: > > > Hi, > I am using atscppapi in my plugin. Specifically, I am using AsyncHttpFetch > api. > When I use the AsyncHttpFetch with a regular url say like ' > ht

Re: atscppapi question

2016-03-09 Thread Sudheer Vinukonda
Can you check your remap rule? Perhaps, you may need to add trailing / in the source URL in the remap rule. Thanks, Sudheer On Wednesday, March 9, 2016 12:43 PM, Dk Jack wrote: Hi, I am using atscppapi in my plugin. Specifically, I am using AsyncHttpFetch api. When I use the

atscppapi question

2016-03-09 Thread Dk Jack
Hi, I am using atscppapi in my plugin. Specifically, I am using AsyncHttpFetch api. When I use the AsyncHttpFetch with a regular url say like ' http://www.foo.com:/' it works. However, if I use the fetch api with a url that includes query args i.e. ' http://www.foo.com:/

ATSCPPAPI

2016-01-27 Thread Yitzchak Weiser
Hi, Im a bit new to TS and TS plugin development, so I started writing one using the ATSCPPAPI I am trying to get the total Req/Resp Hdr/Bdy bite sizes using the transaction.getClientResponseHeaderSize() and getClientResponseBodySize respectively. I placed it in the latest CPP transaction hook

[GitHub] trafficserver pull request: TS-4034: Minor atscppapi cleanup

2015-11-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/345 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-4034: Minor atscppapi cleanup

2015-11-20 Thread bgaff
GitHub user bgaff opened a pull request: https://github.com/apache/trafficserver/pull/345 TS-4034: Minor atscppapi cleanup A few things should be cleaned up in atscppapi. - CaseInsensitiveStringComparitor isn't used internally but it is exposed in a public API, so be

[GitHub] trafficserver pull request: Refactoring of atscppapi code

2015-11-20 Thread canselcik
Github user canselcik closed the pull request at: https://github.com/apache/trafficserver/pull/344 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] trafficserver pull request: Refactoring of atscppapi code

2015-11-20 Thread canselcik
Github user canselcik commented on the pull request: https://github.com/apache/trafficserver/pull/344#issuecomment-158515997 Sounds good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] trafficserver pull request: Refactoring of atscppapi code

2015-11-20 Thread bgaff
Github user bgaff commented on the pull request: https://github.com/apache/trafficserver/pull/344#issuecomment-158515283 I already have these changes locally that I'm about to commit you can close this pull request --- If your project is set up for it, you can reply to this email and

[GitHub] trafficserver pull request: Refactoring of atscppapi code

2015-11-20 Thread canselcik
GitHub user canselcik opened a pull request: https://github.com/apache/trafficserver/pull/344 Refactoring of atscppapi code @bgaff Removing `CaseInsensitiveStringComparator` class from `atscppapi` as it can be replaced with and is not used in the codebase at all

atscppapi coredumps on InterceptPlugin

2015-04-06 Thread Sandeep Davu
in atscppapi::InterceptPlugin::handleEvent (this=0x2b60cc061b10, abstract_event=103, edata=0x2b60cc90ac80) at InterceptPlugin.cc:299* *event = TS_EVENT_VCONN_WRITE_COMPLETE* *__FUNCTION__ = "handleEvent"* *#4 0x2b60b7bede50 in atscppapi::utils::internal::dispatchInte

Re: atscppapi AsyncHttpFetch

2015-01-28 Thread Sandeep Davu
Brian, Yes it makes perfect sense. But when I saw the virtual run() l I thought I might me missing something. Getter will do the trick. For now I will implement my own. Sandeep. On Tue, Jan 27, 2015 at 10:03 PM, Brian Geffon wrote: > Unfortunately you cannot access the state_ member because it

Re: atscppapi AsyncHttpFetch

2015-01-27 Thread Brian Geffon
Unfortunately you cannot access the state_ member because it's private in AsyncHttpFetch, I think the best option here might be for us to add a getter method for the dispatch controller. Alternatively, you can just skip inheriting from AsyncHttpFetch and implement the AsyncProvider interface and co

atscppapi AsyncHttpFetch

2015-01-27 Thread Sandeep Davu
I want to extend AsyncHttpFetch class to have my own run implementation. How can we set "state_->dispatch_controller_" for a derived class of AsyncHttpFetch. Sandeep.

[GitHub] trafficserver pull request: fix for TS-2779 (atscppapi: bug in Asy...

2014-05-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/77 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] trafficserver pull request: fix for TS-2779 (atscppapi: bug in Asy...

2014-05-05 Thread manjeshnilange
GitHub user manjeshnilange opened a pull request: https://github.com/apache/trafficserver/pull/77 fix for TS-2779 (atscppapi: bug in AsyncTimer - cancel results in crash) The fix is that in cancel() we remember this fact and use it to check cancel retry. You can merge this pull

[GitHub] trafficserver pull request: atscppapi: fix for TS-2777 - using con...

2014-05-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/76 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] trafficserver pull request: atscppapi: fix for TS-2777 - using con...

2014-05-02 Thread manjeshnilange
GitHub user manjeshnilange opened a pull request: https://github.com/apache/trafficserver/pull/76 atscppapi: fix for TS-2777 - using content length from correct header Previously, the intercept code was looking for the Content Length header in the data sent by the client. However

[GitHub] trafficserver pull request: patch for TS-2720 atscppapi: Request t...

2014-04-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/73 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] trafficserver pull request: patch for TS-2720 atscppapi: Request t...

2014-04-15 Thread manjeshnilange
GitHub user manjeshnilange opened a pull request: https://github.com/apache/trafficserver/pull/73 patch for TS-2720 atscppapi: Request transformation streaming doesn't work Patch buffers the output till setOutputComplete() is called. You can merge this pull request into

[GitHub] trafficserver pull request: patch for TS-2719 - atscppapi: Check f...

2014-04-15 Thread manjeshnilange
Github user manjeshnilange closed the pull request at: https://github.com/apache/trafficserver/pull/71 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] trafficserver pull request: patch for TS-2719 - atscppapi: Check f...

2014-04-15 Thread manjeshnilange
GitHub user manjeshnilange opened a pull request: https://github.com/apache/trafficserver/pull/71 patch for TS-2719 - atscppapi: Check for error state in intercept You can merge this pull request into a Git repository by running: $ git pull https://github.com/manjeshnilange

Re: git commit: [TS-2688] atscppapi: new exmaple plugin Boom

2014-04-02 Thread Igor Galić
- Original Message - > Repository: trafficserver > Updated Branches: > refs/heads/master f347b0ddd -> 0521f07be > > > [TS-2688] atscppapi: new exmaple plugin Boom > > > Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo > Commit: h

[GitHub] trafficserver pull request: atscppapi: fixes for TS-2651: race con...

2014-03-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/64 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] trafficserver pull request: atscppapi: fixes for TS-2651: race con...

2014-03-19 Thread manjeshnilange
GitHub user manjeshnilange opened a pull request: https://github.com/apache/trafficserver/pull/64 atscppapi: fixes for TS-2651: race conditions in destruction of ... ...async providers. Also, I noticed a duplicated lock while invoking an intercept plugin. Though the

[GitHub] trafficserver pull request: atscppapi: Bug fixes in headers and at...

2014-03-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/62 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] trafficserver pull request: atscppapi: Bug fixes in headers and at...

2014-03-12 Thread manjeshnilange
GitHub user manjeshnilange opened a pull request: https://github.com/apache/trafficserver/pull/62 atscppapi: Bug fixes in headers and atscppapi As discussed - there is now a wireStr() in Headers and I'm fixing a couple of bugs in intercept. You can merge this pull request i

[GitHub] trafficserver pull request: atscppapi: Locking fix in xform and ut...

2014-03-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/60 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] trafficserver pull request: atscppapi: Locking fix in xform and ut...

2014-03-10 Thread manjeshnilange
GitHub user manjeshnilange opened a pull request: https://github.com/apache/trafficserver/pull/60 atscppapi: Locking fix in xform and utility macro for logging You can merge this pull request into a Git repository by running: $ git pull https://github.com/manjeshnilange

[GitHub] trafficserver pull request: atscppapi: Added missing intercept fil...

2014-03-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/58 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] trafficserver pull request: atscppapi: Added missing intercept fil...

2014-03-06 Thread manjeshnilange
GitHub user manjeshnilange opened a pull request: https://github.com/apache/trafficserver/pull/58 atscppapi: Added missing intercept files You can merge this pull request into a Git repository by running: $ git pull https://github.com/manjeshnilange/trafficserver master

[GitHub] trafficserver pull request: atscppapi: async http fixes and interc...

2014-03-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/56 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

Re: [2/2] git commit: intercept support in atscppapi

2014-03-06 Thread James Peach
We should have a JIRA ticket for this so that we can publish accurate change logs and release notes On Mar 6, 2014, at 12:47 PM, bri...@apache.org wrote: > intercept support in atscppapi > > > Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo > Commit:

Re: git commit: Cleaning up build of atscppapi

2013-10-29 Thread James Peach
On Oct 29, 2013, at 3:03 PM, bri...@apache.org wrote: > Updated Branches: > refs/heads/master e0e64ba62 -> 086906ae3 > > > Cleaning up build of atscppapi > [snip] > http://git-wip-us.apache.org/repos/asf/trafficserver/blob/086906ae/lib/atscppapi/examples/asyn

Re: question on atscppapi

2013-10-29 Thread Shu Kit Chan
he coming weeks feel free to get started > now and I can help you as you go. > > Brian > > > On Tue, Oct 29, 2013 at 3:31 PM, Shu Kit Chan > wrote: > > > Hi, > > > > I am experimenting to rewrite esi plugin using only atscppapi. > >

Re: question on atscppapi

2013-10-29 Thread Brian Geffon
ree to get started now and I can help you as you go. Brian On Tue, Oct 29, 2013 at 3:31 PM, Shu Kit Chan wrote: > Hi, > > I am experimenting to rewrite esi plugin using only atscppapi. > First bit of feedback - I need to do transformation on response after the > cache_lookup_co

question on atscppapi

2013-10-29 Thread Shu Kit Chan
Hi, I am experimenting to rewrite esi plugin using only atscppapi. First bit of feedback - I need to do transformation on response after the cache_lookup_complete hook. But it isn't available in the api. I look up the source and it should be pretty easy to add it myself. So i think i can s