+1
On Mon, Jun 18, 2018 at 10:09 AM, Alan Carroll <
solidwallofc...@oath.com.invalid> wrote:
> +1
>
> On Mon, Jun 18, 2018 at 10:06 AM, David Calavera <david.calav...@gmail.com
> >
> wrote:
>
> > I noticed that atscppapi::RegisterGlobalPlugin doesn't return any value.
> > This makes impossible for plugins that use to to know whether they need
> to
> > abort initialization or continue after registering the plugin.
> >
> > I'm proposing to change the method signature to return a boolean value,
> so
> > plugins can abort in case of failure.
> >
> > Example:
> >
> > ```
> > void TSPluginInit(int argc, const char *argv[]) {
> > if (!atscppapi::RegisterGlobalPlugin("netlify", "netlify",
> > da...@netlify.com") {
> > return;
> > }
> > }
> > ```
> >
> > I've opened a PullRequest with this change. If this proposal is
> accepted, I
> > can update all examples and plugins with the new behavior in the same
> Pull
> > Request:
> >
> > https://github.com/apache/trafficserver/pull/3846
> >
>
--
Derek
