GitHub user bgaff opened a pull request:
https://github.com/apache/trafficserver/pull/345
TS-4034: Minor atscppapi cleanup
A few things should be cleaned up in atscppapi.
- CaseInsensitiveStringComparitor isn't used internally but it is exposed
in a public API, so because we can't remove it we should change it to use
strcasecmp() under the covers.
- In several places we do:
somestr = std::string(ptr, len);
We should do:
somestr.assign(ptr,len);
- We use c style includes in a few places when we should use the c++
equivalents.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bgaff/trafficserver ts-4034
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/345.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #345
----
commit def017b4b19619497dcc378595494b97cbc9eb27
Author: Brian Geffon <bri...@apache.org>
Date: 2015-11-19T17:57:27Z
TS-4034: Minor atscppapi cleanup
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
