Re: New feature suggestion: ip_category for ip_allow.yaml

2023-11-30 Thread Shu Kit Chan
So for each request, the plugin will be called into action X number of times for X number of categories found? More specifically, If there is a match in a category, it will not call the remaining number of categories to try? (Since I assume the first match will take precedence over the rest?) If t

Re: I don't often eat crow in public.....

2023-11-08 Thread Shu Kit Chan
That's great. I hope we will have a short session to walk us through the cmake changes in the upcoming ATS summit. Thanks. Kit On Wed, Nov 8, 2023 at 7:42 AM Bryan Call wrote: > > Thank you for the feedback. I was hesitant to switch to cmake myself. > However, after using it and noticing how

Re: [API proposal] Adding a third optional argument to TSMgmtUpdateRegister

2023-10-22 Thread Shu Kit Chan
+1 On Sun, Oct 22, 2023 at 5:05 PM Leif Hedstrom wrote: > > I’d like to update the existing API for TSMgmtUpdateRegister(), to add a > third, optional argument: > > > void TSMgmtUpdateRegister(TSCont contp, const char *plugin_name, const char > *plugin_file_name = nullptr); > > > The old behavi

Interests in joining the CC list for oss-fuzz project for ATS

2023-05-16 Thread Shu Kit Chan
Hi, In today's ATS summit, I talked about OSS-fuzz. People who are interested can check out the slides here - https://cwiki.apache.org/confluence/display/TS/Presentations+-+2023 Also if you are interested, you can send me your email address for adding to the CC list for the project - https://gith

Re: Proposed change to TS API: TSHeapBuf

2022-08-31 Thread Shu Kit Chan
Also are we planning to eventually rewrite our existing APIs (where applicable) to use this? On Wed, Aug 31, 2022 at 8:36 AM Masakazu Kitajo wrote: > > What's the advantage of using TSHeapBuf? What issue does it solve? > > > On Wed, Aug 31, 2022 at 7:48 AM Walt Karas > wrote: > > > Described her

Re: [E] Fwd: Lua plugin development - Global Variables

2022-07-14 Thread Shu Kit Chan
I am just trying to understand the impact of doing IO (faster because of > RAM) but still IO. > I tried mapping the file into memory and it sure works but I am concerned > if this cause memory issues down the line. > > Thanks > > > On Thu, Jul 14, 2022 at 1:10 AM Shu Kit C

Re: [E] Fwd: Lua plugin development - Global Variables

2022-07-13 Thread Shu Kit Chan
You can simply use a a global variable in the lua script to store the configuration information And you can initialize that in the __init__ function, which is run at the start of the server. You can see some examples. here - https://docs.trafficserver.apache.org/en/latest/admin-guide/plugins/lua

Re: Lua plugin assertion failure question.

2022-06-28 Thread Shu Kit Chan
leMLocRelease > within each function in ts_lua_server_request.c ( thus doing the > release within the same call-back ) ? > > Thanks, > Peter > > -Original Message- > From: Shu Kit Chan > Sent: Monday, June 22, 2020 10:36 PM > To: dev > Subject: Re: Lua plugin assertion

Re: Question on Lua plugin differences between ATS 7.1.x and ATS 9.x.

2022-03-14 Thread Shu Kit Chan
gt; local t = {} > t[0] = "TEST" > > local FH = io.open("/dev/urandom", "rb") > > if args[1] == nil then > print("Agument required. Usage " .. args[0] .. " ") > return -1 > end > > for i = 1, args[1], 1

Re: Question on Lua plugin differences between ATS 7.1.x and ATS 9.x.

2022-03-12 Thread Shu Kit Chan
Is this a lua script you in plugin.config or remap.config ? Also what method do you use to see if gc is happening or not ? On Fri, Mar 11, 2022 at 1:22 PM CHOU, PETER wrote: > > Hi, > > > > We have quite a few Lua scripts that were written for use with ATS 7.1.4 and > earlier. We are looking to

Re: [DISCUSS] Promote or deprecate experimental API TSHttpTxnCntl()

2021-10-13 Thread Shu Kit Chan
+1 I think the generic way is a good direction as well. Lua plugin supports that initially because long ago i thought that will be used more often. On Wed, Oct 13, 2021 at 10:38 AM Sudheer Vinukonda wrote: > > +1 > I like the generic API direction, and extending it to support other existing >

Re: Selectively Disable HTTP/2

2021-02-26 Thread Shu Kit Chan
eet, thanks. Is this available in 8.1.x or 9.x? > > > On Feb 26, 2021, at 12:16 PM, Shu Kit Chan wrote: > > > > You can disable http/2 per domain - > > https://docs.trafficserver.apache.org/en/latest/admin-guide/files/sni.yaml.en.html > > Check out the option for

Re: Selectively Disable HTTP/2

2021-02-26 Thread Shu Kit Chan
You can disable http/2 per domain - https://docs.trafficserver.apache.org/en/latest/admin-guide/files/sni.yaml.en.html Check out the option for "http2" . Thanks. On Fri, Feb 26, 2021 at 9:07 AM Hongfei Zhang wrote: > > Hi, > > Is there a configurable option to disable http/2 at service (remap) l

Re: Tracing memory leaks in ATS plug-ins

2021-01-22 Thread Shu Kit Chan
Perhaps you can see if this trick can help you? https://cwiki.apache.org/confluence/display/TS/Presentations+-+2017?preview=/70255385/74684709/ATSSummit_jemalloc.pptx Also the experimental memory_profile plugin is using the same trick to help memory debugging as well. Thanks. Kit On Fri, Jan 22

Re: [E] Re: [API] for accessing server session transaction count

2020-11-18 Thread Shu Kit Chan
I don't think this will work. Prior to 9.x , header rewrite plugin supports a fixed set of string substitutions. e.g. %, % But it is never for generic log tag. And i think this style of string substitutions are deprecated after 9.x In fact, I don't think there are APIs for plugin to get these log

Re: [API] for accessing server session transaction count

2020-11-18 Thread Shu Kit Chan
ecision? May be their application framework/platform doesn't allow them to easily get that? On Wed, Nov 18, 2020 at 12:31 PM Shu Kit Chan wrote: > > I think you mean the existing one is TSHttpSsnTransactionCount . Right ? > > > On Wed, Nov 18, 2020 at 12:15 PM Susan Hinric

Re: [API] for accessing server session transaction count

2020-11-18 Thread Shu Kit Chan
I think you mean the existing one is TSHttpSsnTransactionCount . Right ? On Wed, Nov 18, 2020 at 12:15 PM Susan Hinrichs wrote: > > I propose int TSHttpTxnServerSsnTransactionCount(TSHttpTxn txn) as an > addition to the InkAPI. It returns the number of transactions that have > been performed o

Re: Lua plugin assertion failure question.

2020-06-22 Thread Shu Kit Chan
I actually haven't experienced this before for the server request You mentioned in another thread that this may be related to you guys setting open_write_fail_action to 4 in parent layer ? If you can consistently reproduce this, you can perhaps add the protection similar to client response and see

Re: [ANNOUNCE] Apache Traffic Server Fall 2019 Summit

2019-09-30 Thread Shu Kit Chan
Yes. 2nd Floor. Thanks. Kit On Mon, Sep 30, 2019 at 10:23 PM Masakazu Kitajo wrote: > > Which building is SNVC-2? Is it Building C on Google Maps? > > Thanks, > Masakazu > > On Tue, Oct 1, 2019 at 1:29 AM Bryan Call wrote: >> >> The schedule has been created and can be found on the summit page

Re: Lua plugin memory limit on Linux.

2019-06-20 Thread Shu Kit Chan
; ts.debug("Total bytes allocated = " .. count .. " bytes") > ts.debug("Garbage Collector reports = " .. collectgarbage("count") > .. " MB") > end >end > >io.close(FH) > > end > > Thanks, > Pe

Re: Fetching URL contents in a plugin

2019-06-20 Thread Shu Kit Chan
Hopefully this is of help. https://github.com/apache/trafficserver/pull/5639/files#diff-5c2f3297b2a6ac986fbf042017435a6a It illustrates an example of using the Lua script to get the content of a response into variable and print it out. Kit On Thu, Jun 20, 2019 at 5:41 PM Eric Friedrich -X (efri

Re: Lua plugin memory limit on Linux.

2019-06-19 Thread Shu Kit Chan
Thanks for the info. That's good to know. Have you tried how much more you can allocate? And when you are over the limit, what is the message you are getting? Perhaps we can update the doc with this information. Kit On Wed, Jun 19, 2019 at 12:01 PM Chou, Peter wrote: > > Kit, > > Did not hear

Re: [PROPOSAL] Restructuring the example directory and adding lua scripts to it

2019-05-24 Thread Shu Kit Chan
L, Headers, Intercept, Transform etc and then under > each of those, you've C, CPP, LUA etc. > Thoughts? > Thanks, > Sudheer > > On Friday, May 24, 2019, 9:42:28 AM PDT, Shu Kit Chan > wrote: > > Leif made a suggestion on the PR and suggested

Re: [PROPOSAL] Restructuring the example directory and adding lua scripts to it

2019-05-24 Thread Shu Kit Chan
/ reverse/ transparent/ I think it is easier to find the c/c++/lua examples this way as well. Any comments? Kit On Fri, May 24, 2019 at 12:47 AM Shu Kit Chan wrote: > > Here is the PR for this change. > https://github.com/apache/trafficserver/pull/5573 > > Thanks. > >

Re: [PROPOSAL] Restructuring the example directory and adding lua scripts to it

2019-05-24 Thread Shu Kit Chan
Here is the PR for this change. https://github.com/apache/trafficserver/pull/5573 Thanks. Kit On Tue, May 21, 2019 at 12:29 PM Steven R. Feltner wrote: > > +1 > > On 5/21/19, 2:50 AM, "Shu Kit Chan" wrote: > > Notice: This email is from an external sender. &g

[PROPOSAL] Restructuring the example directory and adding lua scripts to it

2019-05-20 Thread Shu Kit Chan
Hi, During the spring summit, we discussed changing the structure example directory to include some lua scripts as well as other future works Here is my proposal - /example/plugins/ - I will move all existing plugin examples underneath here /example/plugins/lua/ - I will put a few lua scripts as

Re: [PROPOSAL] Move from the IRC to Slack

2019-05-10 Thread Shu Kit Chan
+1 On Fri, May 10, 2019 at 4:54 PM Walt Karas wrote: > > +1 > > On Fri, May 10, 2019 at 6:45 PM Bryan Call wrote: >> >> I would like to propose that we move from the IRC to Slack for IM >> communication by June 1st. This is in response to ASF moving to Slack for >> Infra and other channels an

Re: [PROPOSAL] Remove the email feature from Alarms (proxy.config.alarm_email) and cleanup

2019-05-09 Thread Shu Kit Chan
+1 On Thu, May 9, 2019 at 3:23 PM Leif Hedstrom wrote: > > Hi all, > > I’d like to propose that we eliminate the “email” feature out of Alarms. I > think this is misguided, and in reality, could be wrapped into a script if > someone really, really wanted to send emails. We would remove > prox

Re: Questions on tslua plugin and luajit.

2019-05-01 Thread Shu Kit Chan
into a table until out of memory was reported. Hopefully, the > increased > limit translates into the plugin also. > > Thanks, > Peter > > -Original Message- > From: Shu Kit Chan > Sent: Wednesday, May 1, 2019 2:50 AM > To: dev@trafficserver.apache.org > Su

Re: Questions on tslua plugin and luajit.

2019-05-01 Thread Shu Kit Chan
1) Yes. That looks like it. you can try to lower the number of states in your mapping rules. The default is 256. That is the number of lua_State we start with. 2) I am not aware that luajit-2.1.0-beta3 will have any improvement to the memory limit problem. Thanks. Kit On Tue, Apr 30, 2019 at 11

Re: [DISCUSS] ATS Lua scripts "repository"

2019-02-20 Thread Shu Kit Chan
I kept some simple ones in my own repo - https://github.com/shukitchan/ats_lua_scripts They all just try to illustrating ways of doing simple things so others can build on top of it. Totally fine to put them up in a different repo if others think it is useful. Kit On Wed, Feb 20, 2019 at 6:33 PM

Re: [API proposal]: TSHttpSsnIdGet

2018-05-11 Thread Shu Kit Chan
How are we going to use this Id? I don't think any API takes the Ssn Id as argument. Right? Or are you simply just trying to figure out how many txns reuse the ssn ? Thanks. Kit On Fri, May 11, 2018 at 3:42 PM, Alan Carroll wrote: > +1 > > On Fri, May 11, 2018 at 11:08 AM, Zeyuan Yu wrote: >

Re: [PROPOSAL] Plugin promotions to stable

2018-05-07 Thread Shu Kit Chan
+1 for lua. I have just a couple more fixes on ts_lua before I can make a PR to move it out of experimental (and rename it). Kit On Mon, May 7, 2018 at 8:12 AM, Phil Sorber wrote: > On Mon, May 7, 2018 at 5:49 AM Leif Hedstrom wrote: > >> Hi all, >> >> as discussed today, we’d like to propose

Re: API proposal: TSReturnCode TSSslOCSPCallbackSet(TSSslContext ctx)

2018-03-27 Thread Shu Kit Chan
And it would be of great help if we can have a example plugin to illustrate hot this can be used. Thanks. Kit On Tue, Mar 27, 2018 at 1:06 PM, Alan Carroll wrote: > I made some comments on the PR. I would recommend at a minimum having a > reference / link over to where the OCSP callback is desc

Re: ATS Memory Leak?

2018-03-15 Thread Shu Kit Chan
I tried some memory leak debugging with jemalloc before. The experience is mentioned here - https://cwiki.apache.org/confluence/display/TS/Presentations+-+2017?preview=/70255385/74684709/ATSSummit_jemalloc.pptx Perhaps we can then see what components of the code is contributing to the memory buil

Re: Proposed new ts api calls

2018-01-29 Thread Shu Kit Chan
What does the "I" stand for in "TSIRemapFromUrlStringGet" ? On Mon, Jan 29, 2018 at 10:02 AM, Walt Karas wrote: > const char *TSIRemapFromUrlStringGet(const TSHttpTxn txnp); > > const char *TSIRemapToUrlStringGet(const TSHttpTxn txnp); > > These would return, from the transaction state object, >

Re: [API PROPOSAL] TSIpAddrParse

2017-09-14 Thread Shu Kit Chan
Here is the PR for this. https://github.com/apache/trafficserver/pull/2520 Thanks. Kit On Wed, Sep 13, 2017 at 2:55 PM, Shu Kit Chan wrote: > Hi all, > > I would like to see if there is an interest to add a new API to > support parsing IP address into sockaddr. Here is

[API PROPOSAL] TSIpAddrParse

2017-09-13 Thread Shu Kit Chan
Hi all, I would like to see if there is an interest to add a new API to support parsing IP address into sockaddr. Here is the proposed signature. TSReturnCode TSIpAddrParse(const char *str, size_t str_len, sockaddr *addr) This is going to be largely leveraging ats_ip_parse() and ats_ip_pton() in

Re: [PROPOSAL] Formalize requirements of new configuration files (and major changes to existing files)

2017-07-21 Thread Shu Kit Chan
+1 to that. thanks! On Fri, Jul 21, 2017 at 3:59 AM, Leif Hedstrom wrote: > Hi all, > > to avoid further ossification, I’d like to propose the following: > > 1. All new configuration files *must* be done using Lua syntax (with the > appropriate file extension) > > 2. For major changes to an exis

Re: ATS Spring Summit 2017 Slides

2017-05-24 Thread Shu Kit Chan
Would we also have access to the presentation slides from the traffic control summit as well? And can you provide a link to that? or are they going to appear in our cwiki as well? Thanks a lot Kit On Wed, May 24, 2017 at 3:00 PM, Bryan Call wrote: > If you gave a presentation at the ATS Summit

Fwd: Build failed in Jenkins: osx-master » clang,osx,debug #1601

2017-05-22 Thread Shu Kit Chan
I am not too sure why the parent selection regression test fails on osx-master build. Anyone? Kit -- Forwarded message -- From: Date: Mon, May 22, 2017 at 5:17 PM Subject: Build failed in Jenkins: osx-master » clang,osx,debug #1601 To: iss...@trafficserver.apache.org See

Re: Unit Test Framework

2017-05-20 Thread Shu Kit Chan
For 1), We have a long standing PR to add a unit test framework for C++ plugins. We also wrote tests for the webp transform plugin using that framework. We can revisit this and see if this is a good starting point. https://github.com/apache/trafficserver/pull/408 We still need a good unit test fra

Re: Naming conventions for "lua" style configuration files

2017-02-28 Thread Shu Kit Chan
It looks like .luaconf is the winner. I will also be creating new issues for changing the existing logging.config and metrics.config accordingly. Thanks. Kit On Mon, Feb 27, 2017 at 8:17 AM, Shu Kit Chan wrote: > The reasoning is like this. As we make more changes for other > configu

Re: Naming conventions for "lua" style configuration files

2017-02-27 Thread Shu Kit Chan
at 10:35 PM, Shu Kit Chan wrote: >> >> Hi, >> >> We had recently converted the the custom log and metrics configuration >> files to lua (in 7.0.0 and 6.2.0 release respectively). In doing so, >> we came up with new configuration file names as well. i.e >&g

Naming conventions for "lua" style configuration files

2017-02-26 Thread Shu Kit Chan
Hi, We had recently converted the the custom log and metrics configuration files to lua (in 7.0.0 and 6.2.0 release respectively). In doing so, we came up with new configuration file names as well. i.e logging.config and metrics.config , respectively. We are now trying to come up with a better su

Re: TS LUA Plugin

2017-02-05 Thread Shu Kit Chan
math library or using some value from the > ts.client_request. > > Does that sound right? > > Also, if you have advice on specific tips for organizing scripts (1 hook per > file or something like that) I would appreciate hearing it > > —Eric > >> On Feb 1, 2017, at

Re: TS LUA Plugin

2017-02-01 Thread Shu Kit Chan
Please feel free to ping me or the dev mailing list for questions on the ts- lua plugin It is very good and easy for making quick fixes to manipulate headers and target origin url. Performance is ok and it is quite stable and I think lots of people are using it in production. For more complicated

Re: How to perform a side HTTP request as part of plugin

2017-01-22 Thread Shu Kit Chan
You can check out background fetch plugin - https://github.com/apache/trafficserver/tree/master/plugins/background_fetch and see how to do similar thing with the TSHttpConnect API You can also check out FetchSM and the corresponding TSFetch* APIs as well - https://github.com/apache/trafficserver/

Re: ts_lua ts.fetch has very bad performance

2016-12-22 Thread Shu Kit Chan
hanks, > Di Li > > > > >> On Dec 22, 2016, at 10:00 AM, Shu Kit Chan wrote: >> >> One thing I can think of is that you may be calling ts.fetch() >> unconditionally. We need to check if it is an internal request first. >> If it is, it is likely don

Re: ts_lua ts.fetch has very bad performance

2016-12-22 Thread Shu Kit Chan
situation and severely affect performance. But if you have taken care of that already, pls share your script with you so I can take a closer look. Thanks. On Thu, Dec 22, 2016 at 9:48 AM, Shu Kit Chan wrote: > Can you share your lua script in full with me? > > Thanks. > > Kit >

Re: ts_lua ts.fetch has very bad performance

2016-12-22 Thread Shu Kit Chan
Can you share your lua script in full with me? Thanks. Kit On Thu, Dec 22, 2016 at 1:30 AM, Di Li wrote: > Hey Guys, > > Running 6.2.0 with cherry pick of TS-4497 to make the ts.fetch work, > otherwise it won’t even function. > > The performance came back with very terrible results, not sure t

Re: ts-lua questions

2016-12-09 Thread Shu Kit Chan
a local redis way, but if I have to call the local redis > for every single request, it probably won’t scale ? > > Thanks, > Di Li > > > > > > On Dec 9, 2016, at 3:20 PM, Shu Kit Chan wrote: > > Yeah. That's right. It won't work the way you intended. >

Re: ts-lua questions

2016-12-09 Thread Shu Kit Chan
a table, and if > I update it by local calls from 127.0.0.1 and update that control_data > table, does the following requests check the control_data with new data or > still the initialized data by init ? > > 2. ts.fetch’s context is after_do_remap, you mentioned that yesterday, I >

Re: ts-lua questions

2016-12-08 Thread Shu Kit Chan
1) No. you don't need to do anything in txn close hook. 2) See the example in the documentation. I think we can definitely improve the text a bit. What it means is that you need to add a hook inside do_remap and ts.schedule() can only be called inside that hook function. It is similar to https://d

Re: performance problem with traffic server 6.2

2016-09-09 Thread Shu Kit Chan
Is there any plugins you are using? On Fri, Sep 9, 2016 at 10:10 AM, Siddharth Agarwal wrote: > Hi, > > We are on the traffic server 6.2 release. We are experiencing performance > issues with this release and have enabled slow request logging. Our health > check end point sometimes is taking taki

Re: TS-4724 & PR-859 : To remove host name from GET request send to next-tier

2016-08-19 Thread Shu Kit Chan
Or another way to put it - can we achieve this with existing C APIs? If yes, then we can put that in a lua API. Thanks. Kit On Fri, Aug 19, 2016 at 8:07 AM, James Peach wrote: > >> On Aug 15, 2016, at 10:50 AM, BONUMAHANTI, RAJENDRA KISHORE >> wrote: >> >> Hi, >> >> I have added a new API "TS

Re: [v6.0.0] Experimental Plugins -> Stable

2015-04-24 Thread Shu Kit Chan
That's true. Me and portl4t are still having plans for a few more substantial additions to the plugin in the upcoming weeks. I do want to try making it to the "stable" for 6.0.0. Will work on those additions soon and then shoot for sending an email out for a API review with hopefully substantial e

Re: Adding Gzip/Gunzip feature in ATS core

2015-03-23 Thread Shu Kit Chan
ESI should handle these situations correctly. e.g. it won't gzip the response if it is already gzipped. So it works fine in a standalone way. The problems begin when we starts to chain a few of these standalone transformation plugins together. Each of them will try to do the right thing when they

Re: Req. Info - ts_lua

2015-02-10 Thread Shu Kit Chan
riginal Message----- > From: Shu Kit Chan [mailto:chanshu...@gmail.com] > Sent: venerdì 28 novembre 2014 21:33 > To: dev@trafficserver.apache.org > Subject: Re: Req. Info - ts_lua > > Hi, > > It is not. There are a couple people (including me) working on it. > We have a few fi

Re: Req. Info - ts_lua

2014-12-05 Thread Shu Kit Chan
Here is a small example of using ts_lua as a global plugin. please make sure you a line of "tslua.so /home/kichan/main.lua" in plugin.config and the content of main.lua is as below. ts.add_package_cpath('/home/kichan/lib/?.so') ts.add_package_path('/home/kichan/lualib/?.lua;/home/kichan/lualib/soc

Re: Req. Info - ts_lua

2014-12-05 Thread Shu Kit Chan
Also we need to be careful in these use cases as well since the thread can be blocked by the usage of the resource if we are not careful. And perfomrnace will be affected. Thanks. Kit On Fri, Dec 5, 2014 at 10:14 AM, Shu Kit Chan wrote: > I tried LuaSocket and redis-lua and I was able

Re: Req. Info - ts_lua

2014-12-05 Thread Shu Kit Chan
I tried LuaSocket and redis-lua and I was able to define the client/resources globally and use it inside the hooks. But if you encounter any strange things, please feel free to answer us questions here. Also I have filed TS-3224 and TS-3225 for the fix and enhancement I am planning to commit soon.

Re: Req. Info - ts_lua

2014-11-28 Thread Shu Kit Chan
Hi, It is not. There are a couple people (including me) working on it. We have a few fixes and expansions coming up soon. But anyway, there is also a "Lua" Component in jira that you can file tickets against. Also please feel free to ask questions in this mailing list and one of us will try our b

Re: stale-while-revalidate not always serving stale content

2014-10-09 Thread Shu Kit Chan
It seems to be similar to this jira ticket - https://issues.apache.org/jira/browse/TS-1463 Kit On Thu, Oct 9, 2014 at 3:53 PM, Jared Ocker wrote: > We have the stale-while-revalidate plugin in place and have noticed some > behavior that seems suboptimal. While cache is fresh, everything works

Re: header-rewrite change

2014-08-21 Thread Shu Kit Chan
Yes. We have similar requirements than you, Manjesh. And we implemented our own plugin, too. But we are considering to rewrite that in lua. On Thu, Aug 21, 2014 at 12:35 PM, Leif Hedstrom wrote: > > On Aug 21, 2014, at 1:27 PM, Manjesh Nilange > wrote: > > > Anybody got $0.02? :-) > > > Sounds

Re: ATS 5.0.0 issue with TSHttpConnect

2014-06-25 Thread Shu Kit Chan
On second thought, the patch may not actually help you. But I think that is definitely related to the changes to FetchSM in ATS 5.0.0 On Wed, Jun 25, 2014 at 5:28 PM, Shu Kit Chan wrote: > That may be related to TS-2889 > https://issues.apache.org/jira/browse/TS-2889 > > Perhaps yo

Re: ATS 5.0.0 issue with TSHttpConnect

2014-06-25 Thread Shu Kit Chan
That may be related to TS-2889 https://issues.apache.org/jira/browse/TS-2889 Perhaps you can see if applying the patch will help your case or not. Thanks. Kit On Wed, Jun 25, 2014 at 3:07 PM, Walsh, Peter wrote: > Hello, > I just upgraded from 4.2.1 to ATS 5.0.0 but am having issues in my pl

Re: [VOTE] Release Apache Traffic Server 5.0.0 (RC0)

2014-06-17 Thread Shu Kit Chan
+1 Compiled and tested the ts_lua plugin specifically with and without --disable-luajit on Mac OS X On Mon, Jun 16, 2014 at 7:30 PM, Bryan Call wrote: > +1 > > -Bryan > > > On Jun 15, 2014, at 2:50 PM, Bryan Call > wrote: > > I have updated 5.0.0 with a new release candidate (RC2) and we will

Re: git commit: TS-2555: add more hook support for ts_lua plugin

2014-05-21 Thread Shu Kit Chan
I agree that global functions for hooks is ugly. I can add similar thing as the lua plugin and allow registering hooks outside of global functions before 5.0.0 release. Quehan also has a patch with the idea of using the return value of the registered function of hooks to control the reenabling of

deprecating the old lua plugin

2014-05-20 Thread Shu Kit Chan
Hi, The ts_lua plugin is now supporting almost all features of the old lua plugin except for the support of the Session hooks. For more information on the ts_lua plugin, please read the full list of features here - http://trafficserver.readthedocs.org/en/latest/reference/plugins/ts_lua.en.html I

Re: git commit: TS-2555: updates to share lua context across hook invocations and only add global hooks if corresponding lua functions exist

2014-05-05 Thread Shu Kit Chan
>>> How is it OK to reset the continuation data on a global continuation on each request? Other requests that are in flight are going to get their lua_State switched out from under them. What prevent multiple threads knocking on the same lua_State? Yeah. I was thinking about this a bit and this pr

Re: git commit: TS-2555 add global plugin support for ts_lua plugin

2014-04-17 Thread Shu Kit Chan
I will take some time to refine this over the weekend. Thanks. On Wed, Apr 16, 2014 at 7:19 PM, 李刚(阙寒) wrote: > Maybe we can use the same lua_States in both remap and global plugins. > > 在 2014-4-17,上午12:03,James Peach 写道: > > > On Apr 15, 2014, at 10:34 PM, kic...@apache.org wrote: > > > >> R

deprecating some experimental plugins

2014-04-16 Thread Shu Kit Chan
Hi, There are a few experimental plugins that I think should be deprecated. e.g The lua plugin should be deprecated in favor of the newer ts_lua plugin. The same can be said for the stale_while_revalidate in favor of the newer rfc5861 plugin. During the recent summit in denver we also talked about

Re: git commit: TS-2579: remove ipv4 limit on FetchSM and TSFetchUrl/TSFetchPages

2014-02-26 Thread Shu Kit Chan
>> > >>>> On Feb 26, 2014, at 4:04 PM, James Peach wrote: > >>>> > >>>> On Feb 26, 2014, at 10:19 AM, Shu Kit Chan > >> wrote: > >>>> > >>>> Just curious. Which plugins are using TSHttpConnect incorre

Re: git commit: TS-2579: remove ipv4 limit on FetchSM and TSFetchUrl/TSFetchPages

2014-02-26 Thread Shu Kit Chan
ct to, and all my plugins are > written like that :( > > > > > Brian > > > > On Sunday, February 23, 2014, Shu Kit Chan wrote: > > > >> ESI plugin unfortunately still uses TSFetchUrl and therefore cannot > handle > >> ipv6 client addresses.

Re: git commit: TS-2579: remove ipv4 limit on FetchSM and TSFetchUrl/TSFetchPages

2014-02-23 Thread Shu Kit Chan
ESI plugin unfortunately still uses TSFetchUrl and therefore cannot handle ipv6 client addresses. On Sun, Feb 23, 2014 at 8:19 AM, James Peach wrote: > On Feb 20, 2014, at 2:43 PM, kic...@apache.org wrote: > > > Repository: trafficserver > > Updated Branches: > > refs/heads/master d3e4614bf ->

FetchSM and TSFetchURL/TSFetchPages api ipv4 only?

2014-02-20 Thread Shu Kit Chan
Hi, I find that FetchSM and TSFetchURL/TSFetchPages api are limited to ipv4 only. But I don't think it is really needed. Is there any hidden reasons why they cannot support ipv6 as well? FYI, I also file a JIRA for it. https://issues.apache.org/jira/browse/TS-2579 Thanks. Kit

Re: [API Review] Add TSHttpTxnIsCacheable()

2014-02-06 Thread Shu Kit Chan
so for example, this API will honor settings in records.config, e,g, proxy.config.http.cache.cache_responses_to_cookies proxy.config.http.negative_caching_enabled and tell us whether it is cacheable or not. Right? That should be useful. +1 On Wed, Feb 5, 2014 at 3:01 PM, Leif Hedstrom wrot

Re: TDD/Unit testing ATS plugins

2014-01-10 Thread Shu Kit Chan
That's just unit tests for utilities and helper classes for the plugin. I also want a stub library, too, for writing unit tests for plugin. On Fri, Jan 10, 2014 at 10:59 AM, James Peach wrote: > On Jan 3, 2014, at 8:48 AM, Alan D. Cabrera wrote: > > > > > On Jan 2, 2014, at 9:04 AM, James Peac

Re: experimental/lua vs experimental/ts_lua

2013-12-17 Thread Shu Kit Chan
Hi, For months, I have been trying to look for better ways to write simple plugins. And so the existing experimental/lua is a good starting point. But upon further investigation, it is really experimental and with not much features. I think it is more a skeleton code for us to add on. About a few

Re: [2/2] git commit: TS-2335: Putting Alibaba Lua plugin into experimental

2013-12-03 Thread Shu Kit Chan
Yeah. I can see there are some mistakes. Will fix that today. On Tue, Dec 3, 2013 at 11:40 AM, James Peach wrote: > On Nov 27, 2013, at 1:11 AM, kic...@apache.org wrote: > > > TS-2335: Putting Alibaba Lua plugin into experimental > > This is breaking the build on a number of platforms: > > > ht

Re: git commit: TS-2335: adding README.md to ts_lua plugin directory

2013-11-28 Thread Shu Kit Chan
Agreed. will add it there. On Wed, Nov 27, 2013 at 1:57 AM, Igor Galić wrote: > > > - Original Message - > > Updated Branches: > > refs/heads/master ebd4f5a20 -> 0cb47fa4a > > > > > > TS-2335: adding README.md to ts_lua plugin directory > > This README would serve everyone better as >

Re: Lua Plugin from Alibaba

2013-11-08 Thread Shu Kit Chan
2:26 AM, Shu Kit Chan wrote: > +1 > > That's great news. > In my brief experiments with both lua plugins, i think the alibaba one is > more feature rich, even supporting intercepts and transforms. I recommend > starting with it and add features that the other ones has, su

Re: Lua Plugin from Alibaba

2013-11-08 Thread Shu Kit Chan
: > > > > > > I'm portl4t from Alibaba, and I feel free to put ts-lua to > /experimental/ > > > directory, it is my honor. > > > > > > 在 2013-11-8,上午12:30,Shu Kit Chan < chanshu...@gmail.com > 写道: > > > > > > > P

Fwd: Lua Plugin from Alibaba

2013-11-07 Thread Shu Kit Chan
Posting to dev and hope there will be some responses from alibaba engineers. -- Forwarded message -- From: James Peach Date: Wed, Nov 6, 2013 at 10:24 AM Subject: Re: Lua Plugin from Alibaba To: us...@trafficserver.apache.org On Nov 5, 2013, at 11:16 PM, Shu Kit Chan wrote

Re: question on atscppapi

2013-10-29 Thread Shu Kit Chan
he coming weeks feel free to get started > now and I can help you as you go. > > Brian > > > On Tue, Oct 29, 2013 at 3:31 PM, Shu Kit Chan > wrote: > > > Hi, > > > > I am experimenting to rewrite esi plugin using only atscppapi. > >

question on atscppapi

2013-10-29 Thread Shu Kit Chan
Hi, I am experimenting to rewrite esi plugin using only atscppapi. First bit of feedback - I need to do transformation on response after the cache_lookup_complete hook. But it isn't available in the api. I look up the source and it should be pretty easy to add it myself. So i think i can submit a

Re: Experimental Plugins

2013-09-24 Thread Shu Kit Chan
buffer_upload will also be used in production in Yahoo! soon. Thanks. Kit On Mon, Sep 23, 2013 at 3:05 PM, James Peach wrote: > On Sep 20, 2013, at 2:27 PM, Theo Schlossnagle wrote: > > > experimental is experimental. No restrictions. Innovation comes more > > cheaply when breaking the rule

Re: Yahoo! and Apache Traffic Server

2013-08-20 Thread Shu Kit Chan
Yes. It is indeed a great day. I am looking forward to having more collaborations together. On Tue, Aug 20, 2013 at 9:25 AM, Yongming Zhao wrote: > that is really great news, many thanks for making this happen. > > thanks for the trust, let us work together to make ATS better, for the > future.

Re: esi processor test

2013-05-06 Thread Shu Kit Chan
Basically there is a construct called "special-include" and test 35 is testing that in line 771 for processor_test.cc The "stub" value for "handler" attribute specifies that StubIncludeHandler.cc in the "test" directory should be used. There seems to be some changes around Makefile.am that drops St

Re: [ANNOUNCE] Apache Traffic Server Barcamp/hackathon 5/1/2013 in Mountain View, CA

2013-04-25 Thread Shu Kit Chan
I would also like to drop by and join after 2:30pm. Thanks. Kit On Thu, Apr 25, 2013 at 8:13 AM, vijay mamidi wrote: > I will be in after 2 PM > > > On Tue, Apr 23, 2013 at 2:14 PM, Leif Hedstrom wrote: > > > Hi all, > > > > With short notice, the fine people at LinkedIn have gracefully offer

Re: Questions on rfc5861/stale-while-revalidate experimental plugin

2012-09-12 Thread Shu Kit Chan
t;> On Wed, Sep 12, 2012 at 8:48 PM, Shu Kit Chan wrote: >>> Some updates for #1 after some more debugging. >>> >>> I was wrong on cache URL being locked. There is no lock or connection >>> collapse yet. Those subsequent requests for the same resources are >>

Re: Questions on rfc5861/stale-while-revalidate experimental plugin

2012-09-12 Thread Shu Kit Chan
response for these subsequent requests before the origin responds. Thanks Kit On Wed, Sep 12, 2012 at 9:31 AM, Shu Kit Chan wrote: > Hi, > > I am trying this plugin out > (https://github.com/apache/trafficserver/tree/master/plugins/experimental/rfc5861) > and I have a few concer

Questions on rfc5861/stale-while-revalidate experimental plugin

2012-09-12 Thread Shu Kit Chan
Hi, I am trying this plugin out (https://github.com/apache/trafficserver/tree/master/plugins/experimental/rfc5861) and I have a few concerns 1) Let's assume that my origin server becomes slow and takes 10 seconds to respond after a while. Initially the origin server response is fast and cachable

header_filter plugin

2012-06-12 Thread Shu Kit Chan
Hi, Using header_filter plugin, I can add or replace header to the request/response. However, I find it often useful to add/replace header based on some conditions. I know we can attach the plugin to the mapping rules that we want in remap.config and therefore giving us the ability to add/replace

Re: ESI Plugin

2012-05-06 Thread Shu Kit Chan
ecently fixed ESI in trunk (3.1.x), have you > by any chance taken a look at the fixes there? > > Thanks for the contribution. > > Brian > > > On May 6, 2012, at 12:12 AM, Shu Kit Chan wrote: > >> Hi, >> >> Is the current ESI plugin actually working? I s

ESI Plugin

2012-05-06 Thread Shu Kit Chan
Hi, Is the current ESI plugin actually working? I saw TS 1103 and it is closed so I thought it is working. When I tried to compile it and make it work with traffic server 3.0.4, I got some problems. Even when i manage to compile it, the runtime is not actually working, too. So i decided to try to