Just curious. Which plugins are using TSHttpConnect incorrectly as you indicated? should we have jira open to fix them?
On Sun, Feb 23, 2014 at 3:02 PM, James Peach <jpe...@apache.org> wrote: > On Feb 23, 2014, at 10:47 AM, Brian Geffon <bri...@apache.org> wrote: > > > Doesn't the http connect parse headers anyway? > > Yep > > > Isn't the address only used for local host proxying? > > local host proxying? I followed the code a little way and I thought that > it is the address the connection was accepted on? I used to think that this > was supposed to the the address you connect to, and all my plugins are > written like that :( > > > > > Brian > > > > On Sunday, February 23, 2014, Shu Kit Chan <chanshu...@gmail.com> wrote: > > > >> ESI plugin unfortunately still uses TSFetchUrl and therefore cannot > handle > >> ipv6 client addresses. > >> > >> > >> On Sun, Feb 23, 2014 at 8:19 AM, James Peach <jpe...@apache.org> wrote: > >> > >>> On Feb 20, 2014, at 2:43 PM, kic...@apache.org wrote: > >>> > >>>> Repository: trafficserver > >>>> Updated Branches: > >>>> refs/heads/master d3e4614bf -> d94a47ba8 > >>>> > >>>> > >>>> TS-2579: remove ipv4 limit on FetchSM and TSFetchUrl/TSFetchPages > >>> > >>> What's the use case for this fix? One thing I just noticed is that all > my > >>> code that calls TSHttpConnect uses the wrong IP address :( > >>> > >>>> > >>>> > >>>> Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo > >>>> Commit: > >>> http://git-wip-us.apache.org/repos/asf/trafficserver/commit/d94a47ba > >>>> Tree: > >> http://git-wip-us.apache.org/repos/asf/trafficserver/tree/d94a47ba > >>>> Diff: > >> http://git-wip-us.apache.org/repos/asf/trafficserver/diff/d94a47ba > >>>> > >>>> Branch: refs/heads/master > >>>> Commit: d94a47ba85cad73ebbc0e35b31baaa88279fe5c9 > >>>> Parents: d3e4614 > >>>> Author: Kit Chan <kic...@apache.org> > >>>> Authored: Thu Feb 20 22:42:30 2014 +0000 > >>>> Committer: Kit Chan <kic...@apache.org> > >>>> Committed: Thu Feb 20 22:42:30 2014 +0000 > >>>> > >>>> ---------------------------------------------------------------------- > >>>> CHANGES | 2 ++ > >>>> proxy/FetchSM.cc | 4 +--- > >>>> proxy/FetchSM.h | 8 +++----- > >>>> proxy/InkAPI.cc | 9 ++------- > >>>> 4 files changed, 8 insertions(+), 15 deletions(-) > >>>> ---------------------------------------------------------------------- > >>>> > >>>> > >>>> > >>> > >> > http://git-wip-us.apache.org/repos/asf/trafficserver/blob/d94a47ba/CHANGES > >>>> ---------------------------------------------------------------------- > >>>> diff --git a/CHANGES b/CHANGES > >>>> index 90db4ec..e33e4b9 100644 > >>>> --- a/CHANGES > >>>> +++ b/CHANGES > >>>> @@ -1,6 +1,8 @@ > >>>> -*- coding: > >> utf-8 > >>> -*- > >>>> Changes with Apache Traffic Server 5.0.0 > >>>> > >>>> + *) [TS-2579] Remove ipv4 limit for FetchSM and > >>> TSFetchUrl/TSFetchPages. > >>>> + > >>>> *) [TS-1893] Add more options to server session control. > >>>> > >>>> *) [TS-2239] Initial ALPN TLS extension support. > >>>> > >>>> > >>> > >> > http://git-wip-us.apache.org/repos/asf/trafficserver/blob/d94a47ba/proxy/FetchSM.cc > >>>> ---------------------------------------------------------------------- > >>>> diff --git a/proxy/FetchSM.cc b/proxy/FetchSM.cc > >>>> index 36a6547..a0c70f7 100644 > >>>> --- a/proxy/FetchSM.cc > >>>> +++ b/proxy/FetchSM.cc > >>>> @@ -52,9 +52,7 @@ void > >>>> FetchSM::httpConnect() > >>>> { > >>>> Debug(DEBUG_TAG, "[%s] calling httpconnect write", __FUNCTION__); > >>>> - sockaddr_in addr; > >>>> - ats_ip4_set(&addr, _ip, _port); > >>>> - http_vc = TSHttpConnect(ats_ip_sa_cast(&addr)); > >>>> + http_vc = TSHttpConnect(_addr); > >>>> > >>>> PluginVC *vc = (PluginVC *) http_vc; > >>>> > >>>> > >>>> > >>> > >> > http://git-wip-us.apache.org/repos/asf/trafficserver/blob/d94a47ba/proxy/FetchSM.h > >>>> ------------------------------< > >
