[GitHub] trafficserver issue #720: TS-4560: Fix C++ API shared_ptr detection.

2016-06-16 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/720 > we should do the same with all the ink config stuff rather than including ink_config I'm not sure what you mean by this. This patch is removing {{ink_autoconf.h}} from the public C++

[GitHub] trafficserver issue #697: TS-4510: support multiple header with same name

2016-06-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/697 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/297/ for details. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] trafficserver pull request #697: TS-4510: support multiple header with same ...

2016-06-16 Thread shukitchan
Github user shukitchan closed the pull request at: https://github.com/apache/trafficserver/pull/697 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] trafficserver issue #692: [TS-4500] add cookie-rewrite functionality into he...

2016-06-16 Thread zizhong
Github user zizhong commented on the issue: https://github.com/apache/trafficserver/pull/692 The original name for this operator is exactly set-cookie. However, Brain was worried about the name could be confusing with **set-cookie** in HTTP headers. --- If your project is set up for

[GitHub] trafficserver issue #719: TS-4551: remove OS_TYPE restriction in gunzip and ...

2016-06-16 Thread shukitchan
Github user shukitchan commented on the issue: https://github.com/apache/trafficserver/pull/719 yeah. just checked. it is only built at "make check" time. merging now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] trafficserver pull request #719: TS-4551: remove OS_TYPE restriction in gunz...

2016-06-16 Thread shukitchan
Github user shukitchan closed the pull request at: https://github.com/apache/trafficserver/pull/719 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] trafficserver issue #720: TS-4560: Fix C++ API shared_ptr detection.

2016-06-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/720 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/188/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #720: TS-4560: Fix C++ API shared_ptr detection.

2016-06-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/720 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/296/ for details. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] trafficserver issue #720: TS-4560: Fix C++ API shared_ptr detection.

2016-06-16 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/720 Not sure why the FreeBSD build failed, trying again. [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] trafficserver issue #720: TS-4560: Fix C++ API shared_ptr detection.

2016-06-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/720 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/187/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #720: TS-4560: Fix C++ API shared_ptr detection.

2016-06-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/720 FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/295/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #720: TS-4560: Fix C++ API shared_ptr detection.

2016-06-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/720 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/186/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #705: TS-4100: Remove custom XML metrics.

2016-06-16 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/705 Ok, [TS-4119](https://issues.apache.org/jira/browse/TS-4119) is fixed. How do people feel about landing this? Please read my upgrade comments above :) --- If your project is set up for it, you

[GitHub] trafficserver issue #720: TS-4560: Fix C++ API shared_ptr detection.

2016-06-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/720 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/294/ for details. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] trafficserver pull request #720: TS-4560: Fix C++ API shared_ptr detection.

2016-06-16 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/720 TS-4560: Fix C++ API shared_ptr detection. Since ink_autoconf.h is not installed, we can't use it to figure out which shared_ptr implementation to use. Further, Traffic Server might not

[GitHub] trafficserver issue #720: TS-4560: Fix C++ API shared_ptr detection.

2016-06-16 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/720 Ping @bgaff @SolidWallOfCode --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver pull request #666: TS-4377: update documentation links in defa...

2016-06-16 Thread jsime
Github user jsime closed the pull request at: https://github.com/apache/trafficserver/pull/666 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

Re: [PROPOSAL] One more clang-format change for 7.0.0

2016-06-16 Thread Leif Hedstrom
> On Jun 16, 2016, at 3:04 PM, Leif Hedstrom wrote: > > Hi all, > > James and I would like to make this small, but powerful, change to > clang-format: > > -AlignConsecutiveAssignments: false >+AlignConsecutiveAssignments: true > > > This will try to align assignments such that

[PROPOSAL] One more clang-format change for 7.0.0

2016-06-16 Thread Leif Hedstrom
Hi all, James and I would like to make this small, but powerful, change to clang-format: -AlignConsecutiveAssignments: false +AlignConsecutiveAssignments: true This will try to align assignments such that the = signs line up. E.g. enum { XHEADER_X_CACHE_KEY = 0x0004u, XHEA

Re: [DISCUSS] Relax minimum OS version requirements ?

2016-06-16 Thread Phil Sorber
With my developer hat on, I'm +1 on this for 7.0.0. I cringe a little with my ops hat on and +0 there. Would love to get more feedback from users on this. On Thu, Jun 16, 2016 at 2:47 PM Leif Hedstrom wrote: > > > On Jun 16, 2016, at 2:30 PM, James Peach wrote: > > > > > >> On Jun 16, 2016, at

Re: [DISCUSS] Relax minimum OS version requirements ?

2016-06-16 Thread Leif Hedstrom
> On Jun 16, 2016, at 2:30 PM, James Peach wrote: > > >> On Jun 16, 2016, at 12:25 PM, Alan Carroll >> wrote: >> >> "This is not a reason to go nuts and use every damn C++11 and STL feature >> there is" >> >> Exactly. One doesn't need a reason for that. >> >> Yes, I think we should move t

TS-4523: Add the ability to pause/resume data consumption in the CPP API

2016-06-16 Thread David Ben Zakai
Hi all, I'd like to suggest an API change in the CPP API Transformation interface. My own use case is that I'd like to be able to pause the transformation, handle what I can from the file and release the buffered content before resuming and releasing the rest of the data. Basically what I'm tryin

Re: [DISCUSS] Relax minimum OS version requirements ?

2016-06-16 Thread James Peach
> On Jun 16, 2016, at 12:25 PM, Alan Carroll > wrote: > > "This is not a reason to go nuts and use every damn C++11 and STL feature > there is" > > Exactly. One doesn't need a reason for that. > > Yes, I think we should move this up. Two feature at least that I think would > help making the

[GitHub] trafficserver issue #697: TS-4510: support multiple header with same name

2016-06-16 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/697 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver issue #712: TS-4523

2016-06-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/712 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/293/ for details. --- If your project is set up for it, you can reply to this email and have your r

Re: [DISCUSS] Relax minimum OS version requirements ?

2016-06-16 Thread Alan Carroll
"This is not a reason to go nuts and use every damn C++11 and STL feature there is" Exactly. One doesn't need a reason for that. Yes, I think we should move this up. Two feature at least that I think would help making the code cleaner are "auto" and lambdas. For the latter there is no shortage

[GitHub] trafficserver issue #712: TS-4523

2016-06-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/712 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/185/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #712: TS-4523

2016-06-16 Thread ushachar
Github user ushachar commented on the issue: https://github.com/apache/trafficserver/pull/712 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] trafficserver issue #692: [TS-4500] add cookie-rewrite functionality into he...

2016-06-16 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/692 Looks good. One more thing, didn't think about it last time: The update-cookie, will that work if the cookie doesn't already exist? If so, can we call it set-cookie instead? This is in line with

RE: [DISCUSS] Relax minimum OS version requirements ?

2016-06-16 Thread Schmerge, John (Contractor)
Hi Leif, Small correction for you; devtoolset-2 packages GCC 4.8.2, not 4.8.1 for RH/Centos 6… -John From: Leif Hedstrom [mailto:zw...@apache.org] Sent: Thursday, June 16, 2016 1:53 PM To: ; us...@trafficserver.apache.org Subject: [DISCUSS] Relax minimum OS version requirements ? Hi, [Tldr; W

[DISCUSS] Relax minimum OS version requirements ?

2016-06-16 Thread Leif Hedstrom
Hi, [Tldr; We bump the minimum supported version to CentOS7/RHEL7, or, CentOS6/RHEL6 + devtools-2 compilers.] Today, our minimum run- and build-time requirements are based on a simple criteria: Whatever comes with CentOS / RHEL v6.x. This dictates: * openssl-1.0.1e * gcc-4.4.7

[GitHub] trafficserver issue #692: [TS-4500] add cookie-rewrite functionality into he...

2016-06-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/692 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/292/ for details. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] trafficserver issue #692: [TS-4500] add cookie-rewrite functionality into he...

2016-06-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/692 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/184/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #697: TS-4510: support multiple header with same name

2016-06-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/697 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/291/ for details. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] trafficserver issue #697: TS-4510: support multiple header with same name

2016-06-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/697 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/183/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #719: TS-4551: remove OS_TYPE restriction in gunzip and ...

2016-06-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/719 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/290/ for details. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] trafficserver issue #719: TS-4551: remove OS_TYPE restriction in gunzip and ...

2016-06-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/719 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/182/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #692: [TS-4500] add cookie-rewrite functionality into he...

2016-06-16 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/692 Great, will take a look in a little bit, first CI build tests though [approve ci]. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] trafficserver issue #697: TS-4510: support multiple header with same name

2016-06-16 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/697 Git messed up, manual build [approve ci]. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] trafficserver issue #719: TS-4551: remove OS_TYPE restriction in gunzip and ...

2016-06-16 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/719 I think it looks reasonable. Can you verify that the test programs are only built at "make check" time? We've had an issue with that with H2 tests, and want to make sure it doesn't happen here.

[GitHub] trafficserver issue #719: TS-4551: remove OS_TYPE restriction in gunzip and ...

2016-06-16 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/719 Git messed up again, starting manually [approve ci]. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver issue #719: TS-4551: remove OS_TYPE restriction in gunzip and ...

2016-06-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/719 FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/289/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver pull request #719: TS-4551: remove OS_TYPE restriction in gunz...

2016-06-16 Thread shukitchan
GitHub user shukitchan opened a pull request: https://github.com/apache/trafficserver/pull/719 TS-4551: remove OS_TYPE restriction in gunzip and add unit test @zwoop can you please take a quick look and review? Thanks. You can merge this pull request into a Git repository by running

[GitHub] trafficserver issue #719: TS-4551: remove OS_TYPE restriction in gunzip and ...

2016-06-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/719 Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/181/ for details. --- If your project is set up for it, you can reply to this email and have your reply app