[PROPOSAL] One more clang-format change for 7.0.0

[Leif Hedstrom]

Hi all,

James and I would like to make this small, but powerful, change to clang-format:

        -AlignConsecutiveAssignments: false
        +AlignConsecutiveAssignments: true


This will try to align assignments such that the = signs line up. E.g.

enum {
  XHEADER_X_CACHE_KEY  = 0x0004u,
  XHEADER_X_MILESTONES = 0x0008u,
  XHEADER_X_CACHE      = 0x0010u,
  XHEADER_X_GENERATION = 0x0020u,
  XHEADER_X_TXN_UUID   = 0x0040u,
};

This is a pretty significant change (about 12k lines in 650 files), but I think 
it’s worth it. And again, since we have clang-format, getting your old branches 
up to this new indentation is easy, just temporarily copy over the new 
.clang-format, and re-run “make clang-format", and voila, you are up-to-date 
with master as far as formatting goes.

Please voice concerns with this now. To make the LTS release manageable and 
easy, we’d also back port this to the next RC1 for v6.2.0. I have spoken with 
He-Who-Shall-Make-All-LTS-Releases, and he’s +1 on this idea as well.

Cheers,

— leif