[Paul Burba]
> With only one exception that I know of[1], revert leaves local
> additions of every stripe as unversioned. My first question is
> simple:
>
> "Do we consider this the correct behavior?"
>
> A) "Yes! svn revert only reverts the scheduled addition, but leaves
> the item behind as u
[Gavin Beau Baumanis]
> Just thought I would follow up your last email and see if you're
> still working on this patch?
r984911.
Thanks for the reminder,
Peter
[C. Michael Pilato]
> But, as you said, it's version control -- nothing is ever really lost!
A funny thing to say in a conversation about the obliterate feature.
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
[Justin Erenkrantz]
> On Wed, Aug 25, 2010 at 2:45 PM, Blair Zajac wrote:
> > Does it change the ABI? Do we need to wait for the next svn 1.6.x release
> > before we can use it? I'm asking because I maintain the MacPorts serf
> > package and don't want to break existing installs.
>
> Subversio
extract the charset=
| bit, and pass it's value off to Pygments when doing syntax
| highlighting for the markup and annotate views.
Without that fix, I would expect to see exactly what you saw.
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
[Greg Stein]
> I'm fine with doing the work. Let's gather a few preferences, and if
> they support a change from all-lower-case, then I'll make it happen.
Yay, bikeshed! I always do SQL keywords (including NULL) and builtin
functions (COUNT, MAX) in all caps; tables, views, columns, stored
proce
[C. Michael Pilato]
> It's not about the timing, really. We don't introduce new features in patch
> releases. Now, that said, svnmucc isn't really part of our core product, so
> perhaps it doesn't fall into this restriction. I wonder what other devs
> think about this?
It's the sort of thing I
So, in 1.3 or 1.4 we gained '-c' as a convenience for specifying
changesets as opposed to revision endpoints. Then in 1.5 we got the
svn:mergeinfo property, which expresses ranges of changsets. I don't
know who decided to use "-" instead of ":" as the range operator, but I
do note that the 'svn
[Peter Samuelson]
> Is this, then, a worthwhile feature addition? I don't want to add
> syntax that nobody else wants. In particular, this patch highlights
> the existing inconsistency of ":" vs. "-" as range operators.
Hmmm, in tests/cmdline/log_tests.py XFai
ever else),
trailing spaces are being stripped from blank lines (" \n"), so they
look like they're no longer part of the patch.
Just a guess.
> On Sat, Oct 2, 2010 at 9:34 PM, Peter Samuelson wrote:
> > Hmmm, in tests/cmdline/log_tests.py XFail(log_chanage_range), I see
>
[Paul Burba]
> We can certainly proceed with what you have so far (i.e. -cX-Y
> support) and if anybody wants to take up the -cX:Y banner, let them.
r1004727.
Peter
[Stefan Sperling]
> > + /* Create the CACHE_ID which will be generated based on REALMSTRING
> > similar
> > + to other password caching mechanisms. */
> > + digest = svn_checksum_create(svn_checksum_md5, pool);
> > + svn_checksum(&digest, svn_checksum_md5, realmstring, strlen(realmstring),
and each changeset
contains and is uniquely identified by a cryptographic hash.
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
> On Tue, 2010-10-19 at 04:31 -0400, Greg Stein wrote:
> > The FSFS backend was dropped in as a fait d'accompli.
[Greg Hudson]
> A minor correction: ra_svn was dropped in as a fait d'accompli.
Another minor correction, or perhaps a minor minor-correction
correction: "fair accompli" (literally "f
[Peter Samuelson]
> Another minor correction, or perhaps a minor minor-correction
> correction: "fair accompli" (literally "finished work") has no d'.
_fait_ accompli! Of course when I get pedantic I misspell.
http://linuxmafia.com/~rick/lexicon.html#moenslaw-corrections
[Philip Martin]
> sqlite3 wcx.db "select count(*) from nodes where wc_id = 1 and
> local_relpath = 'zag1/zag27'"
>
> sqlite3 wcx.db "select count(*) from nodes where wc_id = 1 and
> (local_relpath > 'zig1/zag27/' and local_relpath < 'zig1/zag270')"
> sqlite3 wcx.db "select count(*) from
[Hyrum K. Wright]
> Would it be possible to define a simple markup format, and then just
> put these strings in a text file and process that, similar to what we
> do with our sql statements now. Is there a markup format which
> already exists which would suit this purpose?
I have to say I kinda
[Daniel Trebbien]
> I tried your suggestion of removing the subversion and libsvn1
> packages (I'm running Debian Sid)
FWIW, the only package you actually had to remove in order to prevent
linker interference is libsvn-dev. That has the *.la files, *.so
symlinks, etc. that are used at link time.
[s...@apache.org]
> --- subversion/trunk/Makefile.in (original)
> +++ subversion/trunk/Makefile.in Tue Nov 9 23:23:10 2010
> @@ -413,15 +413,11 @@ local-install: @INSTALL_RULES@
> ### HACK!! Find a better way to do this
> revision-install:
> subversion/svnversion/svnversion $(top_srcdir)
[Hyrum K. Wright]
> Instead of trying to cherry-pick specific notes/ to include in the
> release tarballs, I'd like to propose that we just drop the folder
> entirely from our distribution artifacts.
+1. Presumably if there are files we do want to distribute, we can
move them to d
_subr for layers to use that are _not_ specifically talking about
svn_fs internals.
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
to be specified by POSIX. That seems
like a pretty good 'readlink' to me:
if test "$$(cd $(SWIG_PL_DIR); pwd -P)" != "$$(cd $(SWIG_PL_SRC_DIR);
pwd -P)"; then
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
, and time spent on each.
The obvious start is 'strace', as in 'strace svn merge ...'. It spits
out every system call. There's a lot of noise up front as it's loading
shared libraries and such, but it should still be obvious what we're
doing when crawling the tr
[Stefan Sperling]
> > - is_zeros |= (*checksum)->digest[i];
> > + is_nonzero |= ((char *)(*checksum)->digest)[i] = x1 << 4 | x2;
>
> At the very least, this needs parenthesis unless you want everyone
> to pull out their copy of K&R to check operator precedence rules.
Can do. x1 << 4 |
[Daniel Shahaf]
> char *digest = (char *) checksum->digest;
> for (i = 0; ...)
> {
> is_nonzero |= (x1 | x2);
> digest[i] = (x1 << 4) | x2;
> }
r1042319. I left both lines as (x1 << 4) | x2, even though is_nonzero
doesn't need the << 4, so that the
t 'man' and 'PAGER'
some years ago. At least the Debian version uses system() and
interprets PAGER='"/with spaces/pager" -with -args' correctly.
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
places.
Well, or calling them C:/PROGRA~1 and C:/DOCUME~1. Not necessarily
wise, since these days I hear it's possible to disable short name
generation in NTFS, but there you have it.
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
[Martin Furter]
> I again fell over transform_libtool_scripts.sh on solaris.
Would this patch help on Solaris? I believe autoconf goes to some
effort to find a reasonable shell, in /usr/xpg4 or whatever.
[[[
* Makefile.in
(transform-libtool-scripts): Run with $(SHELL) rather than /bin/sh,
o just generate the script from a template.
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
prevailed upon to permit
the standard boilerplate. If this is something we'd want to move to
tools/.
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
sted by gcc docs: wrap your { } with
do...while(0). There's no semantic change to the macro itself, but
consider cases like this:
if (foo)
increment_pointers(file, len, pool);
else
...
Think about what the expansion looks like with and without the "do { }
while (0)", the difference should be clear.
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
ld make your $HOME question moot.
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
ile footprint of
~/.subversion/svnrc, even if we would historically regard it
as a layering violation.
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
ate those callers, we have to supply the function itself forever.
I've addressed this as best we can, in r1053469.
Supplying a given ABI forever is the sort of thing I thought we didn't
have to do for __ functions. I think that's Kamesh's question too.
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
th backward-compatible ABIs in Debian
do this, and it works very well. In that list I grep out all the
svn_*__ symbols, as nobody should be using those. Thus we discovered
that certain symbols like svn_error__locate do appear in binaries,
through no fault of the third-party developers.
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
ll more
common than 127.0.0.1 port 25.
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
caused tests to fail introduced in r9965.
+r850054:Fix bug that caused tests to fail introduced in r850039.
...maybe with a blank line or something between revs, and post it in
some way.
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
delete.
Or, to put it another way, if the copy + delete are in separate
revisions ... then for tree conflict purposes, we can assume that the
delete is just a delete.
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
be ok with getting an error if I tried to merge revisions to a branch
that contain changes in a directory missing in my wc.
Anyway, I guess I just agree that there are a lot of simplifications
they can do over in DVCS-land that we'd be very hard put to match - so
trying to achieve featur
r some conflicts involving
path vs. dirent functions.
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
[[[
* subversion/libsvn_subr/io.c
(svn_io_remove_dir2): Remove rewinddir() magic (see Issues 1896 and
3501). Instead, build linked lists of files and subdirs to delete,
then delete t
[Peter Samuelson]
> Something like the following (untested) against 1.6.x.
Well, it almost worked. Here's one, also for 1.6.x, that seems to pass
the tests. Edgar, can you test this on your NFS client?
I'll commit the trunk version of this soon if no one objects. It
shouldn'
test_info'
|
| 219 tests, 1490 assertions, 0 failures, 1 errors
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
[Kamesh Jayachandran]
> This patch is *not* an RA layer hack rather a transparent generic
> feature so I see nothing wrong in propagating it to higher layers.
Well, I agree with Mike, it is neither "transparent" nor "generic".
I know you dressed it up to look generic, but we all know that it is
s
[Bert Huijben]
> I think it is easier to use svn_io_get_dirents2() then this block
> replicating its implementation.
Indeed it is easier. It took me several days to get around to testing
and committing - r898963.
Peter
[Bert Huijben]
> Do we need a backport of this fix to 1.6.x?
Hmmm - yeah - I guess it would be an easy backport to vote on. Even
though, as you say, the fix doesn't literally merge cleanly. I'll try
and remember to propose it tonight, when I have time to do the whole
backport branch thing.
Pet
[Bert Huijben]
> Do we need a backport of this fix to 1.6.x?
Created and nominated branch 1.6.x-r898963.
Peter
[rhuij...@apache.org]
> ^/subversion/branches/1.6.x-r898963
> Votes:
> +1: peters
> + -0: rhuijben (I see test failures on trunk which could be related to
> + these patches. I'll update when I have more information)
Hmm, what platform? It passed 'make check'
ed on many platforms, even
libtool should not need to, the OS linker handles it.)
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
[Stefan Sperling]
> --- dist.sh (revision 900955)
> +++ dist.sh (working copy)
> @@ -228,6 +228,10 @@
>
> rm -f "$DISTPATH/STATUS"
>
> +# Get COMMITTERS from trunk so email addresses are current.
> +${SVN:-svn} cat
> "http://svn.apache.org/repos/asf/subversion/trunk/COMMITTERS"; \
> + >
[Stefan Sperling]
> I'll do a build now with r901778 reverted to check.
Note that one test is not conclusive. I mean, it could well be
a platform-specific build issue. Even though we have two layers
(gen_make, libtool) trying to shield us from platform-specific
build issues.
Peter
till assuming Linux ELF), if you remove libsvn_foo-1.so
from its installed location, that should prevent this problem without
breaking installed apps. Other platforms probably have similar
distinctions, though perhaps with other filenames.
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
[Julian Foad]
> (I blame Vim. After correcting in 1.6.x, I tried to paste into 1.5.x and
> then 1.4.x:
>
> visual-line (in file 1)
> Yank
> visual-line (in file 2)
> Paste
> visual-line (in file 3)
> Paste# pastes the line that was replaced by the previous paste
Heh, you didn't p
[Brandon Ehle]
> I have a patch below that fixes x86_64 compilation on Ubuntu Lucid
> Lynx with the trunk. I am not sure why I seem to be the only one who
> seems to be running into this yet.
Could you post a full build log? I believe your patch should not be
necessary so I'd like to see. Mayb
hurt ... and nowadays it's used in
> at least 3 programs [svntar, fsvs, and svn+branch], so it probably
> shouldn't be changed now).
That shouldn't really enter into consideration. Anyone who uses a
property in the 'svn:' namespace before that property is accep
.
To my way of thinking, any page where it's important to be able to
retrieve anchor names is also long enough to have a table of contents.
(Or the contrapositive: If it's too short or simple for a table of
contents, why direct the user at a particular anchor?) And the links
in a TOC, unlike to
Jon Delay writes:
> I keep most of my file system under svn, so I have .svn directories all over
> the place owned by root, chmod 700.
>
> Somewhere between 1.6.3 and 1.6.9, `svn checkout` started checking the root
> directory
> for the existence of an .svn directory and trying to look in it.
.
[Stefan Sperling]
> Have you seen ^/subversion/branches/1.6.x-wc-ng-check-override ?
> I think that's the workaround you need. Log of the branch below.
> It's already nominated for backport, so if you like it, please vote :)
I hadn't seen it. Yes, this solves the problem - but I'm not sure this
27;permission denied'. Are there
any errors that we would _want_ to catch? My feeling is no, if there's
any trouble of any sort, we should just stop looking for 1.7 WCs.
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
ucible not only with 1.5.1,
but with Debian's build of 1.6.9. (That mail is probably in the
moderation queue now.)
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
the potential utility.
(Come to think of it, I bet a way to specify "all new directories" in
auto-props would be welcome too.)
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
serious does happen in those weeks,
the candidate is turned into 1.7.0 gold.
>From branch to 1.7.0 is probably at least a couple months. Possibly
longer. Depends on what shape trunk is in (especially the new working
copy format) at the time of branching.
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
[C. Michael Pilato]
> Peter Samuelson wrote:
> > (Come to think of it, I bet a way to specify "all new directories" in
> > auto-props would be welcome too.)
>
> How about "any pattern ending a slash character" meaning "applies to
> directories&qu
l workaround is to get a log -v of its parent directory and
just look for the " D ". And yes, it is annoying (and of course won't
work if the parent was deleted at the same time).
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
[Hyrum K. Wright]
> I'd like to propose that we bump the minimal APR version from the
> current 0.9.7 to something a bit more modern, say 1.3.0.
Only if we drop our "library ABI is compatible all the way back to 1.0"
assertion. At the time Subversion 1.0 was released, I guarantee nobody
built it
ence of an .svn directory and trying to look in it.
[Peter Samuelson]
> ...and getting "Permission denied", and thus he cannot use 'svn checkout'
> in his home directory.
>
> The following (untested) patch will probably fix this - but is it a good
> idea? Are
[Daniel Shahaf]
> > @@ -62,7 +63,12 @@ is_inside_wc_ng(const char *abspath,
> >
> >wc_db_path = svn_path_join_many(pool, abspath, SVN_WC_ADM_DIR_NAME,
> >"wc.db", NULL);
>
> Shouldn't this use svn_wc_get_adm_dir()?
Probably ... but since this is 1.6-spec
[Bert Huijben]
> > > >wc_db_path = svn_path_join_many(pool, abspath,
> > SVN_WC_ADM_DIR_NAME,
> > > >"wc.db", NULL);
> > >
> > > Shouldn't this use svn_wc_get_adm_dir()?
> >
> > Probably ... but since this is 1.6-specific code (it is not and never
> > will
[C. Michael Pilato]
> IIUC, prior to your change, nobody who had enabled authz at all could
> make use of the SVNListParentPath feature (because the authorization
> for that display would systematically fail). But this also means
> that Subversion never leaked the name of a repository that was
>
[Stefan Fuhrmann]
> --- subversion/libsvn_subr/checksum.c (revision 937673)
> +++ subversion/libsvn_subr/checksum.c (working copy)
> @@ -206,12 +206,39 @@
>
>for (i = 0; i < len; i++)
> {
> - if ((! isxdigit(hex[i * 2])) || (! isxdigit(hex[i * 2 + 1])))
> + char c1 = hex[i * 2
[Philip Martin]
> We have svn_ctype_isalpha which is a macro that does a table lookup.
> We don't currently have svn_ctype_isxdigit but it could be added.
>
> > I'd rather see the whole thing become a single table lookup. Untested
> > patch appended.
>
> Is this a bottleneck? I think using the
dd any build-time
requirements, it should be done as part of the regular build.
Partly this is for transparency: the less "non-source" the downstream
users have to trust our Release Manager to generate correctly from the
same source that is shipped, the better. (Of course, an automated
rel
[Jörg Steffens]
> * contrib/client-side/asvn
> (main): uses "$@" instead of $@
That's fine.
> @@ -384,16 +412,17 @@
> case "$1" in
>checkout|co) CHDIR=true; ACTION="post";;
>commit|ci)ACTION="pre";;
> + status|st)ACTION="pre";;
>switch|sw)ACTION="post
7;
tree anymore ... this patch is simple and obviously correct.
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
[Jon Foster]
> All he has to do is change the svn:sync-from-url property on the
> mirror repository to be a file:// URL to the source repository,
> rather than a http:// one. The correct file:// URL is probably
> guessable.
I'd never thought of this as as security problem, but I _do_ think it's
system linker or
GNU binutils, and probably depends on your version of AIX.
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
[Julian Foad]
> 2. Behaviour of Local Renames
> D. Other WC commands
>
> - copy from source path: fail (can't reference a gone-away node)
>
> - copy from target path: record as copy of that target path? (can we
> guarantee ordering such that that will be propagated
[Julian Foad]
> 1. Introduction
>
> B. What is New?
>
> The rename operation can be viewed as having two halves - removal
> from the source path, and adding or copying to the target path - but
> unlike in previous versions of Subversion, these two actions are:
>
>
ith whoever wants to delete it, hoping to end up re-adding it without
permission?
Seems a bit far-fetched. I dunno.
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
Apache 2.0.
Then you probably want to look in the Subversion source distribution
under packages/rpm/, where various .spec and supporting files live.
Building rpms from .spec files is a bit beyond the present scope.
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
zlib, so we don't care about this pathological case.)
*/
>From this comment, it looks like adding your "if (s->level > 0)" adds a
bug. The only time it would work properly is if you use what they call
"this pathological case", which Subversion does
default Cannot reuse a socket until both
ends of all connections have
closed them (or timed out)
SO_REUSEADDR not possibleUnsafe!
Of course what we want is the first case.
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
d with SO_REUSEADDR. Prior to Windows Server 2003,
this will succeed in messing up svnserve, unless you use SO_EXCLUSIVEADDR.
This seems to have been corrected in Windows Server 2003.
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
uot;
>
> So not using SO_EXCLUSIVEADDR means the denial-of-service still works?
Well, the same article describes the changes made in Windows Server
2003: now this seems to be true only if the malicious app is running as
the same user as svnserve.
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
quot; tags to the various CollabNet links on packages.html.
Objections?
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
e. It
would be good to know whether it works as well.
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
[Stefan Sperling]
> So my vote is: leave it as is, but print a more informative error message
> suggesting to create the file (so that people don't have to post to
> users@ to be instructed to do so), and make svnadmin upgrade create it.
I guess the common case is that the source of a hotcopy is
[Stefan Sperling]
> Because of the substantial changes done for 1.7, we will need
> pre-release testing more than ever. So doing source-only 1.7 preview
> releases would pose a major problem. We will have to actively push
> for pre-release testing by providing binaries.
I've always shied away fro
the other error, which would be something like "Cannot open
.../fsfs.conf: is a directory".
I'm not just worried about the extra code; there's also the extra
string to translate. I just don't think anyone needs it.
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
[Ramkumar Ramachandra]
> Let's say some sponsor wants to provide a mirroring service- with the
> proposed feature the person will simply have to create a blank
> repository and enable pre-revprop-change/ pre-uuid-change on and wait
> for someone to load the content into that repository.
Here's an
[Hyrum K. Wright]
> We currently have several (implemented or proposed) sources for
> configuration information, and I think they should be searched in the
> following order:
Ah, and what about things like global-ignores or auto-props, where you
can set multiple "properties" per option?
If the r
[Michael Spang]
> This reverts to using the zlib-provided version, since the old version
> of zlib that was missing this function should be quite rare these
> days.
Maybe I'm just old ... but I bet there's still some zlib 1.1.4
out there. Maybe do the following instead? (Untested.)
[[[
* subve
For reasons I do not understand, swig 2.0.5 and higher has changed
handling of python ints and longs in some way that breaks the Python
testsuite. This fixes it. The testsuite. I don't know if it fixes
the real issue, I have no idea if it's a reasonable approach. I'm not
at all comfortable wit
[Greg Stein]
> That looks fine. There are likely a couple other ways to do it more
> generically (my Pay API Fu is rusty), but that code should be okay. We can
> investigate more if we run into further problems.
Thanks, r1351117.
[Mattias Engdegård]
> The biggest surprise was that COW actually made the checkout slightly
> slower, even though no "true" file copies were made. I'm not sure how
> to explain this---perhaps everything is already in cache so the
> copies aren't very expensive, or the COW operations are somehow
>
[Markus Schaber]
> So my personal experience tells me that multiple-client scenarios are
> the common case, and that the deployment strategy (only using linux
> distro packages, or 3-in-1 bundles like VisualSVN) can reduce that
> problem.
So, we provide a pile of libraries that maintain ABI backw
Reposting under a new thread + subject line, at Daniel's suggestion.
[Markus Schaber]
> So my personal experience tells me that multiple-client scenarios are
> the common case, and that the deployment strategy (only using linux
> distro packages, or 3-in-1 bundles like VisualSVN) can reduce that
[Branko Cibej]
> Like I said in my response to this in the other thread -- API or even
> ABI compatibility is not the issue. Working copy formats, wire
> protocol quirks, etc. etc. are more "interesting". And I really don't
> think it's up to us to tell packagers how to do their stuff.
Well, the
[Philip Martin]
> There needs to be a way to create the initial branch, i.e. mkdir as well
> as copy.
In fact, that's really _all_ that should be needed. If your 'trunk'
has a svn:branch property, and you copy or tag it with 'svn copy', the
target will get the same property. An explicit 'svn co
[stef...@apache.org]
> + for (; len > 0; ++data, --len)
> + if (*data < 0)
> +return data;
Two major problems:
1) It doesn't account for character sets like Shift-JIS, where state
change is signalled by ASCII 14 and 15 ("shift out", "shift in")
2) It assumes a 'char
>for (; len > 0; ++data, --len)
> - if (*data < 0)
> -return data;
> +if (*data < 0 || *data >= 0x80)
> + return data;
A reasonable compiler will collapse it anyway, but this is shorter and
more direct:
if (*data & 0x80)
Peter
1 - 100 of 240 matches
Mail list logo
