Re: fixing old revisions referenced in log messages ...

2009-12-08 Thread Julian Foad
On Tue, 2009-12-08 at 13:05 +0530, Senthil Kumaran S wrote: > Senthil Kumaran S wrote: > > You can get a sample run (20 MB) of the modified script here - > > http://people.apache.org/~stylesen/sample_run_r836401_r880642.txt Thank you. I diffed it against the original log messages, and I attach a s

Re: fixing old revisions referenced in log messages ...

2009-12-07 Thread Senthil Kumaran S
Senthil Kumaran S wrote: > You can get a sample run (20 MB) of the modified script here - > http://people.apache.org/~stylesen/sample_run_r836401_r880642.txt I ve filed a INFRA ticket to get a schedule to run this script on the repository - https://issues.apache.org/jira/browse/INFRA-2366 Thank Y

Re: fixing old revisions referenced in log messages ...

2009-12-07 Thread Senthil Kumaran S
Hi Julian, Julian Foad wrote: >>> If such shortened format were used somewhere in the log messages, it would >>> be hard to decipher it without knowing the original revision number. >> Yes this is a constraint which I thought about. Will try to make the script >> intelligent or will propose some o

Re: fixing old revisions referenced in log messages ...

2009-11-27 Thread Julian Foad
On Fri, 2009-11-27 at 18:36 +0530, Senthil Kumaran S wrote: > Konstantin Kolinko wrote: > > 2009/11/27 Senthil Kumaran S : > >> Already ran a test on r880575 and the script did what it was supposed to > >> do. > >> > > > > How about preserving the old numbers as well (e.g. in brackets)? > > > >

Re: fixing old revisions referenced in log messages ...

2009-11-27 Thread Bhuvaneswaran A
On Fri, 2009-11-27 at 18:06 +0530, Senthil Kumaran S wrote: > > b) If we decide that we should fix those revisions and while we run > the > > script to fix, we should disable post-revprop-change script to avoid > > sending 1000s of prop change emails to commits@ list. > > Yes this is a concern, sh

Re: fixing old revisions referenced in log messages ...

2009-11-27 Thread Stefan Sperling
On Fri, Nov 27, 2009 at 06:36:42PM +0530, Senthil Kumaran S wrote: > 25033.76511 wrote: > > I would suggest to preserve the old revision numbers, for instance like > > r123456[r54321]. > > Who knows if we might need them again some day. > > I like this idea. Lets go with this. I don't think it's

Re: fixing old revisions referenced in log messages ...

2009-11-27 Thread Hyrum K. Wright
On Nov 27, 2009, at 6:52 AM, 25033.76511 wrote: > On 27.11.2009 11:10, Senthil Kumaran S wrote: >> Hi, >> >> Bhuvaneswaran A wrote: >>> Did we discuss about correcting old revisions pointing to svn.collab.net >>> repository referenced in log messages? Like this one: >>> $ svn log -r r880575 >>

Re: fixing old revisions referenced in log messages ...

2009-11-27 Thread Senthil Kumaran S
25033.76511 wrote: > I would suggest to preserve the old revision numbers, for instance like > r123456[r54321]. > Who knows if we might need them again some day. I like this idea. Lets go with this. -- Senthil Kumaran S http://www.stylesen.org/

Re: fixing old revisions referenced in log messages ...

2009-11-27 Thread Senthil Kumaran S
Konstantin Kolinko wrote: > 2009/11/27 Senthil Kumaran S : >> Already ran a test on r880575 and the script did what it was supposed to do. >> > > How about preserving the old numbers as well (e.g. in brackets)? > > I also see that, e.g. in > http://svn.apache.org/repos/asf/subversion/trunk/CHANGE

Re: fixing old revisions referenced in log messages ...

2009-11-27 Thread 25033.76511
On 27.11.2009 11:10, Senthil Kumaran S wrote: Hi, Bhuvaneswaran A wrote: Did we discuss about correcting old revisions pointing to svn.collab.net repository referenced in log messages? Like this one: $ svn log -r r880575 This is my first attempt at ctypes-python bindings for subversion :) The

Re: fixing old revisions referenced in log messages ...

2009-11-27 Thread Konstantin Kolinko
2009/11/27 Senthil Kumaran S : > > Already ran a test on r880575 and the script did what it was supposed to do. > How about preserving the old numbers as well (e.g. in brackets)? I also see that, e.g. in http://svn.apache.org/repos/asf/subversion/trunk/CHANGES when several revision numbers are me

Re: fixing old revisions referenced in log messages ...

2009-11-27 Thread Senthil Kumaran S
Bhuvaneswaran A wrote: > a) I don't know if the new revisions are sequential. The difference > between last revision in the import (r880588) and HEAD (r836420) is > 44168. It does not match with the last revision (r40515) committed in > svn.collab.net repository. IOW, I don't think we are sure that

Re: fixing old revisions referenced in log messages ...

2009-11-27 Thread Stefan Sperling
On Fri, Nov 27, 2009 at 05:04:42PM +0530, Bhuvaneswaran A wrote: > a) I don't know if the new revisions are sequential. The difference > between last revision in the import (r880588) and HEAD (r836420) is > 44168. It does not match with the last revision (r40515) committed in > svn.collab.net repos

Re: fixing old revisions referenced in log messages ...

2009-11-27 Thread Bhuvaneswaran A
On Fri, 2009-11-27 at 15:40 +0530, Senthil Kumaran S wrote: > Hi, > > Bhuvaneswaran A wrote: > > Did we discuss about correcting old revisions pointing to svn.collab.net > > repository referenced in log messages? Like this one: > > $ svn log -r r880575 > > This is my first attempt at ctypes-pytho

Re: fixing old revisions referenced in log messages ...

2009-11-27 Thread Senthil Kumaran S
Hi Brane, Branko Čibej wrote: > Here's a hint for compliance with the Python coding standards: > > --- log_revnum_change_asf.py 2009-11-27 11:21:44.930709595 +0100 > +++ log_revnum_change_asf.py 2009-11-27 11:22:59.490693784 +0100 > @@ -16,19 +16,20 @@ > #specific language governing permis

Re: fixing old revisions referenced in log messages ...

2009-11-27 Thread Branko Čibej
Senthil Kumaran S wrote: > Hi, > > Bhuvaneswaran A wrote: > >> Did we discuss about correcting old revisions pointing to svn.collab.net >> repository referenced in log messages? Like this one: >> $ svn log -r r880575 >> > > This is my first attempt at ctypes-python bindings for subversion :

Re: fixing old revisions referenced in log messages ...

2009-11-27 Thread Senthil Kumaran S
Hi, Bhuvaneswaran A wrote: > Did we discuss about correcting old revisions pointing to svn.collab.net > repository referenced in log messages? Like this one: > $ svn log -r r880575 This is my first attempt at ctypes-python bindings for subversion :) The attached script will do the above. I plan t