Re: Making SVN_DELTA_WINDOW_SIZE configurable

2024-12-07 Thread Johan Corveleyn
On Fri, Dec 6, 2024 at 12:27 PM Nikola Dipanov wrote: > > Hi all, > > A quick summary first: we’ve found that for certain use cases - increasing SVN_DELTA_WINDOW_SIZE yields very significant storage savings on the size of the repo (~10x). We have a POC patch to make it configurable (currently onl

Re: Automated build jobs, GitHub Actions and Buildbot Was: [DISCUSS] backport.pl or backport.py

2024-11-26 Thread Johan Corveleyn
On Tue, Nov 26, 2024 at 9:34 AM Daniel Sahlberg wrote: > There were no comments about consolidating the jobs to GHA so if the > notifications above work, I'm going to assume lazy consensus and migrate the > backport-conflict job to GHA. (The svn-warnings job already has a > corresponding job in

Re: svn commit: r1922105 - in /subversion/trunk: .asf.yaml tools/dev/unix-build/Makefile.svn

2024-11-26 Thread Johan Corveleyn
On Tue, Nov 26, 2024 at 9:27 AM wrote: > > Author: dsahlberg > Date: Tue Nov 26 08:27:28 2024 > New Revision: 1922105 > > URL: http://svn.apache.org/viewvc?rev=1922105&view=rev > Log: > Try to get GitHub Action notifications working, based on instructions from > https://github.com/apache/infrastru

Re: Automated build jobs, GitHub Actions and Buildbot Was: [DISCUSS] backport.pl or backport.py

2024-11-25 Thread Johan Corveleyn
On Fri, Nov 22, 2024 at 4:21 PM Nathan Hartman wrote: > > On Fri, Nov 22, 2024 at 9:17 AM Daniel Sahlberg > wrote: > > > > Den fre 22 nov. 2024 kl 09:39 skrev Daniel Sahlberg > > : > >> > >> Den ons 20 nov. 2024 kl 18:15 skrev Daniel Sahlberg > >> : > >>> > >>> So I'd say we have consensus on m

Re: Releasing Subversion 1.14.5

2024-11-18 Thread Johan Corveleyn
On Sun, Nov 17, 2024 at 11:04 PM Daniel Sahlberg < daniel.l.sahlb...@gmail.com> wrote: ... > r1921266 and r1921267: Seems simple enough but needs to be tested by someone with a working win32 environment (I'm still struggling). @Johan Corveleyn ? Doh! I tested these already but

Re: [DISCUSS] backport.pl or backport.py

2024-11-18 Thread Johan Corveleyn
On Mon, Nov 18, 2024 at 10:05 AM Stefan Sperling wrote: > > On Mon, Nov 18, 2024 at 09:52:31AM +0100, Daniel Sahlberg wrote: > > I'm leaning towards the second option. The interactive features are nice > > but I usually don't use them so I wouldn't mind loosing them - I think the > > advantage of

Performance of 'svnlook changed' is O(revsize)

2024-10-18 Thread Johan Corveleyn
Haven't looked into the code yet, but this might be an nice "bite-sized" issue to investigate, if someone has time and inclination to do so: Seen on a FSFS f8 repository (on Linux) with a 200 MB revision: Apparently 'svnlook changed -r $REV' gets slow if $REV is large (as in "lots of MB", not in

Re: Windows build complaining about missing 'ruby'

2024-10-07 Thread Johan Corveleyn
On Sun, Oct 6, 2024 at 10:17 PM Johan Corveleyn wrote: > > On Sat, Oct 5, 2024 at 8:20 AM Jun Omae wrote: > > > > On 2024/10/04 3:57, Johan Corveleyn wrote: > > > Hi, > > > > > > Another small bump when building on Windows: when gen-make.py runs, or &

Re: Windows build complaining about missing 'ruby'

2024-10-06 Thread Johan Corveleyn
On Sat, Oct 5, 2024 at 8:20 AM Jun Omae wrote: > > On 2024/10/04 3:57, Johan Corveleyn wrote: > > Hi, > > > > Another small bump when building on Windows: when gen-make.py runs, or > > when starting to run tests, I always get the following printed on the > > co

Re: Windows build: gen_make.py trips over zlib 1.3

2024-10-06 Thread Johan Corveleyn
On Sat, Oct 5, 2024 at 7:51 AM Jun Omae wrote: > > On 2024/10/04 3:54, Johan Corveleyn wrote: > > Hi, > > > > I ran into a small issue when building trunk on Windows with zlib 1.3. > > Not a big deal, I could work around it. But I don't have time right > >

Windows build complaining about missing 'ruby'

2024-10-03 Thread Johan Corveleyn
Hi, Another small bump when building on Windows: when gen-make.py runs, or when starting to run tests, I always get the following printed on the console: [[[ 'ruby' is not recognized as an internal or external command, operable program or batch file. ]]] This is quite correct, because I don't ha

Windows build: gen_make.py trips over zlib 1.3

2024-10-03 Thread Johan Corveleyn
Hi, I ran into a small issue when building trunk on Windows with zlib 1.3. Not a big deal, I could work around it. But I don't have time right now to come up with a proper patch, so I thought I'd just mention it here already. When trying to build on Windows with zlib 1.3, gen_make.py (actually ge

Re: Berkely DB precompiled for Windows

2024-09-27 Thread Johan Corveleyn
On Thu, Sep 26, 2024 at 5:34 PM Nathan Hartman wrote: > > On Thu, Sep 26, 2024 at 10:16 AM Daniel Sahlberg > wrote: > > > > Den tors 26 sep. 2024 kl 15:31 skrev Johan Corveleyn : > > (snip) > >> > >> +1, definitely. Since BDB support in Subversion i

Re: Berkely DB precompiled for Windows

2024-09-26 Thread Johan Corveleyn
On Thu, Sep 26, 2024 at 3:16 PM Daniel Sahlberg wrote: > Hi, > > I was reading through INSTALL and noticed under I,C.9 there is text > suggesting to fetch a pre-compiled version of Berkeley DB for Windows from > tigris.org. That doesn't work anymore. > > I'm suggesting to just remove this complet

Re: The efficiency of svnlook changed

2024-07-28 Thread Johan Corveleyn
On Fri, Jul 26, 2024 at 7:08 PM Daniel Sahlberg wrote: > Den tors 25 juli 2024 kl 06:44 skrev zongganli(李宗淦) : >> >> Hello, >> >> I just found that in revision 1303856 >> https://svn.apache.org/viewvc?view=revision&revision=1303856, it sets the >> send_deltas in svnlook to TRUE. >> Actually, on

Re: 1.14.4 release

2024-03-11 Thread Johan Corveleyn
On Mon, Mar 11, 2024 at 8:55 AM Stefan Sperling wrote: > > On Sun, Mar 10, 2024 at 07:59:38PM -0400, Nathan Hartman wrote: > > There is at least a week before I can begin working on it, so there is > > time for the dev community to respond. > > I will be around to help with testing/signing. Thanks

Re: Assert-Anweisung schlug fehl (! svn_path_is_url(relative))

2024-02-07 Thread Johan Corveleyn
On Tue, Feb 6, 2024 at 10:24 PM Jürgen Loh wrote: > > Am 06.02.2024 um 12:00 schrieb Jürgen Loh: > > This evening I can try if TourtoiseSVN fails on the clients, too. > > I did this test. The problem is not related to SUBST, it happens the > same on a network share. > > The situation is: > > The

Re: Switching from SHA1 to a checksum type without known collisions in 1.15 working copy format

2024-01-12 Thread Johan Corveleyn
On Fri, Jan 12, 2024 at 12:37 PM Daniel Shahaf wrote: ... > Procedurally, the long hiatus is counterproductive. Neither kfogel nor > I had the context in our heads, and the cache misses took their toll in > tuits and in wallclock time. Furthermore, I have less spare time for > dev@ discussions t

Re: Changing the permission checks in libsvn_subr/io.c

2024-01-10 Thread Johan Corveleyn
On Sun, Jan 7, 2024 at 2:46 AM Vincent Lefevre wrote: > On 2024-01-05 11:29:16 +0100, Daniel Sahlberg wrote: > > Den fre 5 jan. 2024 kl 10:51 skrev Johan Corveleyn : > > > > > On Fri, Jan 5, 2024 at 8:46 AM Daniel Sahlberg > > > wrote: > > > ... > >

Re: Changing the permission checks in libsvn_subr/io.c

2024-01-05 Thread Johan Corveleyn
On Fri, Jan 5, 2024 at 8:46 AM Daniel Sahlberg wrote: ... > Since the file doesn't have svn:needs-lock it should be RW [and the Reverted > message comes from Subversion trying to restore the W flag ...] Should it? Intuitively I'd say: since the file doesn't have svn:needs-lock Subversion shouldn

Re: Subversion 1.14.3 up for testing/signing

2023-12-22 Thread Johan Corveleyn
On Sat, Dec 9, 2023 at 4:50 PM Nathan Hartman wrote: > > The 1.14.3 release artifacts are now available for testing/signing. > Please get the tarballs from > https://dist.apache.org/repos/dist/dev/subversion > and add your signatures there. > > Thanks! Summary --- +1 to release (Windows) P

Re: Subversion 1.14.3 up for testing/signing

2023-12-22 Thread Johan Corveleyn
On Fri, Dec 22, 2023 at 7:46 AM Daniel Sahlberg wrote: > Den fre 22 dec. 2023 kl 02:49 skrev Johan Corveleyn : ... >> Then, regardless of the above error, when I start building with >> msbuild, I run into following error: >> [[[ >> C:\research\svn\dev\deps64\src\s

Re: Subversion 1.14.3 up for testing/signing

2023-12-22 Thread Johan Corveleyn
On Fri, Dec 22, 2023 at 3:07 AM Yasuhito FUTATSUKI wrote: > > Hi, > > On 2023/12/22 10:49, Johan Corveleyn wrote: ... > > Finally, did some tweaks to get gen_win_dependencies.py to run, but > > then ran into following error: > > [[[ > > python gen

Re: Subversion 1.14.3 up for testing/signing

2023-12-21 Thread Johan Corveleyn
On Tue, Dec 19, 2023 at 1:30 PM Johan Corveleyn wrote: > > On Mon, Dec 18, 2023 at 11:13 PM Nathan Hartman > wrote: > > > > On Sat, Dec 9, 2023 at 10:50 AM Nathan Hartman > > wrote: > > > > > > The 1.14.3 release artifacts are now available for t

Re: Subversion 1.14.3 up for testing/signing

2023-12-19 Thread Johan Corveleyn
On Mon, Dec 18, 2023 at 11:13 PM Nathan Hartman wrote: > > On Sat, Dec 9, 2023 at 10:50 AM Nathan Hartman > wrote: > > > > The 1.14.3 release artifacts are now available for testing/signing. > > Please get the tarballs from > > https://dist.apache.org/repos/dist/dev/subversion > > and add your

Re: 1.14.3 release planning

2023-12-07 Thread Johan Corveleyn
Sounds like a plan :). I'm currently swamped with $dayjob myself, until half of next week at least. After which I'll try to join the effort (I'll first need to blow the dust off my old svn-dev environment, so don't expect me to be quick, but I'll try). -- Johan On Tue, Dec 5, 2023 at 11:25 AM D

Re: Is there a write opposite to "svn cat"?

2023-11-27 Thread Johan Corveleyn
>>> The documentation say: >>> [[[ >>> put SRC-FILE URL : add or modify file URL with contents copied from >>>SRC-FILE (use "-" to read from standard input) >>> ]]] Just chiming in here from the sideline, without ability to test right now, but: has anyone tried

Re: New release

2023-11-10 Thread Johan Corveleyn
On Thu, Nov 9, 2023 at 6:08 PM Nathan Hartman wrote: > > On Fri, Nov 3, 2023 at 12:00 AM Nathan Hartman > wrote: > > Previously I mentioned I plan to RM for the upcoming 1.14.3 release. > > This being my first time, I need to solve some issues first. > > > > One of these, which has been a stumbl

Re: New release

2023-10-13 Thread Johan Corveleyn
On Fri, Oct 13, 2023 at 5:35 PM Stefan Sperling wrote: > > On Fri, Oct 13, 2023 at 08:43:59AM +0200, Daniel Sahlberg wrote: > > Hi, > > > > There are quite a number of improvements waiting to be released. Can we > > muster the energy to do a new release? > > > > In trunk there are a lot of changes

Fwd: Public funding for contributions available

2023-06-09 Thread Johan Corveleyn
Maybe interesting for some people here on dev@subversion? The switch from funded development to almost-all-volunteer work has been hard for our little community, and I always thought some of the originally-funded-devs might have wanted to continue some work here, if only there would be a way to or

Re: Plaintext cache release notes (was: svn commit: r1909352 - /subversion/trunk/CHANGES)

2023-04-27 Thread Johan Corveleyn
On Tue, Apr 25, 2023 at 5:00 AM Nathan Hartman wrote: > > On Mon, Apr 24, 2023 at 12:38 PM Daniel Sahlberg > wrote: > > > > Den mån 24 apr. 2023 kl 18:11 skrev Nathan Hartman > > : > (snip) > >> Sometime in the next few days, I'll draft some text for the 1.15.x > >> release notes about this chan

Re: svn commit: r1909352 - /subversion/trunk/CHANGES

2023-04-22 Thread Johan Corveleyn
On Sat, Apr 22, 2023 at 6:25 PM wrote: > > Author: dsahlberg > Date: Sat Apr 22 16:25:30 2023 > New Revision: 1909352 > > URL: http://svn.apache.org/viewvc?rev=1909352&view=rev > Log: > * CHANGES: Document r1909351 ... > + - Other tool improvements and bugfixes: > +* Storing passwords in plai

Re: [VOTE] Reverting r1845377 (Was: [PROPOSAL] Allow plaintext passwords again.)

2023-04-21 Thread Johan Corveleyn
for picking it up once again :-). Let's hope we can land this now ... > In my mind, it seems we have consensus to revert r1845377 (+1 from Nathan > Hartman, Evgeny Kotkov, Johan Corveleyn, myself, I'm also considering Karl > Fogel to have voted for this by making the initial p

Re: [PROPOSAL] Allow plaintext passwords again.

2023-03-30 Thread Johan Corveleyn
On Thu, Mar 30, 2023 at 12:15 AM Nathan Hartman wrote: > > On Wed, Mar 29, 2023 at 6:02 PM Evgeny Kotkov > wrote: > > > > Nathan Hartman writes: > > > > > I think a good middle ground is: > > > > > > * Build with --enable-plaintext-password-storage by default; users who > > > want to harden th

Re: [PROPOSAL] Allow plaintext passwords again.

2023-03-28 Thread Johan Corveleyn
On Mon, Jan 24, 2022 at 5:02 PM Mark Phippard wrote: > > On Mon, Jan 24, 2022 at 10:44 AM Daniel Shahaf > wrote: > > > > > >I return to my "two camps" argument. The people that do not want > > > > >plaintext passwords to be cached ... do not want them being > > > > >cached. > > > > > > > > I see

Re: svn st shows missing for root folder

2023-02-08 Thread Johan Corveleyn
On Wed, Apr 15, 2020 at 10:40 AM Johan Corveleyn wrote: > > On Tue, Nov 19, 2019 at 9:44 PM Evgeny Kotkov > wrote: > > > > Stefan Kueng writes: > > > > > Using svn 1.13.0 on Windows: > > > > > > SUBST G:\ D:\Development\TestWC > >

Re: Getting to first release of pristines-on-demand feature (#525).

2022-11-29 Thread Johan Corveleyn
My thanks also to the courageous people having developed this, and the gentle souls keeping the ball rolling :-). About the name: On Thu, Nov 24, 2022 at 3:57 PM Nathan Hartman wrote: ... > Previously we got stuck trying to choose the user-facing name of this > feature and its command line switc

Re: Subversion 1.10.0 end-of-life

2022-04-29 Thread Johan Corveleyn
On Thu, Apr 28, 2022 at 9:26 PM Nathan Hartman wrote: > On Thu, Apr 28, 2022 at 3:12 PM Stefan Sperling wrote: >> On Thu, Apr 28, 2022 at 01:29:43PM +, Daniel Shahaf wrote: >> > Stefan Sperling wrote on Thu, 28 Apr 2022 09:55 +00:00: >> > > I think it would be better to have such details spel

Re: Pristines-on-demand=enabled == format 32?

2022-04-19 Thread Johan Corveleyn
On Thu, Apr 7, 2022 at 6:07 PM Julian Foad wrote: > > Johan Corveleyn wrote: > > Ah, yes, I think that makes #4889 a blocker. > > Well, I'm having a hard time deciding what exactly we need and why. > > I previously said "it's pretty clear it needs to be

Re: Pristines-on-demand: fix disabled tests (#4891)

2022-04-07 Thread Johan Corveleyn
Okay, with --wc-format-version=1.8, I now get these (X)FAILs and XPASSes (fails_wc-format-version1.8.log in attachment): [[[ XFAIL: diff-diff3-test 18: 3-way merge, double add XFAIL: dirent_uri-test 47: test match with RFC 6125 s. 6.4.3 Rule 3 XFAIL: op-depth-test 42: mixed_rev_move [[needs

Re: Pristines-on-demand: fix disabled tests (#4891)

2022-04-07 Thread Johan Corveleyn
On Thu, Apr 7, 2022 at 11:31 AM Julian Foad wrote: > Now can you run the test suite with --wc-format-version=1.15? On Unixy > systems that is done by, for example: > > $ make svnserveautocheck WC_FORMAT_VERSION=1.15 ... Okay, passing that option to win-tests.py (the test runner on Windows) failed

Re: Pristines-on-demand: fix disabled tests (#4891)

2022-04-07 Thread Johan Corveleyn
On Thu, Apr 7, 2022 at 11:31 AM Julian Foad wrote: > Jun Omae wrote: > >> FAIL: diff_tests.py 48: svn diff --diff-cmd provides the correct arguments > > > > I've posted patch for the failure. > > See https://lists.apache.org/thread/2o0xtqfzy9xg8wzxscj2wb641p2kyo9c > > Thank you, Jun Omae. Sorry,

Re: Pristines-on-demand: fix disabled tests (#4891)

2022-04-06 Thread Johan Corveleyn
On Wed, Apr 6, 2022 at 5:12 PM Julian Foad wrote: > Johan Corveleyn wrote: > >> A few of these are Windows-specific. I can't very well investigate those > >> myself. Who could volunteer to look at those? They are: > &

Re: Pristines-on-demand=enabled == format 32?

2022-04-06 Thread Johan Corveleyn
On Wed, Apr 6, 2022 at 4:28 PM Julian Foad wrote: > > Johan Corveleyn wrote: > > I think this was asked several times before, but I can't find the > > thread: is the pristines-on-demand behavior still unconditionally tied > > to format 32? Or is it that format 32

Pristines-on-demand=enabled == format 32?

2022-04-06 Thread Johan Corveleyn
I think this was asked several times before, but I can't find the thread: is the pristines-on-demand behavior still unconditionally tied to format 32? Or is it that format 32 makes it _possible_ to enable pristines-on-demand? I would object to having pristines-on-demand=enabled coupled to simply h

Re: Pristines-on-demand: fix disabled tests (#4891)

2022-04-06 Thread Johan Corveleyn
On Wed, Apr 6, 2022 at 4:02 PM Julian Foad wrote: > === Windows-specific issues > > A few of these are Windows-specific. I can't very well investigate those > myself. Who could volunteer to look at those? They are: > > externals_tests.py ... ... ...: > update_modify_file_external(), >

Re: Website prep work and questions (mainly about the 1.15 release notes)

2022-04-06 Thread Johan Corveleyn
On Wed, Apr 6, 2022 at 1:28 AM Nathan Hartman wrote: > On Tue, Apr 5, 2022 at 7:19 PM Mark Phippard wrote: >> On Tue, Apr 5, 2022 at 4:49 PM Johan Corveleyn wrote: >> > 4. Signature verified OK, but Mark's key not trusted, which, as Nathan >> > also said,

Re: Website prep work and questions (mainly about the 1.15 release notes)

2022-04-05 Thread Johan Corveleyn
Thanks all for sharing your gpg key hurdles. It saved me a lot of time when I ran into the same issues while verifying Mark's signature :-). 1. Signature algorithm not recognized -> updated my gpg to latest version (2.3.4) 2. keyserver problem when running 'gpg --refresh-keys' -> put 'keyserver h

Re: Subversion 1.10.8 up for testing.signing

2022-04-05 Thread Johan Corveleyn
On Sat, Apr 2, 2022 at 3:27 PM Mark Phippard wrote: > > The 1.10.8 release artifacts are now available for testing/signing. > > Please get the tarballs from > https://dist.apache.org/repos/dist/dev/subversion > and add your signatures there. > > Thanks! Summary --- +1 to release Platform -

Re: Subversion 1.14.2 up for testing/signing

2022-04-05 Thread Johan Corveleyn
On Sat, Apr 2, 2022 at 3:28 PM Mark Phippard wrote: > > The 1.14.2 release artifacts are now available for testing/signing. > > Please get the tarballs from > https://dist.apache.org/repos/dist/dev/subversion > and add your signatures there. > > Thanks! Summary --- +1 to release (Windows)

Re: [PATCH] limit diff effort to fix performance issue

2022-04-01 Thread Johan Corveleyn
On Fri, Apr 1, 2022 at 5:19 PM Stefan Sperling wrote: > > On Fri, Apr 01, 2022 at 05:04:49PM +0200, Johan Corveleyn wrote: > > Yes, I suppose this is the case: Patience feeds different (smaller) > > things to LCS. Because, as far as I understand, Myers' way of >

Re: [PATCH] limit diff effort to fix performance issue

2022-04-01 Thread Johan Corveleyn
On Fri, Apr 1, 2022 at 4:37 PM Stefan Sperling wrote: > Yes, roughly, Patience diff involves two algorithms, the grouping of > lines along similar-line boundaries performed by Patience, and an > LCS for parts of the files which Patience cannot deal with by itself. > > But LCS needs to complete its

Re: [PATCH] limit diff effort to fix performance issue

2022-04-01 Thread Johan Corveleyn
On Fri, Apr 1, 2022 at 1:12 PM Stefan Sperling wrote: > > On Fri, Apr 01, 2022 at 12:44:24PM +0200, Johan Corveleyn wrote: > > On Tue, Jun 8, 2021 at 5:58 PM Johan Corveleyn wrote: > > > On Tue, Jun 8, 2021 at 3:24 PM Stefan Sperling wrote: > > > > On Tue,

Re: [PATCH] limit diff effort to fix performance issue

2022-04-01 Thread Johan Corveleyn
On Tue, Jun 8, 2021 at 5:58 PM Johan Corveleyn wrote: > On Tue, Jun 8, 2021 at 3:24 PM Stefan Sperling wrote: > > On Tue, Jun 08, 2021 at 02:57:34PM +0200, Johan Corveleyn wrote: > > > Okay, I focused on the first revision causing the annotate to differ, > > >

Re: r1897441 (ping to jun66j5 and futatuki)

2022-03-31 Thread Johan Corveleyn
On Thu, Mar 31, 2022 at 1:25 AM Jun Omae wrote: > > On Thu, Mar 31, 2022 at 3:00 AM Johan Corveleyn wrote: > > Mark nominated it, and I just tested it again. However, r1884474 only > > seems to fix mod_authz_svn_tests.py#10. > > > > mod_authz_svn_tests.py#11 st

Re: r1897441 (ping to jun66j5 and futatuki)

2022-03-30 Thread Johan Corveleyn
On Wed, Mar 30, 2022 at 8:28 AM Daniel Sahlberg wrote: > > Den ons 30 mars 2022 kl 00:54 skrev Jun Omae : >> >> On Wed, Mar 30, 2022 at 6:20 AM Daniel Sahlberg >> wrote: >> > >> > Hi, >> > >> > Does anyone with experience in the bindings have time to look at the >> > backport of r1897441 (in 1.1

Generating CHANGES

2022-03-29 Thread Johan Corveleyn
In the thread with subject "Re: svn commit: r1899324 - /subversion/site/publish/upcoming.part.html": On Mon, Mar 28, 2022 at 10:14 PM Daniel Sahlberg wrote: > > Den mån 28 mars 2022 kl 22:04 skrev Mark Phippard : >> >> What is this file used for? Is it displayed on the website somewhere? > > > Ye

Re: Issue #525/#4892: on only fetching the pristines we really need

2022-03-17 Thread Johan Corveleyn
On Wed, Mar 16, 2022 at 9:59 PM Julian Foad wrote: > Daniel Shahaf wrote: > > Also, why is this specific to «svn update»? > > It's not specific to update. Update is a particular case that Karl cares > about so I looked at doing "update" first. Implementing this approach in one > subcommand at a

Re: Issue #525/#4892: on only fetching the pristines we really need

2022-03-14 Thread Johan Corveleyn
On Mon, Mar 14, 2022 at 5:26 PM Julian Foad wrote: > > Johan Corveleyn wrote: > >Speaking from the peanut gallery, [...] > >If I would be a user with several huge binaries in the repo / WC, I > >imagine I would not be happy with this proposal. The reason is that I >

Re: Issue #525/#4892: on only fetching the pristines we really need

2022-03-14 Thread Johan Corveleyn
On Mon, Mar 14, 2022 at 11:48 AM Julian Foad wrote: > > Dear dev community, and especially Karl and Mark: > > A plea to test the current design/implementation. > > I wonder if we are missing some perspective. > > We are worried that the current design won't be acceptable because it > has poor beha

Re: Issue #525/#4892: on only fetching the pristines we really need

2022-03-12 Thread Johan Corveleyn
On Fri, Mar 11, 2022 at 9:17 PM Nathan Hartman wrote: > If possible and not overly burdensome, I think it would be a good > thing to keep the "restore" functionality for the following reasons: [snip] I agree. I know about the restore feature too, and am used to it. Also, I think it would be a mis

Re: A two-part vision for Subversion and large binary objects.

2022-02-14 Thread Johan Corveleyn
On Mon, Feb 14, 2022 at 11:13 AM Ivan Zhakov wrote: > On Mon, 14 Feb 2022 at 01:39, Karl Fogel wrote: >> On 12 Feb 2022, Mark Phippard wrote: ... >> In any case, the branch name doesn't matter too much here, >> especially since it's going to get merged soon. However, for the >> user-facing name

Re: Streamlining Subversion patch releases

2022-02-09 Thread Johan Corveleyn
On Wed, Feb 9, 2022 at 2:19 PM Stefan Sperling wrote: > > On Wed, Feb 09, 2022 at 08:01:26AM -0500, Mark Phippard wrote: > > Anyway, my feeling has been that one of the blockers to being RM is > > motivation. My feeling has been that it is a fair amount of work that > > might not go anywhere becau

Re: A two-part vision for Subversion and large binary objects.

2022-01-31 Thread Johan Corveleyn
Replying to a few different points in this thread. On Jan 27, Julian Foad wrote: > The user can choose one mode, per WC, from a list of options that may include: > > - off: as in previous versions, no checking, just assume all pristines > are present > - pristines-on-demand: fetch "wanted" pri

Re: A two-part vision for Subversion and large binary objects.

2022-01-21 Thread Johan Corveleyn
On Fri, Jan 21, 2022 at 5:56 AM Karl Fogel wrote: > > On 20 Jan 2022, Julian Foad wrote: > >The more I think about this, the more I think we are prematurely > >complicating the requirements in this respect. I'm going to > >back-track > >and posit that a simple per-WC switch should suffice for the

Re: New release

2022-01-13 Thread Johan Corveleyn
On Tue, Jan 11, 2022 at 5:12 PM Daniel Sahlberg wrote: > Den tis 11 jan. 2022 15:34Julian Foad skrev: >> >> Johan Corveleyn wrote: >> > Thanks for starting to get this ball rolling, Daniel. >> >> Seconded. >> >> >> I have been pondering the q

Re: New release

2022-01-11 Thread Johan Corveleyn
Thanks for starting to get this ball rolling, Daniel. On Thu, Jan 6, 2022 at 6:41 AM Nathan Hartman wrote: ... > I have been pondering the question of which release(s) and in what > order. I think 1.14.2 and 1.10.8 first, then 1.15.x later. +1 > Regarding drumming up support for the backports:

Re: Jira issues cleanup

2022-01-11 Thread Johan Corveleyn
Late to the party, but: thanks for doing this. Some more below. On Tue, Dec 28, 2021 at 12:20 PM Daniel Sahlberg wrote: > > Thanks Nathan for the quick review! > > I'm going to continue to add to this mail to have "one mail to rule them all" > and add more issues to the end as I go along. Please

Re: A strong WTF on compiling out plaintext password support by default?!

2021-10-03 Thread Johan Corveleyn
t, following the example set by OpenBSD. > Four persons seem to have expressed support for this idea (Mark Phippard, Johan Corveleyn, myself (2021-08-26 13:34 to 2021-08-27 07:56) and Martin Edgar Furter Rathod (2021-08-31 12:46)). The former three prefering it over the svn auth, but accepting the

Re: SVN 1.14.1 slightly broken on Windows for working copies in drive root?

2021-09-30 Thread Johan Corveleyn
On Thu, Sep 30, 2021 at 11:24 AM Thomas Singer wrote: > > Hello, > > I have a working copy of the SVN repository at D:\src\svn. With SVN > 1.14.1 binaries I'm getting following status output > > D:\src\svn>svn.exe status -u > Status against revision: 1893746 > > When I create a 'substed' drive G:

Re: Subversion on Solaris (was Re: A strong WTF on compiling out plaintext password support by default?!)

2021-09-02 Thread Johan Corveleyn
On Thu, Sep 2, 2021 at 7:29 AM Daniel Sahlberg wrote: > > Den mån 23 aug. 2021 kl 12:15 skrev Johan Corveleyn : >> >> Anyway, concerning package maintainers, for Solaris, I'm getting even >> more depressed ... >> * We were using Collab.net's distro, but

Re: A strong WTF on compiling out plaintext password support by default?!

2021-08-27 Thread Johan Corveleyn
On Fri, Aug 27, 2021 at 2:03 PM Daniel Shahaf wrote: > > Consensus can only result from an open discussion. That's a standard > ASF operating principle. > > The rhetoric in this thread effects chill on anyone who has an opinion > different from the opinion of certain speakers. I must say I have

Re: A strong WTF on compiling out plaintext password support by default?!

2021-08-27 Thread Johan Corveleyn
On Thu, Aug 26, 2021 at 3:44 PM Mark Phippard wrote: > > On Thu, Aug 26, 2021 at 6:30 AM Stefan Sperling wrote: > > > The answer might be that 'svn authz add' should simply not contact the > > server to check credentials. Which means we cannot check upfront whether > > the user running 'svn auth

Re: A strong WTF on compiling out plaintext password support by default?!

2021-08-26 Thread Johan Corveleyn
On Thu, Aug 26, 2021 at 4:31 PM Daniel Shahaf wrote: > > Johan Corveleyn wrote on Thu, 26 Aug 2021 12:41 +00:00: > > On Wed, Aug 25, 2021 at 8:52 PM Daniel Shahaf > > wrote: > > > This thread is on dev@ as opposed to users@, so I'm trying to solve the > > &

Re: A strong WTF on compiling out plaintext password support by default?!

2021-08-26 Thread Johan Corveleyn
On Wed, Aug 25, 2021 at 8:52 PM Daniel Shahaf wrote: > Johan Corveleyn wrote on Wed, 25 Aug 2021 07:16 +00:00: > > On Tue, Aug 24, 2021 at 7:03 PM Daniel Shahaf > > wrote: > > > Johan Corveleyn wrote on Tue, 24 Aug 2021 15:22 +00:00: > > > > On Tue, A

Re: A strong WTF on compiling out plaintext password support by default?!

2021-08-25 Thread Johan Corveleyn
On Tue, Aug 24, 2021 at 7:03 PM Daniel Shahaf wrote: > Johan Corveleyn wrote on Tue, 24 Aug 2021 15:22 +00:00: > > On Tue, Aug 24, 2021 at 4:45 PM Daniel Shahaf > > wrote: > > > Johan Corveleyn wrote on Tue, 24 Aug 2021 14:25 +00:00: > > > > OTOH, if this

Re: A strong WTF on compiling out plaintext password support by default?!

2021-08-24 Thread Johan Corveleyn
On Tue, Aug 24, 2021 at 4:45 PM Daniel Shahaf wrote: > > Johan Corveleyn wrote on Tue, 24 Aug 2021 14:25 +00:00: > > OTOH, if this kind of behaviour is too far-fetched for a single > > subcommand, I might be able to do it by invoking two commands, if I > > could succesfull

Re: A strong WTF on compiling out plaintext password support by default?!

2021-08-24 Thread Johan Corveleyn
On Tue, Aug 24, 2021 at 1:24 PM Stefan Sperling wrote: > > On Tue, Aug 24, 2021 at 12:16:48PM +0200, Johan Corveleyn wrote: > > But: obviously I have disabled, in the runtime config area, the > > warning prompt that "Your password will be stored in plaintext" (I >

Re: A strong WTF on compiling out plaintext password support by default?!

2021-08-24 Thread Johan Corveleyn
[ sorry Robby, I left you out of a previous reply -- looping you back in in case you're interested in this tangent ... ] On Tue, Aug 24, 2021 at 10:34 AM Stefan Sperling wrote: > > On Mon, Aug 23, 2021 at 02:45:44PM +0200, Johan Corveleyn wrote: > > Thanks, those are good effor

Re: A strong WTF on compiling out plaintext password support by default?!

2021-08-23 Thread Johan Corveleyn
On Mon, Aug 23, 2021 at 1:50 PM Nathan Hartman wrote: > > On Mon, Aug 23, 2021 at 6:15 AM Johan Corveleyn wrote: >> >> On Fri, Aug 7, 2020 at 7:01 AM Robby Zinchak wrote: >> > >> > Small rant here from a very long time subversion user, regarding >>

Re: A strong WTF on compiling out plaintext password support by default?!

2021-08-23 Thread Johan Corveleyn
On Fri, Aug 7, 2020 at 7:01 AM Robby Zinchak wrote: > > Small rant here from a very long time subversion user, regarding subversion > project's decision to compile out plaintext password storage by default > (https://marc.info/?l=subversion-commits&m=154101482302608&w=2). > > There are a tremend

Re: [PATCH] limit diff effort to fix performance issue

2021-06-09 Thread Johan Corveleyn
On Tue, Jun 8, 2021 at 3:29 PM Nathan Hartman wrote: > > On Tue, Jun 8, 2021 at 5:55 AM Stefan Sperling wrote: > > > > On Tue, Jun 08, 2021 at 01:45:00AM -0400, Nathan Hartman wrote: > > > In order to do some testing, I needed some test data that reproduces > > > the issue; since stsp can't share

Re: [PATCH] limit diff effort to fix performance issue

2021-06-08 Thread Johan Corveleyn
On Tue, Jun 8, 2021 at 3:24 PM Stefan Sperling wrote: > > On Tue, Jun 08, 2021 at 02:57:34PM +0200, Johan Corveleyn wrote: > > Okay, I focused on the first revision causing the annotate to differ, > > and with some debug logging: > > - p went up to 139 > > -

Re: [PATCH] limit diff effort to fix performance issue

2021-06-08 Thread Johan Corveleyn
On Sun, Jun 6, 2021 at 4:57 PM Stefan Sperling wrote: > > On Sat, Jun 05, 2021 at 08:56:24PM +0200, Johan Corveleyn wrote: > > Hmm, I tried this patch with my "annotate large XML file with deep > > history test", but the result isn't the same as with 1.14. I

Re: [PATCH] limit diff effort to fix performance issue

2021-06-05 Thread Johan Corveleyn
On Thu, Jun 3, 2021 at 12:57 PM Stefan Sperling wrote: > > On Wed, Jun 02, 2021 at 02:20:12PM +0200, Stefan Sperling wrote: > > The patch below implements an effort limit for Subversion's LCS diff. > > Here is an updated version of this patch. I took a closer look at > other diff implementations a

Re: [PATCH] limit diff effort to fix performance issue

2021-06-02 Thread Johan Corveleyn
On Wed, Jun 2, 2021 at 4:05 PM Daniel Shahaf wrote: > > Stefan Sperling wrote on Wed, 02 Jun 2021 12:20 +00:00: > > The test suite is passing, which implies that trivial diffs aren't affected > > by this change. I expect that most, if not all, diffs which people actually > > want to read will rema

Re: Migrate off Freenode IRC?

2021-05-20 Thread Johan Corveleyn
On Thu, May 20, 2021 at 4:24 PM Nathan Hartman wrote: > > On Thu, May 20, 2021 at 7:18 AM Stefan Sperling wrote: >> >> >> In order to signal our move to the new IRC service, I believe we should >> mark our freenode channels as 'moved to libera.chat' in their topic lines, >> as soon as we have con

Re: Commit reviews' author statistics: bus factor issue?

2021-04-28 Thread Johan Corveleyn
On Sun, Apr 25, 2021 at 4:44 PM Nathan Hartman wrote: > > On Fri, Apr 23, 2021 at 9:40 AM Daniel Shahaf wrote: > > > > Nathan Hartman wrote on Thu, 22 Apr 2021 21:41 +00:00: > > > Not knowing whether / how many people have reviewed a particular > > > commit is, as was said elsewhere, a silent fai

Re: Commit reviews' author statistics: bus factor issue?

2021-04-22 Thread Johan Corveleyn
On Thu, Apr 22, 2021 at 9:22 PM Daniel Shahaf wrote: > > [ Forwarding from private@ with an addition between triple dashes and > some paragraphs omitted altogether. ] > > Methodology: In my dev@ mailbox, I looked at "Re: svn commit" threads > where the subject line contained "trunk" somewhere, fil

Re: JavaHL test failure and warning in 1.14.1

2021-02-19 Thread Johan Corveleyn
On Thu, Feb 18, 2021 at 10:19 PM Alexandr Miloslavskiy wrote: > > Going to take longer, sorry. I'm bombarded with things to take care > of... While trying to have vacation, huh. Again, of the flaky test > stands in the way, I wouldn't mind of you just comment it out for now. Please enjoy your vac

Re: JavaHL test failure and warning in 1.14.1

2021-02-14 Thread Johan Corveleyn
On Fri, Feb 12, 2021 at 6:36 PM James McCoy wrote: > > One of the new JavaHL tests > (testCrash_RequestChannel_nativeRead_AfterException) is failing on > Debian's armhf, mips64el, mipsel, and powerpc builders: > > https://buildd.debian.org/status/logs.php?pkg=subversion&ver=1.14.1-1&suite=sid > >

Re: svn commit: r45955 - /dev/subversion/ /release/subversion/

2021-02-10 Thread Johan Corveleyn
On Wed, Feb 10, 2021 at 2:23 PM Stefan Sperling wrote: > > On Wed, Feb 10, 2021 at 02:16:31PM +0100, Johan Corveleyn wrote: > > On Wed, Feb 10, 2021 at 12:27 PM wrote: > > > > > > Author: stsp > > > Date: Wed Feb 10 11:27:48 2021 > > > Ne

Re: svn commit: r45955 - /dev/subversion/ /release/subversion/

2021-02-10 Thread Johan Corveleyn
On Wed, Feb 10, 2021 at 12:27 PM wrote: > > Author: stsp > Date: Wed Feb 10 11:27:48 2021 > New Revision: 45955 > > Log: > Publish Subversion-1.14.1. Hi Stefan, Don't we need at least 3 votes? Or did you mean to count also your own (implicit perhaps, as RM), in addition to Brane's and mine? If s

Re: Subversion 1.10.7 up for testing/signing

2021-02-07 Thread Johan Corveleyn
On Thu, Feb 4, 2021 at 1:57 PM Stefan Sperling wrote: > > The 1.10.7 release artifacts are now available for testing/signing. > Please get the tarballs from > https://dist.apache.org/repos/dist/dev/subversion > and add your signatures there. > > Thanks! Summary --- +1 to release Platform -

Re: Subversion 1.14.1 up for testing/signing

2021-02-07 Thread Johan Corveleyn
On Thu, Feb 4, 2021 at 1:56 PM Stefan Sperling wrote: > > The 1.14.1 release artifacts are now available for testing/signing. > Please get the tarballs from > https://dist.apache.org/repos/dist/dev/subversion > and add your signatures there. > > Thanks! Summary --- +1 to release (Windows)

Re: Release note entry for 1.14.1 Fix for issue #4762 "authz doesn't combine global and repository rules"?

2021-01-29 Thread Johan Corveleyn
On Fri, Jan 29, 2021 at 9:46 PM Stefan Sperling wrote: > > On Fri, Jan 29, 2021 at 09:29:52PM +0100, Johan Corveleyn wrote: > > I was wondering whether the change in authz behavior, by fixing #4762, > > should be called out explicitly in the 1.14 release notes (maybe > >

Re: svn commit: r1882518 - /subversion/branches/javahl-1.14-fixes/subversion/bindings/javahl/tests/org/apache/subversion/javahl/BasicTests.java

2021-01-29 Thread Johan Corveleyn
On Fri, Jan 29, 2021 at 9:29 PM Alexandr Miloslavskiy wrote: > > On 29.01.2021 20:51, Johan Corveleyn wrote: > > > Fingers crossed for a second vote in STATUS now :-). > > Did that, hopefully I didn't mess anything up, it's my first experience > with it :) Lo

Release note entry for 1.14.1 Fix for issue #4762 "authz doesn't combine global and repository rules"?

2021-01-29 Thread Johan Corveleyn
I was wondering whether the change in authz behavior, by fixing #4762, should be called out explicitly in the 1.14 release notes (maybe somewhere in the "Known issues" section, describing the issue of 1.14.0, and how it is fixed in 1.14.1). And if we would also backport it to 1.10.x (it currently

Re: svn commit: r1882518 - /subversion/branches/javahl-1.14-fixes/subversion/bindings/javahl/tests/org/apache/subversion/javahl/BasicTests.java

2021-01-29 Thread Johan Corveleyn
On Thu, Jan 28, 2021 at 11:28 AM Johan Corveleyn wrote: ... > With that, the branch looks good to me, and I think we should merge > this to trunk, and then nominate it (the merge-to-trunk commit I > guess) for backport to 1.14 (concretely, this means adding an entry to > 1.14

Re: Escaping SVN_EDITOR broken on Windows

2021-01-28 Thread Johan Corveleyn
On Thu, Jan 28, 2021 at 4:22 PM Yasuhito FUTATSUKI wrote: > > On 2021/01/28 20:13, Johan Corveleyn wrote: > > On Thu, Jan 28, 2021 at 12:55 AM Yasuhito FUTATSUKI > > wrote: > >> > >> On 2021/01/28 7:33, Johan Corveleyn wrote: > >>> On Wed, Jan 27,

  1   2   3   4   5   6   7   8   9   10   >