On Sun, Nov 17, 2024 at 11:04 PM Daniel Sahlberg < daniel.l.sahlb...@gmail.com> wrote: ... > r1921266 and r1921267: Seems simple enough but needs to be tested by someone with a working win32 environment (I'm still struggling). @Johan Corveleyn ?
Doh! I tested these already but forgot to vote. I'll add my vote asap. Now, I'm not sure whether 2 votes suffice for these to be approved for backport. Our community guide says [1]: "a change that affects only areas that are not core code (for example, tools/, packages/, bindings/, test scripts, etc.), and that does *not affect the build system*, can go in with one +1 from a full committer or a partial committer for that area, at least one +0 or "concept +1" from any other committer, and no vetoes." I suppose these are changes to the build system (gen-make.py: detection of zlib version; suppressing errors while detecting perl/ruby versions), so would require 3 votes for backport, no? Perhaps a "concept +1", by a committer who just reviews textually would be OK. Or am I interpreting this rule too strict, since this is only about detecting dependencies (some of which are optional, like perl and ruby)? [1] https://subversion.apache.org/docs/community-guide/releasing.html#release-stabilization-how-many-votes -- Johan
