Noorul Islam K M writes:
> Log
> [[[
>
> Follow-up to r1138830. Remove comment in test which became absolute
> after r1138830. Add new comment related to issue #3936.
>
> * subversion/tests/cmdline/log_tests.py
> (log_with_unrelated_peg_and_operative_revs): Fix absolute comment and
> add n
Log
[[[
Follow-up to r1138830. Remove comment in test which became absolute
after r1138830. Add new comment related to issue #3936.
* subversion/tests/cmdline/log_tests.py
(log_with_unrelated_peg_and_operative_revs): Fix absolute comment and
add new relevant one.
Patch by: Noorul Islam K
Daniel came up with idea of extending Makefile.in to support 'make
check' variants.
1. 'make check' with svnserve -T
2. 'make check' with svnadmin create --pre-1.x-compatible (where x in
(1.4, 1.5, 1.6, 1.7))
3. 'make check' with SVNPathAuthz short_circuit. As of now this is
supported by st
I have recently looked into issue 3830 (forward revision range) and thereby
found issue 3931 (returning log of unrelated path).
While implementing support for forward revision ranges i came across various
cases, where i would like to resolve what is actually expected/desired:
- what "svn log" cu
On 23.06.2011 22:59, Bert Huijben wrote:
>
>> -Original Message-
>> From: Greg Stein [mailto:gst...@gmail.com]
>> Sent: donderdag 23 juni 2011 22:30
>> To: Bert Huijben
>> Cc: dev@subversion.apache.org
>> Subject: Re: svn commit: r1132968 - in
>> /subversion/trunk/subversion/include: svn_ty
On Thu, Jun 23, 2011 at 17:20, wrote:
>...
> +++ subversion/trunk/subversion/libsvn_wc/wc_db.c Thu Jun 23 21:20:49 2011
> @@ -6068,16 +6068,15 @@ op_delete_txn(void *baton,
> SVN_ERR(svn_sqlite__step(&have_row, stmt));
> if (have_row)
> {
> - const char *absent_path
> - = svn_
On Thu, Jun 23, 2011 at 18:24, wrote:
> Author: hwright
> Date: Thu Jun 23 22:24:53 2011
> New Revision: 1139096
>
> URL: http://svn.apache.org/viewvc?rev=1139096&view=rev
> Log:
> Update news sections of the website to reflect 1.7.0-alpha2.
>
> * publish/ne
Well, since issue 3931 was fixed today
('svn log' is returning log of unrelated path when peg revision is not related
to operative revision)
i revisited my patch for issue 3830.
+ /* try fetching ra_session again
+ * this time with modified revision argument.
+ * @todo modify already existing
I'm happy to announce Apache Subversion 1.7.0-alpha2, the next public
pre-release of the 1.7.x series, is now available. Please choose the closest
mirror to you by visiting:
http://subversion.apache.org/download/#pre-releases
The SHA1 checksums are:
05cebe1817e171e20dcf5ffa6dce9612217525
The error in the subject has been showing up on the Mac OS X
buildslaves for the past few days (see
http://ci.apache.org/builders/svn-x64-macosx-gnu-shared/builds/1388/steps/Build/logs/stdio),
but nobody has done much about it.
However, this afternoon I ran autogen.sh and configure on my own trunk
Bert Huijben wrote on Thu, Jun 23, 2011 at 23:31:42 +0200:
>
>
> > -Original Message-
> > From: Daniel Shahaf [mailto:d...@daniel.shahaf.name]
> > Sent: donderdag 23 juni 2011 23:26
> > To: Bert Huijben
> > Cc: 'Greg Stein'; dev@subversion.apache.org
> > Subject: Re: svn commit: r1132968
> -Original Message-
> From: Daniel Shahaf [mailto:d...@daniel.shahaf.name]
> Sent: donderdag 23 juni 2011 23:26
> To: Bert Huijben
> Cc: 'Greg Stein'; dev@subversion.apache.org
> Subject: Re: svn commit: r1132968 - in
> /subversion/trunk/subversion/include: svn_types.h svn_version.h
>
>
Bert Huijben wrote on Thu, Jun 23, 2011 at 22:59:47 +0200:
>
>
> > -Original Message-
> > From: Greg Stein [mailto:gst...@gmail.com]
> > Sent: donderdag 23 juni 2011 22:30
> > To: Bert Huijben
> > Cc: dev@subversion.apache.org
> > Subject: Re: svn commit: r1132968 - in
> > /subversion/tru
Stefan,
[[[
/* A single dictionary entry. Since they are allocated statically, these
* entries can either be in use or in used state. An entry is unused, iff
* the offset member is NO_OFFSET. In that case, it must not be linked in
* the list of used entries.
*/
typedef struct entry_t
]]]
Firs
[C. Michael Pilato]
> - spool the diff, count the lines in it, and provide that count in
> some fashion
> - indent the diff by a single column
> - wrap the whole diff in some start/end markers ("[[[" and "]]]", e.g.)
I like the last option, except that I'd use "\n" as the end marker, an
On Thu, Jun 23, 2011 at 4:59 PM, Bert Huijben wrote:
> But most importantly
> #define SVN_VER_TAG " (under development)"
> #define SVN_VER_NUMTAG "-dev"
> #define SVN_VER_REVISION 0
>
> These are redefined by third party distributions that somehow influence how
> Subversion is built
> -Original Message-
> From: Greg Stein [mailto:gst...@gmail.com]
> Sent: donderdag 23 juni 2011 22:30
> To: Bert Huijben
> Cc: dev@subversion.apache.org
> Subject: Re: svn commit: r1132968 - in
> /subversion/trunk/subversion/include: svn_types.h svn_version.h
>
> On Thu, Jun 23, 2011 at
On Thu, Jun 23, 2011 at 15:47, Bert Huijben wrote:
>> -Original Message-
>> From: Greg Stein [mailto:gst...@gmail.com]
>> Sent: donderdag 23 juni 2011 21:01
>> To: dev@subversion.apache.org
>> Subject: Re: svn commit: r1132968 - in
>> /subversion/trunk/subversion/include: svn_types.h svn_v
On Thu, Jun 23, 2011 at 03:32:37PM -0400, C. Michael Pilato wrote:
> On 06/23/2011 03:18 PM, Mark Phippard wrote:
> > Why do we have to do anything? There is no danger of breaking
> > existing scripts here because this requires adding an additional
> > option. Do we just feel like it would be imp
Hi Bert,
this patch seems to solve issue 3917 on pburba's test pc. Given the
error location you mentioned in desc6 I suspect it's the same issue.
Can you test and see if it solves it for you?
thanks,
Lieven
Index: outgoing.c
===
-
On Thu, Jun 23, 2011 at 2:47 PM, Bert Huijben wrote:
>> -Original Message-
>> From: Greg Stein [mailto:gst...@gmail.com]
>> Sent: donderdag 23 juni 2011 21:01
>> To: dev@subversion.apache.org
>> Subject: Re: svn commit: r1132968 - in
>> /subversion/trunk/subversion/include: svn_types.h svn
> -Original Message-
> From: Greg Stein [mailto:gst...@gmail.com]
> Sent: donderdag 23 juni 2011 21:01
> To: dev@subversion.apache.org
> Subject: Re: svn commit: r1132968 - in
> /subversion/trunk/subversion/include: svn_types.h svn_version.h
>
> On Tue, Jun 7, 2011 at 08:14, wrote:
> > A
On 06/23/2011 03:18 PM, Mark Phippard wrote:
> Why do we have to do anything? There is no danger of breaking
> existing scripts here because this requires adding an additional
> option. Do we just feel like it would be impossible to parse the
> current output? Can't --xml be used?
The current o
C. Michael Pilato wrote on Thu, Jun 23, 2011 at 15:15:08 -0400:
> We discussed in IRC some solutions:
>
> - spool the diff, count the lines in it, and provide that count in
> some fashion
> - indent the diff by a single column
> - wrap the whole diff in some start/end markers ("[[[" and
On Thu, Jun 23, 2011 at 3:15 PM, C. Michael Pilato wrote:
> When we designed 'svn log' many moons ago, we added the "N lines" header
> information to aid parsers of the output. Most of us had had poor
> experiences with parsers looking for sentinel lines which could themselves
> appear inside the
When we designed 'svn log' many moons ago, we added the "N lines" header
information to aid parsers of the output. Most of us had had poor
experiences with parsers looking for sentinel lines which could themselves
appear inside the delimited content. We didn't want to see folks writing
scripts ar
On Tue, Jun 7, 2011 at 08:14, wrote:
> Author: rhuijben
> Date: Tue Jun 7 12:14:14 2011
> New Revision: 1132968
>
> URL: http://svn.apache.org/viewvc?rev=1132968&view=rev
> Log:
> Following up on r1132965, just move the type. This matches how we handled the
> problem for svn_error_t.
>
> * subve
On 23 Jun 2011, at 19:00, Daniel Shahaf wrote:
> This is a part of r1134734. Backport proposed. Thanks!
Great, thanks Daniel.
Simon
On Thu, Jun 23, 2011 at 1:17 PM, Julian Foad wrote:
> Greg Stein wrote:
>> Thanks for taking the time to do thus. Only recently did I realize that I
>> named the function incorrectly when I came up with it. In PoCore, I called
>> it pc_error_trace(), for the same reasons you suggested here.
>
> OK
Greg Stein wrote:
> Thanks for taking the time to do thus. Only recently did I realize that I
> named the function incorrectly when I came up with it. In PoCore, I called
> it pc_error_trace(), for the same reasons you suggested here.
OK, I'll do it.
Does anyone want me to leave "svn_error_return
Thanks for taking the time to do thus. Only recently did I realize that I
named the function incorrectly when I came up with it. In PoCore, I called
it pc_error_trace(), for the same reasons you suggested here.
On Jun 23, 2011 9:20 AM, "Julian Foad" wrote:
>
> On Thu, 2011-06-23 at 09:15 -0400, C
Bert Huijben wrote:
> Javahl always calls status with an abspath target as its conversion to
> a c string does that.
OK, thanks. In r1139008 I've fixed the doc string and also documented a
promise that svn_client_status5() will send an abspath to the callback
if given an abspath.
- Julian
> Be
Javahl always calls status with an abspath target as its conversion to
a c string does that.
Bert Huijben (Cell phone) From: Julian Foad
Sent: donderdag 23 juni 2011 18:48
To: dev@subversion.apache.org; Hyrum Wright
Subject: svn_client_status_func_t callback - Java binding may expect an
abspath
Hy
On 23 Jun 2011, at 17:32, Daniel Shahaf wrote:
>> when trying to build SVN 1.6 from this branch:
>> http://svn.apache.org/repos/asf/subversion/branches/1.6.x
>> get-deps.sh fails, because sqlite-amalgamation has been moved:
>>
>> --2011-06-23 14:47:38--
>> http://www.sqlite.org/sqlite-amalgamation
Simon Olofsson wrote on Thu, Jun 23, 2011 at 18:14:20 +0200:
> On 23 Jun 2011, at 17:32, Daniel Shahaf wrote:
> >> when trying to build SVN 1.6 from this branch:
> >> http://svn.apache.org/repos/asf/subversion/branches/1.6.x
> >> get-deps.sh fails, because sqlite-amalgamation has been moved:
> >>
Hyrum or anyone,
svn_client_status_func_t is declared as
/** A callback for reporting a @a status about @a local_abspath.
... */
typedef svn_error_t *(*svn_client_status_func_t)(
void *baton,
const char *path,
moving to dev@
Simon Olofsson wrote on Thu, Jun 23, 2011 at 15:05:39 +0200:
> Hi,
>
> when trying to build SVN 1.6 from this branch:
> http://svn.apache.org/repos/asf/subversion/branches/1.6.x
> get-deps.sh fails, because sqlite-amalgamation has been moved:
>
> --2011-06-23 14:47:38--
> http://
On Thu, Jun 23, 2011 at 04:55:22PM +0200, Stefan Sperling wrote:
> For the record here is the log message and diff to make this change.
> Index: subversion/libsvn_wc/wc_db.h
> ===
> --- subversion/libsvn_wc/wc_db.h (revision 1138
On Thu, Jun 23, 2011 at 04:35:36PM +0200, Stefan Sperling wrote:
> On Thu, Jun 23, 2011 at 10:17:19AM -0400, C. Michael Pilato wrote:
> > On 06/23/2011 10:09 AM, Stefan Sperling wrote:
> > > On Thu, Jun 23, 2011 at 09:59:48AM -0400, C. Michael Pilato wrote:
> > >> Now, I'm fine with using something
On Thu, 2011-06-23 at 16:35 +0200, Stefan Sperling wrote:
> On Thu, Jun 23, 2011 at 10:17:19AM -0400, C. Michael Pilato wrote:
> > On 06/23/2011 10:09 AM, Stefan Sperling wrote:
> > > On Thu, Jun 23, 2011 at 09:59:48AM -0400, C. Michael Pilato wrote:
> > >> Now, I'm fine with using something other
On 06/23/2011 10:35 AM, Stefan Sperling wrote:
> On Thu, Jun 23, 2011 at 10:17:19AM -0400, C. Michael Pilato wrote:
>> On 06/23/2011 10:09 AM, Stefan Sperling wrote:
>>> On Thu, Jun 23, 2011 at 09:59:48AM -0400, C. Michael Pilato wrote:
Now, I'm fine with using something other than "absent" ("
On Thu, Jun 23, 2011 at 10:17:19AM -0400, C. Michael Pilato wrote:
> On 06/23/2011 10:09 AM, Stefan Sperling wrote:
> > On Thu, Jun 23, 2011 at 09:59:48AM -0400, C. Michael Pilato wrote:
> >> Now, I'm fine with using something other than "absent" ("omitted",
> >> "withheld", ...), but -1 on any ter
On Wed, Jun 22, 2011 at 8:12 PM, C. Michael Pilato wrote:
> On 06/22/2011 05:06 PM, Hyrum K Wright wrote:
>> Thanks to those have have provided signatures. I've sent the tarballs
>> to the mirrors for distribution. The official release should happen
>> tomorrow.
>
> Better late than never? (Tes
On 06/23/2011 10:09 AM, Stefan Sperling wrote:
> On Thu, Jun 23, 2011 at 09:59:48AM -0400, C. Michael Pilato wrote:
>> Now, I'm fine with using something other than "absent" ("omitted",
>> "withheld", ...), but -1 on any terminology that allows the WC to presume to
>> know what it simply cannot.
>
On Thu, Jun 23, 2011 at 09:59:48AM -0400, C. Michael Pilato wrote:
>
> On 06/23/2011 09:33 AM, s...@apache.org wrote:
> > Author: stsp
> > Date: Thu Jun 23 13:33:57 2011
> > New Revision: 1138871
> >
> > URL: http://svn.apache.org/viewvc?rev=1138871&view=rev
> > Log:
> > As part of internal API c
On 06/23/2011 09:33 AM, s...@apache.org wrote:
> Author: stsp
> Date: Thu Jun 23 13:33:57 2011
> New Revision: 1138871
>
> URL: http://svn.apache.org/viewvc?rev=1138871&view=rev
> Log:
> As part of internal API cleanup, and in the name of code clarity,
> rename svn_wc__db_status_absent to svn_wc_
I (Julian Foad) wrote:
> On Thu, 2011-06-23 at 13:33 +0200, Bert Huijben wrote:
> >
> > > -Original Message-
> > > From: Julian Foad [mailto:julian.f...@wandisco.com]
> > > Sent: donderdag 23 juni 2011 12:37
> > > To: Subversion Development
> > > Subject: API review - the 'commit_as_operat
On Thu, 2011-06-23 at 13:33 +0200, Bert Huijben wrote:
>
> > -Original Message-
> > From: Julian Foad [mailto:julian.f...@wandisco.com]
> > Sent: donderdag 23 juni 2011 12:37
> > To: Subversion Development
> > Subject: API review - the 'commit_as_operations' flag on
> > svn_client_commit5(
> -Original Message-
> From: Julian Foad [mailto:julian.f...@wandisco.com]
> Sent: donderdag 23 juni 2011 15:20
> To: C. Michael Pilato
> Cc: Subversion
> Subject: Re: [RFC] Rename 'svn_error_return' to 'svn_error_trace'?
>
> On Thu, 2011-06-23 at 09:15 -0400, C. Michael Pilato wrote:
>
On Thu, 2011-06-23 at 09:15 -0400, C. Michael Pilato wrote:
> On 06/23/2011 09:13 AM, Stefan Sperling wrote:
> > To avoid this problem we could call it svn_error_trace1, or even
> > svn_error_trace2 since it is technically an upgrade from svn_error_return :)
>
> Or svn_error_traced() indicating th
C. Michael Pilato wrote on Thu, Jun 23, 2011 at 09:15:24 -0400:
> On 06/23/2011 09:13 AM, Stefan Sperling wrote:
> > To avoid this problem we could call it svn_error_trace1, or even
> > svn_error_trace2 since it is technically an upgrade from svn_error_return :)
>
> Or svn_error_traced() indicatin
On 06/23/2011 09:13 AM, Stefan Sperling wrote:
> To avoid this problem we could call it svn_error_trace1, or even
> svn_error_trace2 since it is technically an upgrade from svn_error_return :)
Or svn_error_traced() indicating that we've traced the error to this spot
(so far). :-)
--
C. Michael
On Thu, Jun 23, 2011 at 08:57:28AM -0400, C. Michael Pilato wrote:
> Omigosh. +1. I, too, know we're well into bikeshed territory here, but if
> we're going to paint our sheds anyway, why use only a clear-coat stain
> ("return svn_error_return(...)")? Use a color that says something!
Yes, +1!
C. Michael Pilato wrote on Thu, Jun 23, 2011 at 08:57:28 -0400:
> Omigosh. +1. I, too, know we're well into bikeshed territory here, but if
> we're going to paint our sheds anyway, why use only a clear-coat stain
> ("return svn_error_return(...)")? Use a color that says something!
>
> "svn_erro
Omigosh. +1. I, too, know we're well into bikeshed territory here, but if
we're going to paint our sheds anyway, why use only a clear-coat stain
("return svn_error_return(...)")? Use a color that says something!
"svn_error_trace" is a fine choice of a name. Just a pity that it's a
character sh
Noorul Islam K M wrote on Thu, Jun 23, 2011 at 15:25:37 +0530:
> "Bert Huijben" writes:
>
> >> -Original Message-
> >> From: Noorul Islam K M [mailto:noo...@collab.net]
> >> Sent: donderdag 23 juni 2011 5:44
> >> To: Daniel Shahaf
> >> Cc: Julian Foad; Subversion; Bert Huijben
> >> Subjec
> -Original Message-
> From: Julian Foad [mailto:julian.f...@wandisco.com]
> Sent: donderdag 23 juni 2011 12:37
> To: Subversion Development
> Subject: API review - the 'commit_as_operations' flag on
> svn_client_commit5()
>
> I'd like to understand the new 'commit_as_operations' flag on
Stefan Sperling writes:
> On Thu, Jun 23, 2011 at 03:25:37PM +0530, Noorul Islam K M wrote:
>
>> I thought if the patch was incorrect, I might be getting some feedback.
>
> Sorry, sometimes things just fall through the cracks :(
>
> Please don't take this as something personal.
Nothing personal
Stefan Sperling writes:
> On Thu, Jun 23, 2011 at 04:02:23PM +0530, Noorul Islam K M wrote:
>
>>
>> Log
>>
>> [[[
>>
>> Fix for issue 3931. 'svn log' is returning log of unrelated path when
>> peg revision is not related to operative revision. This is happening
>> when HEAD is used in operat
On Thu, Jun 23, 2011 at 04:02:23PM +0530, Noorul Islam K M wrote:
>
> Log
>
> [[[
>
> Fix for issue 3931. 'svn log' is returning log of unrelated path when
> peg revision is not related to operative revision. This is happening
> when HEAD is used in operative range. This commit fixes this.
>
On Thu, Jun 23, 2011 at 03:25:37PM +0530, Noorul Islam K M wrote:
> I thought if the patch was incorrect, I might be getting some feedback.
Sorry, sometimes things just fall through the cracks :(
Please don't take this as something personal.
Communications can be delayed or simply get lost since
On Mon, 2011-06-20, Julian Foad wrote:
> On Wed, 2011-06-15, Stefan Fuhrmann wrote:
> > On 15.06.2011 15:29, Julian Foad wrote:
> > > A heads-up: I'm renaming svn_hash_get_bool() to
> > > svn_config_hash_get_bool(), and svn_hash_get_cstring() to
> > > svn_config_hash_get(), moving them from svn_ha
I'd like to understand the new 'commit_as_operations' flag on
svn_client_commit5() a bit better. First, note that the old commit4()
API passes FALSE. The doc string says:
* If @a commit_as_operations is set to FALSE, when a copy is committed
* all changes below the copy are always committed at
Log
[[[
Fix for issue 3931. 'svn log' is returning log of unrelated path when
peg revision is not related to operative revision. This is happening
when HEAD is used in operative range. This commit fixes this.
* subversion/libsvn_client/log.c
(svn_client_log5): Handle HEAD in operative revis
Another new-in-1.7 API. A rather trivial one, this, and I don't want
this to be a long bikeshed discussion, but just looking at usage of the
new svn_error_return() macro, typified by these examples ...
cmt_err = svn_error_return(
check_nonrecursive_dir_delete(ctx->wc_ctx, ...));
"Bert Huijben" writes:
>> -Original Message-
>> From: Noorul Islam K M [mailto:noo...@collab.net]
>> Sent: donderdag 23 juni 2011 5:44
>> To: Daniel Shahaf
>> Cc: Julian Foad; Subversion; Bert Huijben
>> Subject: Re: [PATCH] Fix for issue 3813
>>
>> Daniel Shahaf writes:
>>
>> > Looks
> -Original Message-
> From: Noorul Islam K M [mailto:noo...@collab.net]
> Sent: donderdag 23 juni 2011 5:44
> To: Daniel Shahaf
> Cc: Julian Foad; Subversion; Bert Huijben
> Subject: Re: [PATCH] Fix for issue 3813
>
> Daniel Shahaf writes:
>
> > Looks like Bert committed a functionally
Daniel Shahaf writes:
> What if httpd or serf use apr-1.4.5 compiled with options X and
> Subversion find apr-1.4.5 compiled with options Y?
The user can always break things. They could build Subversion against
APR and then rebuild APR with different options.
I suppose we (somebody with more d
68 matches
Mail list logo
