> -----Original Message----- > From: Julian Foad [mailto:julian.f...@wandisco.com] > Sent: donderdag 23 juni 2011 15:20 > To: C. Michael Pilato > Cc: Subversion > Subject: Re: [RFC] Rename 'svn_error_return' to 'svn_error_trace'? > > On Thu, 2011-06-23 at 09:15 -0400, C. Michael Pilato wrote: > > On 06/23/2011 09:13 AM, Stefan Sperling wrote: > > > To avoid this problem we could call it svn_error_trace1, or even > > > svn_error_trace2 since it is technically an upgrade from svn_error_return > :) > > > > Or svn_error_traced() indicating that we've traced the error to this spot > > (so far). :-) > > Looking closer... > > There are 695 uses of svn_error_return. > > 681 of them are "return svn_error_return(...);". > > The other 14 are "some_err = svn_error_return(...);". > > So if we're going to change the vast majority of these in any way, what > do folks feel about replacing them with > > SVN_ERR_RETURN(...) > > thus saving 9 characters of horizontal space?
+1 Maybe I should paint my shed like SVN_RETURN_ERR(...) Bert