On 21.05.2011 00:36, Hyrum K Wright wrote:
> This may be picking nits, but is the format for size_t and apr_size_t
> guaranteed to be the same on all platforms?
I expect it is. But even if it isn't it's certainly better than %d,
because sizeof(int) and sizeof(size_t) are certainly not guaranteed t
Hyrum K Wright writes:
> This is already nominated elsewhere in the file.
>
> (Hint: look in the 'Vetoed' section. :) )
Hmm,
-1: hwright (I'm not sure we need this: the merge conflicts, and the
assert isn't even in 1.6.x. I'm happy to remove this veto
This may be picking nits, but is the format for size_t and apr_size_t
guaranteed to be the same on all platforms?
-Hyrum
On Fri, May 20, 2011 at 4:17 AM, wrote:
> Author: philip
> Date: Fri May 20 11:17:58 2011
> New Revision: 1125327
>
> URL: http://svn.apache.org/viewvc?rev=1125327&view=rev
>
This is already nominated elsewhere in the file.
(Hint: look in the 'Vetoed' section. :) )
-Hyrum
On Fri, May 20, 2011 at 9:46 AM, wrote:
> Author: philip
> Date: Fri May 20 16:46:29 2011
> New Revision: 1125459
>
> URL: http://svn.apache.org/viewvc?rev=1125459&view=rev
> Log:
> * STATUS: prop
Stefan Sperling wrote on Fri, May 20, 2011 at 17:26:39 +0200:
> On Fri, May 20, 2011 at 04:28:55PM +0200, Neels J Hofmeyr wrote:
> > On 05/18/2011 09:38 PM, Branko Čibej wrote:
> > >On 17.05.2011 11:36, Stefan Sperling wrote:
> > >>On Tue, May 17, 2011 at 12:45:50AM +0200, Stefan Sperling wrote:
>
Log message and patch attached.
svnadmin create accepts the --config-dir option but no longer uses it
for anything. I do not believe we can remove the option from the UI,
but we can remove the code that get the configuration. The reason is
that I have observed a couple of odd scenarios where thi
I (Julian Foad) wrote:
> Thanks everyone. The consensus is for ".svn-base" so that's what I'll
> use.
r1125455 adds the code.
- Julian
[...]
> Also a reminder of what we agreed elsewhere in this thread: we'll
> combine this format bump with the one Bert's doing for externals.
On Fri, May 20, 2011 at 04:28:55PM +0200, Neels J Hofmeyr wrote:
> On 05/18/2011 09:38 PM, Branko Čibej wrote:
> >On 17.05.2011 11:36, Stefan Sperling wrote:
> >>On Tue, May 17, 2011 at 12:45:50AM +0200, Stefan Sperling wrote:
> >>>Any comments or objections?
> >>Neels didn't like the arbitrary "ro
On Fri, May 20, 2011 at 16:11, Ivan Zhakov wrote:
> On Fri, May 20, 2011 at 16:07, Greg Stein wrote:
>> On Fri, May 20, 2011 at 09:48, wrote:
>>> - supports_deadprop_count = (deadprop_count != NULL);
>>> + SVN_ERR(svn_ra_neon__get_deadprop_count_support
>>> + (&supp
On 05/18/2011 09:38 PM, Branko Čibej wrote:
On 17.05.2011 11:36, Stefan Sperling wrote:
On Tue, May 17, 2011 at 12:45:50AM +0200, Stefan Sperling wrote:
Any comments or objections?
Neels didn't like the arbitrary "round to 00:00 of next day" rules
and everyone in the hackathon room seems to ag
On Fri, May 20, 2011 at 16:07, Greg Stein wrote:
> On Fri, May 20, 2011 at 09:48, wrote:
>>...
>> +++ subversion/trunk/subversion/libsvn_ra_neon/fetch.c Fri May 20 13:48:53
>> 2011
>>...
>> @@ -830,15 +822,8 @@ svn_error_t *svn_ra_neon__get_dir(svn_ra
>> targeted PROPFIND. */
>>
On Fri, May 20, 2011 at 09:48, wrote:
>...
> +++ subversion/trunk/subversion/libsvn_ra_neon/fetch.c Fri May 20 13:48:53
> 2011
>...
> @@ -830,15 +822,8 @@ svn_error_t *svn_ra_neon__get_dir(svn_ra
> targeted PROPFIND. */
> if (dirent_fields & SVN_DIRENT_HAS_PROPS)
> {
> -
I believe the following two svn_wc__db_scan_deletion() calls are never
hit, or, more precisely, the first is never hit and the second never
returns a result, during a run of the test suite on RA-local + fsfs.
Anybody got ideas about this? Maybe they could be hit but the test
coverage is insuffici
Ivan and I just spoke in person, and the summary of what I described
is: using "HEAD" for the revision number opens us up to problems. If
we started checking out !svn/rvr/HEAD when that was r10... but halfway
through the checkout, we might start fetching r11 resources. We need a
*consistent* revisi
Johan Corveleyn wrote:
> On Thu, May 19, 2011 at 5:32 PM, Bob Archer wrote:
> >> On 05/19/2011 11:34 AM, Julian Foad wrote:
> >> > Oh, it looks like the choice of name
> >> >
> >> > '.pristine'
[...]
> >> > '.svn-base'
[...]
> >> +1 for .svn-base
> >
> > .svn-base
>
> Yes. Just wanted to add
Daniel Shahaf wrote:
> Perhaps change 'svnserve -M' too, for consistency?
>
> stef...@apache.org wrote on Wed, May 18, 2011 at 11:53:54 -:
> > Make the SVNInMemoryCacheSize mod_dav_svn module setting interpret
> > its parameter value as "kB" instead of "MB". This is more in line with how
> > a
Hi,
Currently in HTTPv2 enabled server we have various special stubs URL
that client can construct without contacting the server. One of them
is revision root: '!svn/rvr/REV/' [1]
REV can be only valid revision and in many cases client still has to
request HEAD revision to construct URL.
So, is i
On Fri, May 20, 2011 at 13:41, Greg Stein wrote:
> On Fri, May 20, 2011 at 07:31, wrote:
>>...
>> +++ subversion/trunk/subversion/libsvn_ra_neon/fetch.c Fri May 20 11:31:42
>> 2011
>> @@ -796,7 +796,6 @@ svn_error_t *svn_ra_neon__get_dir(svn_ra
>> apr_hash_t *resources;
>> const char *final
On Fri, May 20, 2011 at 13:37, Greg Stein wrote:
> On Fri, May 20, 2011 at 07:15, wrote:
>> Author: ivan
>> Date: Fri May 20 11:15:41 2011
>> New Revision: 1125326
>>
>> URL: http://svn.apache.org/viewvc?rev=1125326&view=rev
>> Log:
>> ra_neon: Reduce number of HTTP requests for svn ls command t
On Fri, May 20, 2011 at 07:31, wrote:
>...
> +++ subversion/trunk/subversion/libsvn_ra_neon/fetch.c Fri May 20 11:31:42
> 2011
> @@ -796,7 +796,6 @@ svn_error_t *svn_ra_neon__get_dir(svn_ra
> apr_hash_t *resources;
> const char *final_url;
> apr_size_t final_url_n_components;
> - svn_bool
Oh, and if you respond with "but the build keeps breaking because
people leave this in", then I have a very simple response: don't paper
over the problem. The problem is that developers were NEVER supposed
to leave them in. Teach the developer to be more careful. Don't give
them a crutch.
On Fri,
No.
By design, we did not want to leave these scattered around the code
base. SVN_DBG() is generally for personal use only (people want to
print different things at different times, for different reasons). The
entire *idea* was to make it create a build failure for non-DEBUG
situations.
I very mu
On Fri, May 20, 2011 at 07:15, wrote:
> Author: ivan
> Date: Fri May 20 11:15:41 2011
> New Revision: 1125326
>
> URL: http://svn.apache.org/viewvc?rev=1125326&view=rev
> Log:
> ra_neon: Reduce number of HTTP requests for svn ls command to 11 from 14
> when working with HTTPv1 server.
>
> * subve
On Fri, May 20, 2011 at 01:04:18PM +0200, Stefan Sperling wrote:
> On Fri, May 20, 2011 at 03:25:50PM +0530, Noorul Islam K M wrote:
> > Pinging again.
>
> Looking into this...
Noorul,
unfortunately your patch does not apply cleanly to trunk anymore.
Can you update it? Thanks!
Stefan Fuhrmann wrote:
> On 16.05.2011 18:47, Julian Foad wrote:
> > Hi Stefan. Please could you give this function a doc string, and
> > init_callbacks() later in the same file. Thanks.
> Took me 4 days to get to this, but now its done.
> See r1125312.
Thanks, Stefan, that's much better now. A
On Fri, May 20, 2011 at 03:25:50PM +0530, Noorul Islam K M wrote:
> Pinging again.
Looking into this...
Noorul Islam K M writes:
> Index: subversion/libsvn_client/export.c
> ===
> --- subversion/libsvn_client/export.c (revision 1071880)
> +++ subversion/libsvn_client/export.c (working copy)
> @@ -524,7 +524,26 @@
> }
>else if
Stefan Fuhrmann writes:
> On 15.05.2011 20:23, Blair Zajac wrote:
>> On May 15, 2011, at 11:06 AM, stef...@apache.org wrote:
>>>item->kind = SVN_RA_SVN_STRING;
>>> - item->u.string = apr_palloc(pool, sizeof(*item->u.string));
>>> - item->u.string->data = stringbuf->data;
>>> - item->u.stri
On 16.05.2011 18:47, Julian Foad wrote:
On Sun, 2011-05-15, stef...@apache.org wrote:
Don't give the impression that init_txn_callbacks might fail.
* subversion/libsvn_fs_fs/caching.c
(init_txn_callbacks): void is the appropriate return type.
Modified: subversion/trunk/subversion/libsvn_fs_f
Noorul Islam K M writes:
> Noorul Islam K M writes:
>
>> Gavin Baumanis writes:
>>
>>> Hi Noorul,
>>>
>>> Just a quick message to see if you're still working on this patch or not?
>>> My threads stop at the comments below from Andrew?
>>>
>>
>> Someone has to review this and if everything is fi
30 matches
Mail list logo
