I believe the following two svn_wc__db_scan_deletion() calls are never
hit, or, more precisely, the first is never hit and the second never
returns a result, during a run of the test suite on RA-local + fsfs.
Anybody got ideas about this? Maybe they could be hit but the test
coverage is insufficient?
[[[
Index: subversion/libsvn_wc/entries.c
===================================================================
--- subversion/libsvn_wc/entries.c (revision 1125336)
+++ subversion/libsvn_wc/entries.c (working copy)
@@ -271,12 +271,13 @@ get_info_for_deleted(svn_wc_entry_t *ent
SVN_ERR(svn_wc__db_scan_deletion(NULL,
NULL,
&work_del_abspath,
db, entry_abspath,
scratch_pool, scratch_pool));
+ SVN_DBG(("get_base_info_for_deleted(): 1\n")); /* ### NO HIT */
SVN_ERR_ASSERT(work_del_abspath != NULL);
parent_abspath = svn_dirent_dirname(work_del_abspath, scratch_pool);
/* The parent directory of the delete root must be added, so we
can find the required information there */
SVN_ERR(svn_wc__db_scan_addition(NULL, NULL,
Index: subversion/libsvn_wc/node.c
===================================================================
--- subversion/libsvn_wc/node.c (revision 1125336)
+++ subversion/libsvn_wc/node.c (working copy)
@@ -992,12 +992,13 @@ svn_wc__internal_get_commit_base_rev(svn
SVN_ERR(svn_wc__db_scan_deletion(NULL, NULL,
&work_del_abspath,
db, local_abspath,
scratch_pool, scratch_pool));
if (work_del_abspath != NULL)
{
+ SVN_DBG(("svn_wc__node_get_commit_base_rev(): 1\n")); /* ### NO HIT
*/
/* This is a deletion within a copied subtree. Get the copied-from
* revision. */
SVN_ERR(svn_wc__db_scan_addition(NULL, NULL, NULL, NULL, NULL, NULL,
NULL, NULL,
commit_base_revision,
db,
]]]
- Julian
